95610 2012-08-31 14:21:19 -0700 JSC bindings appear to sometimes ignore the possibility of arrays being in sparse mode 2012-09-25 16:42:47 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo fpizlo ap barraclough ggaren mhahnenberg msaboff oliver sam oldest_to_newest 709983 0 fpizlo 2012-08-31 14:21:19 -0700 I'm not sure entirely what to do about this yet, or if it is even a bug. 710053 1 oliver 2012-08-31 16:17:49 -0700 <rdar://problem/12219385> 727979 2 165676 fpizlo 2012-09-25 14:35:56 -0700 Created attachment 165676 the pathc 727982 3 165676 oliver 2012-09-25 14:38:23 -0700 Comment on attachment 165676 the pathc View in context: https://bugs.webkit.org/attachment.cgi?id=165676&action=review > Source/WebCore/bindings/js/JSInspectorFrontendHostCustom.cpp:92 > // FIXME: What if the array is in sparse mode? https://bugs.webkit.org/show_bug.cgi?id=95610 this can go > Source/WebCore/bindings/js/JSWebSocketCustom.cpp:77 > // FIXME: What if the array is in sparse mode? https://bugs.webkit.org/show_bug.cgi?id=95610 and this 728083 4 fpizlo 2012-09-25 16:42:47 -0700 Landed in http://trac.webkit.org/changeset/129574 165676 2012-09-25 14:35:56 -0700 2012-09-25 14:38:23 -0700 the pathc fixgetindex.patch text/plain 11789 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI5NTU0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEyLTA5LTI1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg SlNDIGJpbmRpbmdzIGFwcGVhciB0byBzb21ldGltZXMgaWdub3JlIHRoZSBwb3NzaWJpbGl0eSBv ZiBhcnJheXMgYmVpbmcgaW4gc3BhcnNlIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk1NjEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkIGJldHRlciBzdXBwb3J0IGZvciBxdWlja2x5IGFjY2Vz c2luZyB0aGUgaW5kZXhlZCBzdG9yYWdlIGZyb20gYmluZGluZ3MuCisKKyAgICAgICAgKiBydW50 aW1lL0pTT2JqZWN0Lmg6CisgICAgICAgIChKU0M6OkpTT2JqZWN0Ojp0cnlHZXRJbmRleFF1aWNr bHkpOgorICAgICAgICAoSlNPYmplY3QpOgorICAgICAgICAoSlNDOjpKU09iamVjdDo6Z2V0RGly ZWN0SW5kZXgpOgorICAgICAgICAoSlNDOjpKU09iamVjdDo6Z2V0SW5kZXgpOgorCiAyMDEyLTA5 LTI1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgU3RydWN0dXJl IGNoZWNrIGhvaXN0aW5nIHBoYXNlIGRvZXNuJ3Qga25vdyBhYm91dCB0aGUgc2lkZS1lZmZlY3Rp bmcgbmF0dXJlIG9mIEFycmF5aWZ5CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU09iamVjdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTT2JqZWN0LmgJKHJldmlzaW9uIDEyOTQ3NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTT2JqZWN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTIyNiw2ICsyMjYsNDIgQEAgbmFt ZXNwYWNlIEpTQyB7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICAgICAgCisgICAgICAg IEpTVmFsdWUgdHJ5R2V0SW5kZXhRdWlja2x5KHVuc2lnbmVkIGkpCisgICAgICAgIHsKKyAgICAg ICAgICAgIHN3aXRjaCAoc3RydWN0dXJlKCktPmluZGV4aW5nVHlwZSgpKSB7CisgICAgICAgICAg ICBjYXNlIEFMTF9CTEFOS19JTkRFWElOR19UWVBFUzoKKyAgICAgICAgICAgICAgICBicmVhazsK KyAgICAgICAgICAgIGNhc2UgQUxMX0FSUkFZX1NUT1JBR0VfSU5ERVhJTkdfVFlQRVM6CisgICAg ICAgICAgICAgICAgaWYgKGkgPCBtX2J1dHRlcmZseS0+YXJyYXlTdG9yYWdlKCktPnZlY3Rvckxl bmd0aCgpKSB7CisgICAgICAgICAgICAgICAgICAgIEpTVmFsdWUgdiA9IG1fYnV0dGVyZmx5LT5h cnJheVN0b3JhZ2UoKS0+bV92ZWN0b3JbaV0uZ2V0KCk7CisgICAgICAgICAgICAgICAgICAgIGlm ICh2KQorICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHY7CisgICAgICAgICAgICAgICAg fQorICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgZGVmYXVsdDoKKyAgICAgICAg ICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAg ICAgICAgICAgIH0KKyAgICAgICAgICAgIHJldHVybiBKU1ZhbHVlKCk7CisgICAgICAgIH0KKyAg ICAgICAgCisgICAgICAgIEpTVmFsdWUgZ2V0RGlyZWN0SW5kZXgoRXhlY1N0YXRlKiBleGVjLCB1 bnNpZ25lZCBpKQorICAgICAgICB7CisgICAgICAgICAgICBpZiAoSlNWYWx1ZSByZXN1bHQgPSB0 cnlHZXRJbmRleFF1aWNrbHkoaSkpCisgICAgICAgICAgICAgICAgcmV0dXJuIHJlc3VsdDsKKyAg ICAgICAgICAgIFByb3BlcnR5U2xvdCBzbG90KHRoaXMpOworICAgICAgICAgICAgaWYgKG1ldGhv ZFRhYmxlKCktPmdldE93blByb3BlcnR5U2xvdEJ5SW5kZXgodGhpcywgZXhlYywgaSwgc2xvdCkp CisgICAgICAgICAgICAgICAgcmV0dXJuIHNsb3QuZ2V0VmFsdWUoZXhlYywgaSk7CisgICAgICAg ICAgICByZXR1cm4gSlNWYWx1ZSgpOworICAgICAgICB9CisgICAgICAgIAorICAgICAgICBKU1Zh bHVlIGdldEluZGV4KEV4ZWNTdGF0ZSogZXhlYywgdW5zaWduZWQgaSkKKyAgICAgICAgeworICAg ICAgICAgICAgaWYgKEpTVmFsdWUgcmVzdWx0ID0gdHJ5R2V0SW5kZXhRdWlja2x5KGkpKQorICAg ICAgICAgICAgICAgIHJldHVybiByZXN1bHQ7CisgICAgICAgICAgICByZXR1cm4gZ2V0KGV4ZWMs IGkpOworICAgICAgICB9CisgICAgICAgIAogICAgICAgICBib29sIGNhblNldEluZGV4UXVpY2ts eSh1bnNpZ25lZCBpKQogICAgICAgICB7CiAgICAgICAgICAgICBzd2l0Y2ggKHN0cnVjdHVyZSgp LT5pbmRleGluZ1R5cGUoKSkgewpJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI5NTU0KQorKysg U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzEgQEAK KzIwMTItMDktMjUgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBK U0MgYmluZGluZ3MgYXBwZWFyIHRvIHNvbWV0aW1lcyBpZ25vcmUgdGhlIHBvc3NpYmlsaXR5IG9m IGFycmF5cyBiZWluZyBpbiBzcGFyc2UgbW9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU2MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXggYWxsIG9mIHRoZSBjYXNlcyBJIGZvdW5kIHdoZXJlIHdl IHdlcmUgdXNpbmcgZ2V0SW5kZXhRdWlja2x5KCksIHdoaWNoIHdhcyB3cm9uZworICAgICAgICBp ZiB3ZSB3ZXJlIGluIHNwYXJzZSBtb2RlLgorCisgICAgICAgICogYmluZGluZ3MvanMvQXJyYXlW YWx1ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBcnJheVZhbHVlOjpnZXQpOgorICAgICAgICAq IGJpbmRpbmdzL2pzL0pTQmxvYkN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU0Jsb2JD b25zdHJ1Y3Rvcjo6Y29uc3RydWN0SlNCbG9iKToKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0Nh bnZhc1JlbmRlcmluZ0NvbnRleHQyREN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU0Nh bnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6c2V0V2Via2l0TGluZURhc2gpOgorICAgICAgICAqIGJp bmRpbmdzL2pzL0pTRE9NU3RyaW5nTGlzdEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0 b0RPTVN0cmluZ0xpc3QpOgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTSW5zcGVjdG9yRnJvbnRl bmRIb3N0Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnBvcHVsYXRlQ29udGV4dE1lbnVJ dGVtcyk6CisgICAgICAgICogYmluZGluZ3MvanMvSlNXZWJTb2NrZXRDdXN0b20uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SlNXZWJTb2NrZXRDb25zdHJ1Y3Rvcjo6Y29uc3RydWN0SlNXZWJTb2Nr ZXQpOgorICAgICAgICAqIGJpbmRpbmdzL2pzL1NjcmlwdFZhbHVlLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OmpzVG9JbnNwZWN0b3JWYWx1ZSk6CisgICAgICAgICogYmluZGluZ3MvanMvU2VyaWFs aXplZFNjcmlwdFZhbHVlLmNwcDoKKyAgICAgICAgKENsb25lU2VyaWFsaXplcik6CisgICAgICAg IChXZWJDb3JlOjpDbG9uZVNlcmlhbGl6ZXI6OnNlcmlhbGl6ZSk6CisKIDIwMTItMDktMjUgIEFk YW0gS2xlaW4gIDxhZGFta0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVtb3ZlIHVudXNlZCBE T01BdHRyTW9kaWZpZWQgZnJvbSBFdmVudHNOYW1lcyBhbmQgRG9jdW1lbnQ6Okxpc3RlbmVyVHlw ZQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvQXJyYXlWYWx1ZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvQXJyYXlWYWx1ZS5jcHAJKHJldmlz aW9uIDEyOTQ3NSkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0FycmF5VmFsdWUuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC03MiwxMiArNzIsNyBAQCBib29sIEFycmF5VmFsdWU6OmdldChz aXplX3QgaW5kZXgsIERpY3RpCiAgICAgaWYgKGlzVW5kZWZpbmVkT3JOdWxsKCkpCiAgICAgICAg IHJldHVybiBmYWxzZTsKIAotICAgIEpTQXJyYXkqIGFycmF5ID0gYXNBcnJheShtX3ZhbHVlKTsK LSAgICAvLyBGSVhNRTogV2hhdCBpZiB0aGUgYXJyYXkgaXMgaW4gc3BhcnNlIG1vZGU/IGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTYxMAotICAgIGlmICghYXJyYXkt PmNhbkdldEluZGV4UXVpY2tseShpbmRleCkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQotICAg IEpTVmFsdWUgaW5kZXhlZFZhbHVlID0gYXJyYXktPmdldEluZGV4UXVpY2tseShpbmRleCk7Cisg ICAgSlNWYWx1ZSBpbmRleGVkVmFsdWUgPSBhc0FycmF5KG1fdmFsdWUpLT5nZXRJbmRleChtX2V4 ZWMsIGluZGV4KTsKICAgICBpZiAoaW5kZXhlZFZhbHVlLmlzVW5kZWZpbmVkT3JOdWxsKCkgfHwg IWluZGV4ZWRWYWx1ZS5pc09iamVjdCgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQmxvYkN1c3RvbS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNCbG9iQ3VzdG9tLmNwcAkocmV2aXNpb24g MTI5NDc1KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNCbG9iQ3VzdG9tLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTE4LDggKzExOCw3IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NU X0NBTEwgSlNCbG9iQ29uc3QKICAgICB1bnNpZ25lZCBsZW5ndGggPSBhcnJheS0+bGVuZ3RoKCk7 CiAKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbGVuZ3RoOyArK2kpIHsKLSAgICAgICAg Ly8gRklYTUU6IFdoYXQgaWYgdGhlIGFycmF5IGlzIGluIHNwYXJzZSBtb2RlPyBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU2MTAKLSAgICAgICAgSlNWYWx1ZSBpdGVt ID0gYXJyYXktPmdldEluZGV4UXVpY2tseShpKTsKKyAgICAgICAgSlNWYWx1ZSBpdGVtID0gYXJy YXktPmdldEluZGV4KGV4ZWMsIGkpOwogI2lmIEVOQUJMRShCTE9CKQogICAgICAgICBpZiAoaXRl bS5pbmhlcml0cygmSlNBcnJheUJ1ZmZlcjo6c19pbmZvKSkKICAgICAgICAgICAgIGJsb2JCdWls ZGVyLT5hcHBlbmQoY29udGV4dCwgdG9BcnJheUJ1ZmZlcihpdGVtKSk7CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyREN1c3RvbS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDYW52YXNSZW5kZXJp bmdDb250ZXh0MkRDdXN0b20uY3BwCShyZXZpc2lvbiAxMjk0NzUpCisrKyBTb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyREN1c3RvbS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTExMCw5ICsxMTAsOCBAQCB2b2lkIEpTQ2FudmFzUmVuZGVyaW5nQ29udGV4 dDJEOjpzZXRXZWJrCiAKICAgICBWZWN0b3I8ZmxvYXQ+IGRhc2g7CiAgICAgSlNBcnJheSogdmFs dWVBcnJheSA9IGFzQXJyYXkodmFsdWUpOwotICAgIC8vIEZJWE1FOiBXaGF0IGlmIHRoZSBhcnJh eSBpcyBpbiBzcGFyc2UgbW9kZT8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk1NjEwCiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IHZhbHVlQXJyYXktPmxlbmd0 aCgpOyArK2kpIHsKLSAgICAgICAgZmxvYXQgZWxlbSA9IHZhbHVlQXJyYXktPmdldEluZGV4UXVp Y2tseShpKS50b0Zsb2F0KGV4ZWMpOworICAgICAgICBmbG9hdCBlbGVtID0gdmFsdWVBcnJheS0+ Z2V0SW5kZXgoZXhlYywgaSkudG9GbG9hdChleGVjKTsKICAgICAgICAgaWYgKGVsZW0gPD0gMCB8 fCAhaXNmaW5pdGUoZWxlbSkpCiAgICAgICAgICAgICByZXR1cm47CiAKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NU3RyaW5nTGlzdEN1c3RvbS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01TdHJpbmdMaXN0Q3VzdG9tLmNwcAko cmV2aXNpb24gMTI5NDc1KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01TdHJp bmdMaXN0Q3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzMsOSArMzMsOCBAQCBQYXNzUmVm UHRyPERPTVN0cmluZ0xpc3Q+IHRvRE9NU3RyaW5nTGlzCiAKICAgICBKU0FycmF5KiBhcnJheSA9 IGFzQXJyYXkodmFsdWUpOwogICAgIFJlZlB0cjxET01TdHJpbmdMaXN0PiBzdHJpbmdMaXN0ID0g RE9NU3RyaW5nTGlzdDo6Y3JlYXRlKCk7Ci0gICAgLy8gRklYTUU6IFdoYXQgaWYgdGhlIGFycmF5 IGlzIGluIHNwYXJzZSBtb2RlPyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTU2MTAKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgYXJyYXktPmxlbmd0aCgpOyAr K2kpCi0gICAgICAgIHN0cmluZ0xpc3QtPmFwcGVuZChhcnJheS0+Z2V0SW5kZXhRdWlja2x5KGkp LnRvU3RyaW5nKGV4ZWMpLT52YWx1ZShleGVjKSk7CisgICAgICAgIHN0cmluZ0xpc3QtPmFwcGVu ZChhcnJheS0+Z2V0SW5kZXgoZXhlYywgaSkudG9TdHJpbmcoZXhlYyktPnZhbHVlKGV4ZWMpKTsK IAogICAgIHJldHVybiBzdHJpbmdMaXN0LnJlbGVhc2UoKTsKIH0KSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2pzL0pTSW5zcGVjdG9yRnJvbnRlbmRIb3N0Q3VzdG9tLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0luc3BlY3RvckZyb250ZW5kSG9z dEN1c3RvbS5jcHAJKHJldmlzaW9uIDEyOTQ3NSkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTSW5zcGVjdG9yRnJvbnRlbmRIb3N0Q3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAt OTAsNyArOTAsNyBAQCBzdGF0aWMgdm9pZCBwb3B1bGF0ZUNvbnRleHRNZW51SXRlbXMoRXhlCiB7 CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBhcnJheS0+bGVuZ3RoKCk7ICsraSkgewogICAg ICAgICAvLyBGSVhNRTogV2hhdCBpZiB0aGUgYXJyYXkgaXMgaW4gc3BhcnNlIG1vZGU/IGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTYxMAotICAgICAgICBKU09iamVj dCogaXRlbSA9IGFzT2JqZWN0KGFycmF5LT5nZXRJbmRleFF1aWNrbHkoaSkpOworICAgICAgICBK U09iamVjdCogaXRlbSA9IGFzT2JqZWN0KGFycmF5LT5nZXRJbmRleChleGVjLCBpKSk7CiAgICAg ICAgIEpTVmFsdWUgbGFiZWwgPSBpdGVtLT5nZXQoZXhlYywgSWRlbnRpZmllcihleGVjLCAibGFi ZWwiKSk7CiAgICAgICAgIEpTVmFsdWUgdHlwZSA9IGl0ZW0tPmdldChleGVjLCBJZGVudGlmaWVy KGV4ZWMsICJ0eXBlIikpOwogICAgICAgICBKU1ZhbHVlIGlkID0gaXRlbS0+Z2V0KGV4ZWMsIElk ZW50aWZpZXIoZXhlYywgImlkIikpOwpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMv SlNXZWJTb2NrZXRDdXN0b20uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL0pTV2ViU29ja2V0Q3VzdG9tLmNwcAkocmV2aXNpb24gMTI5NDc1KQorKysgU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvSlNXZWJTb2NrZXRDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkp CkBAIC03NSw3ICs3NSw3IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgSlNXZWJTb2Nr ZXQKICAgICAgICAgICAgIEpTQXJyYXkqIHByb3RvY29sc0FycmF5ID0gYXNBcnJheShwcm90b2Nv bHNWYWx1ZSk7CiAgICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgcHJvdG9jb2xz QXJyYXktPmxlbmd0aCgpOyArK2kpIHsKICAgICAgICAgICAgICAgICAvLyBGSVhNRTogV2hhdCBp ZiB0aGUgYXJyYXkgaXMgaW4gc3BhcnNlIG1vZGU/IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05NTYxMAotICAgICAgICAgICAgICAgIFN0cmluZyBwcm90b2NvbCA9IHBy b3RvY29sc0FycmF5LT5nZXRJbmRleFF1aWNrbHkoaSkudG9TdHJpbmcoZXhlYyktPnZhbHVlKGV4 ZWMpOworICAgICAgICAgICAgICAgIFN0cmluZyBwcm90b2NvbCA9IHByb3RvY29sc0FycmF5LT5n ZXRJbmRleChleGVjLCBpKS50b1N0cmluZyhleGVjKS0+dmFsdWUoZXhlYyk7CiAgICAgICAgICAg ICAgICAgaWYgKGV4ZWMtPmhhZEV4Y2VwdGlvbigpKQogICAgICAgICAgICAgICAgICAgICByZXR1 cm4gSlNWYWx1ZTo6ZW5jb2RlKEpTVmFsdWUoKSk7CiAgICAgICAgICAgICAgICAgcHJvdG9jb2xz LmFwcGVuZChwcm90b2NvbCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3Jp cHRWYWx1ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2Ny aXB0VmFsdWUuY3BwCShyZXZpc2lvbiAxMjk0NzUpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9TY3JpcHRWYWx1ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0NCw4ICsxNDQsNyBAQCBz dGF0aWMgUGFzc1JlZlB0cjxJbnNwZWN0b3JWYWx1ZT4ganNUb0luCiAgICAgICAgICAgICBKU0Fy cmF5KiBhcnJheSA9IGFzQXJyYXkodmFsdWUpOwogICAgICAgICAgICAgdW5zaWduZWQgbGVuZ3Ro ID0gYXJyYXktPmxlbmd0aCgpOwogICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8 IGxlbmd0aDsgaSsrKSB7Ci0gICAgICAgICAgICAgICAgLy8gRklYTUU6IFdoYXQgaWYgdGhlIGFy cmF5IGlzIGluIHNwYXJzZSBtb2RlPyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTU2MTAKLSAgICAgICAgICAgICAgICBKU1ZhbHVlIGVsZW1lbnQgPSBhcnJheS0+Z2V0 SW5kZXhRdWlja2x5KGkpOworICAgICAgICAgICAgICAgIEpTVmFsdWUgZWxlbWVudCA9IGFycmF5 LT5nZXRJbmRleChzY3JpcHRTdGF0ZSwgaSk7CiAgICAgICAgICAgICAgICAgUmVmUHRyPEluc3Bl Y3RvclZhbHVlPiBlbGVtZW50VmFsdWUgPSBqc1RvSW5zcGVjdG9yVmFsdWUoc2NyaXB0U3RhdGUs IGVsZW1lbnQsIG1heERlcHRoKTsKICAgICAgICAgICAgICAgICBpZiAoIWVsZW1lbnRWYWx1ZSkK ICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIDA7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9TZXJpYWxpemVkU2NyaXB0VmFsdWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAJKHJldmlzaW9uIDEy OTQ3NSkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NlcmlhbGl6ZWRTY3JpcHRWYWx1 ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ3MSwyMiArNDcxLDYgQEAgcHJpdmF0ZToKICAgICAg ICAgd3JpdGUoVGVybWluYXRvclRhZyk7CiAgICAgfQogCi0gICAgSlNWYWx1ZSBnZXRTcGFyc2VJ bmRleChKU0FycmF5KiBhcnJheSwgdW5zaWduZWQgcHJvcGVydHlOYW1lLCBib29sJiBoYXNJbmRl eCkKLSAgICB7Ci0gICAgICAgIFByb3BlcnR5U2xvdCBzbG90KGFycmF5KTsKLSAgICAgICAgaWYg KGlzSlNBcnJheShhcnJheSkpIHsKLSAgICAgICAgICAgIGlmIChKU0FycmF5OjpnZXRPd25Qcm9w ZXJ0eVNsb3RCeUluZGV4KGFycmF5LCBtX2V4ZWMsIHByb3BlcnR5TmFtZSwgc2xvdCkpIHsKLSAg ICAgICAgICAgICAgICBoYXNJbmRleCA9IHRydWU7Ci0gICAgICAgICAgICAgICAgcmV0dXJuIHNs b3QuZ2V0VmFsdWUobV9leGVjLCBwcm9wZXJ0eU5hbWUpOwotICAgICAgICAgICAgfQotICAgICAg ICB9IGVsc2UgaWYgKGFycmF5LT5tZXRob2RUYWJsZSgpLT5nZXRPd25Qcm9wZXJ0eVNsb3RCeUlu ZGV4KGFycmF5LCBtX2V4ZWMsIHByb3BlcnR5TmFtZSwgc2xvdCkpIHsKLSAgICAgICAgICAgIGhh c0luZGV4ID0gdHJ1ZTsKLSAgICAgICAgICAgIHJldHVybiBzbG90LmdldFZhbHVlKG1fZXhlYywg cHJvcGVydHlOYW1lKTsKLSAgICAgICAgfQotICAgICAgICBoYXNJbmRleCA9IGZhbHNlOwotICAg ICAgICByZXR1cm4ganNOdWxsKCk7Ci0gICAgfQotCiAgICAgSlNWYWx1ZSBnZXRQcm9wZXJ0eShK U09iamVjdCogb2JqZWN0LCBjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUpCiAgICAgewog ICAgICAgICBQcm9wZXJ0eVNsb3Qgc2xvdChvYmplY3QpOwpAQCAtODk0LDE2ICs4NzgsMTAgQEAg U2VyaWFsaXphdGlvblJldHVybkNvZGUgQ2xvbmVTZXJpYWxpemVyOgogICAgICAgICAgICAgICAg ICAgICBsZW5ndGhTdGFjay5yZW1vdmVMYXN0KCk7CiAgICAgICAgICAgICAgICAgICAgIGJyZWFr OwogICAgICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAgICAvLyBGSVhNRTogV2hhdCBpZiB0 aGUgYXJyYXkgaXMgaW4gc3BhcnNlIG1vZGU/IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05NTYxMAotICAgICAgICAgICAgICAgIGlmIChhcnJheS0+Y2FuR2V0SW5kZXhR dWlja2x5KGluZGV4KSkKLSAgICAgICAgICAgICAgICAgICAgaW5WYWx1ZSA9IGFycmF5LT5nZXRJ bmRleFF1aWNrbHkoaW5kZXgpOwotICAgICAgICAgICAgICAgIGVsc2UgewotICAgICAgICAgICAg ICAgICAgICBib29sIGhhc0luZGV4ID0gZmFsc2U7Ci0gICAgICAgICAgICAgICAgICAgIGluVmFs dWUgPSBnZXRTcGFyc2VJbmRleChhcnJheSwgaW5kZXgsIGhhc0luZGV4KTsKLSAgICAgICAgICAg ICAgICAgICAgaWYgKCFoYXNJbmRleCkgewotICAgICAgICAgICAgICAgICAgICAgICAgaW5kZXhT dGFjay5sYXN0KCkrKzsKLSAgICAgICAgICAgICAgICAgICAgICAgIGdvdG8gYXJyYXlTdGFydFZp c2l0TWVtYmVyOwotICAgICAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgaW5WYWx1 ZSA9IGFycmF5LT5nZXREaXJlY3RJbmRleChtX2V4ZWMsIGluZGV4KTsKKyAgICAgICAgICAgICAg ICBpZiAoIWluVmFsdWUpIHsKKyAgICAgICAgICAgICAgICAgICAgaW5kZXhTdGFjay5sYXN0KCkr KzsKKyAgICAgICAgICAgICAgICAgICAgZ290byBhcnJheVN0YXJ0VmlzaXRNZW1iZXI7CiAgICAg ICAgICAgICAgICAgfQogCiAgICAgICAgICAgICAgICAgd3JpdGUoaW5kZXgpOwo=