95590 2012-08-31 11:02:18 -0700 [Gtk] Assert on ChromeClientGtk::scroll with delta (0, -1) 2012-08-31 15:51:37 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Critical --- 0 jdapena webkit-unassigned webkit.review.bot oldest_to_newest 709808 0 jdapena 2012-08-31 11:02:18 -0700 Steps to reproduce: 1. Build WK1-GTK with Accelerated compositing and webgl enabled. 2. Run GtkLauncher 3. Open http://2012.beercamp.com Outcome: crash due to the assert. Assert: ASSERTION FAILED: !delta.isEmpty() Backtrace: #0 0x00007ffff531cc27 in WebKit::ChromeClient::scroll (this=0x59b780, delta=..., rectToScroll=..., clipRect=...) at ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:654 #1 0x00007ffff5bdd09c in WebCore::Chrome::scroll (this=0x5bb7e0, scrollDelta=..., rectToScroll=..., clipRect=...) at ../../Source/WebCore/page/Chrome.cpp:97 #2 0x00007ffff5c2bf40 in WebCore::FrameView::scrollContentsFastPath (this=0x1780480, scrollDelta=..., rectToScroll=..., clipRect=...) at ../../Source/WebCore/page/FrameView.cpp:1554 #3 0x00007ffff5d7cd59 in WebCore::ScrollView::scrollContents (this=0x1780480, scrollDelta=...) at ../../Source/WebCore/platform/ScrollView.cpp:678 #4 0x00007ffff5d7b00f in WebCore::ScrollView::scrollTo (this=0x1780480, newOffset=...) at ../../Source/WebCore/platform/ScrollView.cpp:385 #5 0x00007ffff5c30714 in WebCore::FrameView::scrollTo (this=0x1780480, newOffset=...) at ../../Source/WebCore/page/FrameView.cpp:2693 #6 0x00007ffff5d7af68 in WebCore::ScrollView::setScrollOffset (this=0x1780480, offset=...) at ../../Source/WebCore/platform/ScrollView.cpp:365 #7 0x00007ffff5d741fa in WebCore::ScrollableArea::scrollPositionChanged (this=0x17804d0, position=...) at ../../Source/WebCore/platform/ScrollableArea.cpp:147 #8 0x00007ffff5d74491 in WebCore::ScrollableArea::setScrollOffsetFromAnimation (this=0x17804d0, offset=...) at ../../Source/WebCore/platform/ScrollableArea.cpp:192 #9 0x00007ffff5d712e1 in WebCore::ScrollAnimator::notifyPositionChanged (this=0x97f0c0) at ../../Source/WebCore/platform/ScrollAnimator.cpp:149 #10 0x00007ffff5d70c79 in WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation (this=0x97f0c0, offset=...) at ../../Source/WebCore/platform/ScrollAnimator.cpp:79 #11 0x00007ffff5d74090 in WebCore::ScrollableArea::scrollToOffsetWithoutAnimation (this=0x17804d0, offset=...) at ../../Source/WebCore/platform/ScrollableArea.cpp:126 #12 0x00007ffff5d7c7fd in WebCore::ScrollView::updateScrollbars (this=0x1780480, desiredOffset=...) at ../../Source/WebCore/platform/ScrollView.cpp:623 #13 0x00007ffff5d7b203 in WebCore::ScrollView::setScrollPosition (this=0x1780480, scrollPoint=...) at ../../Source/WebCore/platform/ScrollView.cpp:420 #14 0x00007ffff5c2cd09 in WebCore::FrameView::setScrollPosition (this=0x1780480, scrollPoint=...) at ../../Source/WebCore/page/FrameView.cpp:1762 #15 0x00007ffff5bf91af in WebCore::DOMWindow::scrollTo (this=0x10c9e40, x=0, y=1) at ../../Source/WebCore/page/DOMWindow.cpp:1414 #16 0x00007ffff61e5c49 in WebCore::jsDOMWindowPrototypeFunctionScrollTo (exec=0x7fff86bfe088) at DerivedSources/WebCore/JSDOMWindow.cpp:9653 #17 0x00007fffab5a4265 in ?? () #18 0x00007fffffffc9f0 in ?? () #19 0x00007ffff3b80079 in llint_op_call () from /home/jose/Desarrollo/git/WebKit/WebKitBuild/Debug/.libs/libjavascriptcoregtk-3.0.so.0 #20 0x00007fffffffc980 in ?? () #21 0x00007fffffffc9b0 in ?? () #22 0x00007fff954f1d00 in ?? () #23 0x00007ffff3a84c77 in JSC::Register::Register (this=0x0) at ../../Source/JavaScriptCore/interpreter/Register.h:105 #24 0x00007ffff3b2d3aa in JSC::JITCode::execute (this=0x7fff8434ea68, registerFile=0x5ebb38, callFrame=0x7fff86bfe038, globalData=0x89fbe0) at ../../Source/JavaScriptCore/jit/JITCode.h:133 #25 0x00007ffff3b29cc0 in JSC::Interpreter::executeCall (this=0x5ebb20, callFrame=0x7fffa81cf388, function=0x7fff954f1d00, callType=JSC::CallTypeJS, callData=..., thisValue=..., args=...) at ../../Source/JavaScriptCore/interpreter/Interpreter.cpp:1045 #26 0x00007ffff3bf64b1 in JSC::call (exec=0x7fffa81cf388, functionObject=..., callType=JSC::CallTypeJS, callData=..., thisValue=..., args=...) at ../../Source/JavaScriptCore/runtime/CallData.cpp:39 #27 0x00007ffff5482bf3 in WebCore::JSMainThreadExecState::call (exec=0x7fffa81cf388, functionObject=..., callType=JSC::CallTypeJS, callData=..., thisValue=..., args=...) at ../../Source/WebCore/bindings/js/JSMainThreadExecState.h:56 #28 0x00007ffff54e6dbb in WebCore::ScheduledAction::executeFunctionInContext (this=0x2061030, globalObject=0x7fffa81cf180, thisValue=..., context=0x12454d8) at ../../Source/WebCore/bindings/js/ScheduledAction.cpp:115 #29 0x00007ffff54e6f92 in WebCore::ScheduledAction::execute (this=0x2061030, document=0x12453b0) at ../../Source/WebCore/bindings/js/ScheduledAction.cpp:137 #30 0x00007ffff54e6b32 in WebCore::ScheduledAction::execute (this=0x2061030, context=0x12454d8) at ../../Source/WebCore/bindings/js/ScheduledAction.cpp:83 #31 0x00007ffff5bf38a6 in WebCore::DOMTimer::fired (this=0xa9d7e0) at ../../Source/WebCore/page/DOMTimer.cpp:149 #32 0x00007ffff5da32b9 in WebCore::ThreadTimers::sharedTimerFiredInternal (this=0x5de160) at ../../Source/WebCore/platform/ThreadTimers.cpp:115 #33 0x00007ffff5da31e7 in WebCore::ThreadTimers::sharedTimerFired () at ../../Source/WebCore/platform/ThreadTimers.cpp:93 #34 0x00007ffff64c15ca in WebCore::timeout_cb () at ../../Source/WebCore/platform/gtk/SharedTimerGtk.cpp:49 #35 0x00007ffff471f379 in g_timeout_dispatch (source=0x9b8a10, callback=0x7ffff64c15a9 <WebCore::timeout_cb(gpointer)>, user_data=0x0) at gmain.c:3882 #36 0x00007ffff471d5ec in g_main_dispatch (context=0x472ef0) at gmain.c:2539 #37 0x00007ffff471e291 in g_main_context_dispatch (context=0x472ef0) at gmain.c:3075 #38 0x00007ffff471e474 in g_main_context_iterate (context=0x472ef0, block=1, dispatch=1, self=0x74d120) at gmain.c:3146 #39 0x00007ffff471e89d in g_main_loop_run (loop=0x76af00) at gmain.c:3340 #40 0x00007ffff4b871ae in gtk_main () at gtkmain.c:1161 #41 0x000000000040546d in main (argc=1, argv=0x7fffffffd268) at ../../Tools/GtkLauncher/main.c:534 709823 1 161738 jdapena 2012-08-31 11:16:04 -0700 Created attachment 161738 Patch 709833 2 161738 mrobinson 2012-08-31 11:27:48 -0700 Comment on attachment 161738 Patch Great! Thanks. 710039 3 161738 webkit.review.bot 2012-08-31 15:51:35 -0700 Comment on attachment 161738 Patch Clearing flags on attachment: 161738 Committed r127328: <http://trac.webkit.org/changeset/127328> 710040 4 webkit.review.bot 2012-08-31 15:51:37 -0700 All reviewed patches have been landed. Closing bug. 161738 2012-08-31 11:16:04 -0700 2012-08-31 15:51:35 -0700 Patch bug-95590-20120831201551.patch text/plain 1615 jdapena U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggMDQzNjVmMzI5 NDgwNDY5YjdiZDM1NDYwNTM0NjM2ZmUzNjkxMjE5NS4uYWI3OTgzNDMyMGJjYjQ2ZmE0MTc4Yzdk MWY1N2RlZjVlMzNlZGNkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEy LTA4LTMxICBKb3PDqSBEYXBlbmEgUGF6ICA8amRhcGVuYUBpZ2FsaWEuY29tPgorCisgICAgICAg IFtHVEtdIEFzc2VydCBvbiBDaHJvbWVDbGllbnRHdGs6OnNjcm9sbCB3aXRoIGRlbHRhICgwLCAt MSkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTU5 MAorCisgICAgICAgIENoYW5nZSB0aGUgYXNzZXJ0IHRvIGF2b2lkIGhpdHRpbmcgd2hlbiB0aGUg ZGVsdGEgZG9lcyBub3QgaGF2ZSBhbnkKKyAgICAgICAgdmFsdWUgPiAwLgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQ2hy b21lQ2xpZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hyb21lQ2xpZW50OjpzY3JvbGwp OgorCiAyMDEyLTA4LTMwICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+ CiAKICAgICAgICAgVXNlIEFTQ0lJTGl0ZXJhbCBmb3IgREVGSU5FX1NUQVRJQ19MT0NBTCBzdHJp bmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNs aWVudEd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGll bnRHdGsuY3BwCmluZGV4IDc0MGUzYmJjYTUxNTFkMGRiYzIzNDlmZjUyYWY0YWU5NWE3YTdmNTUu LmI3YzE1NTc3MGYzNjZiZWY0NDUzYWZmNzU0OTM3NzVlNWUyZDU5NDggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAKKysrIGIv U291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcApAQCAt NjUxLDcgKzY1MSw3IEBAIHZvaWQgQ2hyb21lQ2xpZW50OjpzY3JvbGwoY29uc3QgSW50U2l6ZSYg ZGVsdGEsIGNvbnN0IEludFJlY3QmIHJlY3RUb1Njcm9sbCwgY29uCiAgICAgQWNjZWxlcmF0ZWRD b21wb3NpdGluZ0NvbnRleHQqIGNvbXBvc2l0aW5nQ29udGV4dCA9IG1fd2ViVmlldy0+cHJpdi0+ YWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQuZ2V0KCk7CiAgICAgaWYgKGNvbXBvc2l0aW5n Q29udGV4dC0+ZW5hYmxlZCgpKSB7CiAgICAgICAgIEFTU0VSVCghcmVjdFRvU2Nyb2xsLmlzRW1w dHkoKSk7Ci0gICAgICAgIEFTU0VSVCghZGVsdGEuaXNFbXB0eSgpKTsKKyAgICAgICAgQVNTRVJU KGRlbHRhLndpZHRoKCkgfHwgZGVsdGEuaGVpZ2h0KCkpOwogCiAgICAgICAgIGNvbXBvc2l0aW5n Q29udGV4dC0+c2Nyb2xsTm9uQ29tcG9zaXRlZENvbnRlbnRzKHJlY3RUb1Njcm9sbCwgZGVsdGEp OwogICAgICAgICByZXR1cm47Cg==