95578 2012-08-31 08:23:29 -0700 [WK2][WTR] CodeGeneratorTestRunner should support web idl overloading functions. 2017-05-12 06:48:32 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All NEW P2 Normal --- 42197 1 kangil.han webkit-unassigned ap benjamin fred.wang jussi.kukkonen mjs sam sh4.seo oldest_to_newest 709647 0 kangil.han 2012-08-31 08:23:29 -0700 // FIXME: handle non-boolean preferences. void overridePreference(in DOMString preference, in boolean value); 711051 1 162028 kangil.han 2012-09-04 06:24:00 -0700 Created attachment 162028 patch 711764 2 kangil.han 2012-09-04 23:41:03 -0700 ap : review please? 715254 3 162028 benjamin 2012-09-07 21:46:07 -0700 Comment on attachment 162028 patch View in context: https://bugs.webkit.org/attachment.cgi?id=162028&action=review r- as discussed on IRC. > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:213 > + if (preference == "WebKit2AsynchronousPluginInitializationEnabled" || preference == "WebKit2AsynchronousPluginInitializationEnabledForAllPlugins" > + || preference == "WebKit2ArtificialPluginInitializationDelayEnabled" || preference == "WebKitAcceleratedCompositingEnabled" > + || preference == "WebKitCSSCustomFilterEnabled" || preference == "WebKitCSSRegionsEnabled" > + || preference == "WebKitCSSGridLayoutEnabled" || preference == "WebKitJavaEnabled" > + || preference == "WebKitJavaScriptEnabled" || preference == "WebKitLoadSiteIconsKey" > + || preference == "WebKitOfflineWebApplicationCacheEnabled" || preference == "WebKitPageCacheSupportsPluginsPreferenceKey" > + || preference == "WebKitPluginsEnabled" || preference == "WebKitUsesPageCachePreferenceKey" > + || preference == "WebKitWebAudioEnabled" || preference == "WebKitWebGLEnabled" > + || preference == "WebKitXSSAuditorEnabled" || preference == "WebKitShouldRespectImageOrientation" > + || preference == "WebKitEnableCaretBrowsing" || preference == "WebKitAcceleratedCompositingEnabled") > + return overrideBoolPreferenceForTestRunner(pageGroup, preference, toBool(value)); This is not maintainable. 715255 4 kangil.han 2012-09-07 21:47:53 -0700 (In reply to comment #3) > > This is not maintainable. Agreed. I will change CodeGenerator to support overloading method. 790501 5 jussi.kukkonen 2012-12-13 04:35:41 -0800 Seo Sanghyeon, Kangil: hi. Is one of you working on this or should I take a stab? I think I have a vision of how this could be done. 790502 6 jussi.kukkonen 2012-12-13 04:41:21 -0800 Actually, how many tests really use non-boolean overridePreference()? I can only see a couple on a quick look through. This might not be worth it if it would only be used in a few tests, and there are no other overloaded IDL functions we need... 790506 7 kangil.han 2012-12-13 04:48:37 -0800 (In reply to comment #6) > Actually, how many tests really use non-boolean overridePreference()? I can only see a couple on a quick look through. > > This might not be worth it if it would only be used in a few tests, and there are no other overloaded IDL functions we need... I am okay if benjamin would agree with you. :) 790886 8 benjamin 2012-12-13 13:53:37 -0800 > This might not be worth it if it would only be used in a few tests, and there are no other overloaded IDL functions we need... Can you please quantify "a few tests"? 791497 9 jussi.kukkonen 2012-12-14 03:02:51 -0800 (In reply to comment #8) > > This might not be worth it if it would only be used in a few tests, and there are no other overloaded IDL functions we need... > > Can you please quantify "a few tests"? I have not checked each preference yet. I can tell that only three tests use overrridePreference() with a value other than [true, false, 0, 1, "0", "1"]: LayoutTests/fast/harness/override-preferences-2.html: testRunner.overridePreference("WebKitDefaultFontSize", "24") LayoutTests/fast/harness/override-preferences-2.html: testRunner.overridePreference("WebKitMinimumFontSize", "12"); LayoutTests/http/tests/download/default-encoding.html: testRunner.overridePreference("WebKitDefaultTextEncodingName", "koi8-r"); Btw, as I was checking things I realized that we have 99 webgl tests in wk2/TestExpectations with this comment: # WebKit2 needs layoutTestController.overridePreference # <https://bugs.webkit.org/show_bug.cgi?id=42197> My understanding was that boolean preferences already work and it looks like these tests only use a boolean override... I run the tests and 82/99 tests pass on wk2-efl. 162028 2012-09-04 06:24:00 -0700 2012-09-07 21:46:07 -0700 patch wtr_override_preference.txt text/plain 9912 kangil.han ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyZTMzY2I4Li43NmZkNThmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTItMDktMDQgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgorCisg ICAgICAgIFtXSzJdW1dUUl0gQ2hhbmdlIG92ZXJyaWRlUHJlZmVyZW5jZSBpbXBsZW1lbnRhdGlv biB0byBhZG9wdCB2YWx1ZSBhcyBTdHJpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05NTU3OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZSBmaXJzdCBhcHByb2FjaCBvZiB0aGlzIHBhdGNoIHdhcyB0 byBjcmVhdGUgdGhyZWUgbW9yZSBvdmVycmlkZVByZWZlcmVuY2Ugb3ZlcmxvYWRpbmcgbWV0aG9k cy4KKyAgICAgICAgSG93ZXZlciwgaXQgd291bGRuJ3QgYmUgcG9zc2libGUgdW5kZXIgY3VycmVu dCBDb2RlR2VuZXJhdG9yVGVzdFJ1bm5lci5wbSBpbXBsZW1lbnRhdGlvbi4KKyAgICAgICAgVGhl cmVmb3JlLCB0aGlzIHBhdGNoIGhhcyBhZG9wdGVkIFdLMSBhcHByb2FjaCwgZS5nLiB0byBvYnRh aW4gYSB2YWx1ZSBhcyBhIFN0cmluZyBhbmQgY2hhbmdlIGl0IHRvIGEgcmVsZXZhbnQgdHlwZSBp biBjYXNlIGJ5IGNhc2UgbWFubmVyLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1 bmRsZS9BUEkvYy9XS0J1bmRsZS5jcHA6CisgICAgICAgIChXS0J1bmRsZU92ZXJyaWRlUHJlZmVy ZW5jZUZvclRlc3RSdW5uZXIpOgorICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUv QVBJL2MvV0tCdW5kbGVQcml2YXRlLmg6CisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1 bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OnRvQm9vbCk6CisgICAg ICAgIChXZWJLaXQpOgorICAgICAgICAoV2ViS2l0OjpJbmplY3RlZEJ1bmRsZTo6b3ZlcnJpZGVQ cmVmZXJlbmNlRm9yVGVzdFJ1bm5lcik6CisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1 bmRsZS9JbmplY3RlZEJ1bmRsZS5oOgorICAgICAgICAoSW5qZWN0ZWRCdW5kbGUpOgorCiAyMDEy LTA5LTA0ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBb RUZMXSBEcm9wIGRlZmF1bHQgdGhlbWUgY29uY2VwdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZS5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlLmNwcAppbmRl eCA2OTE5YTFlLi43MTFhNzQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlLmNwcApAQCAtMTM2LDYgKzEz NiwxMSBAQCB2b2lkIFdLQnVuZGxlT3ZlcnJpZGVCb29sUHJlZmVyZW5jZUZvclRlc3RSdW5uZXIo V0tCdW5kbGVSZWYgYnVuZGxlUmVmLCBXS0J1bmRsZQogICAgIHRvSW1wbChidW5kbGVSZWYpLT5v dmVycmlkZUJvb2xQcmVmZXJlbmNlRm9yVGVzdFJ1bm5lcih0b0ltcGwocGFnZUdyb3VwUmVmKSwg dG9JbXBsKHByZWZlcmVuY2UpLT5zdHJpbmcoKSwgZW5hYmxlZCk7CiB9CiAKK3ZvaWQgV0tCdW5k bGVPdmVycmlkZVByZWZlcmVuY2VGb3JUZXN0UnVubmVyKFdLQnVuZGxlUmVmIGJ1bmRsZVJlZiwg V0tCdW5kbGVQYWdlR3JvdXBSZWYgcGFnZUdyb3VwUmVmLCBXS1N0cmluZ1JlZiBwcmVmZXJlbmNl LCBXS1N0cmluZ1JlZiB2YWx1ZSkKK3sKKyAgICB0b0ltcGwoYnVuZGxlUmVmKS0+b3ZlcnJpZGVQ cmVmZXJlbmNlRm9yVGVzdFJ1bm5lcih0b0ltcGwocGFnZUdyb3VwUmVmKSwgdG9JbXBsKHByZWZl cmVuY2UpLT5zdHJpbmcoKSwgdG9JbXBsKHZhbHVlKS0+c3RyaW5nKCkpOworfQorCiB2b2lkIFdL QnVuZGxlU2V0QWxsb3dVbml2ZXJzYWxBY2Nlc3NGcm9tRmlsZVVSTHMoV0tCdW5kbGVSZWYgYnVu ZGxlUmVmLCBXS0J1bmRsZVBhZ2VHcm91cFJlZiBwYWdlR3JvdXBSZWYsIGJvb2wgZW5hYmxlZCkK IHsKICAgICB0b0ltcGwoYnVuZGxlUmVmKS0+c2V0QWxsb3dVbml2ZXJzYWxBY2Nlc3NGcm9tRmls ZVVSTHModG9JbXBsKHBhZ2VHcm91cFJlZiksIGVuYWJsZWQpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVByaXZhdGUu aCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5k bGVQcml2YXRlLmgKaW5kZXggNDgwNDc4OS4uODEyNWI3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVByaXZhdGUuaAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVu ZGxlUHJpdmF0ZS5oCkBAIC01NSw2ICs1NSw3IEBAIFdLX0VYUE9SVCB2b2lkIFdLQnVuZGxlUmVt b3ZlQWxsVmlzaXRlZExpbmtzKFdLQnVuZGxlUmVmIGJ1bmRsZSk7CiBXS19FWFBPUlQgdm9pZCBX S0J1bmRsZUFjdGl2YXRlTWFjRm9udEFzY2VudEhhY2soV0tCdW5kbGVSZWYgYnVuZGxlKTsKIC8v IFdpbGwgbWFrZSBXZWJQcm9jZXNzIGlnbm9yZSB0aGlzIHByZWZlcmVuY2UgdW50aWwgYSBwcmVm ZXJlbmNlcyBjaGFuZ2Ugbm90aWZpY2F0aW9uLCBvbmx5IGZvciBXZWJLaXRUZXN0UnVubmVyIHVz ZS4KIFdLX0VYUE9SVCB2b2lkIFdLQnVuZGxlT3ZlcnJpZGVCb29sUHJlZmVyZW5jZUZvclRlc3RS dW5uZXIoV0tCdW5kbGVSZWYgYnVuZGxlLCBXS0J1bmRsZVBhZ2VHcm91cFJlZiBwYWdlR3JvdXAs IFdLU3RyaW5nUmVmIHByZWZlcmVuY2UsIGJvb2wgZW5hYmxlZCk7CitXS19FWFBPUlQgdm9pZCBX S0J1bmRsZU92ZXJyaWRlUHJlZmVyZW5jZUZvclRlc3RSdW5uZXIoV0tCdW5kbGVSZWYgYnVuZGxl LCBXS0J1bmRsZVBhZ2VHcm91cFJlZiBwYWdlR3JvdXAsIFdLU3RyaW5nUmVmIHByZWZlcmVuY2Us IFdLU3RyaW5nUmVmIHZhbHVlKTsKIFdLX0VYUE9SVCB2b2lkIFdLQnVuZGxlU2V0QWxsb3dVbml2 ZXJzYWxBY2Nlc3NGcm9tRmlsZVVSTHMoV0tCdW5kbGVSZWYgYnVuZGxlLCBXS0J1bmRsZVBhZ2VH cm91cFJlZiBwYWdlR3JvdXAsIGJvb2wgZW5hYmxlZCk7CiBXS19FWFBPUlQgdm9pZCBXS0J1bmRs ZVNldEFsbG93RmlsZUFjY2Vzc0Zyb21GaWxlVVJMcyhXS0J1bmRsZVJlZiBidW5kbGUsIFdLQnVu ZGxlUGFnZUdyb3VwUmVmIHBhZ2VHcm91cCwgYm9vbCBlbmFibGVkKTsKIFdLX0VYUE9SVCB2b2lk IFdLQnVuZGxlU2V0RnJhbWVGbGF0dGVuaW5nRW5hYmxlZChXS0J1bmRsZVJlZiBidW5kbGUsIFdL QnVuZGxlUGFnZUdyb3VwUmVmIHBhZ2VHcm91cCwgYm9vbCBlbmFibGVkKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUu Y3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1 bmRsZS5jcHAKaW5kZXggM2ZlYWUyOS4uZDU3ZjAzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAK QEAgLTE5Myw2ICsxOTMsMjYgQEAgdm9pZCBJbmplY3RlZEJ1bmRsZTo6b3ZlcnJpZGVCb29sUHJl ZmVyZW5jZUZvclRlc3RSdW5uZXIoV2ViUGFnZUdyb3VwUHJveHkqIHBhZ2UKICN1bmRlZiBGT1Jf RUFDSF9PVkVSUklERV9CT09MX1BSRUZFUkVOQ0UKIH0KIAorc3RhdGljIGlubGluZSBib29sIHRv Qm9vbChjb25zdCBTdHJpbmcmIHZhbHVlKQoreworICAgIHJldHVybiB2YWx1ZSA9PSAidHJ1ZSIg fHwgdmFsdWUgPT0gIjEiOworfQorCit2b2lkIEluamVjdGVkQnVuZGxlOjpvdmVycmlkZVByZWZl cmVuY2VGb3JUZXN0UnVubmVyKFdlYlBhZ2VHcm91cFByb3h5KiBwYWdlR3JvdXAsIGNvbnN0IFN0 cmluZyYgcHJlZmVyZW5jZSwgY29uc3QgU3RyaW5nJiB2YWx1ZSkKK3sKKyAgICBpZiAocHJlZmVy ZW5jZSA9PSAiV2ViS2l0MkFzeW5jaHJvbm91c1BsdWdpbkluaXRpYWxpemF0aW9uRW5hYmxlZCIg fHwgcHJlZmVyZW5jZSA9PSAiV2ViS2l0MkFzeW5jaHJvbm91c1BsdWdpbkluaXRpYWxpemF0aW9u RW5hYmxlZEZvckFsbFBsdWdpbnMiCisgICAgICAgIHx8IHByZWZlcmVuY2UgPT0gIldlYktpdDJB cnRpZmljaWFsUGx1Z2luSW5pdGlhbGl6YXRpb25EZWxheUVuYWJsZWQiIHx8IHByZWZlcmVuY2Ug PT0gIldlYktpdEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkIgorICAgICAgICB8fCBwcmVm ZXJlbmNlID09ICJXZWJLaXRDU1NDdXN0b21GaWx0ZXJFbmFibGVkIiB8fCBwcmVmZXJlbmNlID09 ICJXZWJLaXRDU1NSZWdpb25zRW5hYmxlZCIKKyAgICAgICAgfHwgcHJlZmVyZW5jZSA9PSAiV2Vi S2l0Q1NTR3JpZExheW91dEVuYWJsZWQiIHx8IHByZWZlcmVuY2UgPT0gIldlYktpdEphdmFFbmFi bGVkIgorICAgICAgICB8fCBwcmVmZXJlbmNlID09ICJXZWJLaXRKYXZhU2NyaXB0RW5hYmxlZCIg fHwgcHJlZmVyZW5jZSA9PSAiV2ViS2l0TG9hZFNpdGVJY29uc0tleSIKKyAgICAgICAgfHwgcHJl ZmVyZW5jZSA9PSAiV2ViS2l0T2ZmbGluZVdlYkFwcGxpY2F0aW9uQ2FjaGVFbmFibGVkIiB8fCBw cmVmZXJlbmNlID09ICJXZWJLaXRQYWdlQ2FjaGVTdXBwb3J0c1BsdWdpbnNQcmVmZXJlbmNlS2V5 IgorICAgICAgICB8fCBwcmVmZXJlbmNlID09ICJXZWJLaXRQbHVnaW5zRW5hYmxlZCIgfHwgcHJl ZmVyZW5jZSA9PSAiV2ViS2l0VXNlc1BhZ2VDYWNoZVByZWZlcmVuY2VLZXkiCisgICAgICAgIHx8 IHByZWZlcmVuY2UgPT0gIldlYktpdFdlYkF1ZGlvRW5hYmxlZCIgfHwgcHJlZmVyZW5jZSA9PSAi V2ViS2l0V2ViR0xFbmFibGVkIgorICAgICAgICB8fCBwcmVmZXJlbmNlID09ICJXZWJLaXRYU1NB dWRpdG9yRW5hYmxlZCIgfHwgcHJlZmVyZW5jZSA9PSAiV2ViS2l0U2hvdWxkUmVzcGVjdEltYWdl T3JpZW50YXRpb24iCisgICAgICAgIHx8IHByZWZlcmVuY2UgPT0gIldlYktpdEVuYWJsZUNhcmV0 QnJvd3NpbmciIHx8IHByZWZlcmVuY2UgPT0gIldlYktpdEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdF bmFibGVkIikKKyAgICAgICAgcmV0dXJuIG92ZXJyaWRlQm9vbFByZWZlcmVuY2VGb3JUZXN0UnVu bmVyKHBhZ2VHcm91cCwgcHJlZmVyZW5jZSwgdG9Cb29sKHZhbHVlKSk7Cit9CisKIHZvaWQgSW5q ZWN0ZWRCdW5kbGU6Om92ZXJyaWRlWFNTQXVkaXRvckVuYWJsZWRGb3JUZXN0UnVubmVyKFdlYlBh Z2VHcm91cFByb3h5KiBwYWdlR3JvdXAsIGJvb2wgZW5hYmxlZCkKIHsKICAgICAvLyBPdmVycmlk ZSB0aGUgcHJlZmVyZW5jZSBmb3IgYWxsIGZ1dHVyZSBwYWdlcy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuaCBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuaApp bmRleCBiMDFmZGM1Li42YjdlMGEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmgKKysrIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5oCkBAIC0xMDUsNiArMTA1 LDcgQEAgcHVibGljOgogICAgIHZvaWQgcmVtb3ZlQWxsVmlzaXRlZExpbmtzKCk7CiAgICAgdm9p ZCBhY3RpdmF0ZU1hY0ZvbnRBc2NlbnRIYWNrKCk7CiAgICAgdm9pZCBvdmVycmlkZUJvb2xQcmVm ZXJlbmNlRm9yVGVzdFJ1bm5lcihXZWJQYWdlR3JvdXBQcm94eSosIGNvbnN0IFN0cmluZyYgcHJl ZmVyZW5jZSwgYm9vbCBlbmFibGVkKTsKKyAgICB2b2lkIG92ZXJyaWRlUHJlZmVyZW5jZUZvclRl c3RSdW5uZXIoV2ViUGFnZUdyb3VwUHJveHkqLCBjb25zdCBTdHJpbmcmIHByZWZlcmVuY2UsIGNv bnN0IFN0cmluZyYgdmFsdWUpOwogICAgIHZvaWQgb3ZlcnJpZGVYU1NBdWRpdG9yRW5hYmxlZEZv clRlc3RSdW5uZXIoV2ViUGFnZUdyb3VwUHJveHkqIHBhZ2VHcm91cCwgYm9vbCBlbmFibGVkKTsK ICAgICB2b2lkIHNldEFsbG93VW5pdmVyc2FsQWNjZXNzRnJvbUZpbGVVUkxzKFdlYlBhZ2VHcm91 cFByb3h5KiwgYm9vbCk7CiAgICAgdm9pZCBzZXRBbGxvd0ZpbGVBY2Nlc3NGcm9tRmlsZVVSTHMo V2ViUGFnZUdyb3VwUHJveHkqLCBib29sKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1MzYwOWUyLi5mODliMWM0IDEwMDY0NAotLS0gYS9Ub29s cy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTIt MDktMDQgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtX SzJdW1dUUl0gQ2hhbmdlIG92ZXJyaWRlUHJlZmVyZW5jZSBpbXBsZW1lbnRhdGlvbiB0byBhZG9w dCB2YWx1ZSBhcyBTdHJpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05NTU3OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZSBmaXJzdCBhcHByb2FjaCBvZiB0aGlzIHBhdGNoIHdhcyB0byBjcmVhdGUg dGhyZWUgbW9yZSBvdmVycmlkZVByZWZlcmVuY2Ugb3ZlcmxvYWRpbmcgbWV0aG9kcy4KKyAgICAg ICAgSG93ZXZlciwgaXQgd291bGRuJ3QgYmUgcG9zc2libGUgdW5kZXIgY3VycmVudCBDb2RlR2Vu ZXJhdG9yVGVzdFJ1bm5lci5wbSBpbXBsZW1lbnRhdGlvbi4KKyAgICAgICAgVGhlcmVmb3JlLCB0 aGlzIHBhdGNoIGhhcyBhZG9wdGVkIFdLMSBhcHByb2FjaCwgZS5nLiB0byBvYnRhaW4gYSB2YWx1 ZSBhcyBhIFN0cmluZyBhbmQgY2hhbmdlIGl0IHRvIGEgcmVsZXZhbnQgdHlwZSBpbiBjYXNlIGJ5 IGNhc2UgbWFubmVyLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRs ZS9CaW5kaW5ncy9UZXN0UnVubmVyLmlkbDoKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0lu amVjdGVkQnVuZGxlL1Rlc3RSdW5uZXIuY3BwOgorICAgICAgICAoV1RSOjpUZXN0UnVubmVyOjpv dmVycmlkZVByZWZlcmVuY2UpOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRC dW5kbGUvVGVzdFJ1bm5lci5oOgorICAgICAgICAoVGVzdFJ1bm5lcik6CisKIDIwMTItMDktMDMg IFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIENo YW5nZSB0aGUgZm9jdXMgd2hlbiB0aGUgd2ViIHZpZXcgaXMgY2xpY2tlZCBpbiBNaW5pQnJvd3Nl ciBhbmQgRVdlYkxhdW5jaGVyCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0lu amVjdGVkQnVuZGxlL0JpbmRpbmdzL1Rlc3RSdW5uZXIuaWRsIGIvVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9JbmplY3RlZEJ1bmRsZS9CaW5kaW5ncy9UZXN0UnVubmVyLmlkbAppbmRleCAwN2EzNWEy Li4yODA1YTNkIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVu ZGxlL0JpbmRpbmdzL1Rlc3RSdW5uZXIuaWRsCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv SW5qZWN0ZWRCdW5kbGUvQmluZGluZ3MvVGVzdFJ1bm5lci5pZGwKQEAgLTE0OCw5ICsxNDgsNyBA QCBtb2R1bGUgV1RSIHsKIAogICAgICAgICAvLyBDb29raWVzIHRlc3RpbmcKICAgICAgICAgdm9p ZCBzZXRBbHdheXNBY2NlcHRDb29raWVzKGluIGJvb2xlYW4gYWNjZXB0KTsKLQotICAgICAgICAv LyBGSVhNRTogaGFuZGxlIG5vbi1ib29sZWFuIHByZWZlcmVuY2VzLgotICAgICAgICB2b2lkIG92 ZXJyaWRlUHJlZmVyZW5jZShpbiBET01TdHJpbmcgcHJlZmVyZW5jZSwgaW4gYm9vbGVhbiB2YWx1 ZSk7CisgICAgICAgIHZvaWQgb3ZlcnJpZGVQcmVmZXJlbmNlKGluIERPTVN0cmluZyBwcmVmZXJl bmNlLCBpbiBET01TdHJpbmcgdmFsdWUpOwogCiAgICAgICAgIC8vIFBhZ2UgVmlzaWJpbGl0eSBB UEkKICAgICAgICAgdm9pZCBzZXRQYWdlVmlzaWJpbGl0eShpbiBET01TdHJpbmcgc3RhdGUpOwpk aWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9UZXN0UnVu bmVyLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvVGVzdFJ1bm5l ci5jcHAKaW5kZXggMWFkY2RhYy4uMGEzN2JmYyAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVz dFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9UZXN0UnVubmVyLmNwcAorKysgYi9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL1Rlc3RSdW5uZXIuY3BwCkBAIC02MTEsOSArNjExLDkg QEAgdm9pZCBUZXN0UnVubmVyOjpjYWxsU2V0QmFja2luZ1NjYWxlRmFjdG9yQ2FsbGJhY2soKQog ICAgIGNhbGxUZXN0UnVubmVyQ2FsbGJhY2soU2V0QmFja2luZ1NjYWxlRmFjdG9yQ2FsbGJhY2tJ RCk7CiB9CiAKLXZvaWQgVGVzdFJ1bm5lcjo6b3ZlcnJpZGVQcmVmZXJlbmNlKEpTU3RyaW5nUmVm IHByZWZlcmVuY2UsIGJvb2wgdmFsdWUpCit2b2lkIFRlc3RSdW5uZXI6Om92ZXJyaWRlUHJlZmVy ZW5jZShKU1N0cmluZ1JlZiBwcmVmZXJlbmNlLCBKU1N0cmluZ1JlZiB2YWx1ZSkKIHsKLSAgICBX S0J1bmRsZU92ZXJyaWRlQm9vbFByZWZlcmVuY2VGb3JUZXN0UnVubmVyKEluamVjdGVkQnVuZGxl OjpzaGFyZWQoKS5idW5kbGUoKSwgSW5qZWN0ZWRCdW5kbGU6OnNoYXJlZCgpLnBhZ2VHcm91cCgp LCB0b1dLKHByZWZlcmVuY2UpLmdldCgpLCB2YWx1ZSk7CisgICAgV0tCdW5kbGVPdmVycmlkZVBy ZWZlcmVuY2VGb3JUZXN0UnVubmVyKEluamVjdGVkQnVuZGxlOjpzaGFyZWQoKS5idW5kbGUoKSwg SW5qZWN0ZWRCdW5kbGU6OnNoYXJlZCgpLnBhZ2VHcm91cCgpLCB0b1dLKHByZWZlcmVuY2UpLmdl dCgpLCB0b1dLKHZhbHVlKS5nZXQoKSk7CiB9CiAKIHZvaWQgVGVzdFJ1bm5lcjo6c2VuZFdlYklu dGVudFJlc3BvbnNlKEpTU3RyaW5nUmVmIHJlcGx5KQpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9UZXN0UnVubmVyLmggYi9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL0luamVjdGVkQnVuZGxlL1Rlc3RSdW5uZXIuaAppbmRleCA4YzQwNDJlLi42MzRmMzA1 IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL1Rlc3RS dW5uZXIuaAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL1Rlc3RS dW5uZXIuaApAQCAtMjEwLDggKzIxMCw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGNhbGxSZW1vdmVD aHJvbWVJbnB1dEZpZWxkQ2FsbGJhY2soKTsKICAgICB2b2lkIGNhbGxGb2N1c1dlYlZpZXdDYWxs YmFjaygpOwogICAgIHZvaWQgY2FsbFNldEJhY2tpbmdTY2FsZUZhY3RvckNhbGxiYWNrKCk7Ci0K LSAgICB2b2lkIG92ZXJyaWRlUHJlZmVyZW5jZShKU1N0cmluZ1JlZiBwcmVmZXJlbmNlLCBib29s IHZhbHVlKTsKKyAgICB2b2lkIG92ZXJyaWRlUHJlZmVyZW5jZShKU1N0cmluZ1JlZiBwcmVmZXJl bmNlLCBKU1N0cmluZ1JlZiB2YWx1ZSk7CiAKICAgICAvLyBXZWIgaW50ZW50cyB0ZXN0aW5nLgog ICAgIHZvaWQgc2VuZFdlYkludGVudFJlc3BvbnNlKEpTU3RyaW5nUmVmIHJlcGx5KTsK