95575 2012-08-31 08:11:34 -0700 [Qt] ImageDiff output is not in the expected form if image dimensions differ 2012-08-31 08:49:55 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kbalazs kbalazs ossy oldest_to_newest 709641 0 kbalazs 2012-08-31 08:11:34 -0700 This makes NRWT confused so it tries to read towards the stdout, than it reports that ImageDiff has timed out. We should put smg like 'diff: 100% failed' to the stdout, as it is done for mac and gtk (at least). 709642 1 161705 kbalazs 2012-08-31 08:14:06 -0700 Created attachment 161705 Patch 709648 2 161705 ossy 2012-08-31 08:24:22 -0700 Comment on attachment 161705 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161705&action=review LGTM, r=me with some minor nit. > Tools/ChangeLog:8 > + > + nit: - an empty line :) > Tools/DumpRenderTree/qt/ImageDiff.cpp:87 > + fputs("diff: 100%% failed\n", stdout); Could you use fprintf as everywhere else? 709666 3 kbalazs 2012-08-31 08:49:40 -0700 Landed in http://trac.webkit.org/changeset/127268 161705 2012-08-31 08:14:06 -0700 2012-08-31 08:49:55 -0700 Patch bug-95575-20120831171353.patch text/plain 1516 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MjY0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTBkZThjNjFhYzI5MjQ0ODdiMzI3YTRjZDc4YmYxZTA1 ZDQyMWIzNi4uMDYzYjI2Yzg2OWY5OGMwMWIzNGU0ODM4OTM4M2Q1OTViZmY2ODk5OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTA4LTMxICBCYWxhenMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKwor ICAgICAgICBbUXRdIEltYWdlRGlmZiBvdXRwdXQgaXMgbm90IGluIHRoZSBleHBlY3RlZCBmb3Jt IGlmIGltYWdlIGRpbWVuc2lvbnMgZGlmZmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05NTU3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisKKyAgICAgICAgT3V0cHV0IDEwMCUgZGlmZmVyZW5jZSBpbiB0aGUgY2FzZSBv ZiBkaWZmZXJpbmcgaW1hZ2UgZGltZW5zaW9ucyBzbworICAgICAgICB0aGUgdGVzdCBoYXJuZXNz IGtub3dzIHRoYXQgd2Ugd29uJ3QgcHJvZHVjZSBhbnkgb3V0cHV0IGZ1cnRoZXIuCisgICAgICAg IFRoaXMgbWF0Y2hlcyB0aGUgYmVoYXZpb3Igb2Ygb3RoZXIgcG9ydHMuCisKKyAgICAgICAgKiBE dW1wUmVuZGVyVHJlZS9xdC9JbWFnZURpZmYuY3BwOgorICAgICAgICAobWFpbik6CisKIDIwMTIt MDgtMzEgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjcyNjEuCmRpZmYgLS1naXQgYS9Ub29scy9E dW1wUmVuZGVyVHJlZS9xdC9JbWFnZURpZmYuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQv SW1hZ2VEaWZmLmNwcAppbmRleCA3YWZhMWVlMTg3OWQxNDA0MGJkNWIxNzhiZDI3MjFiNjBiYWI0 ZmQ3Li45MThlNWNiYmE0OTJiM2ExOTdmZDZmMzg0Y2ZiMjM5MzM4NDAyYjE4IDEwMDY0NAotLS0g YS9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9JbWFnZURpZmYuY3BwCisrKyBiL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL3F0L0ltYWdlRGlmZi5jcHAKQEAgLTg0LDcgKzg0LDkgQEAgaW50IG1haW4oaW50 IGFyZ2MsIGNoYXIqIGFyZ3ZbXSkKIAogICAgICAgICAgICAgaWYgKGFjdHVhbEltYWdlLnNpemUo KSAhPSBiYXNlbGluZUltYWdlLnNpemUoKSkgewogICAgICAgICAgICAgICAgIGZwcmludGYoc3Rk ZXJyLCAiZXJyb3IsIHRlc3QgYW5kIHJlZmVyZW5jZSBpbWFnZSBoYXZlIGRpZmZlcmVudCBwcm9w ZXJ0aWVzLlxuIik7CisgICAgICAgICAgICAgICAgZnB1dHMoImRpZmY6IDEwMCUlIGZhaWxlZFxu Iiwgc3Rkb3V0KTsKICAgICAgICAgICAgICAgICBmZmx1c2goc3RkZXJyKTsKKyAgICAgICAgICAg ICAgICBmZmx1c2goc3Rkb3V0KTsKICAgICAgICAgICAgIH0gZWxzZSB7CiAKICAgICAgICAgICAg ICAgICBpbnQgdyA9IGFjdHVhbEltYWdlLndpZHRoKCk7Cg==