95558 2012-08-31 04:58:36 -0700 [Qt] The LayerTreeRenderer::callOnMainTread method name is misleading 2012-08-31 10:08:36 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kbalazs kbalazs kenneth luiz noam oldest_to_newest 709494 0 kbalazs 2012-08-31 04:58:36 -0700 This is a typo. The function is actually named callOnMainTread (no h), but call sites spells it correctly so they call WTF::callOnMainThread. 709498 1 161668 kbalazs 2012-08-31 05:03:01 -0700 Created attachment 161668 Patch 709506 2 161668 rafael.lobo 2012-08-31 05:12:56 -0700 Comment on attachment 161668 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161668&action=review > Source/WebKit2/ChangeLog:3 > + [Qt] LayerTreeRenderer::callOnMainThread is brokken like this senteance You should rewrite this bug title, it's not clear what are you trying to fix by reading that and there are typos ("broken" and "sentence"). > Source/WebKit2/ChangeLog:10 > + make it clear that these things are not the same. Could you explain the difference? For some reason I think "call" is more clear, but maybe I didn't get what this is actually doing. 709529 3 161677 kbalazs 2012-08-31 05:49:13 -0700 Created attachment 161677 Patch 709535 4 161677 kenneth 2012-08-31 05:52:26 -0700 Comment on attachment 161677 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161677&action=review > Source/WebKit2/ChangeLog:3 > + [Qt] LayerTreeRenderer::callOnMainThread is mistyped I changed the bug name as this is even more misleading... it sounds like it is using wrong types 709538 5 kbalazs 2012-08-31 05:53:56 -0700 (In reply to comment #4) > (From update of attachment 161677 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=161677&action=review > > > Source/WebKit2/ChangeLog:3 > > + [Qt] LayerTreeRenderer::callOnMainThread is mistyped > > I changed the bug name as this is even more misleading... it sounds like it is using wrong types Ok, right, I actually uploaded a new patch but I can fix the changelog title before landing. 709546 6 161677 kenneth 2012-08-31 06:00:26 -0700 Comment on attachment 161677 Patch That is fine 709748 7 kbalazs 2012-08-31 10:08:26 -0700 Landed in http://trac.webkit.org/changeset/127273 161668 2012-08-31 05:03:01 -0700 2012-08-31 05:49:09 -0700 Patch bug-95558-20120831140219.patch text/plain 3508 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NzQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2NiZmI3YmI2OTdhMzBm Y2IyZGI0NzZhZjg5ZjA1NzM1MTZiZjk3ZS4uMzg4NTIyYzBiYmNiNDJiYzUyMWZjNmMwMWU0ZGEy YTIwNDJiZGE2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA4LTMxICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdIExheWVyVHJl ZVJlbmRlcmVyOjpjYWxsT25NYWluVGhyZWFkIGlzIGJyb2trZW4gbGlrZSB0aGlzIHNlbnRlYW5j ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU1NTgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdGhl IHR5cG8gaW4gdGhlIGZ1bmN0aW9uIG5hbWUgc28gY2FsbGVycyB3aWxsIHJlYWxseSBjYWxsIHRo aXMKKyAgICAgICAgYW5kIG5vdCBXVEY6OmNhbGxPbk1haW5UaHJlYWQuIFJlbmFtZWQgdG8gZGlz cGF0Y2hPbk1haW5UaHJlYWQgdG8KKyAgICAgICAgbWFrZSBpdCBjbGVhciB0aGF0IHRoZXNlIHRo aW5ncyBhcmUgbm90IHRoZSBzYW1lLgorCisgICAgICAgICogVUlQcm9jZXNzL0Nvb3JkaW5hdGVk R3JhcGhpY3MvTGF5ZXJUcmVlUmVuZGVyZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpMYXllclRy ZWVSZW5kZXJlcjo6ZGlzcGF0Y2hPbk1haW5UaHJlYWQpOgorICAgICAgICAoV2ViS2l0OjpMYXll clRyZWVSZW5kZXJlcjo6Zmx1c2hMYXllckNoYW5nZXMpOgorICAgICAgICAoV2ViS2l0OjpMYXll clRyZWVSZW5kZXJlcjo6cHVyZ2VHTFJlc291cmNlcyk6CisgICAgICAgICogVUlQcm9jZXNzL0Nv b3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlUmVuZGVyZXIuaDoKKyAgICAgICAgKExheWVyVHJl ZVJlbmRlcmVyKToKKwogMjAxMi0wOC0yNyAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFu bkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XVtXSzJdIFJFR1JFU1NJT04ocjEyNjA2Nyk6IEl0 IG1hZGUgcW1sdGVzdHM6OkRvdWJsZVRhcFRvWm9vbTo6dGVzdF9iYXNpYygpIGZhaWwKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVy VHJlZVJlbmRlcmVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdy YXBoaWNzL0xheWVyVHJlZVJlbmRlcmVyLmNwcAppbmRleCA0ODFiOWY3NGI4OTg2MTE5NDZjYjY4 NzRkZGJhZTI5NTIyMDc5ZGJiLi5iOTRjNjZiOWQzNjYwMTFiZDg1Y2FkMzIyN2YwNWRmNzdiYzQ5 M2VlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFw aGljcy9MYXllclRyZWVSZW5kZXJlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlUmVuZGVyZXIuY3BwCkBAIC02Niw3ICs2Niw3 IEBAIHByaXZhdGU6CiAgICAgfQogfTsKIAotdm9pZCBMYXllclRyZWVSZW5kZXJlcjo6Y2FsbE9u TWFpblRyZWFkKGNvbnN0IEZ1bmN0aW9uPHZvaWQoKT4mIGZ1bmN0aW9uKQordm9pZCBMYXllclRy ZWVSZW5kZXJlcjo6ZGlzcGF0Y2hPbk1haW5UaHJlYWQoY29uc3QgRnVuY3Rpb248dm9pZCgpPiYg ZnVuY3Rpb24pCiB7CiAgICAgaWYgKGlzTWFpblRocmVhZCgpKQogICAgICAgICBmdW5jdGlvbigp OwpAQCAtMzk3LDcgKzM5Nyw3IEBAIHZvaWQgTGF5ZXJUcmVlUmVuZGVyZXI6OmZsdXNoTGF5ZXJD aGFuZ2VzKCkKICAgICBjb21taXRUaWxlT3BlcmF0aW9ucygpOwogCiAgICAgLy8gVGhlIHBlbmRp bmcgdGlsZXMgc3RhdGUgaXMgb24gaXRzIHdheSBmb3IgdGhlIHNjcmVlbiwgdGVsbCB0aGUgd2Vi IHByb2Nlc3MgdG8gcmVuZGVyIHRoZSBuZXh0IG9uZS4KLSAgICBjYWxsT25NYWluVGhyZWFkKGJp bmQoJkxheWVyVHJlZVJlbmRlcmVyOjpyZW5kZXJOZXh0RnJhbWUsIHRoaXMpKTsKKyAgICBkaXNw YXRjaE9uTWFpblRocmVhZChiaW5kKCZMYXllclRyZWVSZW5kZXJlcjo6cmVuZGVyTmV4dEZyYW1l LCB0aGlzKSk7CiB9CiAKIHZvaWQgTGF5ZXJUcmVlUmVuZGVyZXI6OnJlbmRlck5leHRGcmFtZSgp CkBAIC00NTgsNyArNDU4LDcgQEAgdm9pZCBMYXllclRyZWVSZW5kZXJlcjo6cHVyZ2VHTFJlc291 cmNlcygpCiAKICAgICBzZXRBY3RpdmUoZmFsc2UpOwogCi0gICAgY2FsbE9uTWFpblRocmVhZChi aW5kKCZMYXllclRyZWVSZW5kZXJlcjo6cHVyZ2VCYWNraW5nU3RvcmVzLCB0aGlzKSk7CisgICAg ZGlzcGF0Y2hPbk1haW5UaHJlYWQoYmluZCgmTGF5ZXJUcmVlUmVuZGVyZXI6OnB1cmdlQmFja2lu Z1N0b3JlcywgdGhpcykpOwogfQogCiB2b2lkIExheWVyVHJlZVJlbmRlcmVyOjpzZXRBbmltYXRl ZE9wYWNpdHkodWludDMyX3QgaWQsIGZsb2F0IG9wYWNpdHkpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRyZWVSZW5kZXJlci5o IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVl UmVuZGVyZXIuaAppbmRleCA1NzA2YTRjY2RmY2QwNzQ4NTYxNzljMzMxMmY3MGVhMjRhZmQ4MzZh Li40ZTQ1Njc4ZTZmMDAzYWU1MjJjMDlkZjBiZDNlNzdmNmExZGE2MWRiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRyZWVSZW5k ZXJlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNz L0xheWVyVHJlZVJlbmRlcmVyLmgKQEAgLTEwNCw3ICsxMDQsNyBAQCBwcml2YXRlOgogICAgIHZp cnR1YWwgYm9vbCBzaG93RGVidWdCb3JkZXJzKGNvbnN0IFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXIq KSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogICAgIHZpcnR1YWwgYm9vbCBzaG93UmVwYWludENv dW50ZXIoY29uc3QgV2ViQ29yZTo6R3JhcGhpY3NMYXllciopIGNvbnN0IHsgcmV0dXJuIGZhbHNl OyB9CiAgICAgdm9pZCBwYWludENvbnRlbnRzKGNvbnN0IFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXIq LCBXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQmLCBXZWJDb3JlOjpHcmFwaGljc0xheWVyUGFpbnRp bmdQaGFzZSwgY29uc3QgV2ViQ29yZTo6SW50UmVjdCYpIHsgfQotICAgIHZvaWQgY2FsbE9uTWFp blRyZWFkKGNvbnN0IEZ1bmN0aW9uPHZvaWQoKT4mKTsKKyAgICB2b2lkIGRpc3BhdGNoT25NYWlu VGhyZWFkKGNvbnN0IEZ1bmN0aW9uPHZvaWQoKT4mKTsKICAgICB2b2lkIGFkanVzdFBvc2l0aW9u Rm9yRml4ZWRMYXllcnMoKTsKIAogICAgIHR5cGVkZWYgSGFzaE1hcDxXZWJMYXllcklELCBXZWJD b3JlOjpHcmFwaGljc0xheWVyKj4gTGF5ZXJNYXA7Cg== 161677 2012-08-31 05:49:13 -0700 2012-08-31 10:08:36 -0700 Patch bug-95558-20120831144831.patch text/plain 3489 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NzQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2NiZmI3YmI2OTdhMzBm Y2IyZGI0NzZhZjg5ZjA1NzM1MTZiZjk3ZS4uOWRiNTlkMmQxMDA5MWI1ZWZjYTJmNThhZjRhYzBh NWY3MDAyODgxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA4LTMxICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdIExheWVyVHJl ZVJlbmRlcmVyOjpjYWxsT25NYWluVGhyZWFkIGlzIG1pc3R5cGVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTU1OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCB0aGUgdHlwbyBpbiB0aGUgZnVuY3Rp b24gbmFtZSBzbyBjYWxsZXJzIHdpbGwgcmVhbGx5IGNhbGwgdGhpcworICAgICAgICBhbmQgbm90 IFdURjo6Y2FsbE9uTWFpblRocmVhZC4gUmVuYW1lZCB0byBkaXNwYXRjaE9uTWFpblRocmVhZCB0 bworICAgICAgICBtYWtlIGl0IGNsZWFyIHRoYXQgdGhlc2UgdGhpbmdzIGFyZSBub3QgdGhlIHNh bWUuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRyZWVS ZW5kZXJlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OkxheWVyVHJlZVJlbmRlcmVyOjpkaXNwYXRj aE9uTWFpblRocmVhZCk6CisgICAgICAgIChXZWJLaXQ6OkxheWVyVHJlZVJlbmRlcmVyOjpmbHVz aExheWVyQ2hhbmdlcyk6CisgICAgICAgIChXZWJLaXQ6OkxheWVyVHJlZVJlbmRlcmVyOjpwdXJn ZUdMUmVzb3VyY2VzKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9M YXllclRyZWVSZW5kZXJlci5oOgorICAgICAgICAoTGF5ZXJUcmVlUmVuZGVyZXIpOgorCiAyMDEy LTA4LTI3ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KIAogICAg ICAgICBbUXRdW1dLMl0gUkVHUkVTU0lPTihyMTI2MDY3KTogSXQgbWFkZSBxbWx0ZXN0czo6RG91 YmxlVGFwVG9ab29tOjp0ZXN0X2Jhc2ljKCkgZmFpbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlUmVuZGVyZXIuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlUmVu ZGVyZXIuY3BwCmluZGV4IDQ4MWI5Zjc0Yjg5ODYxMTk0NmNiNjg3NGRkYmFlMjk1MjIwNzlkYmIu LmI5NGM2NmI5ZDM2NjAxMWJkODVjYWQzMjI3ZjA1ZGY3N2JjNDkzZWUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZVJlbmRl cmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGlj cy9MYXllclRyZWVSZW5kZXJlci5jcHAKQEAgLTY2LDcgKzY2LDcgQEAgcHJpdmF0ZToKICAgICB9 CiB9OwogCi12b2lkIExheWVyVHJlZVJlbmRlcmVyOjpjYWxsT25NYWluVHJlYWQoY29uc3QgRnVu Y3Rpb248dm9pZCgpPiYgZnVuY3Rpb24pCit2b2lkIExheWVyVHJlZVJlbmRlcmVyOjpkaXNwYXRj aE9uTWFpblRocmVhZChjb25zdCBGdW5jdGlvbjx2b2lkKCk+JiBmdW5jdGlvbikKIHsKICAgICBp ZiAoaXNNYWluVGhyZWFkKCkpCiAgICAgICAgIGZ1bmN0aW9uKCk7CkBAIC0zOTcsNyArMzk3LDcg QEAgdm9pZCBMYXllclRyZWVSZW5kZXJlcjo6Zmx1c2hMYXllckNoYW5nZXMoKQogICAgIGNvbW1p dFRpbGVPcGVyYXRpb25zKCk7CiAKICAgICAvLyBUaGUgcGVuZGluZyB0aWxlcyBzdGF0ZSBpcyBv biBpdHMgd2F5IGZvciB0aGUgc2NyZWVuLCB0ZWxsIHRoZSB3ZWIgcHJvY2VzcyB0byByZW5kZXIg dGhlIG5leHQgb25lLgotICAgIGNhbGxPbk1haW5UaHJlYWQoYmluZCgmTGF5ZXJUcmVlUmVuZGVy ZXI6OnJlbmRlck5leHRGcmFtZSwgdGhpcykpOworICAgIGRpc3BhdGNoT25NYWluVGhyZWFkKGJp bmQoJkxheWVyVHJlZVJlbmRlcmVyOjpyZW5kZXJOZXh0RnJhbWUsIHRoaXMpKTsKIH0KIAogdm9p ZCBMYXllclRyZWVSZW5kZXJlcjo6cmVuZGVyTmV4dEZyYW1lKCkKQEAgLTQ1OCw3ICs0NTgsNyBA QCB2b2lkIExheWVyVHJlZVJlbmRlcmVyOjpwdXJnZUdMUmVzb3VyY2VzKCkKIAogICAgIHNldEFj dGl2ZShmYWxzZSk7CiAKLSAgICBjYWxsT25NYWluVGhyZWFkKGJpbmQoJkxheWVyVHJlZVJlbmRl cmVyOjpwdXJnZUJhY2tpbmdTdG9yZXMsIHRoaXMpKTsKKyAgICBkaXNwYXRjaE9uTWFpblRocmVh ZChiaW5kKCZMYXllclRyZWVSZW5kZXJlcjo6cHVyZ2VCYWNraW5nU3RvcmVzLCB0aGlzKSk7CiB9 CiAKIHZvaWQgTGF5ZXJUcmVlUmVuZGVyZXI6OnNldEFuaW1hdGVkT3BhY2l0eSh1aW50MzJfdCBp ZCwgZmxvYXQgb3BhY2l0eSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9D b29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZVJlbmRlcmVyLmggYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRyZWVSZW5kZXJlci5oCmluZGV4IDU3 MDZhNGNjZGZjZDA3NDg1NjE3OWMzMzEyZjcwZWEyNGFmZDgzNmEuLjRlNDU2NzhlNmYwMDNhZTUy MmMwOWRmMGJkM2U3N2Y2YTFkYTYxZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZVJlbmRlcmVyLmgKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlUmVuZGVyZXIu aApAQCAtMTA0LDcgKzEwNCw3IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCBib29sIHNob3dEZWJ1 Z0JvcmRlcnMoY29uc3QgV2ViQ29yZTo6R3JhcGhpY3NMYXllciopIGNvbnN0IHsgcmV0dXJuIGZh bHNlOyB9CiAgICAgdmlydHVhbCBib29sIHNob3dSZXBhaW50Q291bnRlcihjb25zdCBXZWJDb3Jl OjpHcmFwaGljc0xheWVyKikgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICAgICB2b2lkIHBhaW50 Q29udGVudHMoY29uc3QgV2ViQ29yZTo6R3JhcGhpY3NMYXllciosIFdlYkNvcmU6OkdyYXBoaWNz Q29udGV4dCYsIFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJQYWludGluZ1BoYXNlLCBjb25zdCBXZWJD b3JlOjpJbnRSZWN0JikgeyB9Ci0gICAgdm9pZCBjYWxsT25NYWluVHJlYWQoY29uc3QgRnVuY3Rp b248dm9pZCgpPiYpOworICAgIHZvaWQgZGlzcGF0Y2hPbk1haW5UaHJlYWQoY29uc3QgRnVuY3Rp b248dm9pZCgpPiYpOwogICAgIHZvaWQgYWRqdXN0UG9zaXRpb25Gb3JGaXhlZExheWVycygpOwog CiAgICAgdHlwZWRlZiBIYXNoTWFwPFdlYkxheWVySUQsIFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXIq PiBMYXllck1hcDsK