95550 2012-08-31 03:59:38 -0700 Build warning : -Wformat on WebMemorySampler.cpp. 2012-08-31 20:45:40 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 bw80.lee webkit-unassigned gyuyoung.kim slewis webkit.review.bot oldest_to_newest 709469 0 bw80.lee 2012-08-31 03:59:38 -0700 Fix build warning -Wformat on WebMemorySampler.cpp by adding explicit casting. 709474 1 161658 bw80.lee 2012-08-31 04:05:16 -0700 Created attachment 161658 Patch 709552 2 161658 gyuyoung.kim 2012-08-31 06:06:52 -0700 Comment on attachment 161658 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161658&action=review > Source/WebKit2/Shared/WebMemorySampler.cpp:178 > + statString.append(String::format("%lu", static_cast<long unsigned int>(memoryStats.values[i]))); Is it enough *unsigned long* ? 709867 3 161658 darin 2012-08-31 12:04:21 -0700 Comment on attachment 161658 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161658&action=review A better fix would probably be to use String::number instead of String::format. >> Source/WebKit2/Shared/WebMemorySampler.cpp:178 >> + statString.append(String::format("%lu", static_cast<long unsigned int>(memoryStats.values[i]))); > > Is it enough *unsigned long* ? That’s right. In our code we use the name “unsigned long” for this type, not “long unsigned int”, which is equivalent, but not idiomatic. When landing this please use “unsigned long” rather than “long unsigned int”. 710103 4 161801 bw80.lee 2012-08-31 17:52:58 -0700 Created attachment 161801 Patch 710104 5 bw80.lee 2012-08-31 17:54:07 -0700 Ok I applied that. Thanks for all your comments :) 710116 6 161805 bw80.lee 2012-08-31 18:10:50 -0700 Created attachment 161805 Patch 710126 7 161805 gyuyoung.kim 2012-08-31 19:10:41 -0700 Comment on attachment 161805 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161805&action=review > Source/WebKit2/Shared/WebMemorySampler.cpp:178 > + statString.append(String::format("%lu", static_cast<unsigned long>(memoryStats.values[i]))); As Darin said, please use String::number instead of String::format. 710131 8 bw80.lee 2012-08-31 19:35:20 -0700 (In reply to comment #7) > (From update of attachment 161805 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=161805&action=review > > > Source/WebKit2/Shared/WebMemorySampler.cpp:178 > > + statString.append(String::format("%lu", static_cast<unsigned long>(memoryStats.values[i]))); > > As Darin said, please use String::number instead of String::format. Sorry for my carelessness. I didn't read the upper part about String::number. I'll apply those and upload again. Thanks :) 710134 9 161811 bw80.lee 2012-08-31 19:50:01 -0700 Created attachment 161811 Patch 710145 10 161811 webkit.review.bot 2012-08-31 20:45:36 -0700 Comment on attachment 161811 Patch Clearing flags on attachment: 161811 Committed r127353: <http://trac.webkit.org/changeset/127353> 710146 11 webkit.review.bot 2012-08-31 20:45:40 -0700 All reviewed patches have been landed. Closing bug. 161658 2012-08-31 04:05:16 -0700 2012-08-31 17:52:50 -0700 Patch bug-95550-20120831200500.patch text/plain 1569 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmUyMzY1NDQyNjIwMTNi MWJjYWQ1MTRjYjQxM2EzMzYzOTg3Njg2MC4uNTJjMTdhYzU5ZGQ4OWQ0NDdlMzg1ZTE4ZGIwNDhm YTFmYjJkYTFjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTMxICBCeXVu Z3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBCdWlsZCB3YXJuaW5n IDogLVdmb3JtYXQgb24gV2ViTWVtb3J5U2FtcGxlci5jcHAuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTU1MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBidWlsZCB3YXJuaW5nIGJ5IGFkZGluZyBl eHBsaWNpdCBjYXN0aW5nLgorCisgICAgICAgICogU2hhcmVkL1dlYk1lbW9yeVNhbXBsZXIuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJNZW1vcnlTYW1wbGVyOjphcHBlbmRDdXJyZW50TWVtb3J5 VXNhZ2VUb0ZpbGUpOgorCiAyMDEyLTA4LTMwICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVy Z0BhcHBsZS5jb20+CiAKICAgICAgICAgfkpTTlBPYmplY3Qgc2hvdWxkIGNhbGwgaW52YWxpZGF0 ZSgpIGlmIGl0IGhhc24ndCBiZWVuIGNhbGxlZCBhbHJlYWR5CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvV2ViTWVtb3J5U2FtcGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFy ZWQvV2ViTWVtb3J5U2FtcGxlci5jcHAKaW5kZXggYmRiYWIyZDJkOGU3NDk4YTAwYzlhYjFhZjNh MzFkYTgzMzg3ZWUzYy4uMzg0YjcxNjM1MGJkZjhlM2VmNWEwNjYxZmNmNjZjOGQ1MTdmNjQ0OSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYk1lbW9yeVNhbXBsZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJNZW1vcnlTYW1wbGVyLmNwcApAQCAtMTc1LDcg KzE3NSw3IEBAIHZvaWQgV2ViTWVtb3J5U2FtcGxlcjo6YXBwZW5kQ3VycmVudE1lbW9yeVVzYWdl VG9GaWxlKFBsYXRmb3JtRmlsZUhhbmRsZSYgZmlsZSkKICAgICAgICAgc3RhdFN0cmluZy5hcHBl bmQobV9zZXBhcmF0b3IpOwogICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1lbW9yeVN0 YXRzLnZhbHVlcy5zaXplKCk7ICsraSkgewogICAgICAgICAgICAgc3RhdFN0cmluZy5hcHBlbmQo bV9zZXBhcmF0b3IpOwotICAgICAgICAgICAgc3RhdFN0cmluZy5hcHBlbmQoU3RyaW5nOjpmb3Jt YXQoIiVsdSIsIG1lbW9yeVN0YXRzLnZhbHVlc1tpXSkpOworICAgICAgICAgICAgc3RhdFN0cmlu Zy5hcHBlbmQoU3RyaW5nOjpmb3JtYXQoIiVsdSIsIHN0YXRpY19jYXN0PGxvbmcgdW5zaWduZWQg aW50PihtZW1vcnlTdGF0cy52YWx1ZXNbaV0pKSk7CiAgICAgICAgIH0KICAgICB9CiAgICAgc3Rh dFN0cmluZy5hcHBlbmQoU3RyaW5nKCJcbiIpKTsK 161801 2012-08-31 17:52:58 -0700 2012-08-31 18:10:43 -0700 Patch bug-95550-20120901095240.patch text/plain 1565 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MjM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmUyMzY1NDQyNjIwMTNi MWJjYWQ1MTRjYjQxM2EzMzYzOTg3Njg2MC4uNTJjMTdhYzU5ZGQ4OWQ0NDdlMzg1ZTE4ZGIwNDhm YTFmYjJkYTFjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTMxICBCeXVu Z3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBCdWlsZCB3YXJuaW5n IDogLVdmb3JtYXQgb24gV2ViTWVtb3J5U2FtcGxlci5jcHAuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTU1MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBidWlsZCB3YXJuaW5nIGJ5IGFkZGluZyBl eHBsaWNpdCBjYXN0aW5nLgorCisgICAgICAgICogU2hhcmVkL1dlYk1lbW9yeVNhbXBsZXIuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJNZW1vcnlTYW1wbGVyOjphcHBlbmRDdXJyZW50TWVtb3J5 VXNhZ2VUb0ZpbGUpOgorCiAyMDEyLTA4LTMwICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVy Z0BhcHBsZS5jb20+CiAKICAgICAgICAgfkpTTlBPYmplY3Qgc2hvdWxkIGNhbGwgaW52YWxpZGF0 ZSgpIGlmIGl0IGhhc24ndCBiZWVuIGNhbGxlZCBhbHJlYWR5CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvV2ViTWVtb3J5U2FtcGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFy ZWQvV2ViTWVtb3J5U2FtcGxlci5jcHAKaW5kZXggYmRiYWIyZDJkOGU3NDk4YTAwYzlhYjFhZjNh MzFkYTgzMzg3ZWUzYy4uMzY3YTFkYzU1M2M4ZThlOWQ5YjlkNGZkMmQ3NTNkNzA1MmFlNzgwMCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYk1lbW9yeVNhbXBsZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJNZW1vcnlTYW1wbGVyLmNwcApAQCAtMTc1LDcg KzE3NSw3IEBAIHZvaWQgV2ViTWVtb3J5U2FtcGxlcjo6YXBwZW5kQ3VycmVudE1lbW9yeVVzYWdl VG9GaWxlKFBsYXRmb3JtRmlsZUhhbmRsZSYgZmlsZSkKICAgICAgICAgc3RhdFN0cmluZy5hcHBl bmQobV9zZXBhcmF0b3IpOwogICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1lbW9yeVN0 YXRzLnZhbHVlcy5zaXplKCk7ICsraSkgewogICAgICAgICAgICAgc3RhdFN0cmluZy5hcHBlbmQo bV9zZXBhcmF0b3IpOwotICAgICAgICAgICAgc3RhdFN0cmluZy5hcHBlbmQoU3RyaW5nOjpmb3Jt YXQoIiVsdSIsIG1lbW9yeVN0YXRzLnZhbHVlc1tpXSkpOworICAgICAgICAgICAgc3RhdFN0cmlu Zy5hcHBlbmQoU3RyaW5nOjpmb3JtYXQoIiVsdSIsIHN0YXRpY19jYXN0PHVuc2lnbmVkIGxvbmc+ KG1lbW9yeVN0YXRzLnZhbHVlc1tpXSkpKTsKICAgICAgICAgfQogICAgIH0KICAgICBzdGF0U3Ry aW5nLmFwcGVuZChTdHJpbmcoIlxuIikpOwo= 161805 2012-08-31 18:10:50 -0700 2012-08-31 19:49:53 -0700 Patch bug-95550-20120901101033.patch text/plain 1562 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MjM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmUyMzY1NDQyNjIwMTNi MWJjYWQ1MTRjYjQxM2EzMzYzOTg3Njg2MC4uODE4OTdlYjA3NzEzODcxYTYwNzc2N2U3YTg4ZTU3 YThhYzgyMjNhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTMxICBCeXVu Z3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBCdWlsZCB3YXJuaW5n IDogLVdmb3JtYXQgb24gV2ViTWVtb3J5U2FtcGxlci5jcHAuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTU1MAorCisgICAgICAgIFJldmlld2VkIGJ5 IERhcmluIEFkbGVyLgorCisgICAgICAgIEZpeCBidWlsZCB3YXJuaW5nIGJ5IGFkZGluZyBleHBs aWNpdCBjYXN0aW5nLgorCisgICAgICAgICogU2hhcmVkL1dlYk1lbW9yeVNhbXBsZXIuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJNZW1vcnlTYW1wbGVyOjphcHBlbmRDdXJyZW50TWVtb3J5VXNh Z2VUb0ZpbGUpOgorCiAyMDEyLTA4LTMwICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0Bh cHBsZS5jb20+CiAKICAgICAgICAgfkpTTlBPYmplY3Qgc2hvdWxkIGNhbGwgaW52YWxpZGF0ZSgp IGlmIGl0IGhhc24ndCBiZWVuIGNhbGxlZCBhbHJlYWR5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvV2ViTWVtb3J5U2FtcGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv V2ViTWVtb3J5U2FtcGxlci5jcHAKaW5kZXggYmRiYWIyZDJkOGU3NDk4YTAwYzlhYjFhZjNhMzFk YTgzMzg3ZWUzYy4uMzY3YTFkYzU1M2M4ZThlOWQ5YjlkNGZkMmQ3NTNkNzA1MmFlNzgwMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYk1lbW9yeVNhbXBsZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJNZW1vcnlTYW1wbGVyLmNwcApAQCAtMTc1LDcgKzE3 NSw3IEBAIHZvaWQgV2ViTWVtb3J5U2FtcGxlcjo6YXBwZW5kQ3VycmVudE1lbW9yeVVzYWdlVG9G aWxlKFBsYXRmb3JtRmlsZUhhbmRsZSYgZmlsZSkKICAgICAgICAgc3RhdFN0cmluZy5hcHBlbmQo bV9zZXBhcmF0b3IpOwogICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1lbW9yeVN0YXRz LnZhbHVlcy5zaXplKCk7ICsraSkgewogICAgICAgICAgICAgc3RhdFN0cmluZy5hcHBlbmQobV9z ZXBhcmF0b3IpOwotICAgICAgICAgICAgc3RhdFN0cmluZy5hcHBlbmQoU3RyaW5nOjpmb3JtYXQo IiVsdSIsIG1lbW9yeVN0YXRzLnZhbHVlc1tpXSkpOworICAgICAgICAgICAgc3RhdFN0cmluZy5h cHBlbmQoU3RyaW5nOjpmb3JtYXQoIiVsdSIsIHN0YXRpY19jYXN0PHVuc2lnbmVkIGxvbmc+KG1l bW9yeVN0YXRzLnZhbHVlc1tpXSkpKTsKICAgICAgICAgfQogICAgIH0KICAgICBzdGF0U3RyaW5n LmFwcGVuZChTdHJpbmcoIlxuIikpOwo= 161811 2012-08-31 19:50:01 -0700 2012-08-31 20:45:36 -0700 Patch bug-95550-20120901114944.patch text/plain 1555 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MjM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmUyMzY1NDQyNjIwMTNi MWJjYWQ1MTRjYjQxM2EzMzYzOTg3Njg2MC4uNDRkM2NiMDA0ZWVmNGZiMGU2MWY4OWI5MmNiZTM5 MmJkYTMxMDZmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA5LTAxICBCeXVu Z3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBCdWlsZCB3YXJuaW5n IDogLVdmb3JtYXQgb24gV2ViTWVtb3J5U2FtcGxlci5jcHAuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTU1MAorCisgICAgICAgIFJldmlld2VkIGJ5 IERhcmluIEFkbGVyLgorCisgICAgICAgIEZpeCBidWlsZCB3YXJuaW5nLgorICAgICAgICBVc2Ug U3RyaW5nOjpudW1iZXIgaW5zdGVhZCBvZiBTdHJpbmc6OmZvcm1hdC4KKworICAgICAgICAqIFNo YXJlZC9XZWJNZW1vcnlTYW1wbGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTWVtb3J5U2Ft cGxlcjo6YXBwZW5kQ3VycmVudE1lbW9yeVVzYWdlVG9GaWxlKToKKwogMjAxMi0wOC0zMCAgTWFy ayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIH5KU05QT2Jq ZWN0IHNob3VsZCBjYWxsIGludmFsaWRhdGUoKSBpZiBpdCBoYXNuJ3QgYmVlbiBjYWxsZWQgYWxy ZWFkeQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYk1lbW9yeVNhbXBsZXIu Y3BwIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYk1lbW9yeVNhbXBsZXIuY3BwCmluZGV4IGJk YmFiMmQyZDhlNzQ5OGEwMGM5YWIxYWYzYTMxZGE4MzM4N2VlM2MuLmMwMzI0NmEyNzQ5MWJiMDEw ZWMwMTkxNjNlN2QxODRlOTZjOWFjMzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJl ZC9XZWJNZW1vcnlTYW1wbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViTWVt b3J5U2FtcGxlci5jcHAKQEAgLTE3NSw3ICsxNzUsNyBAQCB2b2lkIFdlYk1lbW9yeVNhbXBsZXI6 OmFwcGVuZEN1cnJlbnRNZW1vcnlVc2FnZVRvRmlsZShQbGF0Zm9ybUZpbGVIYW5kbGUmIGZpbGUp CiAgICAgICAgIHN0YXRTdHJpbmcuYXBwZW5kKG1fc2VwYXJhdG9yKTsKICAgICAgICAgZm9yIChz aXplX3QgaSA9IDA7IGkgPCBtZW1vcnlTdGF0cy52YWx1ZXMuc2l6ZSgpOyArK2kpIHsKICAgICAg ICAgICAgIHN0YXRTdHJpbmcuYXBwZW5kKG1fc2VwYXJhdG9yKTsKLSAgICAgICAgICAgIHN0YXRT dHJpbmcuYXBwZW5kKFN0cmluZzo6Zm9ybWF0KCIlbHUiLCBtZW1vcnlTdGF0cy52YWx1ZXNbaV0p KTsKKyAgICAgICAgICAgIHN0YXRTdHJpbmcuYXBwZW5kKFN0cmluZzo6bnVtYmVyKG1lbW9yeVN0 YXRzLnZhbHVlc1tpXSkpOwogICAgICAgICB9CiAgICAgfQogICAgIHN0YXRTdHJpbmcuYXBwZW5k KFN0cmluZygiXG4iKSk7Cg==