95546 2012-08-31 02:54:52 -0700 [DRT] Make simulating a web click on a notification a queued task 2012-08-31 11:55:23 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.8 RESOLVED FIXED InRadar P2 Normal --- 77969 1 jonlee jonlee ap jberlin webkit-bug-importer oldest_to_newest 709437 0 jonlee 2012-08-31 02:54:52 -0700 When simulating a user click on a web notification, make sure that the click is treated like a 0-timer task, rather than clicking synchronously. It mimics reality more accurately. 709438 1 webkit-bug-importer 2012-08-31 02:55:24 -0700 <rdar://problem/12214170> 709770 2 161730 jonlee 2012-08-31 10:29:51 -0700 Created attachment 161730 Patch 709797 3 161730 ap 2012-08-31 10:53:02 -0700 Comment on attachment 161730 Patch r=me I suggest adding an ASSERT(!m_hasPendingWebNotificationClick) when DRT is dumping test results - the m_hasPendingWebNotificationClick check in dispatched block is insufficient for safety. If one test calls simulateWebNotificationClick, finishes, and then another one does the same, we'll end up dispatching original notificationID, breaking the second test. 709816 4 ap 2012-08-31 11:08:54 -0700 To be clear, r+ is conditional on fixing this. A test that leaves an outstanding notification clearly has a bug, and an assertion would go a longer way towards preventing flakiness than silently passing the error condition to the next test. The dispatched block is going to be executed anyway during the next test, and there is no guarantee that m_hasPendingWebNotificationClick will still be false by that time 709855 5 161730 jonlee 2012-08-31 11:51:26 -0700 Comment on attachment 161730 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161730&action=review > Tools/DumpRenderTree/mac/TestRunnerMac.mm:331 > + m_hasPendingWebNotificationClick = false; Per ap's comments, removing this reset, and instead add an assert in dump(). 709857 6 jonlee 2012-08-31 11:55:23 -0700 Committed r127298: <http://trac.webkit.org/changeset/127298> 161730 2012-08-31 10:29:51 -0700 2012-08-31 11:51:26 -0700 Patch bug-95546-20120831102939.patch text/plain 4169 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3Mjc1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTBhOTQwMGI3MDkyYjExOWE1ZjE2MjI4NzRmM2EyOWU4 ODI1MTJhOS4uMDY0MGVkNTlhNDZkOTQ1MGExODI4MzlkZTQxMWRlMWY0ZjIwZDUzNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1 IEBACisyMDEyLTA4LTMxICBKb24gTGVlICA8am9ubGVlQGFwcGxlLmNvbT4KKworICAgICAgICBb RFJUXSBNYWtlIHNpbXVsYXRpbmcgYSB3ZWIgY2xpY2sgb24gYSBub3RpZmljYXRpb24gYSBxdWV1 ZWQgdGFzaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTU1NDYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyMjE0MTcwPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2luZyB0aGUgd2ViIGNsaWNrIGhh cHBlbiBhc3luY2hyb25vdXNseSBiZXR0ZXIgbWltaWNzIHVzZXIgaW50ZXJhY3Rpb24gd2l0aCB0 aGUgcGxhdGZvcm0uCisgICAgICAgIFdlIG5lZWQgdG8gbWFrZSBzdXJlLCBob3dldmVyLCB0aGF0 IGEgcGVuZGluZyBjbGljayBkb2VzIGdldCBleGVjdXRlZCBpZiB3ZSd2ZSBhbHJlYWR5IGZpbmlz aGVkCisgICAgICAgIHRoZSB0ZXN0LgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvVGVzdFJ1 bm5lci5oOiBBZGQgYSBmbGFnIHRoYXQgZGV0ZXJtaW5lcyB3aGV0aGVyIHdlIGhhdmUgYSBwZW5k aW5nIG5vdGlmaWNhdGlvbiBjbGljay4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL1Rlc3RS dW5uZXIuY3BwOiBUZXN0cyB0aGF0IHVzZSBzaW11bGF0ZWQgY2xpY2tzIGJ5IG5hdHVyZSBtdXN0 IGhhdmUKKyAgICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCkgc2V0LiBXaGVuIHRoZSB0 ZXN0IGNhbGxzIG5vdGlmeURvbmUoKSwgd2UgdW5zZXQgdGhpcyBmbGFnLgorICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL21hYy9UZXN0UnVubmVyTWFjLm1tOgorICAgICAgICAoVGVzdFJ1bm5lcjo6 bm90aWZ5RG9uZSk6IFVuc2V0IHRoZSBmbGFnLgorICAgICAgICAoVGVzdFJ1bm5lcjo6c2ltdWxh dGVXZWJOb3RpZmljYXRpb25DbGljayk6IFNldCB0aGUgZmxhZywgdGhlbiBhZGQgYSB0YXNrIHRv IGNsaWNrIHRoZQorICAgICAgICBub3RpZmljYXRpb24uIEluIHRoZSBjYXNlIHdoZXJlIHRoZSBi bG9jayBnZXRzIGV4ZWN1dGVkIGFmdGVyIHRoZSBmbGFnIGhhcyBiZWVuIHVuc2V0LCB3ZSBhdm9p ZAorICAgICAgICBwZXJmb3JtaW5nIHRoZSBjbGljay4KKwogMjAxMi0wOC0zMSAgQmFsYXpzIEtl bGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XSBJbWFnZURpZmYgb3V0 cHV0IGlzIG5vdCBpbiB0aGUgZXhwZWN0ZWQgZm9ybSBpZiBpbWFnZSBkaW1lbnNpb25zIGRpZmZl cgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdFJ1bm5lci5jcHAgYi9Ub29s cy9EdW1wUmVuZGVyVHJlZS9UZXN0UnVubmVyLmNwcAppbmRleCBkNWU3OTlkOGZkMTM0YWIwZGI5 ZDlkNjA3NGQwYmYxZTlhMDhkMjNmLi43OTRlYjE5MjM1YTQwN2M3NjgwMWU0Mjk2YjdlNTRjZDBm MTgzMzJkIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0UnVubmVyLmNwcAor KysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0UnVubmVyLmNwcApAQCAtOTQsNiArOTQsNyBA QCBUZXN0UnVubmVyOjpUZXN0UnVubmVyKGNvbnN0IHN0ZDo6c3RyaW5nJiB0ZXN0UGF0aE9yVVJM LCBjb25zdCBzdGQ6OnN0cmluZyYgZXhwZQogICAgICwgbV9zaG91bGRTdGF5T25QYWdlQWZ0ZXJI YW5kbGluZ0JlZm9yZVVubG9hZChmYWxzZSkKICAgICAsIG1fYXJlTGVnYWN5V2ViTm90aWZpY2F0 aW9uUGVybWlzc2lvblJlcXVlc3RzSWdub3JlZChmYWxzZSkKICAgICAsIG1fY3VzdG9tRnVsbFNj cmVlbkJlaGF2aW9yKGZhbHNlKSAKKyAgICAsIG1faGFzUGVuZGluZ1dlYk5vdGlmaWNhdGlvbkNs aWNrKGZhbHNlKQogICAgICwgbV90ZXN0UGF0aE9yVVJMKHRlc3RQYXRoT3JVUkwpCiAgICAgLCBt X2V4cGVjdGVkUGl4ZWxIYXNoKGV4cGVjdGVkUGl4ZWxIYXNoKQogICAgICwgbV90aXRsZVRleHRE aXJlY3Rpb24oImx0ciIpCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0UnVu bmVyLmggYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0UnVubmVyLmgKaW5kZXggYjY2MzdjNmFm ZDEzODE3NjA4ZDExYzdhMzBkZDBlY2FhZTI0NzNhNC4uODRkYTE4MGUzYTBlZDQ3NjJlZmI2ZmQ5 NzMxYWI5NjE4OWVhMWRhNyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdFJ1 bm5lci5oCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3RSdW5uZXIuaApAQCAtNDIzLDYg KzQyMyw3IEBAIHByaXZhdGU6CiAgICAgLy8gRklYTUUgODE2OTc6IFRoaXMgdmFyaWFibGUgbW9z dCBsaWtlbHkgd2lsbCBiZSByZW1vdmVkIG9uY2Ugd2UgaGF2ZSBtaWdyYXRlZCB0aGUgdGVzdHMg ZnJvbSBmYXN0L25vdGlmaWNhdGlvbnMgdG8gaHR0cC90ZXN0cy9ub3RpZmljYXRpb25zLgogICAg IGJvb2wgbV9hcmVMZWdhY3lXZWJOb3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVzdHNJZ25vcmVk OwogICAgIGJvb2wgbV9jdXN0b21GdWxsU2NyZWVuQmVoYXZpb3I7CisgICAgYm9vbCBtX2hhc1Bl bmRpbmdXZWJOb3RpZmljYXRpb25DbGljazsKIAogICAgIHN0ZDo6c3RyaW5nIG1fYXV0aGVudGlj YXRpb25Vc2VybmFtZTsKICAgICBzdGQ6OnN0cmluZyBtX2F1dGhlbnRpY2F0aW9uUGFzc3dvcmQ7 IApkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL1Rlc3RSdW5uZXJNYWMubW0g Yi9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMvVGVzdFJ1bm5lck1hYy5tbQppbmRleCA2YzY1MTY2 MmJmNzBhNmJkNzM1ZjlkY2MxOWU0NDg2OTlmNTI3NTI1Li41ZjJiZDI0NjNhOThiZTVkZTFmNDUx ZGY2NDhkZmVhNmI1N2ZlYmEzIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMv VGVzdFJ1bm5lck1hYy5tbQorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMvVGVzdFJ1bm5l ck1hYy5tbQpAQCAtMzI4LDYgKzMyOCw3IEBAIHZvaWQgVGVzdFJ1bm5lcjo6bm90aWZ5RG9uZSgp CiAgICAgaWYgKG1fd2FpdFRvRHVtcCAmJiAhdG9wTG9hZGluZ0ZyYW1lICYmICFXb3JrUXVldWU6 OnNoYXJlZCgpLT5jb3VudCgpKQogICAgICAgICBkdW1wKCk7CiAgICAgbV93YWl0VG9EdW1wID0g ZmFsc2U7CisgICAgbV9oYXNQZW5kaW5nV2ViTm90aWZpY2F0aW9uQ2xpY2sgPSBmYWxzZTsKIH0K IAogc3RhdGljIGlubGluZSBzdGQ6OnN0cmluZyBzdHJpbmdGcm9tSlNTdHJpbmcoSlNTdHJpbmdS ZWYganNTdHJpbmcpCkBAIC0xMjA2LDcgKzEyMDcsMTMgQEAgdm9pZCBUZXN0UnVubmVyOjpyZW1v dmVBbGxXZWJOb3RpZmljYXRpb25QZXJtaXNzaW9ucygpCiB2b2lkIFRlc3RSdW5uZXI6OnNpbXVs YXRlV2ViTm90aWZpY2F0aW9uQ2xpY2soSlNWYWx1ZVJlZiBqc05vdGlmaWNhdGlvbikKIHsKICAg ICB1aW50NjRfdCBub3RpZmljYXRpb25JRCA9IFtbbWFpbkZyYW1lIHdlYlZpZXddIF9ub3RpZmlj YXRpb25JREZvclRlc3Rpbmc6anNOb3RpZmljYXRpb25dOwotICAgIFtbTW9ja1dlYk5vdGlmaWNh dGlvblByb3ZpZGVyIHNoYXJlZF0gc2ltdWxhdGVXZWJOb3RpZmljYXRpb25DbGljazpub3RpZmlj YXRpb25JRF07CisgICAgbV9oYXNQZW5kaW5nV2ViTm90aWZpY2F0aW9uQ2xpY2sgPSB0cnVlOwor ICAgIGRpc3BhdGNoX2FzeW5jKGRpc3BhdGNoX2dldF9tYWluX3F1ZXVlKCksIF57CisgICAgICAg IGlmICghbV9oYXNQZW5kaW5nV2ViTm90aWZpY2F0aW9uQ2xpY2spCisgICAgICAgICAgICByZXR1 cm47CisgICAgICAgIFtbTW9ja1dlYk5vdGlmaWNhdGlvblByb3ZpZGVyIHNoYXJlZF0gc2ltdWxh dGVXZWJOb3RpZmljYXRpb25DbGljazpub3RpZmljYXRpb25JRF07CisgICAgICAgIG1faGFzUGVu ZGluZ1dlYk5vdGlmaWNhdGlvbkNsaWNrID0gZmFsc2U7CisgICAgfSk7CiB9CiAKIHZvaWQgVGVz dFJ1bm5lcjo6c2ltdWxhdGVMZWdhY3lXZWJOb3RpZmljYXRpb25DbGljayhKU1N0cmluZ1JlZiBq c1RpdGxlKQo=