95540 2012-08-31 02:02:44 -0700 Web Inspector: use linkifyResourceAsNode, not linkifyLocation when linkifying resources in Timeline 2012-09-03 02:57:15 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 709403 0 caseq 2012-08-31 02:02:44 -0700 linkifyLocation requires line number and is for linkifying location within potentially source-mapped resources, so use linkifyResoruceAsNode for resource-related records (ScheduleResourceRequest..ResourceFinish). 709408 1 161643 caseq 2012-08-31 02:06:15 -0700 Created attachment 161643 Patch 709441 2 161643 webkit.review.bot 2012-08-31 02:56:33 -0700 Comment on attachment 161643 Patch Rejecting attachment 161643 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13714149 710517 3 caseq 2012-09-03 02:57:15 -0700 Committed r127415: <http://trac.webkit.org/changeset/127415> 161643 2012-08-31 02:06:15 -0700 2012-08-31 02:56:33 -0700 Patch bug-95540-20120831130602.patch text/plain 2827 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzMwMTEyNTI2OTQ5OTBl NWMwMjg1YTY5Yjg1MTMzNjEwOWVkMzlmZC4uZWY0NTFiM2ViNzIzODg3YmQ3ZDA3NTEwZDkyMjc2 ZjYzNjkzYjUzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTMxICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogdXNlIGxpbmtpZnlSZXNvdXJjZUFzTm9kZSwgbm90IGxpbmtpZnlMb2NhdGlvbiB3aGVuIGxp bmtpZnlpbmcgcmVzb3VyY2VzIGluIFRpbWVsaW5lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTU0MAorCisgICAgICAgTGlua2lmeSByZWNvdXJjZSBk ZXRhaWxzIHVzaW5nIFdlYkluc3BlY3Rvci5saW5raWZ5UmVzb3VyY2VBc05vZGUoKSwgc28gdGhl c2UgYnlwYXNzIGxpbmtpZmllci4gQWxzbworICAgICAgIGZpeCBjbG9zdXJlIGNvbXBpbGVyIHdh cm5pbmcuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUHJlc2VudGF0 aW9uTW9kZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVQcmVzZW50YXRpb25N b2RlbC5SZWNvcmQucHJvdG90eXBlLl9nZW5lcmF0ZVBvcHVwQ29udGVudFdpdGhJbWFnZVByZXZp ZXcpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUHJlc2VudGF0aW9uTW9kZWwuUmVj b3JkLnByb3RvdHlwZS5fbGlua2lmeUxvY2F0aW9uKToKKwogMjAxMi0wOC0zMSAgU2ltb24gSGF1 c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBQb3J0IGNv bnZlcnRWYWx1ZVRvUVZhcmlhbnQgdG8gdXNlIHRoZSBKU0MgQyBBUEkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQcmVzZW50YXRpb25Nb2Rl bC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQcmVzZW50 YXRpb25Nb2RlbC5qcwppbmRleCBlMDI0YWExNDk2M2NhN2U2N2MwYTRhYzkzNWM2ZTE4ZGM5ZTgy ZTU2Li4yZDJlZGVhNGUwMjE0OTQ3ODVlM2EwYWNiMmI5MGE4Y2I4ODFmOGQ4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUHJlc2VudGF0aW9u TW9kZWwuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGlu ZVByZXNlbnRhdGlvbk1vZGVsLmpzCkBAIC03NTEsNyArNzUxLDcgQEAgV2ViSW5zcGVjdG9yLlRp bWVsaW5lUHJlc2VudGF0aW9uTW9kZWwuUmVjb3JkLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAg IGNhc2UgcmVjb3JkVHlwZXMuUmVzb3VyY2VSZWNlaXZlUmVzcG9uc2U6CiAgICAgICAgICAgICBj YXNlIHJlY29yZFR5cGVzLlJlc291cmNlUmVjZWl2ZWREYXRhOgogICAgICAgICAgICAgY2FzZSBy ZWNvcmRUeXBlcy5SZXNvdXJjZUZpbmlzaDoKLSAgICAgICAgICAgICAgICBjb250ZW50SGVscGVy Ll9hcHBlbmRFbGVtZW50Um93KFdlYkluc3BlY3Rvci5VSVN0cmluZygiUmVzb3VyY2UiKSwgdGhp cy5fbGlua2lmeUxvY2F0aW9uKHRoaXMudXJsKSk7CisgICAgICAgICAgICAgICAgY29udGVudEhl bHBlci5fYXBwZW5kRWxlbWVudFJvdyhXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlJlc291cmNlIiks IFdlYkluc3BlY3Rvci5saW5raWZ5UmVzb3VyY2VBc05vZGUodGhpcy51cmwpKTsKICAgICAgICAg ICAgICAgICBpZiAocHJldmlld0VsZW1lbnQpCiAgICAgICAgICAgICAgICAgICAgIGNvbnRlbnRI ZWxwZXIuX2FwcGVuZEVsZW1lbnRSb3coV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJQcmV2aWV3Iiks IHByZXZpZXdFbGVtZW50KTsKICAgICAgICAgICAgICAgICBpZiAodGhpcy5kYXRhWyJyZXF1ZXN0 TWV0aG9kIl0pCkBAIC04NzAsMTUgKzg3MCwxNCBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVQcmVz ZW50YXRpb25Nb2RlbC5SZWNvcmQucHJvdG90eXBlID0gewogCiAgICAgLyoqCiAgICAgICogQHBh cmFtIHtzdHJpbmd9IHVybAotICAgICAqIEBwYXJhbSB7bnVtYmVyPX0gbGluZU51bWJlcgorICAg ICAqIEBwYXJhbSB7bnVtYmVyfSBsaW5lTnVtYmVyCiAgICAgICogQHBhcmFtIHtudW1iZXI9fSBj b2x1bW5OdW1iZXIKICAgICAgKi8KICAgICBfbGlua2lmeUxvY2F0aW9uOiBmdW5jdGlvbih1cmws IGxpbmVOdW1iZXIsIGNvbHVtbk51bWJlcikKICAgICB7CiAgICAgICAgIC8vIEZJWE1FKDYyNzI1 KTogc3RhY2sgdHJhY2UgbGluZS9jb2x1bW4gbnVtYmVycyBhcmUgb25lLWJhc2VkLgotICAgICAg ICBsaW5lTnVtYmVyID0gbGluZU51bWJlciA/IGxpbmVOdW1iZXIgLSAxIDogbGluZU51bWJlcjsK ICAgICAgICAgY29sdW1uTnVtYmVyID0gY29sdW1uTnVtYmVyID8gY29sdW1uTnVtYmVyIC0gMSA6 IDA7Ci0gICAgICAgIHJldHVybiB0aGlzLl9saW5raWZpZXIubGlua2lmeUxvY2F0aW9uKHVybCwg bGluZU51bWJlciwgY29sdW1uTnVtYmVyLCAidGltZWxpbmUtZGV0YWlscyIpOworICAgICAgICBy ZXR1cm4gdGhpcy5fbGlua2lmaWVyLmxpbmtpZnlMb2NhdGlvbih1cmwsIGxpbmVOdW1iZXIgLSAx LCBjb2x1bW5OdW1iZXIsICJ0aW1lbGluZS1kZXRhaWxzIik7CiAgICAgfSwKIAogICAgIF9saW5r aWZ5Q2FsbEZyYW1lOiBmdW5jdGlvbihjYWxsRnJhbWUpCg==