95538 2012-08-31 01:46:27 -0700 The options dictionary in Notification constructor should not accept event listeners 2012-09-10 11:07:55 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac OS X 10.8 RESOLVED FIXED InRadar P2 Normal --- 1 jonlee jonlee ap eoconnor jberlin jianli webkit-bug-importer oldest_to_newest 709385 0 jonlee 2012-08-31 01:46:27 -0700 According to the latest spec, event listeners can only be set after the Notification has been created. A previous version allowed them to be set in the options dictionary. http://dvcs.w3.org/hg/notifications/raw-file/tip/Overview.html#api 709386 1 webkit-bug-importer 2012-08-31 01:46:52 -0700 <rdar://problem/12213901> 709963 2 161768 jonlee 2012-08-31 14:06:25 -0700 Created attachment 161768 Patch 716287 3 jonlee 2012-09-10 11:07:55 -0700 Committed r128080: <http://trac.webkit.org/changeset/128080> 161768 2012-08-31 14:06:25 -0700 2012-09-10 10:35:30 -0700 Patch bug-95538-20120831140613.patch text/plain 5535 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MzEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzg3YWNjYzRiNDI5N2Zh ZWYzMTcwOTEwZjQxZGZiMWI4NjhkMTkxNy4uNWFlMWE5YWIxNDMzNjk5OTgwYzc1NDQ4NDdmMzg1 NGM5Njc0YTU1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTMxICBKb24g TGVlICA8am9ubGVlQGFwcGxlLmNvbT4KKworICAgICAgICBUaGUgb3B0aW9ucyBkaWN0aW9uYXJ5 IGluIE5vdGlmaWNhdGlvbiBjb25zdHJ1Y3RvciBzaG91bGQgbm90IGFjY2VwdCBldmVudCBsaXN0 ZW5lcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1 NTM4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMjIxMzkwMT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgbGF0ZXN0IHNwZWMgb25seSBhbGxv d3Mgc2V0dGluZyB0aGUgZXZlbnQgbGlzdGVuZXJzIGFmdGVyIHRoZSBub3RpZmljYXRpb24gaGFz IGJlZW4gY3JlYXRlZC4KKworICAgICAgICBUZXN0OiBodHRwL3Rlc3RzL25vdGlmaWNhdGlvbnMv ZXZlbnRzLWluLWRpY3Rpb25hcnkuaHRtbAorCisgICAgICAgICogTW9kdWxlcy9ub3RpZmljYXRp b25zL05vdGlmaWNhdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOb3RpZmljYXRpb246OmNy ZWF0ZSk6IERvIG5vdCBsb29rIGZvciB0aGUgZXZlbnQgaGFuZGxlcnMgaW4gdGhlIG9wdGlvbnMg ZGljdGlvbmFyeS4KKwogMjAxMi0wOC0zMCAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gUHV0IGNvbXBvc2l0b3IgY2xpZW50IGludGVy ZmFjZXMgaW4gc2VwYXJhdGUgaGVhZGVycywgbm9ybWFsaXplIG5hbWluZwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbi5jcHAgYi9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uLmNwcAppbmRl eCAzNmExYzhjYmJlNjM5NzFiZDMxMjcxNTVhYTM0ZjQzMmQ1MTAzNjMyLi44Y2I2ZGZlZWIzNTli ZTA5M2NiYjU0MTRmYjNjOGIwOWU4NWU3OTJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uLmNwcApAQCAtMTM4LDEzICsxMzgs NiBAQCBQYXNzUmVmUHRyPE5vdGlmaWNhdGlvbj4gTm90aWZpY2F0aW9uOjpjcmVhdGUoY29uc3Qg U3RyaW5nJiB0aXRsZSwgY29uc3QgU3RyaW5nJgogI2VuZGlmCiAKICNpZiBFTkFCTEUoTk9USUZJ Q0FUSU9OUykKLXN0YXRpYyB2b2lkIGdldEFuZEFkZEV2ZW50TGlzdGVuZXIoY29uc3QgQXRvbWlj U3RyaW5nJiBldmVudE5hbWUsIGNvbnN0IGNoYXIqIHByb3BlcnR5LCBjb25zdCBEaWN0aW9uYXJ5 JiBvcHRpb25zLCBOb3RpZmljYXRpb24qIG5vdGlmaWNhdGlvbikKLXsKLSAgICBSZWZQdHI8RXZl bnRMaXN0ZW5lcj4gbGlzdGVuZXIgPSBvcHRpb25zLmdldEV2ZW50TGlzdGVuZXIocHJvcGVydHks IG5vdGlmaWNhdGlvbik7Ci0gICAgaWYgKGxpc3RlbmVyKQotICAgICAgICBub3RpZmljYXRpb24t PmFkZEV2ZW50TGlzdGVuZXIoZXZlbnROYW1lLCBsaXN0ZW5lci5yZWxlYXNlKCksIGZhbHNlKTsK LX0KLQogUGFzc1JlZlB0cjxOb3RpZmljYXRpb24+IE5vdGlmaWNhdGlvbjo6Y3JlYXRlKFNjcmlw dEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIGNvbnN0IFN0cmluZyYgdGl0bGUsIGNvbnN0IERp Y3Rpb25hcnkmIG9wdGlvbnMpCiB7CiAgICAgUmVmUHRyPE5vdGlmaWNhdGlvbj4gbm90aWZpY2F0 aW9uKGFkb3B0UmVmKG5ldyBOb3RpZmljYXRpb24oY29udGV4dCwgdGl0bGUpKSk7CkBAIC0xNTMs MTAgKzE0Niw2IEBAIFBhc3NSZWZQdHI8Tm90aWZpY2F0aW9uPiBOb3RpZmljYXRpb246OmNyZWF0 ZShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0LCBjCiAgICAgICAgIG5vdGlmaWNhdGlv bi0+c2V0Qm9keShhcmd1bWVudCk7CiAgICAgaWYgKG9wdGlvbnMuZ2V0KCJ0YWciLCBhcmd1bWVu dCkpCiAgICAgICAgIG5vdGlmaWNhdGlvbi0+c2V0VGFnKGFyZ3VtZW50KTsKLSAgICBnZXRBbmRB ZGRFdmVudExpc3RlbmVyKGV2ZW50TmFtZXMoKS5zaG93RXZlbnQsICJvbnNob3ciLCBvcHRpb25z LCBub3RpZmljYXRpb24uZ2V0KCkpOwotICAgIGdldEFuZEFkZEV2ZW50TGlzdGVuZXIoZXZlbnRO YW1lcygpLmNsb3NlRXZlbnQsICJvbmNsb3NlIiwgb3B0aW9ucywgbm90aWZpY2F0aW9uLmdldCgp KTsKLSAgICBnZXRBbmRBZGRFdmVudExpc3RlbmVyKGV2ZW50TmFtZXMoKS5lcnJvckV2ZW50LCAi b25lcnJvciIsIG9wdGlvbnMsIG5vdGlmaWNhdGlvbi5nZXQoKSk7Ci0gICAgZ2V0QW5kQWRkRXZl bnRMaXN0ZW5lcihldmVudE5hbWVzKCkuY2xpY2tFdmVudCwgIm9uY2xpY2siLCBvcHRpb25zLCBu b3RpZmljYXRpb24uZ2V0KCkpOwogCiAgICAgbm90aWZpY2F0aW9uLT5zdXNwZW5kSWZOZWVkZWQo KTsKICAgICByZXR1cm4gbm90aWZpY2F0aW9uLnJlbGVhc2UoKTsKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4MGIxMzAxZWI5 NWE5OWE2ZGE1ZGRiYjZlN2E5YTJmN2JkYjc1OGFiLi4yZWRmYTIyOTJjNmM4MWUzNmMzMTQ2MjU4 MjFhODI1NWI4Nzg1YTRlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDgtMzEgIEpvbiBM ZWUgIDxqb25sZWVAYXBwbGUuY29tPgorCisgICAgICAgIFRoZSBvcHRpb25zIGRpY3Rpb25hcnkg aW4gTm90aWZpY2F0aW9uIGNvbnN0cnVjdG9yIHNob3VsZCBub3QgYWNjZXB0IGV2ZW50IGxpc3Rl bmVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU1 MzgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyMjEzOTAxPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3VyZSB0aGUgb25zaG93IGhhbmRs ZXIgYWRkZWQgaW4gdGhlIG9wdGlvbnMgZGljdGlvbmFyeSBkb2VzIG5vdCBnZXQgY2FsbGVkLgor CisgICAgICAgICogaHR0cC90ZXN0cy9ub3RpZmljYXRpb25zL2V2ZW50cy1pbi1kaWN0aW9uYXJ5 LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9ub3RpZmljYXRpb25z L2V2ZW50cy1pbi1kaWN0aW9uYXJ5Lmh0bWw6IEFkZGVkLgorCiAyMDEyLTA4LTMxICBKZXNzaWUg QmVybGluICA8amJlcmxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgVGhlIGZhc3QvZm9ybXMvIGZp bGUgdGVzdHMgd2VyZSBtb3ZlZCBpbiB0aGUgZmlsZSBzdWItZGlyZWN0b3J5IGluIHI5NjkxOC4g UmVtb3ZlIHRoZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9ub3RpZmljYXRp b25zL2V2ZW50cy1pbi1kaWN0aW9uYXJ5LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0dHAv dGVzdHMvbm90aWZpY2F0aW9ucy9ldmVudHMtaW4tZGljdGlvbmFyeS1leHBlY3RlZC50eHQKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uODQwMWE0YzY3OGI4OTgwM2YzNDYyNjVjZWNjZTBmNzA1NzFjOWM5MAotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbm90aWZpY2F0aW9ucy9ldmVudHMt aW4tZGljdGlvbmFyeS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMSBAQAorVGhpcyB0ZXN0IGVu c3VyZXMgZXZlbnQgaGFuZGxlcnMgZGVmaW5lZCBpbnNpZGUgdGhlIG9wdGlvbnMgZGljdGlvbmFy eSBhcmUgaWdub3JlZC4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQ QVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgTm90 aWZpY2F0aW9uLnBlcm1pc3Npb24gaXMgImdyYW50ZWQiCitQQVNTIG9uc2hvdyBldmVudCBoYW5k bGVyIGRlZmluZWQgYWZ0ZXIgTm90aWZpY2F0aW9uIGNvbnN0cnVjdGlvbiB3YXMgY2FsbGVkCitQ QVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9ub3RpZmljYXRpb25zL2V2ZW50cy1pbi1kaWN0 aW9uYXJ5Lmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25vdGlmaWNhdGlvbnMvZXZlbnRz LWluLWRpY3Rpb25hcnkuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43NGZhNGYyMTQ4MmVkMTg1YzgzZDJkMDg1 NTg3MGY4MzIyYjAwNWJmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9ub3RpZmljYXRpb25zL2V2ZW50cy1pbi1kaWN0aW9uYXJ5Lmh0bWwKQEAgLTAsMCArMSwyNiBA QAorPCFET0NUWVBFIGh0bWw+Cis8c2NyaXB0IHNyYz0iL3Jlc291cmNlcy9qcy10ZXN0LXByZS5q cyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iL3Jlc291cmNlcy9ub3RpZmljYXRpb25zLXRlc3Qt cHJlLmpzIj48L3NjcmlwdD4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29u c29sZSI+PC9kaXY+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKQorCXRlc3RSdW5u ZXIud2FpdFVudGlsRG9uZSgpOworCitkZXNjcmlwdGlvbigiVGhpcyB0ZXN0IGVuc3VyZXMgZXZl bnQgaGFuZGxlcnMgZGVmaW5lZCBpbnNpZGUgdGhlIG9wdGlvbnMgZGljdGlvbmFyeSBhcmUgaWdu b3JlZC4iKTsKKworaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisJdGVzdFJ1bm5lci5ncmFudFdl Yk5vdGlmaWNhdGlvblBlcm1pc3Npb24odGVzdFVSTCk7CisJc2hvdWxkQmVFcXVhbFRvU3RyaW5n KCJOb3RpZmljYXRpb24ucGVybWlzc2lvbiIsICJncmFudGVkIik7CisKKwl2YXIgbiA9IG5ldyBO b3RpZmljYXRpb24oInRpdGxlIiwgeyBvbnNob3c6IGZ1bmN0aW9uKCkgeworCQl0ZXN0RmFpbGVk KCJvbnNob3cgZXZlbnQgaGFuZGxlciBkZWZpbmVkIGluIG9wdGlvbnMgZGljdGlvbmFyeSBzaG91 bGQgbm90IGJlIGNhbGxlZCIpOworCX19KTsKKwluLmFkZEV2ZW50TGlzdGVuZXIoInNob3ciLCBm dW5jdGlvbigpIHsKKwkJdGVzdFBhc3NlZCgib25zaG93IGV2ZW50IGhhbmRsZXIgZGVmaW5lZCBh ZnRlciBOb3RpZmljYXRpb24gY29uc3RydWN0aW9uIHdhcyBjYWxsZWQiKTsKKwkJdGVzdENvbXBs ZXRlZCgpOworCX0pOworfQorCitzZXRUaW1lb3V0KHRlc3RDb21wbGV0ZWQsIDEwMCk7Cis8L3Nj cmlwdD4K