95529 2012-08-30 23:25:32 -0700 [chromium] Rename WebViewClient::handleDisambiguationPopup 2012-09-04 13:25:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 trchen webkit-unassigned abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 709325 0 trchen 2012-08-30 23:25:32 -0700 [chromium] Rename WebViewClient::handleDisambiguationPopup 709326 1 161622 trchen 2012-08-30 23:26:46 -0700 Created attachment 161622 Patch 709327 2 webkit.review.bot 2012-08-30 23:28:10 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 709844 3 161622 abarth 2012-08-31 11:36:13 -0700 Comment on attachment 161622 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161622&action=review > Source/WebKit/chromium/public/WebViewClient.h:291 > - virtual bool handleDisambiguationPopup(const WebGestureEvent&, const WebVector<WebRect>& targetRects) { return false; } > + virtual bool multipleTargetsTapped(const WebGestureEvent&, const WebVector<WebRect>& targetRects) { return false; } didTapMultipleTargets or willTapMultipleTargets? 710038 4 161622 fishd 2012-08-31 15:51:18 -0700 Comment on attachment 161622 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161622&action=review >> Source/WebKit/chromium/public/WebViewClient.h:291 >> + virtual bool multipleTargetsTapped(const WebGestureEvent&, const WebVector<WebRect>& targetRects) { return false; } > > didTapMultipleTargets or willTapMultipleTargets? +1 ... probably didTap* since this is called from handleGestureEvent. The tap already happened. 710076 5 161792 trchen 2012-08-31 16:59:02 -0700 Created attachment 161792 Patch 711395 6 161792 webkit.review.bot 2012-09-04 13:25:23 -0700 Comment on attachment 161792 Patch Clearing flags on attachment: 161792 Committed r127494: <http://trac.webkit.org/changeset/127494> 711396 7 webkit.review.bot 2012-09-04 13:25:26 -0700 All reviewed patches have been landed. Closing bug. 161622 2012-08-30 23:26:46 -0700 2012-08-31 16:58:59 -0700 Patch bug-95529-20120830232634.patch text/plain 3504 trchen U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MTk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGY1OTc1OGJlNDE1YTY0ODIxZGM5M2Y3OGI4MjdhN2FjMjUzYmQ2ZWYuLjI1NWYwYjAyNmVmYTJk ZDRjMWY3NTJlNmRkOGRlMTUxMDFlZTFlNDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMDgtMzAgIFRpZW4tUmVuIENoZW4gIDx0cmNoZW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gUmVuYW1lIFdlYlZpZXdDbGllbnQ6OmhhbmRs ZURpc2FtYmlndWF0aW9uUG9wdXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk1NTI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUmVuYW1lIGl0IHRvIHNvbWV0aGluZyBtb3JlIGRlc2NyaXB0aXZlIChXZWJW aWV3Q2xpZW50OjptdWx0aXBsZVRhcmdldHNUYXBwZWQpIGJlZm9yZSBwZW9wbGUgc3RhcnQgdXNp bmcgaXQuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViVmlld0NsaWVudC5oOgorICAgICAgICAoV2Vi S2l0OjpXZWJWaWV3Q2xpZW50OjptdWx0aXBsZVRhcmdldHNUYXBwZWQpOgorICAgICAgICAqIHNy Yy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpoYW5kbGVH ZXN0dXJlRXZlbnQpOgorICAgICAgICAqIHRlc3RzL1dlYkZyYW1lVGVzdC5jcHA6CisKIDIwMTIt MDgtMzAgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBb Y2hyb21pdW1dIE1ha2Ugd2Via2l0X2NvbXBvc2l0b3Igc3BlY2lmaWMgdW5pdCB0ZXN0IGNvbXBp bGF0aW9uIGNvbmRpdGlvbmFsIG9uIGd5cCB2YXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYlZpZXdDbGllbnQuaAppbmRleCBiZDBmNTU2N2JkNjU3YWZkNDczYjFlZGRlZWFl NjIyMTJkYTcyMDdkLi5mZGYxNzBlOTc3NjVlYTdmZjIwNzIzNTQzNjIzY2U5NWJkMThlODQ5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlld0NsaWVudC5oCkBAIC0y ODgsNyArMjg4LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBkaWRVcGRhdGVMYXlvdXQo KSB7IH0KIAogICAgIC8vIFJldHVybiB0cnVlIHRvIHN3YWxsb3cgdGhlIGlucHV0IGV2ZW50IGlm IHRoZSBlbWJlZGRlciB3aWxsIHN0YXJ0IGEgZGlzYW1iaWd1YXRpb24gcG9wdXAKLSAgICB2aXJ0 dWFsIGJvb2wgaGFuZGxlRGlzYW1iaWd1YXRpb25Qb3B1cChjb25zdCBXZWJHZXN0dXJlRXZlbnQm LCBjb25zdCBXZWJWZWN0b3I8V2ViUmVjdD4mIHRhcmdldFJlY3RzKSB7IHJldHVybiBmYWxzZTsg fQorICAgIHZpcnR1YWwgYm9vbCBtdWx0aXBsZVRhcmdldHNUYXBwZWQoY29uc3QgV2ViR2VzdHVy ZUV2ZW50JiwgY29uc3QgV2ViVmVjdG9yPFdlYlJlY3Q+JiB0YXJnZXRSZWN0cykgeyByZXR1cm4g ZmFsc2U7IH0KIAogICAgIC8vIFNlc3Npb24gaGlzdG9yeSAtLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJWaWV3SW1wbC5jcHAKaW5kZXggNjI2Y2IwYjVmMWFhYTIzZWVlNzg5NjA1ZWNjNzEx N2NjM2E3ZjFmMy4uNjI1MWY2MmNiM2ExNDA5NWJmZmNiY2FjZGY0MGVkMmJjNDY3ODViNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcApAQCAtNzE4LDcgKzcx OCw3IEBAIGJvb2wgV2ViVmlld0ltcGw6OmhhbmRsZUdlc3R1cmVFdmVudChjb25zdCBXZWJHZXN0 dXJlRXZlbnQmIGV2ZW50KQogICAgICAgICAgICAgZmluZEdvb2RUb3VjaFRhcmdldHMoZXZlbnQu Ym91bmRpbmdCb3gsIG1haW5GcmFtZUltcGwoKS0+ZnJhbWUoKSwgcGFnZVNjYWxlRmFjdG9yKCks IGdvb2RUYXJnZXRzKTsKICAgICAgICAgICAgIC8vIEZJWE1FOiByZXBsYWNlIHRvdWNoIGFkanVz dG1lbnQgY29kZSB3aGVuIG51bWJlck9mR29vZFRhcmdldHMgPT0gMT8KICAgICAgICAgICAgIC8v IFNpbmdsZSBjYW5kaWRhdGUgY2FzZSBpcyBjdXJyZW50bHkgaGFuZGxlZCBieTogaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1MTAxCi0gICAgICAgICAgICBpZiAoZ29v ZFRhcmdldHMuc2l6ZSgpID49IDIgJiYgbV9jbGllbnQgJiYgbV9jbGllbnQtPmhhbmRsZURpc2Ft YmlndWF0aW9uUG9wdXAoZXZlbnQsIGdvb2RUYXJnZXRzKSkKKyAgICAgICAgICAgIGlmIChnb29k VGFyZ2V0cy5zaXplKCkgPj0gMiAmJiBtX2NsaWVudCAmJiBtX2NsaWVudC0+bXVsdGlwbGVUYXJn ZXRzVGFwcGVkKGV2ZW50LCBnb29kVGFyZ2V0cykpCiAgICAgICAgICAgICAgICAgcmV0dXJuIHRy dWU7CiAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0 cy9XZWJGcmFtZVRlc3QuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9XZWJGcmFt ZVRlc3QuY3BwCmluZGV4IDRlZmRjN2JlZGJhMTAzNGVkZTIyNjk5MjUxNzY5ZjZmMmNlYzMyOTcu LjE5YTdmNzVjNmZlMjgxZDk3Mjc5MjM2MzRiMGQ5ZjVlYjU1OTZlNzUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViRnJhbWVUZXN0LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYkZyYW1lVGVzdC5jcHAKQEAgLTEwODAsNyArMTA4MCw3 IEBAIFRFU1RfRihXZWJGcmFtZVRlc3QsIFNlbGVjdFJhbmdlKQogCiBjbGFzcyBEaXNhbWJpZ3Vh dGlvblBvcHVwVGVzdFdlYlZpZXdDbGllbnQgOiBwdWJsaWMgV2ViVmlld0NsaWVudCB7CiBwdWJs aWM6Ci0gICAgdmlydHVhbCBib29sIGhhbmRsZURpc2FtYmlndWF0aW9uUG9wdXAoY29uc3QgV2Vi R2VzdHVyZUV2ZW50JiwgY29uc3QgV2ViVmVjdG9yPFdlYlJlY3Q+JiB0YXJnZXRSZWN0cykgT1ZF UlJJREUKKyAgICB2aXJ0dWFsIGJvb2wgbXVsdGlwbGVUYXJnZXRzVGFwcGVkKGNvbnN0IFdlYkdl c3R1cmVFdmVudCYsIGNvbnN0IFdlYlZlY3RvcjxXZWJSZWN0PiYgdGFyZ2V0UmVjdHMpIE9WRVJS SURFCiAgICAgewogICAgICAgICBFWFBFQ1RfR0UodGFyZ2V0UmVjdHMuc2l6ZSgpLCAydSk7CiAg ICAgICAgIG1fdHJpZ2dlcmVkID0gdHJ1ZTsK 161792 2012-08-31 16:59:02 -0700 2012-09-04 13:25:23 -0700 Patch bug-95529-20120831165849.patch text/plain 3504 trchen U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MTk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGY1OTc1OGJlNDE1YTY0ODIxZGM5M2Y3OGI4MjdhN2FjMjUzYmQ2ZWYuLjk4NDE4MWFlMWUxZWY3 YjhkNTQ5NWRmZWFkOTFmOGUzZTM0MTRlY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMDgtMzAgIFRpZW4tUmVuIENoZW4gIDx0cmNoZW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gUmVuYW1lIFdlYlZpZXdDbGllbnQ6OmhhbmRs ZURpc2FtYmlndWF0aW9uUG9wdXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk1NTI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUmVuYW1lIGl0IHRvIHNvbWV0aGluZyBtb3JlIGRlc2NyaXB0aXZlIChXZWJW aWV3Q2xpZW50OjpkaWRUYXBNdWx0aXBsZVRhcmdldHMpIGJlZm9yZSBwZW9wbGUgc3RhcnQgdXNp bmcgaXQuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViVmlld0NsaWVudC5oOgorICAgICAgICAoV2Vi S2l0OjpXZWJWaWV3Q2xpZW50OjpkaWRUYXBNdWx0aXBsZVRhcmdldHMpOgorICAgICAgICAqIHNy Yy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpoYW5kbGVH ZXN0dXJlRXZlbnQpOgorICAgICAgICAqIHRlc3RzL1dlYkZyYW1lVGVzdC5jcHA6CisKIDIwMTIt MDgtMzAgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBb Y2hyb21pdW1dIE1ha2Ugd2Via2l0X2NvbXBvc2l0b3Igc3BlY2lmaWMgdW5pdCB0ZXN0IGNvbXBp bGF0aW9uIGNvbmRpdGlvbmFsIG9uIGd5cCB2YXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYlZpZXdDbGllbnQuaAppbmRleCBiZDBmNTU2N2JkNjU3YWZkNDczYjFlZGRlZWFl NjIyMTJkYTcyMDdkLi44MzllZDBkMTc0MWZjMWY5NmU0YzU0ZGYwYzQ0ZTZlYmNjYTJmNmE2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlld0NsaWVudC5oCkBAIC0y ODgsNyArMjg4LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBkaWRVcGRhdGVMYXlvdXQo KSB7IH0KIAogICAgIC8vIFJldHVybiB0cnVlIHRvIHN3YWxsb3cgdGhlIGlucHV0IGV2ZW50IGlm IHRoZSBlbWJlZGRlciB3aWxsIHN0YXJ0IGEgZGlzYW1iaWd1YXRpb24gcG9wdXAKLSAgICB2aXJ0 dWFsIGJvb2wgaGFuZGxlRGlzYW1iaWd1YXRpb25Qb3B1cChjb25zdCBXZWJHZXN0dXJlRXZlbnQm LCBjb25zdCBXZWJWZWN0b3I8V2ViUmVjdD4mIHRhcmdldFJlY3RzKSB7IHJldHVybiBmYWxzZTsg fQorICAgIHZpcnR1YWwgYm9vbCBkaWRUYXBNdWx0aXBsZVRhcmdldHMoY29uc3QgV2ViR2VzdHVy ZUV2ZW50JiwgY29uc3QgV2ViVmVjdG9yPFdlYlJlY3Q+JiB0YXJnZXRSZWN0cykgeyByZXR1cm4g ZmFsc2U7IH0KIAogICAgIC8vIFNlc3Npb24gaGlzdG9yeSAtLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJWaWV3SW1wbC5jcHAKaW5kZXggNjI2Y2IwYjVmMWFhYTIzZWVlNzg5NjA1ZWNjNzEx N2NjM2E3ZjFmMy4uMGQzMzg5ZTViZmQxYjk1NjRlOWY3ZWRiZThkYzZkMWU2NzQ4M2Y0YyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcApAQCAtNzE4LDcgKzcx OCw3IEBAIGJvb2wgV2ViVmlld0ltcGw6OmhhbmRsZUdlc3R1cmVFdmVudChjb25zdCBXZWJHZXN0 dXJlRXZlbnQmIGV2ZW50KQogICAgICAgICAgICAgZmluZEdvb2RUb3VjaFRhcmdldHMoZXZlbnQu Ym91bmRpbmdCb3gsIG1haW5GcmFtZUltcGwoKS0+ZnJhbWUoKSwgcGFnZVNjYWxlRmFjdG9yKCks IGdvb2RUYXJnZXRzKTsKICAgICAgICAgICAgIC8vIEZJWE1FOiByZXBsYWNlIHRvdWNoIGFkanVz dG1lbnQgY29kZSB3aGVuIG51bWJlck9mR29vZFRhcmdldHMgPT0gMT8KICAgICAgICAgICAgIC8v IFNpbmdsZSBjYW5kaWRhdGUgY2FzZSBpcyBjdXJyZW50bHkgaGFuZGxlZCBieTogaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1MTAxCi0gICAgICAgICAgICBpZiAoZ29v ZFRhcmdldHMuc2l6ZSgpID49IDIgJiYgbV9jbGllbnQgJiYgbV9jbGllbnQtPmhhbmRsZURpc2Ft YmlndWF0aW9uUG9wdXAoZXZlbnQsIGdvb2RUYXJnZXRzKSkKKyAgICAgICAgICAgIGlmIChnb29k VGFyZ2V0cy5zaXplKCkgPj0gMiAmJiBtX2NsaWVudCAmJiBtX2NsaWVudC0+ZGlkVGFwTXVsdGlw bGVUYXJnZXRzKGV2ZW50LCBnb29kVGFyZ2V0cykpCiAgICAgICAgICAgICAgICAgcmV0dXJuIHRy dWU7CiAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0 cy9XZWJGcmFtZVRlc3QuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9XZWJGcmFt ZVRlc3QuY3BwCmluZGV4IDRlZmRjN2JlZGJhMTAzNGVkZTIyNjk5MjUxNzY5ZjZmMmNlYzMyOTcu LjYyMmFiNTJhMTM4YjU4MmQzNWRiNTc1YTc5YWQ5MTBjZDA0YjdmZWMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViRnJhbWVUZXN0LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYkZyYW1lVGVzdC5jcHAKQEAgLTEwODAsNyArMTA4MCw3 IEBAIFRFU1RfRihXZWJGcmFtZVRlc3QsIFNlbGVjdFJhbmdlKQogCiBjbGFzcyBEaXNhbWJpZ3Vh dGlvblBvcHVwVGVzdFdlYlZpZXdDbGllbnQgOiBwdWJsaWMgV2ViVmlld0NsaWVudCB7CiBwdWJs aWM6Ci0gICAgdmlydHVhbCBib29sIGhhbmRsZURpc2FtYmlndWF0aW9uUG9wdXAoY29uc3QgV2Vi R2VzdHVyZUV2ZW50JiwgY29uc3QgV2ViVmVjdG9yPFdlYlJlY3Q+JiB0YXJnZXRSZWN0cykgT1ZF UlJJREUKKyAgICB2aXJ0dWFsIGJvb2wgZGlkVGFwTXVsdGlwbGVUYXJnZXRzKGNvbnN0IFdlYkdl c3R1cmVFdmVudCYsIGNvbnN0IFdlYlZlY3RvcjxXZWJSZWN0PiYgdGFyZ2V0UmVjdHMpIE9WRVJS SURFCiAgICAgewogICAgICAgICBFWFBFQ1RfR0UodGFyZ2V0UmVjdHMuc2l6ZSgpLCAydSk7CiAg ICAgICAgIG1fdHJpZ2dlcmVkID0gdHJ1ZTsK