95509 2012-08-30 16:22:10 -0700 Ambiguous operator[] after r127191 on some compiler 2012-08-30 16:41:05 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 709130 0 benjamin 2012-08-30 16:22:10 -0700 Ambiguous operato[] after r127191 on some compiler 709135 1 161581 benjamin 2012-08-30 16:28:17 -0700 Created attachment 161581 Patch 709136 2 161581 simon.fraser 2012-08-30 16:31:19 -0700 Comment on attachment 161581 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161581&action=review > Source/JavaScriptCore/ChangeLog:8 > + On some compiler, the operator[] conflicts with the Obj-C++ operators. This attempts to solve Typo > Source/WTF/wtf/text/WTFString.h:452 > + // Workaround for a compiler bug. Use operato[] instead. Typo 709146 3 benjamin 2012-08-30 16:41:05 -0700 Committed r127212: <http://trac.webkit.org/changeset/127212> 161581 2012-08-30 16:28:17 -0700 2012-08-30 16:31:19 -0700 Patch bug-95509-20120830162805.patch text/plain 4553 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 ZTQxZTRiYjlhMTQwMWUyYmEwMGYyOWM4MjI4MmUxMTllMjEyMTFhLi40YzFjYzBkMDc0OTBhZGYx N2U0ZmQ2NWYwMjdhMTI2OTY1NWNjZGE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMiBAQAogMjAxMi0wOC0zMCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KIAorICAgICAgICBBbWJpZ3VvdXMgb3BlcmF0b3JbXSAgYWZ0ZXIgcjEyNzE5MSBvbiBz b21lIGNvbXBpbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05NTUwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE9uIHNvbWUgY29tcGlsZXIsIHRoZSBvcGVyYXRvcltdIGNvbmZsaWN0cyB3aXRoIHRoZSBP YmotQysrIG9wZXJhdG9ycy4gVGhpcyBhdHRlbXB0cyB0byBzb2x2ZQorICAgICAgICB0aGUgaXNz dWUuCisKKyAgICAgICAgKiBydW50aW1lL0pTU3RyaW5nLmg6CisgICAgICAgIChKU0M6OmpzU2lu Z2xlQ2hhcmFjdGVyU3Vic3RyaW5nKToKKyAgICAgICAgKEpTQzo6anNTdHJpbmcpOgorICAgICAg ICAoSlNDOjpqc1N1YnN0cmluZzgpOgorICAgICAgICAoSlNDOjpqc1N1YnN0cmluZyk6CisgICAg ICAgIChKU0M6OmpzT3duZWRTdHJpbmcpOgorCisyMDEyLTA4LTMwICBCZW5qYW1pbiBQb3VsYWlu ICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCiAgICAgICAgIFJlcGxhY2UgSlNDOjpVU3RyaW5nIGJ5 IFdURjo6U3RyaW5nCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05NTI3MQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9X VEYvQ2hhbmdlTG9nCmluZGV4IDBjM2E5ZGM5ODgxYmFlYzFjNmJlYjc4Yzk1MjkwMzU5OWY1NmFl NWUuLmEwOGQ1ZDUzZWRkNmQ1NGFiY2MzNmMyZThjZGI3MmMyYWZmYjVmNmMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDUg KzEsMTUgQEAKIDIwMTItMDgtMzAgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5j b20+CiAKKyAgICAgICAgQW1iaWd1b3VzIG9wZXJhdG9yW10gIGFmdGVyIHIxMjcxOTEgb24gc29t ZSBjb21waWxlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTU1MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHd0Zi90ZXh0L1dURlN0cmluZy5oOgorICAgICAgICAoV1RGOjpTdHJpbmc6OmNoYXJhY3Rl ckF0KTogQXQgdGhpcyBhcyBhIHN5bm9ueW0gdG8gb3BlcmF0b3JbXSB0byBhdHRlbXB0IGEgYnVp bGQgZml4LgorCisyMDEyLTA4LTMwICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUu Y29tPgorCiAgICAgICAgIFJlcGxhY2UgSlNDOjpVU3RyaW5nIGJ5IFdURjo6U3RyaW5nCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTI3MQogCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmluZy5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdHJpbmcuaAppbmRleCBlMDA5ZWNiOGIxYzVmMjU3 YzZjMWRiM2Q1MWUxNjAyNDJiYzQ0Mzg3Li45ZjE3NmFkMjNjZmQyMDM0ZTI0YjU3MDBmMTRiNDA0 MzZmMWNlZTgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0 cmluZy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3RyaW5nLmgKQEAg LTM0Nyw3ICszNDcsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICB7CiAgICAgICAgIEpTR2xvYmFs RGF0YSogZ2xvYmFsRGF0YSA9ICZleGVjLT5nbG9iYWxEYXRhKCk7CiAgICAgICAgIEFTU0VSVChv ZmZzZXQgPCBzdGF0aWNfY2FzdDx1bnNpZ25lZD4ocy5sZW5ndGgoKSkpOwotICAgICAgICBVQ2hh ciBjID0gc1tvZmZzZXRdOworICAgICAgICBVQ2hhciBjID0gcy5jaGFyYWN0ZXJBdChvZmZzZXQp OwogICAgICAgICBpZiAoYyA8PSBtYXhTaW5nbGVDaGFyYWN0ZXJTdHJpbmcpCiAgICAgICAgICAg ICByZXR1cm4gZ2xvYmFsRGF0YS0+c21hbGxTdHJpbmdzLnNpbmdsZUNoYXJhY3RlclN0cmluZyhn bG9iYWxEYXRhLCBjKTsKICAgICAgICAgcmV0dXJuIEpTU3RyaW5nOjpjcmVhdGUoKmdsb2JhbERh dGEsIFN0cmluZ0ltcGw6OmNyZWF0ZShzLmltcGwoKSwgb2Zmc2V0LCAxKSk7CkBAIC0zOTYsNyAr Mzk2LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIGlmICghc2l6ZSkKICAgICAgICAgICAg IHJldHVybiBnbG9iYWxEYXRhLT5zbWFsbFN0cmluZ3MuZW1wdHlTdHJpbmcoZ2xvYmFsRGF0YSk7 CiAgICAgICAgIGlmIChzaXplID09IDEpIHsKLSAgICAgICAgICAgIFVDaGFyIGMgPSBzWzBdOwor ICAgICAgICAgICAgVUNoYXIgYyA9IHMuY2hhcmFjdGVyQXQoMCk7CiAgICAgICAgICAgICBpZiAo YyA8PSBtYXhTaW5nbGVDaGFyYWN0ZXJTdHJpbmcpCiAgICAgICAgICAgICAgICAgcmV0dXJuIGds b2JhbERhdGEtPnNtYWxsU3RyaW5ncy5zaW5nbGVDaGFyYWN0ZXJTdHJpbmcoZ2xvYmFsRGF0YSwg Yyk7CiAgICAgICAgIH0KQEAgLTQyMiw3ICs0MjIsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAg ICAgaWYgKCFsZW5ndGgpCiAgICAgICAgICAgICByZXR1cm4gZ2xvYmFsRGF0YS0+c21hbGxTdHJp bmdzLmVtcHR5U3RyaW5nKGdsb2JhbERhdGEpOwogICAgICAgICBpZiAobGVuZ3RoID09IDEpIHsK LSAgICAgICAgICAgIFVDaGFyIGMgPSBzW29mZnNldF07CisgICAgICAgICAgICBVQ2hhciBjID0g cy5jaGFyYWN0ZXJBdChvZmZzZXQpOwogICAgICAgICAgICAgaWYgKGMgPD0gbWF4U2luZ2xlQ2hh cmFjdGVyU3RyaW5nKQogICAgICAgICAgICAgICAgIHJldHVybiBnbG9iYWxEYXRhLT5zbWFsbFN0 cmluZ3Muc2luZ2xlQ2hhcmFjdGVyU3RyaW5nKGdsb2JhbERhdGEsIGMpOwogICAgICAgICB9CkBA IC00MzcsNyArNDM3LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIGlmICghbGVuZ3RoKQog ICAgICAgICAgICAgcmV0dXJuIGdsb2JhbERhdGEtPnNtYWxsU3RyaW5ncy5lbXB0eVN0cmluZyhn bG9iYWxEYXRhKTsKICAgICAgICAgaWYgKGxlbmd0aCA9PSAxKSB7Ci0gICAgICAgICAgICBVQ2hh ciBjID0gc1tvZmZzZXRdOworICAgICAgICAgICAgVUNoYXIgYyA9IHMuY2hhcmFjdGVyQXQob2Zm c2V0KTsKICAgICAgICAgICAgIGlmIChjIDw9IG1heFNpbmdsZUNoYXJhY3RlclN0cmluZykKICAg ICAgICAgICAgICAgICByZXR1cm4gZ2xvYmFsRGF0YS0+c21hbGxTdHJpbmdzLnNpbmdsZUNoYXJh Y3RlclN0cmluZyhnbG9iYWxEYXRhLCBjKTsKICAgICAgICAgfQpAQCAtNDUwLDcgKzQ1MCw3IEBA IG5hbWVzcGFjZSBKU0MgewogICAgICAgICBpZiAoIXNpemUpCiAgICAgICAgICAgICByZXR1cm4g Z2xvYmFsRGF0YS0+c21hbGxTdHJpbmdzLmVtcHR5U3RyaW5nKGdsb2JhbERhdGEpOwogICAgICAg ICBpZiAoc2l6ZSA9PSAxKSB7Ci0gICAgICAgICAgICBVQ2hhciBjID0gc1swXTsKKyAgICAgICAg ICAgIFVDaGFyIGMgPSBzLmNoYXJhY3RlckF0KDApOwogICAgICAgICAgICAgaWYgKGMgPD0gbWF4 U2luZ2xlQ2hhcmFjdGVyU3RyaW5nKQogICAgICAgICAgICAgICAgIHJldHVybiBnbG9iYWxEYXRh LT5zbWFsbFN0cmluZ3Muc2luZ2xlQ2hhcmFjdGVyU3RyaW5nKGdsb2JhbERhdGEsIGMpOwogICAg ICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmluZy5oIGIvU291 cmNlL1dURi93dGYvdGV4dC9XVEZTdHJpbmcuaAppbmRleCAzYWIwYWRmM2JmOTk1MzNmZTRkZDIx ODNmYjI2ZTgyZTRhMDIzMjQxLi4yZjBlZDlmYTMwZDg2NTdjYWIxZmJlM2MyYWIyZWM5NDJkOTNm MzgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmluZy5oCisrKyBiL1Nv dXJjZS9XVEYvd3RmL3RleHQvV1RGU3RyaW5nLmgKQEAgLTQ0OSw2ICs0NDksMTQgQEAgcHVibGlj OgogICAgIFdURl9FWFBPUlRfU1RSSU5HX0FQSSB2b2lkIHNob3coKSBjb25zdDsKICNlbmRpZgog CisgICAgLy8gV29ya2Fyb3VuZCBmb3IgYSBjb21waWxlciBidWcuIFVzZSBvcGVyYXRvW10gaW5z dGVhZC4KKyAgICBVQ2hhciBjaGFyYWN0ZXJBdCh1bnNpZ25lZCBpbmRleCkgY29uc3QKKyAgICB7 CisgICAgICAgIGlmICghbV9pbXBsIHx8IGluZGV4ID49IG1faW1wbC0+bGVuZ3RoKCkpCisgICAg ICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgcmV0dXJuICgqbV9pbXBsKVtpbmRleF07CisgICAg fQorCiBwcml2YXRlOgogICAgIFJlZlB0cjxTdHJpbmdJbXBsPiBtX2ltcGw7CiB9Owo=