95497 2012-08-30 13:59:59 -0700 ~JSNPObject should call invalidate() if it hasn't been called already 2012-08-30 17:42:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg ggaren webkit.review.bot oldest_to_newest 709009 0 mhahnenberg 2012-08-30 13:59:59 -0700 Finalization is no longer eager, just like destruction, so the original intent behind this ASSERT in ~JSNPObject is no longer relevant. Therefore, we can remove all destruction-related stuff from JSNPObject. 709012 1 161551 mhahnenberg 2012-08-30 14:01:36 -0700 Created attachment 161551 Patch 709016 2 mhahnenberg 2012-08-30 14:08:30 -0700 http://trac.webkit.org/changeset/121316 is the change that caused this new behavior. It was meant to remove this ASSERT, but it was overlooked. 709028 3 161551 ggaren 2012-08-30 14:18:24 -0700 Comment on attachment 161551 Patch Still need a destructor so we don't leak the np object. 709034 4 161558 mhahnenberg 2012-08-30 14:34:08 -0700 Created attachment 161558 Patch 709089 5 161558 ggaren 2012-08-30 15:15:37 -0700 Comment on attachment 161558 Patch r=me 709199 6 161558 webkit.review.bot 2012-08-30 17:42:51 -0700 Comment on attachment 161558 Patch Clearing flags on attachment: 161558 Committed r127219: <http://trac.webkit.org/changeset/127219> 709200 7 webkit.review.bot 2012-08-30 17:42:54 -0700 All reviewed patches have been landed. Closing bug. 161551 2012-08-30 14:01:36 -0700 2012-08-30 14:34:07 -0700 Patch bug-95497-20120830140125.patch text/plain 2027 mhahnenberg SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNzE4NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTMwICBNYXJrIEhh aG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgfkpTTlBPYmplY3Qg c2hvdWxkbid0IGV4aXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NTQ5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZpbmFsaXphdGlvbiBpcyBubyBsb25nZXIgZWFnZXIsIGp1c3QgbGlrZSBkZXN0cnVj dGlvbiwgc28gdGhlIG9yaWdpbmFsIGludGVudCBiZWhpbmQgCisgICAgICAgIHRoaXMgQVNTRVJU IGluIH5KU05QT2JqZWN0IGlzIG5vIGxvbmdlciByZWxldmFudC4gVGhlcmVmb3JlLCB3ZSBjYW4g cmVtb3ZlIGFsbCBkZXN0cnVjdGlvbi1yZWxhdGVkIAorICAgICAgICBzdHVmZiBmcm9tIEpTTlBP YmplY3QuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvSlNOUE9iamVj dC5jcHA6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9O ZXRzY2FwZS9KU05QT2JqZWN0Lmg6CisgICAgICAgIChKU05QT2JqZWN0KToKKwogMjAxMi0wOC0y OSAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIEpT TlBPYmplY3QgZG9lc24ndCBhbHdheXMgcHJvdGVjdCBpdHMgZGF0YSB3aGVuIGNhbGxpbmcgaW50 byBwbHVnaW4gY29kZQpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05l dHNjYXBlL0pTTlBPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9KU05QT2JqZWN0LmNwcAkocmV2aXNpb24gMTI3MTYwKQor KysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL0pTTlBPYmplY3Qu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NSwxNiArNzUsNiBAQCB2b2lkIEpTTlBPYmplY3Q6OmZp bmlzaENyZWF0aW9uKEpTR2xvYmFsCiAgICAgcmV0YWluTlBPYmplY3QobV9ucE9iamVjdCk7CiB9 CiAKLUpTTlBPYmplY3Q6On5KU05QT2JqZWN0KCkKLXsKLSAgICBBU1NFUlQoIW1fbnBPYmplY3Qp OwotfQotCi12b2lkIEpTTlBPYmplY3Q6OmRlc3Ryb3koSlNDZWxsKiBjZWxsKQotewotICAgIHN0 YXRpY19jYXN0PEpTTlBPYmplY3QqPihjZWxsKS0+SlNOUE9iamVjdDo6fkpTTlBPYmplY3QoKTsK LX0KLQogdm9pZCBKU05QT2JqZWN0OjppbnZhbGlkYXRlKCkKIHsKICAgICBBU1NFUlQobV9ucE9i amVjdCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUv SlNOUE9iamVjdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1 Z2lucy9OZXRzY2FwZS9KU05QT2JqZWN0LmgJKHJldmlzaW9uIDEyNzE2MCkKKysrIFNvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9KU05QT2JqZWN0LmgJKHdvcmtpbmcg Y29weSkKQEAgLTUzLDkgKzUzLDYgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gb2JqZWN0Owog ICAgIH0KIAotICAgIH5KU05QT2JqZWN0KCk7Ci0gICAgc3RhdGljIHZvaWQgZGVzdHJveShKU0Nl bGwqKTsKLQogICAgIHZvaWQgaW52YWxpZGF0ZSgpOwogCiAgICAgLy8gVXNlZCB0byBpbnZhbGlk YXRlIGFuIE5QT2JqZWN0IGFzeW5jaHJvbm91c2x5Lgo= 161558 2012-08-30 14:34:08 -0700 2012-08-30 17:42:51 -0700 Patch bug-95497-20120830143357.patch text/plain 1369 mhahnenberg SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNzE5MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTMwICBNYXJrIEhh aG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgfkpTTlBPYmplY3Qg c2hvdWxkIGNhbGwgaW52YWxpZGF0ZSgpIGlmIGl0IGhhc24ndCBiZWVuIGNhbGxlZCBhbHJlYWR5 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTQ5Nwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpbmFsaXph dGlvbiBpcyBubyBsb25nZXIgZWFnZXIsIGp1c3QgbGlrZSBkZXN0cnVjdGlvbiwgc28gdGhlIG9y aWdpbmFsIGludGVudCBiZWhpbmQgCisgICAgICAgIHRoaXMgQVNTRVJUIGluIH5KU05QT2JqZWN0 IGlzIG5vIGxvbmdlciByZWxldmFudC4gVGhlcmVmb3JlLCB3ZSBjYW4ganVzdCBjYWxsIGludmFs aWRhdGUoKSAKKyAgICAgICAgb3Vyc2VsdmVzIGluIH5KU05QT2JqZWN0LgorCisgICAgICAgICog V2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL0pTTlBPYmplY3QuY3BwOgorICAgICAgICAoV2Vi S2l0OjpKU05QT2JqZWN0Ojp+SlNOUE9iamVjdCk6CisKIDIwMTItMDgtMzAgIEJlbmphbWluIFBv dWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVwbGFjZSBKU0M6OlVTdHJp bmcgYnkgV1RGOjpTdHJpbmcKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lu cy9OZXRzY2FwZS9KU05QT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvSlNOUE9iamVjdC5jcHAJKHJldmlzaW9uIDEyNzE4 OSkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9KU05QT2Jq ZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzcsNyArNzcsOCBAQCB2b2lkIEpTTlBPYmplY3Q6 OmZpbmlzaENyZWF0aW9uKEpTR2xvYmFsCiAKIEpTTlBPYmplY3Q6On5KU05QT2JqZWN0KCkKIHsK LSAgICBBU1NFUlQoIW1fbnBPYmplY3QpOworICAgIGlmIChtX25wT2JqZWN0KQorICAgICAgICBp bnZhbGlkYXRlKCk7CiB9CiAKIHZvaWQgSlNOUE9iamVjdDo6ZGVzdHJveShKU0NlbGwqIGNlbGwp Cg==