95476 2012-08-30 10:33:17 -0700 [BlackBerry] Remove unneeded force-immediate-repaint from InRegionScroller::setLayerScrollPosition 2012-08-30 10:48:04 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tonikitoo tonikitoo mifenton tonikitoo webkit.review.bot oldest_to_newest 708802 0 tonikitoo 2012-08-30 10:33:17 -0700 This code is not needed at this point for neither the fast nor slow scroll code paths at this point, and it a huge performance beast as it forces all containers to get full-repainted by scroll call (in webkit thread). PR #200704 708809 1 161512 tonikitoo 2012-08-30 10:37:26 -0700 Created attachment 161512 patch 708818 2 161512 yong.li.webkit 2012-08-30 10:43:13 -0700 Comment on attachment 161512 patch View in context: https://bugs.webkit.org/attachment.cgi?id=161512&action=review > Source/WebKit/blackberry/ChangeLog:11 > + scroll codepaths, and it a huge performance beast as it forces all missing "is" 708825 3 tonikitoo 2012-08-30 10:48:04 -0700 http://trac.webkit.org/changeset/127160 161512 2012-08-30 10:37:26 -0700 2012-08-30 10:43:13 -0700 patch 0001-BlackBerry-Remove-unneeded-force-immediate-repaint-f.patch text/plain 3348 tonikitoo RnJvbSBlOTg0ODEzODQ2NjBjNmY3ZTRjYWJhMTZhNWVhZmZlMjY3ODA5OTExIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDxhZ29tZXNAcmltLmNvbT4KRGF0ZTog VGh1LCAzMCBBdWcgMjAxMiAxMzozNjozMCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtCbGFja0Jl cnJ5XSBSZW1vdmUgdW5uZWVkZWQgZm9yY2UtaW1tZWRpYXRlLXJlcGFpbnQgZnJvbQogSW5SZWdp b25TY3JvbGxlcjo6c2V0TGF5ZXJTY3JvbGxQb3NpdGlvbgogaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk1NDc2IFBSICMyMDA3MDQKClJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgpQYXRjaCBieSBBbnRvbmlvIEdvbWVzIDxhZ29tZXNAcmltLmNvbT4KClRoaXMgY29k ZSBpcyBub3QgbmVlZGVkIGF0IHRoaXMgcG9pbnQgZm9yIG5laXRoZXIgdGhlIGZhc3Qgbm9yIHNs b3cgaW4tcmVnaW9uCnNjcm9sbCBjb2RlcGF0aHMsIGFuZCBpdCBhIGh1Z2UgcGVyZm9ybWFuY2Ug YmVhc3QgYXMgaXQgZm9yY2VzIGFsbApjb250YWluZXJzIHRvIGdldCBmdWxsLXJlcGFpbnRlZCBw ZXIgc2Nyb2xsIGNhbGwgKGluIHdlYmtpdCB0aHJlYWQpLgoKUGF0Y2ggYWxzbyB0YWtlIHRoaXMg b3Bwb3J0dW5pdHkgdG8gcmVtb3ZlIGFuIGVhcmx5LXJldHVybiB3ZQpoYXZlIGluIHRoZSB7aX1m cmFtZSBzbG93IHNjcm9sbGluZyBjb2RlIHBhdGggc28gdGhhdCB3ZSBjYW4KYWRqdXN0IHRoZSBz ZWxlY3Rpb24gaGFuZGxlcyBpbiB0aGlzIGNhc2UgYXMgd2VsbC4KCiogQXBpL0luUmVnaW9uU2Ny b2xsZXIuY3BwOgooQmxhY2tCZXJyeTo6V2ViS2l0OjpJblJlZ2lvblNjcm9sbGVyUHJpdmF0ZTo6 c2V0TGF5ZXJTY3JvbGxQb3NpdGlvbik6Ci0tLQogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0Fw aS9JblJlZ2lvblNjcm9sbGVyLmNwcCB8ICAgMTAgKysrKy0tLS0tLQogU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAgICAgICAgICB8ICAgMjAgKysrKysrKysrKysrKysr KysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0luUmVnaW9uU2Nyb2xs ZXIuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9JblJlZ2lvblNjcm9sbGVyLmNw cAppbmRleCA3NzA5NGUzLi5kOGFkNjg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQXBpL0luUmVnaW9uU2Nyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9BcGkvSW5SZWdpb25TY3JvbGxlci5jcHAKQEAgLTI4OSwxMyArMjg5LDExIEBAIGJvb2wg SW5SZWdpb25TY3JvbGxlclByaXZhdGU6OnNldExheWVyU2Nyb2xsUG9zaXRpb24oUmVuZGVyTGF5 ZXIqIGxheWVyLCBjb25zdCBJCiAgICAgICAgICAgICBiYWNraW5nU3RvcmVDbGllbnQtPnNldElz U2Nyb2xsTm90aWZpY2F0aW9uU3VwcHJlc3NlZChmYWxzZSk7CiAgICAgICAgIH0KIAotICAgICAg ICByZXR1cm4gdHJ1ZTsKLSAgICB9CisgICAgfSBlbHNlIHsKIAotICAgIC8vIFJlbmRlckJveC1i YXNlZCBlbGVtZW50cyBjYXNlIChzY3JvbGxhYmxlIGJveGVzIChkaXYncywgcCdzLCB0ZXh0YXJl YSdzLCBldGMpKS4KLSAgICBsYXllci0+c2Nyb2xsVG9PZmZzZXQoc2Nyb2xsUG9zaXRpb24ueCgp LCBzY3JvbGxQb3NpdGlvbi55KCkpOwotICAgIC8vIEZJWE1FX2Fnb21lczogUGxlYXNlIHJlY2hl Y2sgaWYgaXQgaXMgbmVlZGVkIHN0aWxsIQotICAgIGxheWVyLT5yZW5kZXJlcigpLT5yZXBhaW50 KHRydWUpOworICAgICAgICAvLyBSZW5kZXJCb3gtYmFzZWQgZWxlbWVudHMgY2FzZSAoc2Nyb2xs YWJsZSBib3hlcyAoZGl2J3MsIHAncywgdGV4dGFyZWEncywgZXRjKSkuCisgICAgICAgIGxheWVy LT5zY3JvbGxUb09mZnNldCh0b1NpemUoc2Nyb2xsUG9zaXRpb24pKTsKKyAgICB9CiAKICAgICBt X3dlYlBhZ2UtPm1fc2VsZWN0aW9uSGFuZGxlci0+c2VsZWN0aW9uUG9zaXRpb25DaGFuZ2VkKCk7 CiAgICAgLy8gRklYTUU6IFdlIGhhdmUgY29kZSBpbiBwbGFjZSB0byBoYW5kbGUgc2Nyb2xsaW5n IGFuZCBjbGlwcGluZyB0YXAgaGlnaGxpZ2h0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA1NDExYmU3Li43YTE4MzFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyMyBAQAorMjAxMi0wOC0zMCAgQW50b25pbyBHb21lcyAgPGFnb21lc0ByaW0uY29t PgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBSZW1vdmUgdW5uZWVkZWQgZm9yY2UtaW1tZWRpYXRl LXJlcGFpbnQgZnJvbSBJblJlZ2lvblNjcm9sbGVyOjpzZXRMYXllclNjcm9sbFBvc2l0aW9uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTQ3NgorCisg ICAgICAgIFBSICMyMDA3MDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGlzIGNvZGUgaXMgbm90IG5lZWRlZCBhdCB0aGlzIHBvaW50IGZvciBuZWl0 aGVyIHRoZSBmYXN0IG5vciBzbG93IGluLXJlZ2lvbgorICAgICAgICBzY3JvbGwgY29kZXBhdGhz LCBhbmQgaXQgYSBodWdlIHBlcmZvcm1hbmNlIGJlYXN0IGFzIGl0IGZvcmNlcyBhbGwKKyAgICAg ICAgY29udGFpbmVycyB0byBnZXQgZnVsbC1yZXBhaW50ZWQgcGVyIHNjcm9sbCBjYWxsIChpbiB3 ZWJraXQgdGhyZWFkKS4KKworICAgICAgICBQYXRjaCBhbHNvIHRha2UgdGhpcyBvcHBvcnR1bml0 eSB0byByZW1vdmUgYW4gZWFybHktcmV0dXJuIHdlCisgICAgICAgIGhhdmUgaW4gdGhlIHtpfWZy YW1lIHNsb3cgc2Nyb2xsaW5nIGNvZGUgcGF0aCBzbyB0aGF0IHdlIGNhbgorICAgICAgICBhZGp1 c3QgdGhlIHNlbGVjdGlvbiBoYW5kbGVzIGluIHRoaXMgY2FzZSBhcyB3ZWxsLgorCisgICAgICAg ICogQXBpL0luUmVnaW9uU2Nyb2xsZXIuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0 OjpJblJlZ2lvblNjcm9sbGVyUHJpdmF0ZTo6c2V0TGF5ZXJTY3JvbGxQb3NpdGlvbik6CisKIDIw MTItMDgtMjkgIEFudG9uaW8gR29tZXMgIDxhZ29tZXNAcmltLmNvbT4KIAogICAgICAgICBbQmxh Y2tCZXJyeV0gUmVwbGFjZSBibGFja2JlcnJ5IHNwZWNpZmljIEhpdFRlc3RSZXF1ZXN0OjpGaW5n ZXJVcCBieSBUb3VjaEV2ZW50ICsgUmVsZWFzZQotLSAKMS43LjUuNAoK