95469 2012-08-30 09:36:34 -0700 [BlackBerry] Implement IncrementalSweeper for PLATFORM(BLACKBERRY) 2012-08-30 13:50:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yong.li.webkit webkit-unassigned fpizlo ggaren webkit.review.bot oldest_to_newest 708717 0 yong.li.webkit 2012-08-30 09:36:34 -0700 as we have the HeapTimer implemented 708728 1 161496 yong.li.webkit 2012-08-30 09:43:20 -0700 Created attachment 161496 the patch It shares most code with USE(CF). But I have to change CFTimeInterval to double. Geoffrey, is that OK? 708742 2 161500 yong.li.webkit 2012-08-30 09:52:55 -0700 Created attachment 161500 the patch 708778 3 161500 rwlbuis 2012-08-30 10:16:20 -0700 Comment on attachment 161500 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=161500&action=review > Source/JavaScriptCore/heap/IncrementalSweeper.cpp:106 > + double elapsedTime = WTF::monotonicallyIncreasingTime() - sweepBeginTime; This patch looks good to me, Yong said he took double over CFTimeInterval here since all methods used return double's. Maybe some Apple folks can comment whether CFTimeInterval usage is absolutely needed here? 708975 4 161500 rwlbuis 2012-08-30 13:36:46 -0700 Comment on attachment 161500 the patch LGTM. 708990 5 161500 webkit.review.bot 2012-08-30 13:50:16 -0700 Comment on attachment 161500 the patch Clearing flags on attachment: 161500 Committed r127185: <http://trac.webkit.org/changeset/127185> 708991 6 webkit.review.bot 2012-08-30 13:50:19 -0700 All reviewed patches have been landed. Closing bug. 161496 2012-08-30 09:43:20 -0700 2012-08-30 09:49:35 -0700 the patch 95469.patch text/plain 3552 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGFlM2U2YjUuLjBjY2FhMTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEyLTA4LTMwICBZb25nIExpICA8eW9s aUByaW0uY29tPgogCisgICAgICAgIFtCbGFja0JlcnJ5XSBJbXBsZW1lbnQgSW5jcmVtZW50YWxT d2VlcGVyIGZvciBQTEFURk9STShCTEFDS0JFUlJZKQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU0NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBTaGFyZSBtb3N0IGNvZGUgd2l0aCBVU0UoQ0YpIGFuZCBp bXBsZW1lbnQgdGltZXItcmVsYXRlZCBtZXRob2RzCisgICAgICAgIGZvciBQTEFURk9STShCTEFD S0JFUlJZKS4KKworICAgICAgICAqIGhlYXAvSW5jcmVtZW50YWxTd2VlcGVyLmNwcDoKKyAgICAg ICAgKEpTQyk6CisgICAgICAgIChKU0M6OkluY3JlbWVudGFsU3dlZXBlcjo6SW5jcmVtZW50YWxT d2VlcGVyKToKKyAgICAgICAgKEpTQzo6SW5jcmVtZW50YWxTd2VlcGVyOjpjcmVhdGUpOgorICAg ICAgICAoSlNDOjpJbmNyZW1lbnRhbFN3ZWVwZXI6OnNjaGVkdWxlVGltZXIpOgorICAgICAgICAo SlNDOjpJbmNyZW1lbnRhbFN3ZWVwZXI6OmNhbmNlbFRpbWVyKToKKyAgICAgICAgKEpTQzo6SW5j cmVtZW50YWxTd2VlcGVyOjpkb1N3ZWVwKToKKyAgICAgICAgKiBoZWFwL0luY3JlbWVudGFsU3dl ZXBlci5oOgorICAgICAgICAoSW5jcmVtZW50YWxTd2VlcGVyKToKKworMjAxMi0wOC0zMCAgWW9u ZyBMaSAgPHlvbGlAcmltLmNvbT4KKwogICAgICAgICBbQmxhY2tCZXJyeV0gU2V0IHRpbWVyIGNs aWVudCBvbiBwbGF0Zm9ybSB0aW1lciB1c2VkIGluIEhlYXBUaW1lcgogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU0NjQKIApkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSW5jcmVtZW50YWxTd2VlcGVyLmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9oZWFwL0luY3JlbWVudGFsU3dlZXBlci5jcHAKaW5kZXggZjI4NGQ4Yi4u OWM5ZDlkNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSW5jcmVtZW50 YWxTd2VlcGVyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9JbmNyZW1lbnRh bFN3ZWVwZXIuY3BwCkBAIC0zNywxNiArMzcsMTggQEAKIAogbmFtZXNwYWNlIEpTQyB7CiAKLSNp ZiBVU0UoQ0YpCisjaWYgVVNFKENGKSB8fCBQTEFURk9STShCTEFDS0JFUlJZKQogCi1zdGF0aWMg Y29uc3QgQ0ZUaW1lSW50ZXJ2YWwgc3dlZXBUaW1lU2xpY2UgPSAuMDE7IC8vIHNlY29uZHMKLXN0 YXRpYyBjb25zdCBDRlRpbWVJbnRlcnZhbCBzd2VlcFRpbWVUb3RhbCA9IC4xMDsKLXN0YXRpYyBj b25zdCBDRlRpbWVJbnRlcnZhbCBzd2VlcFRpbWVNdWx0aXBsaWVyID0gMS4wIC8gc3dlZXBUaW1l VG90YWw7CitzdGF0aWMgY29uc3QgZG91YmxlIHN3ZWVwVGltZVNsaWNlID0gLjAxOyAvLyBzZWNv bmRzCitzdGF0aWMgY29uc3QgZG91YmxlIHN3ZWVwVGltZVRvdGFsID0gLjEwOworc3RhdGljIGNv bnN0IGRvdWJsZSBzd2VlcFRpbWVNdWx0aXBsaWVyID0gMS4wIC8gc3dlZXBUaW1lVG90YWw7CiAK IHZvaWQgSW5jcmVtZW50YWxTd2VlcGVyOjpkb1dvcmsoKQogewogICAgIGRvU3dlZXAoV1RGOjpt b25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKSk7CiB9CisKKyNpZiBVU0UoQ0YpCiAgICAgCiBJ bmNyZW1lbnRhbFN3ZWVwZXI6OkluY3JlbWVudGFsU3dlZXBlcihIZWFwKiBoZWFwLCBDRlJ1bkxv b3BSZWYgcnVuTG9vcCkKICAgICA6IEhlYXBUaW1lcihoZWFwLT5nbG9iYWxEYXRhKCksIHJ1bkxv b3ApCkBAIC03MCwxMiArNzIsMzggQEAgdm9pZCBJbmNyZW1lbnRhbFN3ZWVwZXI6OmNhbmNlbFRp bWVyKCkKICAgICBDRlJ1bkxvb3BUaW1lclNldE5leHRGaXJlRGF0ZShtX3RpbWVyLmdldCgpLCBD RkFic29sdXRlVGltZUdldEN1cnJlbnQoKSArIHNfZGVjYWRlKTsKIH0KIAorI2VsaWYgUExBVEZP Uk0oQkxBQ0tCRVJSWSkKKyAgIAorSW5jcmVtZW50YWxTd2VlcGVyOjpJbmNyZW1lbnRhbFN3ZWVw ZXIoSGVhcCogaGVhcCkKKyAgICA6IEhlYXBUaW1lcihoZWFwLT5nbG9iYWxEYXRhKCkpCisgICAg LCBtX2N1cnJlbnRCbG9ja1RvU3dlZXBJbmRleCgwKQorICAgICwgbV9zdHJ1Y3R1cmVzQ2FuQmVT d2VwdChmYWxzZSkKK3sKK30KKworSW5jcmVtZW50YWxTd2VlcGVyKiBJbmNyZW1lbnRhbFN3ZWVw ZXI6OmNyZWF0ZShIZWFwKiBoZWFwKQoreworICAgIHJldHVybiBuZXcgSW5jcmVtZW50YWxTd2Vl cGVyKGhlYXApOworfQorCit2b2lkIEluY3JlbWVudGFsU3dlZXBlcjo6c2NoZWR1bGVUaW1lcigp Cit7CisgICAgbV90aW1lci5zdGFydCgwLjEpOworfQorCit2b2lkIEluY3JlbWVudGFsU3dlZXBl cjo6Y2FuY2VsVGltZXIoKQoreworICAgIG1fdGltZXIuc3RvcCgpOworfQorCisjZW5kaWYKKwog dm9pZCBJbmNyZW1lbnRhbFN3ZWVwZXI6OmRvU3dlZXAoZG91YmxlIHN3ZWVwQmVnaW5UaW1lKQog ewogICAgIHdoaWxlIChtX2N1cnJlbnRCbG9ja1RvU3dlZXBJbmRleCA8IG1fYmxvY2tzVG9Td2Vl cC5zaXplKCkpIHsKICAgICAgICAgc3dlZXBOZXh0QmxvY2soKTsKIAotICAgICAgICBDRlRpbWVJ bnRlcnZhbCBlbGFwc2VkVGltZSA9IFdURjo6bW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lKCkg LSBzd2VlcEJlZ2luVGltZTsKKyAgICAgICAgZG91YmxlIGVsYXBzZWRUaW1lID0gV1RGOjptb25v dG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKSAtIHN3ZWVwQmVnaW5UaW1lOwogICAgICAgICBpZiAo ZWxhcHNlZFRpbWUgPCBzd2VlcFRpbWVTbGljZSkKICAgICAgICAgICAgIGNvbnRpbnVlOwogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9JbmNyZW1lbnRhbFN3ZWVwZXIu aCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0luY3JlbWVudGFsU3dlZXBlci5oCmluZGV4 IGM4MDA1YjAuLjAzYzYyMGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFw L0luY3JlbWVudGFsU3dlZXBlci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0lu Y3JlbWVudGFsU3dlZXBlci5oCkBAIC02MCw4ICs2MCwxMiBAQCBwdWJsaWM6CiAgICAgdm9pZCB3 aWxsRmluaXNoU3dlZXBpbmcoKTsKIAogcHJpdmF0ZToKKyNpZiBVU0UoQ0YpIHx8IFBMQVRGT1JN KEJMQUNLQkVSUlkpCiAjaWYgVVNFKENGKQogICAgIEluY3JlbWVudGFsU3dlZXBlcihIZWFwKiwg Q0ZSdW5Mb29wUmVmKTsKKyNlbHNlCisgICAgSW5jcmVtZW50YWxTd2VlcGVyKEhlYXAqKTsKKyNl bmRpZgogICAgIAogICAgIHZvaWQgZG9Td2VlcChkb3VibGUgc3RhcnRUaW1lKTsKICAgICB2b2lk IHNjaGVkdWxlVGltZXIoKTsK 161500 2012-08-30 09:52:55 -0700 2012-08-30 13:50:16 -0700 the patch 95469.patch text/plain 3701 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGFlM2U2YjUuLjkzODQwMjEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEyLTA4LTMwICBZb25nIExpICA8eW9s aUByaW0uY29tPgogCisgICAgICAgIFtCbGFja0JlcnJ5XSBJbXBsZW1lbnQgSW5jcmVtZW50YWxT d2VlcGVyIGZvciBQTEFURk9STShCTEFDS0JFUlJZKQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU0NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSSU0gUFIjIDIwMDU5NS4KKyAgICAgICAgU2hhcmUgbW9z dCBjb2RlIHdpdGggVVNFKENGKSBhbmQgaW1wbGVtZW50IHRpbWVyLXJlbGF0ZWQgbWV0aG9kcwor ICAgICAgICBmb3IgUExBVEZPUk0oQkxBQ0tCRVJSWSkuCisKKyAgICAgICAgKiBoZWFwL0luY3Jl bWVudGFsU3dlZXBlci5jcHA6CisgICAgICAgIChKU0MpOgorICAgICAgICAoSlNDOjpJbmNyZW1l bnRhbFN3ZWVwZXI6OkluY3JlbWVudGFsU3dlZXBlcik6CisgICAgICAgIChKU0M6OkluY3JlbWVu dGFsU3dlZXBlcjo6Y3JlYXRlKToKKyAgICAgICAgKEpTQzo6SW5jcmVtZW50YWxTd2VlcGVyOjpz Y2hlZHVsZVRpbWVyKToKKyAgICAgICAgKEpTQzo6SW5jcmVtZW50YWxTd2VlcGVyOjpjYW5jZWxU aW1lcik6CisgICAgICAgIChKU0M6OkluY3JlbWVudGFsU3dlZXBlcjo6ZG9Td2VlcCk6CisgICAg ICAgICogaGVhcC9JbmNyZW1lbnRhbFN3ZWVwZXIuaDoKKyAgICAgICAgKEluY3JlbWVudGFsU3dl ZXBlcik6CisKKzIwMTItMDgtMzAgIFlvbmcgTGkgIDx5b2xpQHJpbS5jb20+CisKICAgICAgICAg W0JsYWNrQmVycnldIFNldCB0aW1lciBjbGllbnQgb24gcGxhdGZvcm0gdGltZXIgdXNlZCBpbiBI ZWFwVGltZXIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk1NDY0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0luY3JlbWVu dGFsU3dlZXBlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9JbmNyZW1lbnRhbFN3 ZWVwZXIuY3BwCmluZGV4IGYyODRkOGIuLmRjZjc2YWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9oZWFwL0luY3JlbWVudGFsU3dlZXBlci5jcHAKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2hlYXAvSW5jcmVtZW50YWxTd2VlcGVyLmNwcApAQCAtMzcsMTYgKzM3LDEzIEBA CiAKIG5hbWVzcGFjZSBKU0MgewogCi0jaWYgVVNFKENGKQorI2lmIFVTRShDRikgfHwgUExBVEZP Uk0oQkxBQ0tCRVJSWSkKIAotc3RhdGljIGNvbnN0IENGVGltZUludGVydmFsIHN3ZWVwVGltZVNs aWNlID0gLjAxOyAvLyBzZWNvbmRzCi1zdGF0aWMgY29uc3QgQ0ZUaW1lSW50ZXJ2YWwgc3dlZXBU aW1lVG90YWwgPSAuMTA7Ci1zdGF0aWMgY29uc3QgQ0ZUaW1lSW50ZXJ2YWwgc3dlZXBUaW1lTXVs dGlwbGllciA9IDEuMCAvIHN3ZWVwVGltZVRvdGFsOworc3RhdGljIGNvbnN0IGRvdWJsZSBzd2Vl cFRpbWVTbGljZSA9IC4wMTsgLy8gc2Vjb25kcworc3RhdGljIGNvbnN0IGRvdWJsZSBzd2VlcFRp bWVUb3RhbCA9IC4xMDsKK3N0YXRpYyBjb25zdCBkb3VibGUgc3dlZXBUaW1lTXVsdGlwbGllciA9 IDEuMCAvIHN3ZWVwVGltZVRvdGFsOwogCi12b2lkIEluY3JlbWVudGFsU3dlZXBlcjo6ZG9Xb3Jr KCkKLXsKLSAgICBkb1N3ZWVwKFdURjo6bW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lKCkpOwot fQorI2lmIFVTRShDRikKICAgICAKIEluY3JlbWVudGFsU3dlZXBlcjo6SW5jcmVtZW50YWxTd2Vl cGVyKEhlYXAqIGhlYXAsIENGUnVuTG9vcFJlZiBydW5Mb29wKQogICAgIDogSGVhcFRpbWVyKGhl YXAtPmdsb2JhbERhdGEoKSwgcnVuTG9vcCkKQEAgLTcwLDEyICs2Nyw0MyBAQCB2b2lkIEluY3Jl bWVudGFsU3dlZXBlcjo6Y2FuY2VsVGltZXIoKQogICAgIENGUnVuTG9vcFRpbWVyU2V0TmV4dEZp cmVEYXRlKG1fdGltZXIuZ2V0KCksIENGQWJzb2x1dGVUaW1lR2V0Q3VycmVudCgpICsgc19kZWNh ZGUpOwogfQogCisjZWxpZiBQTEFURk9STShCTEFDS0JFUlJZKQorICAgCitJbmNyZW1lbnRhbFN3 ZWVwZXI6OkluY3JlbWVudGFsU3dlZXBlcihIZWFwKiBoZWFwKQorICAgIDogSGVhcFRpbWVyKGhl YXAtPmdsb2JhbERhdGEoKSkKKyAgICAsIG1fY3VycmVudEJsb2NrVG9Td2VlcEluZGV4KDApCisg ICAgLCBtX3N0cnVjdHVyZXNDYW5CZVN3ZXB0KGZhbHNlKQoreworfQorCitJbmNyZW1lbnRhbFN3 ZWVwZXIqIEluY3JlbWVudGFsU3dlZXBlcjo6Y3JlYXRlKEhlYXAqIGhlYXApCit7CisgICAgcmV0 dXJuIG5ldyBJbmNyZW1lbnRhbFN3ZWVwZXIoaGVhcCk7Cit9CisKK3ZvaWQgSW5jcmVtZW50YWxT d2VlcGVyOjpzY2hlZHVsZVRpbWVyKCkKK3sKKyAgICBtX3RpbWVyLnN0YXJ0KHN3ZWVwVGltZVNs aWNlICogc3dlZXBUaW1lTXVsdGlwbGllcik7Cit9CisKK3ZvaWQgSW5jcmVtZW50YWxTd2VlcGVy OjpjYW5jZWxUaW1lcigpCit7CisgICAgbV90aW1lci5zdG9wKCk7Cit9CisKKyNlbmRpZgorCit2 b2lkIEluY3JlbWVudGFsU3dlZXBlcjo6ZG9Xb3JrKCkKK3sKKyAgICBkb1N3ZWVwKFdURjo6bW9u b3RvbmljYWxseUluY3JlYXNpbmdUaW1lKCkpOworfQorCiB2b2lkIEluY3JlbWVudGFsU3dlZXBl cjo6ZG9Td2VlcChkb3VibGUgc3dlZXBCZWdpblRpbWUpCiB7CiAgICAgd2hpbGUgKG1fY3VycmVu dEJsb2NrVG9Td2VlcEluZGV4IDwgbV9ibG9ja3NUb1N3ZWVwLnNpemUoKSkgewogICAgICAgICBz d2VlcE5leHRCbG9jaygpOwogCi0gICAgICAgIENGVGltZUludGVydmFsIGVsYXBzZWRUaW1lID0g V1RGOjptb25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKSAtIHN3ZWVwQmVnaW5UaW1lOworICAg ICAgICBkb3VibGUgZWxhcHNlZFRpbWUgPSBXVEY6Om1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGlt ZSgpIC0gc3dlZXBCZWdpblRpbWU7CiAgICAgICAgIGlmIChlbGFwc2VkVGltZSA8IHN3ZWVwVGlt ZVNsaWNlKQogICAgICAgICAgICAgY29udGludWU7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9oZWFwL0luY3JlbWVudGFsU3dlZXBlci5oIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2hlYXAvSW5jcmVtZW50YWxTd2VlcGVyLmgKaW5kZXggYzgwMDViMC4uMDNjNjIwZiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSW5jcmVtZW50YWxTd2VlcGVyLmgK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSW5jcmVtZW50YWxTd2VlcGVyLmgKQEAg LTYwLDggKzYwLDEyIEBAIHB1YmxpYzoKICAgICB2b2lkIHdpbGxGaW5pc2hTd2VlcGluZygpOwog CiBwcml2YXRlOgorI2lmIFVTRShDRikgfHwgUExBVEZPUk0oQkxBQ0tCRVJSWSkKICNpZiBVU0Uo Q0YpCiAgICAgSW5jcmVtZW50YWxTd2VlcGVyKEhlYXAqLCBDRlJ1bkxvb3BSZWYpOworI2Vsc2UK KyAgICBJbmNyZW1lbnRhbFN3ZWVwZXIoSGVhcCopOworI2VuZGlmCiAgICAgCiAgICAgdm9pZCBk b1N3ZWVwKGRvdWJsZSBzdGFydFRpbWUpOwogICAgIHZvaWQgc2NoZWR1bGVUaW1lcigpOwo=