95447 2012-08-30 05:01:01 -0700 [BlackBerry] One shot drawing sync flag never cleared when there's no layers 2012-08-30 08:06:29 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anilsson anilsson anilsson anlo mifenton staikos tonikitoo webkit.review.bot oldest_to_newest 708509 0 anilsson 2012-08-30 05:01:01 -0700 When we remove the layers, WebKit could tell us we need a one shot drawing sync to repaint the BackingStore with the content that was previously drawn by layers. We also sometimes set the one shot drawing sync flag manually. We would bail from commit if there were no layers and not actually perform the osds, so it left the osds flag set forever and the situation prevails, because nobody will ever clear the osds flag. No commit means no blit, and the result of regular rendering does not show up on screen. 708517 1 anilsson 2012-08-30 05:17:23 -0700 PR 199866 708519 2 161447 anilsson 2012-08-30 05:22:14 -0700 Created attachment 161447 Patch 708625 3 161447 webkit.review.bot 2012-08-30 08:06:25 -0700 Comment on attachment 161447 Patch Clearing flags on attachment: 161447 Committed r127141: <http://trac.webkit.org/changeset/127141> 708627 4 webkit.review.bot 2012-08-30 08:06:29 -0700 All reviewed patches have been landed. Closing bug. 161447 2012-08-30 05:22:14 -0700 2012-08-30 08:06:25 -0700 Patch bug-95447-20120830142202.patch text/plain 2642 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MDgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA4ZWMyZTM0NTQ4YjcwNDhmOWE1YTRlZjVkZGY4YjY0ZmRhZmMzM2U1Li5mMDU4ZjA4MDk0 N2UwMTIxM2E1OTM3MzgxNjlmZTRlYjY2MTBjNWQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwzNiBAQAorMjAxMi0wOC0zMCAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxz c29uQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIE9uZSBzaG90IGRyYXdpbmcgc3lu YyBmbGFnIG5ldmVyIGNsZWFyZWQgd2hlbiB0aGVyZSdzIG5vIGxheWVycworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU0NDcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQUiAxOTk4NjYKKyAgICAgICAgV2hl biB3ZSByZW1vdmUgdGhlIGxheWVycywgV2ViS2l0IGNvdWxkIHRlbGwgdXMgd2UgbmVlZCBhIG9u ZSBzaG90CisgICAgICAgIGRyYXdpbmcgc3luYyB0byByZXBhaW50IHRoZSBCYWNraW5nU3RvcmUg d2l0aCB0aGUgY29udGVudCB0aGF0IHdhcworICAgICAgICBwcmV2aW91c2x5IGRyYXduIGJ5IGxh eWVycy4gV2UgYWxzbyBzb21ldGltZXMgc2V0IHRoZSBvbmUgc2hvdCBkcmF3aW5nCisgICAgICAg IHN5bmMgZmxhZyBtYW51YWxseS4KKworICAgICAgICBXZSB3b3VsZCBiYWlsIGZyb20gY29tbWl0 IGlmIHRoZXJlIHdlcmUgbm8gbGF5ZXJzIGFuZCBub3QgYWN0dWFsbHkKKyAgICAgICAgcGVyZm9y bSB0aGUgb3Nkcywgc28gaXQgbGVmdCB0aGUgb3NkcyBmbGFnIHNldCBmb3JldmVyIGFuZCB0aGUK KyAgICAgICAgc2l0dWF0aW9uIHByZXZhaWxzLCBiZWNhdXNlIG5vYm9keSB3aWxsIGV2ZXIgY2xl YXIgdGhlIG9zZHMgZmxhZy4KKworICAgICAgICBUaGUgQmFja2luZ1N0b3JlIHN1cnJlbmRlcnMg dGhlIHJlc3BvbnNpYmlsaXR5IG9mIGJsaXR0aW5nIHRvIHRoZSBBQworICAgICAgICBjb21taXQg bWVjaGFuaXNtIHdoZW4gYSBvbmUgc2hvdCBkcmF3aW5nIHN5bmMgaXMgcGVuZGluZywgYmVjYXVz ZSB3ZQorICAgICAgICB3YW50IHRoZSBvcGVyYXRpb25zIHJlbmRlciwgY29tbWl0IGFuZCBibGl0 IHRvIGhhcHBlbiBpbiB0aGUgY29ycmVjdAorICAgICAgICBvcmRlciB3aXRoIG5vIGludGVybWVk aWF0ZSBibGl0cy4KKworICAgICAgICBTbywgbm8gY29tbWl0IG1lYW5zIG5vIGJsaXQsIGFuZCB0 aGUgcmVzdWx0IG9mIHJlZ3VsYXIgcmVuZGVyaW5nIGRpZAorICAgICAgICBub3Qgc2hvdyB1cCBv biBzY3JlZW4uCisKKyAgICAgICAgRml4ZWQgYnkgbm90IGJhaWxpbmcgZnJvbSBjb21taXQgaWYg dGhlcmUncyBubyBsYXllcnMsIGluc3RlYWQgY2xlYXJpbmcKKyAgICAgICAgdGhlICJuZWVkcyBj b21taXQiIGFuZCBvc2RzIGZsYWdzIGFuZCBwZXJmb3JtaW5nIGEgYmxpdC4KKworICAgICAgICBS ZXZpZXdlZCBpbnRlcm5hbGx5IGJ5IEFuZHJldyBMby4KKworICAgICAgICAqIEFwaS9XZWJQYWdl LmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6OmNvbW1p dFJvb3RMYXllcklmTmVlZGVkKToKKwogMjAxMi0wOC0yOSAgUm9iaW4gQ2FvICA8cm9iaW4uY2Fv QHRvcmNobW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gTW92ZSB0aGUgaGFu ZGxpbmcgb2YgVXNlck1lZGlhIHJlcXVlc3RzIHRvIHRoZSBjbGllbnQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IDlmZDU3NzBjMDE5MTYzZjdiOWZhNWQ2ZGQx MmRiYzk2NzI0Mzc0NjIuLjk4MjFlOTQxZjIzNDI1ZDM0MDQxY2I3YzIwOWVlNWE5OTQzODQ4MDAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKKysr IGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtNTY4MCw3ICs1 NjgwLDkgQEAgYm9vbCBXZWJQYWdlUHJpdmF0ZTo6Y29tbWl0Um9vdExheWVySWZOZWVkZWQoKQog ICAgIGlmICghbV9uZWVkc0NvbW1pdCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgaWYg KCEobV9mcmFtZUxheWVycyAmJiBtX2ZyYW1lTGF5ZXJzLT5oYXNMYXllcigpKSAmJiAhbV9vdmVy bGF5TGF5ZXIpCisgICAgLy8gRG9uJ3QgYmFpbCBpZiB0aGUgbGF5ZXJzIHdlcmUgcmVtb3ZlZCBh bmQgd2Ugbm93IG5lZWQgYSBvbmUgc2hvdCBkcmF3aW5nIHN5bmMgYXMgYSBjb25zZXF1ZW5jZS4K KyAgICBpZiAoIShtX2ZyYW1lTGF5ZXJzICYmIG1fZnJhbWVMYXllcnMtPmhhc0xheWVyKCkpICYm ICFtX292ZXJsYXlMYXllcgorICAgICAmJiAhbV9uZWVkc09uZVNob3REcmF3aW5nU3luY2hyb25p emF0aW9uKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBGcmFtZVZpZXcqIHZpZXcgPSBt X21haW5GcmFtZS0+dmlldygpOwo=