95442 2012-08-30 04:15:15 -0700 New fast/events/set-attribute-listener-window-onerror-crash.html fails on JSC platforms 2012-08-30 05:59:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy antonm abarth antonm ossy webkit.review.bot oldest_to_newest 708486 0 ossy 2012-08-30 04:15:15 -0700 It introduced in https://trac.webkit.org/changeset/127117 (https://bugs.webkit.org/show_bug.cgi?id=94440 is security bug) --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/events/set-attribute-listener-window-onerror-crash-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/events/set-attribute-listener-window-onerror-crash-actual.txt @@ -1,2 +1,2 @@ -CONSOLE MESSAGE: line 16: Uncaught SyntaxError: Unexpected token ; +CONSOLE MESSAGE: line 16: SyntaxError: Unexpected token ';' Test passes if it does not crash. As far as I remember the consensus is that platform independent result should be the JSC one it JSC and V8 results are different. Could you update it, please? 708494 1 antonm 2012-08-30 04:30:40 -0700 Sure, will do and sorry for inconvenience. (In reply to comment #0) > It introduced in https://trac.webkit.org/changeset/127117 > (https://bugs.webkit.org/show_bug.cgi?id=94440 is security bug) > > --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/events/set-attribute-listener-window-onerror-crash-expected.txt > +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/events/set-attribute-listener-window-onerror-crash-actual.txt > @@ -1,2 +1,2 @@ > -CONSOLE MESSAGE: line 16: Uncaught SyntaxError: Unexpected token ; > +CONSOLE MESSAGE: line 16: SyntaxError: Unexpected token ';' > Test passes if it does not crash. > > As far as I remember the consensus is that platform independent > result should be the JSC one it JSC and V8 results are different. > Could you update it, please? 708502 2 161442 antonm 2012-08-30 04:49:27 -0700 Created attachment 161442 Patch 708503 3 161442 ossy 2012-08-30 04:51:09 -0700 Comment on attachment 161442 Patch Not problem, thanks for the quick fix. 708541 4 161442 ossy 2012-08-30 05:59:05 -0700 Comment on attachment 161442 Patch Clearing flags on attachment: 161442 Committed r127129: <http://trac.webkit.org/changeset/127129> 708542 5 ossy 2012-08-30 05:59:11 -0700 All reviewed patches have been landed. Closing bug. 161442 2012-08-30 04:49:27 -0700 2012-08-30 05:59:05 -0700 Patch bug-95442-20120830154915.patch text/plain 1898 antonm SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyNzEyNikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTMwICBBbnRvbiBNdWhpbiAgPGFu dG9ubUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVXBkYXRlIHRlc3QgZXhwZWN0YXRpb25zIHRv IGZvbGxvdyBjb21tb24gZ3VpZGVsaW5lcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk1NDQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRm9sbG93IHVwIHRvIGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL2No YW5nZXNldC8xMjcxMTcKKworICAgICAgICAqIGZhc3QvZXZlbnRzL3NldC1hdHRyaWJ1dGUtbGlz dGVuZXItd2luZG93LW9uZXJyb3ItY3Jhc2gtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHBsYXRm b3JtL2Nocm9taXVtL2Zhc3QvZXZlbnRzL3NldC1hdHRyaWJ1dGUtbGlzdGVuZXItd2luZG93LW9u ZXJyb3ItY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKwogMjAxMi0wOC0zMCAgQ3NhYmEgT3N6 dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0gUkVHUkVTU0lPTihy MTIyMTc1KTogZmFzdC9sb2FkZXIvZG9jdW1lbnQtZGVzdHJ1Y3Rpb24td2l0aGluLXVubG9hZC5o dG1sIG1ha2VzIHRoZSBmb2xsb3dpbmcgdGVzdCBhc3NlcnQKSW5kZXg6IExheW91dFRlc3RzL2Zh c3QvZXZlbnRzL3NldC1hdHRyaWJ1dGUtbGlzdGVuZXItd2luZG93LW9uZXJyb3ItY3Jhc2gtZXhw ZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3NldC1hdHRy aWJ1dGUtbGlzdGVuZXItd2luZG93LW9uZXJyb3ItY3Jhc2gtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAxMjcxMjYpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zZXQtYXR0cmlidXRlLWxpc3Rl bmVyLXdpbmRvdy1vbmVycm9yLWNyYXNoLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAt MSwyICsxLDIgQEAKLUNPTlNPTEUgTUVTU0FHRTogbGluZSAxNjogVW5jYXVnaHQgU3ludGF4RXJy b3I6IFVuZXhwZWN0ZWQgdG9rZW4gOworQ09OU09MRSBNRVNTQUdFOiBsaW5lIDE2OiBTeW50YXhF cnJvcjogVW5leHBlY3RlZCB0b2tlbiAnOycKIFRlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IGNy YXNoLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vZmFzdC9ldmVudHMvc2V0 LWF0dHJpYnV0ZS1saXN0ZW5lci13aW5kb3ctb25lcnJvci1jcmFzaC1leHBlY3RlZC50eHQKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vZmFzdC9ldmVudHMvc2V0 LWF0dHJpYnV0ZS1saXN0ZW5lci13aW5kb3ctb25lcnJvci1jcmFzaC1leHBlY3RlZC50eHQJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L2V2ZW50cy9z ZXQtYXR0cmlidXRlLWxpc3RlbmVyLXdpbmRvdy1vbmVycm9yLWNyYXNoLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKQEAgLTAsMCArMSwyIEBACitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMTY6IFVu Y2F1Z2h0IFN5bnRheEVycm9yOiBVbmV4cGVjdGVkIHRva2VuIDsKK1Rlc3QgcGFzc2VzIGlmIGl0 IGRvZXMgbm90IGNyYXNoLgo=