95434 2012-08-30 01:10:43 -0700 [Forms] Left/Right keys in multiple fields time input UI should move focus physical left/right instead of logical left/right regardless text direction. 2012-08-31 00:08:48 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 95168 1 yosin yosin tkent oldest_to_newest 708402 0 yosin 2012-08-30 01:10:43 -0700 Current implementation moves focus to logical left/right for Left/Right keys. 709331 1 161624 yosin 2012-08-30 23:42:42 -0700 Created attachment 161624 Patch 1 709332 2 161624 yosin 2012-08-30 23:43:26 -0700 Comment on attachment 161624 Patch 1 Could you review this patch? Thanks in advance. 709335 3 161624 tkent 2012-08-30 23:52:51 -0700 Comment on attachment 161624 Patch 1 ok 709338 4 161624 yosin 2012-08-31 00:08:44 -0700 Comment on attachment 161624 Patch 1 Clearing flags on attachment: 161624 Committed r127235: <http://trac.webkit.org/changeset/127235> 709339 5 yosin 2012-08-31 00:08:48 -0700 All reviewed patches have been landed. Closing bug. 161624 2012-08-30 23:42:42 -0700 2012-08-31 00:08:44 -0700 Patch 1 bug-95434-20120831154230.patch text/plain 6648 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MjM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGIwNjE4OWIzMGNmYjJl MjczMzM1MzkxZmE3YTUwNGRmMzFiYmY1Yy4uOTA4YmU2YjczMWQ1YjQxZTg1M2U4NjY0NDI0MWU0 MmMzYTg3MThkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA4LTMxICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBMZWZ0 L1JpZ2h0IGtleXMgaW4gbXVsdGlwbGUgZmllbGRzIHRpbWUgaW5wdXQgVUkgc2hvdWxkIG1vdmUg Zm9jdXMgcGh5c2ljYWwgbGVmdC9yaWdodCBpbnN0ZWFkIG9mIGxvZ2ljYWwgbGVmdC9yaWdodCBy ZWdhcmRsZXNzIHRleHQgZGlyZWN0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTU0MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGFsc28gY2hhbmdlcyBoYW5kbGluZyBvZiBMZWZ0 L1JpZ2h0IGtleXMgdG8gYXdhcmUgdGV4dAorICAgICAgICBkaXJlY3Rpb24gKCJkaXIiIGF0dHJp YnV0ZSIpLiBMZWZ0L1JpZ2h0IGtleXMgc2hvdWxkIG1vdmUgZm9jdXMKKyAgICAgICAgcGh5c2lj YWwgcmlnaHQvbGVmdCBpbnN0ZWFkIG9mIGxvZ2ljYWwgcmlnaHQvbGVmdC4KKworICAgICAgICBU aGlzIHBhdGNoIGFmZmVjdHMgcG9ydHMgd2hpY2ggZW5hYmxlIGJvdGggRU5BQkxFX0lOUFVUX1RZ UEVfVElNRSBhbmQKKyAgICAgICAgRU5BQkxFX0lOUFVUX1RZUEVfVElNRV9NVUxUSVBMRV9GSUVM RFMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIHBhdGNoIGFkZHMgYSB0ZXN0IGNhc2Ug aW50byBmYXN0L2Zvcm1zL3RpbWUtbXVsdGlwbGUtZmllbGRzL3RpbWUtbXVsdGlwbGUtZmllbGRz LWtleWJvYXJkLWV2ZW50cy5odG1sCisKKyAgICAgICAgKiBodG1sL3NoYWRvdy9EYXRlVGltZUZp ZWxkRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEYXRlVGltZUZpZWxkRWxlbWVudDo6 ZGVmYXVsdEtleWJvYXJkRXZlbnRIYW5kbGVyKTogQ2hhbmdlZCB0byBjaGVjayBpc1JUTCgpIGZv ciBMZWZ0L1JpZ2h0IGtleXMgdGhlbiB3ZSBjYWxsCisgICAgICAgIGFwcHJvcHJpYXRlIGZvY3Vz IG1vdGlvbiBmdW5jdGlvbi4KKyAgICAgICAgKFdlYkNvcmU6OkRhdGVUaW1lRmllbGRFbGVtZW50 Ojppc1JUTCk6IEFkZGVkIGZvciBjaGVja2luZyB0ZXh0IGRpcmVjdGlvbiBpcyByaWdodC10by1s ZWZ0IG9yIG5vdC4KKyAgICAgICAgKiBodG1sL3NoYWRvdy9EYXRlVGltZUZpZWxkRWxlbWVudC5o OgorICAgICAgICAoRGF0ZVRpbWVGaWVsZEVsZW1lbnQpOiBBZGRlZCBkZWNsYXJhdGlvbiBvZiBp c1JUTCgpLgorCiAyMDEyLTA4LTMwICBZb3NoaWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgW0Zvcm1zXSBCbHVyIGZyb20gZmllbGQgc2hvdWxkIHJlc2V0IHR5cGVh aGVhZCBidWZmZXIgaW4gbXVsdGlwbGUgZmllbGRzIHRpbWUgaW5wdXQgVUkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L0RhdGVUaW1lRmllbGRFbGVtZW50LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L0RhdGVUaW1lRmllbGRFbGVtZW50LmNwcAppbmRleCA1 YjY5NjQ3OGE4OTZkOTYwZmJjMTQwZTcyZmUzMTJkZDM0NDljZWI1Li5iNjI0NjdkNGI5YTcwYzY1 ZjkxM2NkMWE0YzUwOTk3MGIzNjQ5NzJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1s L3NoYWRvdy9EYXRlVGltZUZpZWxkRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRt bC9zaGFkb3cvRGF0ZVRpbWVGaWVsZEVsZW1lbnQuY3BwCkBAIC04NCw3ICs4NCw3IEBAIHZvaWQg RGF0ZVRpbWVGaWVsZEVsZW1lbnQ6OmRlZmF1bHRLZXlib2FyZEV2ZW50SGFuZGxlcihLZXlib2Fy ZEV2ZW50KiBrZXlib2FyZEV2CiAgICAgaWYgKGtleUlkZW50aWZpZXIgPT0gIkxlZnQiKSB7CiAg ICAgICAgIGlmICghbV9maWVsZE93bmVyKQogICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICBp ZiAobV9maWVsZE93bmVyLT5mb2N1c09uUHJldmlvdXNGaWVsZCgqdGhpcykpCisgICAgICAgIGlm IChpc1JUTCgpID8gbV9maWVsZE93bmVyLT5mb2N1c09uTmV4dEZpZWxkKCp0aGlzKSA6IG1fZmll bGRPd25lci0+Zm9jdXNPblByZXZpb3VzRmllbGQoKnRoaXMpKQogICAgICAgICAgICAga2V5Ym9h cmRFdmVudC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KQEAg LTkyLDcgKzkyLDcgQEAgdm9pZCBEYXRlVGltZUZpZWxkRWxlbWVudDo6ZGVmYXVsdEtleWJvYXJk RXZlbnRIYW5kbGVyKEtleWJvYXJkRXZlbnQqIGtleWJvYXJkRXYKICAgICBpZiAoa2V5SWRlbnRp ZmllciA9PSAiUmlnaHQiKSB7CiAgICAgICAgIGlmICghbV9maWVsZE93bmVyKQogICAgICAgICAg ICAgcmV0dXJuOwotICAgICAgICBpZiAobV9maWVsZE93bmVyLT5mb2N1c09uTmV4dEZpZWxkKCp0 aGlzKSkKKyAgICAgICAgaWYgKGlzUlRMKCkgPyBtX2ZpZWxkT3duZXItPmZvY3VzT25QcmV2aW91 c0ZpZWxkKCp0aGlzKSA6IG1fZmllbGRPd25lci0+Zm9jdXNPbk5leHRGaWVsZCgqdGhpcykpCiAg ICAgICAgICAgICBrZXlib2FyZEV2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgpOwogICAgICAgICBy ZXR1cm47CiAgICAgfQpAQCAtMTQ1LDYgKzE0NSwxMSBAQCBib29sIERhdGVUaW1lRmllbGRFbGVt ZW50Ojppc1JlYWRPbmx5KCkgY29uc3QKICAgICByZXR1cm4gZmFzdEhhc0F0dHJpYnV0ZShyZWFk b25seUF0dHIpOwogfQogCitib29sIERhdGVUaW1lRmllbGRFbGVtZW50Ojppc1JUTCgpIGNvbnN0 Cit7CisgICAgcmV0dXJuIHJlbmRlcmVyKCkgJiYgcmVuZGVyZXIoKS0+c3R5bGUoKS0+ZGlyZWN0 aW9uKCkgPT0gUlRMOworfQorCiB2b2lkIERhdGVUaW1lRmllbGRFbGVtZW50OjpzZXRSZWFkT25s eSgpCiB7CiAgICAgLy8gU2V0IEhUTUwgYXR0cmlidXRlIHJlYWRvbmx5IHRvIGNoYW5nZSBhcHBl cmFuY2UuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9EYXRlVGltZUZp ZWxkRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvRGF0ZVRpbWVGaWVsZEVs ZW1lbnQuaAppbmRleCAxMzc2YzYyZjQ3OWI0Y2JmMGRmZjE2NDc3MGIzMzIzMWUzY2JhMWRjLi4w YTliZWUwMTA2MWQxMDMzZDQ1MWM3YWMyMDQ4YjEyMTk2ZjNmZjYzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL3NoYWRvdy9EYXRlVGltZUZpZWxkRWxlbWVudC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvc2hhZG93L0RhdGVUaW1lRmllbGRFbGVtZW50LmgKQEAgLTg0LDYgKzg0 LDcgQEAgcHJvdGVjdGVkOgogcHJpdmF0ZToKICAgICB2b2lkIGRlZmF1bHRLZXlib2FyZEV2ZW50 SGFuZGxlcihLZXlib2FyZEV2ZW50Kik7CiAgICAgdmlydHVhbCBib29sIGlzRm9jdXNhYmxlKCkg Y29uc3QgT1ZFUlJJREUgRklOQUw7CisgICAgYm9vbCBpc1JUTCgpIGNvbnN0OwogICAgIHZpcnR1 YWwgYm9vbCBzdXBwb3J0c0ZvY3VzKCkgY29uc3QgT1ZFUlJJREUgRklOQUw7CiAKICAgICBGaWVs ZE93bmVyKiBtX2ZpZWxkT3duZXI7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWQzNzNiZTViZTQzZDU1Y2I0ODliMzk2NDM4 NTUwYjAzNTY0YmY3My4uNGY4YTA0MWYyYWJjZDQ3NTI0MWE2ODQzMjY4MWEyNzAyMmNmZWUwMiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTMxICBZb3NoaWZ1bWkgSW5vdWUgIDx5b3Np bkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBMZWZ0L1JpZ2h0IGtleXMgaW4gbXVs dGlwbGUgZmllbGRzIHRpbWUgaW5wdXQgVUkgc2hvdWxkIG1vdmUgZm9jdXMgcGh5c2ljYWwgbGVm dC9yaWdodCBpbnN0ZWFkIG9mIGxvZ2ljYWwgbGVmdC9yaWdodCByZWdhcmRsZXNzIHRleHQgZGly ZWN0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTU0MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIHBhdGNoIGFkZHMgYSBuZXcgdGVzdCBjYXNlIG9mIExlZnQvUmlnaHQga2V5cyBuYXZpZ2F0 aW9uIG9uCisgICAgICAgIHJpZ2h0LXRvLWxlZnQgdGV4dCBkaXJlY3Rpb24gZm9yIG11bHRpcGxl IGZpZWxkIHRpbWUgaW5wdXQgVUkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZmZlY3RzIHBvcnRz IHdoaWNoIGVuYWJsZSBib3RoIEVOQUJMRV9JTlBVVF9UWVBFX1RJTUUgYW5kCisgICAgICAgIEVO QUJMRV9JTlBVVF9UWVBFX1RJTUVfTVVMVElQTEVfRklFTERTLgorCisgICAgICAgICogZmFzdC9m b3Jtcy90aW1lLW11bHRpcGxlLWZpZWxkcy90aW1lLW11bHRpcGxlLWZpZWxkcy1rZXlib2FyZC1l dmVudHMuaHRtbDogQ2hhbmdlZCB0byBoYXZlIExlZnQvUmlnaHQga2V5cyBuYXZpZ2F0aW9uIGlu CisgICAgICAgIHJpZ2h0LXRvLWxlZnQgdGV4dCBkaXJlY3Rpb24uCisKIDIwMTItMDgtMzAgIFlv c2hpZnVtaSBJbm91ZSAgPHlvc2luQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbRm9ybXNdIEJs dXIgZnJvbSBmaWVsZCBzaG91bGQgcmVzZXQgdHlwZWFoZWFkIGJ1ZmZlciBpbiBtdWx0aXBsZSBm aWVsZHMgdGltZSBpbnB1dCBVSQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90 aW1lLW11bHRpcGxlLWZpZWxkcy90aW1lLW11bHRpcGxlLWZpZWxkcy1rZXlib2FyZC1ldmVudHMt ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90aW1lLW11bHRpcGxlLWZpZWxk cy90aW1lLW11bHRpcGxlLWZpZWxkcy1rZXlib2FyZC1ldmVudHMtZXhwZWN0ZWQudHh0CmluZGV4 IGNiNDUwYWVhZDJiZDYxZDQwYjMzYmQzZWNlYWFjZGY0N2ZkZjY1OTIuLjJmMzk1YjI1NzYxNzYy Y2NhZTkzNDNjODNlMGQ0MTRjNDhlZWYwMWEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qv Zm9ybXMvdGltZS1tdWx0aXBsZS1maWVsZHMvdGltZS1tdWx0aXBsZS1maWVsZHMta2V5Ym9hcmQt ZXZlbnRzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RpbWUtbXVs dGlwbGUtZmllbGRzL3RpbWUtbXVsdGlwbGUtZmllbGRzLWtleWJvYXJkLWV2ZW50cy1leHBlY3Rl ZC50eHQKQEAgLTM3LDYgKzM3LDEwIEBAIFBBU1MgaW5wdXQudmFsdWUgaXMgIiIKID09IFR5cGVh aGVhZCA9PQogUEFTUyBpbnB1dC52YWx1ZSBpcyAiMTI6MDE6NTYiCiBQQVNTIGlucHV0LnZhbHVl IGlzICIxMjowMjo1NiIKKz09IFJUTCBMZWZ0L1JpZ2h0IGtleXMgPT0KK1BBU1MgaW5wdXQudmFs dWUgaXMgIjAxOjU2IgorUEFTUyBpbnB1dC52YWx1ZSBpcyAiMDE6MDIiCitQQVNTIGlucHV0LnZh bHVlIGlzICIwMzowMiIKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAogVEVTVCBD T01QTEVURQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90aW1lLW11bHRpcGxl LWZpZWxkcy90aW1lLW11bHRpcGxlLWZpZWxkcy1rZXlib2FyZC1ldmVudHMuaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvZm9ybXMvdGltZS1tdWx0aXBsZS1maWVsZHMvdGltZS1tdWx0aXBsZS1maWVs ZHMta2V5Ym9hcmQtZXZlbnRzLmh0bWwKaW5kZXggNjMzNGI1ZWQxNjgxZWU0MTkzZmZlODYzNGIy NGYxNjlhMjhkOWExYy4uMmFhNjkyZWViYmE2MWU5YWI4YzMzNmU2NjAwMDZhMjMzODZkZDBlMSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90aW1lLW11bHRpcGxlLWZpZWxkcy90 aW1lLW11bHRpcGxlLWZpZWxkcy1rZXlib2FyZC1ldmVudHMuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL3RpbWUtbXVsdGlwbGUtZmllbGRzL3RpbWUtbXVsdGlwbGUtZmllbGRzLWtl eWJvYXJkLWV2ZW50cy5odG1sCkBAIC0xMjYsNiArMTI2LDE3IEBAIGtleURvd24oJ3JpZ2h0QXJy b3cnKTsKIGtleURvd24oJ2xlZnRBcnJvdycpOwoga2V5RG93bignMicpOwogc2hvdWxkQmVFcXVh bFRvU3RyaW5nKCdpbnB1dC52YWx1ZScsICcxMjowMjo1NicpOworCitiZWdpblRlc3QoJ1JUTCBM ZWZ0L1JpZ2h0IGtleXMnLCAnMDQ6NTYnKTsKK2lucHV0LnNldEF0dHJpYnV0ZSgiZGlyIiwgInJ0 bCIpOwora2V5RG93bignMScpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCdpbnB1dC52YWx1ZScs ICcwMTo1NicpOwora2V5RG93bignbGVmdEFycm93Jyk7CitrZXlEb3duKCcyJyk7CitzaG91bGRC ZUVxdWFsVG9TdHJpbmcoJ2lucHV0LnZhbHVlJywgJzAxOjAyJyk7CitrZXlEb3duKCdyaWdodEFy cm93Jyk7CitrZXlEb3duKCczJyk7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ2lucHV0LnZhbHVl JywgJzAzOjAyJyk7CiA8L3NjcmlwdD4KIDxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMv anMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KIDwvYm9keT4K