95422 2012-08-29 22:53:33 -0700 Fix compile warning when enable tiled backing store 2012-08-30 02:38:32 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 95342 1 kangil.han kangil.han fpizlo haraken rakuco webkit.review.bot oldest_to_newest 708326 0 kangil.han 2012-08-29 22:53:33 -0700 There are some compile warnings when enable tiled backing store. 708335 1 161405 kangil.han 2012-08-29 23:04:48 -0700 Created attachment 161405 patch 708340 2 fpizlo 2012-08-29 23:20:18 -0700 This looks good, but lets wait and see if all of the build systems are happy. 708342 3 kangil.han 2012-08-29 23:22:25 -0700 (In reply to comment #2) > This looks good, but lets wait and see if all of the build systems are happy. Thanks, sure thing! 708440 4 161405 haraken 2012-08-30 02:22:49 -0700 Comment on attachment 161405 patch bots are green:) 708449 5 161405 webkit.review.bot 2012-08-30 02:38:28 -0700 Comment on attachment 161405 patch Clearing flags on attachment: 161405 Committed r127118: <http://trac.webkit.org/changeset/127118> 708450 6 webkit.review.bot 2012-08-30 02:38:32 -0700 All reviewed patches have been landed. Closing bug. 161405 2012-08-29 23:04:48 -0700 2012-08-30 02:38:27 -0700 patch tiled_fix_compile_warning_webcore.txt text/plain 6376 kangil.han ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhODk4NTcxLi42ZDUwZGNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTItMDgtMjkgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgorCisg ICAgICAgIEZpeCBjb21waWxlIHdhcm5pbmcgd2hlbiBlbmFibGUgdGlsZWQgYmFja2luZyBzdG9y ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU0MjIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCBj b21waWxlIHdhcm5pbmcgbWVzc2FnZXMgd2hlbiBlbmFibGVkIHRpbGVkIGJhY2tpbmcgc3RvcmUu CisgICAgICAgIEluIGNhc2Ugb2YgVGlsZWRCYWNraW5nU3RvcmUsIGl0IHdhcyBmaXJzdCB0aG91 Z2h0IGFib3V0IHN0YXRpY19jYXN0PHVuc2lnbmVkPi4KKyAgICAgICAgSG93ZXZlciwgaWYgbWlu dXMgdmFsdWUgaXMgYXNzaWduZWQgdG8gdGhlIGNvbXBhcmlzb24sIGl0IHdvdWxkIGJlIGNyaXRp Y2FsLgorICAgICAgICBTbywgaXQgd2FzIG1vZGlmaWVkIGFzIHVzaW5nIGludCB2YWx1ZSBpbiB0 aWxlZCBjb29yZGluYXRlIGNhbGN1bGF0aW9uLgorCisgICAgICAgICogcGFnZS9GcmFtZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpGcmFtZTo6dGlsZWRCYWNraW5nU3RvcmVQYWludEVuZCk6IGNv bXBhcmlzb24gYmV0d2VlbiBzaWduZWQgYW5kIHVuc2lnbmVkIGludGVnZXIgZXhwcmVzc2lvbnMg Wy1Xc2lnbi1jb21wYXJlXQorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFja2lu Z1N0b3JlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRpbGVkQmFja2luZ1N0b3JlOjppbnZhbGlk YXRlKTogY29tcGFyaXNvbiBiZXR3ZWVuIHNpZ25lZCBhbmQgdW5zaWduZWQgaW50ZWdlciBleHBy ZXNzaW9ucyBbLVdzaWduLWNvbXBhcmVdCisgICAgICAgIChXZWJDb3JlOjpUaWxlZEJhY2tpbmdT dG9yZTo6cGFpbnQpOiBjb21wYXJpc29uIGJldHdlZW4gc2lnbmVkIGFuZCB1bnNpZ25lZCBpbnRl Z2VyIGV4cHJlc3Npb25zIFstV3NpZ24tY29tcGFyZV0KKyAgICAgICAgKFdlYkNvcmU6OlRpbGVk QmFja2luZ1N0b3JlOjpjb3ZlcmFnZVJhdGlvKTogY29tcGFyaXNvbiBiZXR3ZWVuIHNpZ25lZCBh bmQgdW5zaWduZWQgaW50ZWdlciBleHByZXNzaW9ucyBbLVdzaWduLWNvbXBhcmVdCisgICAgICAg IChXZWJDb3JlOjpUaWxlZEJhY2tpbmdTdG9yZTo6Y3JlYXRlVGlsZXMpOiBjb21wYXJpc29uIGJl dHdlZW4gc2lnbmVkIGFuZCB1bnNpZ25lZCBpbnRlZ2VyIGV4cHJlc3Npb25zIFstV3NpZ24tY29t cGFyZV0KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HTENvbnRleHQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6R0xDb250ZXh0OjpjcmVhdGVPZmZzY3JlZW5Db250ZXh0KTogbm8g cmV0dXJuIHN0YXRlbWVudCBpbiBmdW5jdGlvbiByZXR1cm5pbmcgbm9uLXZvaWQgWy1XcmV0dXJu LXR5cGVdCisKIDIwMTItMDgtMjkgIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTI2ODE2KTogTWlzc2luZyBpbmNsdWRlcyB3aGVu IGNvbXBpbGluZyB3aXRob3V0IFNWRwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9G cmFtZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAppbmRleCBjOGUzYmZmLi5i MzY0OGY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcApAQCAtODUwLDcgKzg1MCw3IEBAIHZvaWQgRnJh bWU6OnRpbGVkQmFja2luZ1N0b3JlUGFpbnRFbmQoY29uc3QgVmVjdG9yPEludFJlY3Q+JiBwYWlu dGVkQXJlYSkKICAgICAgICAgcmV0dXJuOwogICAgIHVuc2lnbmVkIHNpemUgPSBwYWludGVkQXJl YS5zaXplKCk7CiAgICAgLy8gUmVxdWVzdCByZXBhaW50IGZyb20gdGhlIHN5c3RlbQotICAgIGZv ciAoaW50IG4gPSAwOyBuIDwgc2l6ZTsgKytuKQorICAgIGZvciAodW5zaWduZWQgbiA9IDA7IG4g PCBzaXplOyArK24pCiAgICAgICAgIG1fcGFnZS0+Y2hyb21lKCktPmludmFsaWRhdGVDb250ZW50 c0FuZFJvb3RWaWV3KG1fdmlldy0+Y29udGVudHNUb1Jvb3RWaWV3KHBhaW50ZWRBcmVhW25dKSwg ZmFsc2UpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9UaWxlZEJhY2tpbmdTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9UaWxlZEJhY2tpbmdTdG9yZS5jcHAKaW5kZXggYjQ4NWRjZi4uYTE5ZjZhNiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFja2luZ1N0b3Jl LmNwcApAQCAtOTEsOCArOTEsOCBAQCB2b2lkIFRpbGVkQmFja2luZ1N0b3JlOjppbnZhbGlkYXRl KGNvbnN0IEludFJlY3QmIGNvbnRlbnRzRGlydHlSZWN0KQogICAgIFRpbGU6OkNvb3JkaW5hdGUg dG9wTGVmdCA9IHRpbGVDb29yZGluYXRlRm9yUG9pbnQoY292ZXJlZERpcnR5UmVjdC5sb2NhdGlv bigpKTsKICAgICBUaWxlOjpDb29yZGluYXRlIGJvdHRvbVJpZ2h0ID0gdGlsZUNvb3JkaW5hdGVG b3JQb2ludChpbm5lckJvdHRvbVJpZ2h0KGNvdmVyZWREaXJ0eVJlY3QpKTsKIAotICAgIGZvciAo dW5zaWduZWQgeUNvb3JkaW5hdGUgPSB0b3BMZWZ0LnkoKTsgeUNvb3JkaW5hdGUgPD0gYm90dG9t UmlnaHQueSgpOyArK3lDb29yZGluYXRlKSB7Ci0gICAgICAgIGZvciAodW5zaWduZWQgeENvb3Jk aW5hdGUgPSB0b3BMZWZ0LngoKTsgeENvb3JkaW5hdGUgPD0gYm90dG9tUmlnaHQueCgpOyArK3hD b29yZGluYXRlKSB7CisgICAgZm9yIChpbnQgeUNvb3JkaW5hdGUgPSB0b3BMZWZ0LnkoKTsgeUNv b3JkaW5hdGUgPD0gYm90dG9tUmlnaHQueSgpOyArK3lDb29yZGluYXRlKSB7CisgICAgICAgIGZv ciAoaW50IHhDb29yZGluYXRlID0gdG9wTGVmdC54KCk7IHhDb29yZGluYXRlIDw9IGJvdHRvbVJp Z2h0LngoKTsgKyt4Q29vcmRpbmF0ZSkgewogICAgICAgICAgICAgUmVmUHRyPFRpbGU+IGN1cnJl bnRUaWxlID0gdGlsZUF0KFRpbGU6OkNvb3JkaW5hdGUoeENvb3JkaW5hdGUsIHlDb29yZGluYXRl KSk7CiAgICAgICAgICAgICBpZiAoIWN1cnJlbnRUaWxlKQogICAgICAgICAgICAgICAgIGNvbnRp bnVlOwpAQCAtMTUyLDggKzE1Miw4IEBAIHZvaWQgVGlsZWRCYWNraW5nU3RvcmU6OnBhaW50KEdy YXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgSW50UmVjdCYgcmVjdCkKICAgICBUaWxlOjpD b29yZGluYXRlIHRvcExlZnQgPSB0aWxlQ29vcmRpbmF0ZUZvclBvaW50KGRpcnR5UmVjdC5sb2Nh dGlvbigpKTsKICAgICBUaWxlOjpDb29yZGluYXRlIGJvdHRvbVJpZ2h0ID0gdGlsZUNvb3JkaW5h dGVGb3JQb2ludChpbm5lckJvdHRvbVJpZ2h0KGRpcnR5UmVjdCkpOwogCi0gICAgZm9yICh1bnNp Z25lZCB5Q29vcmRpbmF0ZSA9IHRvcExlZnQueSgpOyB5Q29vcmRpbmF0ZSA8PSBib3R0b21SaWdo dC55KCk7ICsreUNvb3JkaW5hdGUpIHsKLSAgICAgICAgZm9yICh1bnNpZ25lZCB4Q29vcmRpbmF0 ZSA9IHRvcExlZnQueCgpOyB4Q29vcmRpbmF0ZSA8PSBib3R0b21SaWdodC54KCk7ICsreENvb3Jk aW5hdGUpIHsKKyAgICBmb3IgKGludCB5Q29vcmRpbmF0ZSA9IHRvcExlZnQueSgpOyB5Q29vcmRp bmF0ZSA8PSBib3R0b21SaWdodC55KCk7ICsreUNvb3JkaW5hdGUpIHsKKyAgICAgICAgZm9yIChp bnQgeENvb3JkaW5hdGUgPSB0b3BMZWZ0LngoKTsgeENvb3JkaW5hdGUgPD0gYm90dG9tUmlnaHQu eCgpOyArK3hDb29yZGluYXRlKSB7CiAgICAgICAgICAgICBUaWxlOjpDb29yZGluYXRlIGN1cnJl bnRDb29yZGluYXRlKHhDb29yZGluYXRlLCB5Q29vcmRpbmF0ZSk7CiAgICAgICAgICAgICBSZWZQ dHI8VGlsZT4gY3VycmVudFRpbGUgPSB0aWxlQXQoY3VycmVudENvb3JkaW5hdGUpOwogICAgICAg ICAgICAgaWYgKGN1cnJlbnRUaWxlICYmIGN1cnJlbnRUaWxlLT5pc1JlYWR5VG9QYWludCgpKQpA QCAtMjIxLDggKzIyMSw4IEBAIGZsb2F0IFRpbGVkQmFja2luZ1N0b3JlOjpjb3ZlcmFnZVJhdGlv KGNvbnN0IFdlYkNvcmU6OkludFJlY3QmIGNvbnRlbnRzUmVjdCkgY29uCiAgICAgVGlsZTo6Q29v cmRpbmF0ZSB0b3BMZWZ0ID0gdGlsZUNvb3JkaW5hdGVGb3JQb2ludChkaXJ0eVJlY3QubG9jYXRp b24oKSk7CiAgICAgVGlsZTo6Q29vcmRpbmF0ZSBib3R0b21SaWdodCA9IHRpbGVDb29yZGluYXRl Rm9yUG9pbnQoaW5uZXJCb3R0b21SaWdodChkaXJ0eVJlY3QpKTsKIAotICAgIGZvciAodW5zaWdu ZWQgeUNvb3JkaW5hdGUgPSB0b3BMZWZ0LnkoKTsgeUNvb3JkaW5hdGUgPD0gYm90dG9tUmlnaHQu eSgpOyArK3lDb29yZGluYXRlKSB7Ci0gICAgICAgIGZvciAodW5zaWduZWQgeENvb3JkaW5hdGUg PSB0b3BMZWZ0LngoKTsgeENvb3JkaW5hdGUgPD0gYm90dG9tUmlnaHQueCgpOyArK3hDb29yZGlu YXRlKSB7CisgICAgZm9yIChpbnQgeUNvb3JkaW5hdGUgPSB0b3BMZWZ0LnkoKTsgeUNvb3JkaW5h dGUgPD0gYm90dG9tUmlnaHQueSgpOyArK3lDb29yZGluYXRlKSB7CisgICAgICAgIGZvciAoaW50 IHhDb29yZGluYXRlID0gdG9wTGVmdC54KCk7IHhDb29yZGluYXRlIDw9IGJvdHRvbVJpZ2h0Lngo KTsgKyt4Q29vcmRpbmF0ZSkgewogICAgICAgICAgICAgVGlsZTo6Q29vcmRpbmF0ZSBjdXJyZW50 Q29vcmRpbmF0ZSh4Q29vcmRpbmF0ZSwgeUNvb3JkaW5hdGUpOwogICAgICAgICAgICAgUmVmUHRy PFRpbGU+IGN1cnJlbnRUaWxlID0gdGlsZUF0KGN1cnJlbnRDb29yZGluYXRlKTsKICAgICAgICAg ICAgIGlmIChjdXJyZW50VGlsZSAmJiBjdXJyZW50VGlsZS0+aXNSZWFkeVRvUGFpbnQoKSkgewpA QCAtMjc4LDggKzI3OCw4IEBAIHZvaWQgVGlsZWRCYWNraW5nU3RvcmU6OmNyZWF0ZVRpbGVzKCkK ICAgICAvLyBpbnNpZGUgdGhlIHZpc2libGUgcmVjdC4KICAgICBUaWxlOjpDb29yZGluYXRlIHRv cExlZnQgPSB0aWxlQ29vcmRpbmF0ZUZvclBvaW50KGNvdmVyUmVjdC5sb2NhdGlvbigpKTsKICAg ICBUaWxlOjpDb29yZGluYXRlIGJvdHRvbVJpZ2h0ID0gdGlsZUNvb3JkaW5hdGVGb3JQb2ludChp bm5lckJvdHRvbVJpZ2h0KGNvdmVyUmVjdCkpOwotICAgIGZvciAodW5zaWduZWQgeUNvb3JkaW5h dGUgPSB0b3BMZWZ0LnkoKTsgeUNvb3JkaW5hdGUgPD0gYm90dG9tUmlnaHQueSgpOyArK3lDb29y ZGluYXRlKSB7Ci0gICAgICAgIGZvciAodW5zaWduZWQgeENvb3JkaW5hdGUgPSB0b3BMZWZ0Lngo KTsgeENvb3JkaW5hdGUgPD0gYm90dG9tUmlnaHQueCgpOyArK3hDb29yZGluYXRlKSB7CisgICAg Zm9yIChpbnQgeUNvb3JkaW5hdGUgPSB0b3BMZWZ0LnkoKTsgeUNvb3JkaW5hdGUgPD0gYm90dG9t UmlnaHQueSgpOyArK3lDb29yZGluYXRlKSB7CisgICAgICAgIGZvciAoaW50IHhDb29yZGluYXRl ID0gdG9wTGVmdC54KCk7IHhDb29yZGluYXRlIDw9IGJvdHRvbVJpZ2h0LngoKTsgKyt4Q29vcmRp bmF0ZSkgewogICAgICAgICAgICAgVGlsZTo6Q29vcmRpbmF0ZSBjdXJyZW50Q29vcmRpbmF0ZSh4 Q29vcmRpbmF0ZSwgeUNvb3JkaW5hdGUpOwogICAgICAgICAgICAgaWYgKHRpbGVBdChjdXJyZW50 Q29vcmRpbmF0ZSkpCiAgICAgICAgICAgICAgICAgY29udGludWU7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HTENvbnRleHQuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR0xDb250ZXh0LmNwcAppbmRleCA2ZWI5 OTA0Li4zYjgwNGY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jYWlyby9HTENvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2NhaXJvL0dMQ29udGV4dC5jcHAKQEAgLTUzLDYgKzUzLDcgQEAgUGFzc093blB0cjxHTENv bnRleHQ+IEdMQ29udGV4dDo6Y3JlYXRlT2Zmc2NyZWVuQ29udGV4dChHTENvbnRleHQqIHNoYXJp bmcpCiAjaWYgVVNFKEdMWCkKICAgICByZXR1cm4gR0xDb250ZXh0R0xYOjpjcmVhdGVDb250ZXh0 KDAsIHNoYXJpbmcpOwogI2VuZGlmCisgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAKIC8vIEZJWE1F OiBUaGlzIHNob3VsZCBiZSBhIHRocmVhZCBsb2NhbCBldmVudHVhbGx5IGlmIHdlCg==