95400 2012-08-29 16:42:10 -0700 [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests 2012-08-30 15:57:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Android RESOLVED FIXED P2 Normal --- 93627 1 wangxianzhu wangxianzhu abarth dpranke ojan webkit.review.bot oldest_to_newest 708045 0 wangxianzhu 2012-08-29 16:42:10 -0700 WebGL is not enabled and should be skipped on Android (http://crbug.com/135877). 708048 1 161357 wangxianzhu 2012-08-29 16:43:54 -0700 Created attachment 161357 Patch 709047 2 wangxianzhu 2012-08-30 14:50:31 -0700 Adam and Dirk, could you review this change? Thanks. 709064 3 161357 dpranke 2012-08-30 14:58:15 -0700 Comment on attachment 161357 Patch why don't you just include the directories below line 258? Also, I think that ever since I implemented support for cascading expectations, skipped directory names will skip all of the tests in the directory even if there are individual expectations for a test in earlier files. So, I don't think you need to call _real_tests() at all, you can just return a list of directories. We should test this, and if what I just wrote is wrong, fix the bugs and make it right :). 709085 4 161571 wangxianzhu 2012-08-30 15:14:43 -0700 Created attachment 161571 Patch 709088 5 wangxianzhu 2012-08-30 15:15:36 -0700 (In reply to comment #3) > (From update of attachment 161357 [details]) > why don't you just include the directories below line 258? > > Also, I think that ever since I implemented support for cascading expectations, skipped directory names will skip all of the tests in the directory even if there are individual expectations for a test in earlier files. So, I don't think you need to call _real_tests() at all, you can just return a list of directories. > > We should test this, and if what I just wrote is wrong, fix the bugs and make it right :). Great to know that. Tested and it works! 709093 6 161571 dpranke 2012-08-30 15:16:47 -0700 Comment on attachment 161571 Patch much simpler :). 709117 7 161571 webkit.review.bot 2012-08-30 15:57:31 -0700 Comment on attachment 161571 Patch Clearing flags on attachment: 161571 Committed r127203: <http://trac.webkit.org/changeset/127203> 709118 8 webkit.review.bot 2012-08-30 15:57:34 -0700 All reviewed patches have been landed. Closing bug. 161357 2012-08-29 16:43:54 -0700 2012-08-30 15:14:40 -0700 Patch bug-95400-20120829164343.patch text/plain 2112 wangxianzhu U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MDYzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzE1MWZmNzNmNzkxNTgwNzRjMWE4Yzg5ZWNiYTk5NmRi ZjBhNzdlMy4uYTdjMjk5MTg4OTJkYzA3MjM3ODdlZWE3OGI3ZTMxY2RhOGY1ZjRlZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA4LTI5ICBYaWFuemh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgW0Nocm9taXVtLUFuZHJvaWRdIFNraXAgY29tcG9zaXRpbmcvd2ViZ2wgYW5k IHBsYXRmb3JtL2Nocm9taXVtL3ZpcnR1YWwvdGhyZWFkZWQvY29tcG9zaXRpbmcvd2ViZ2wgdGVz dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1NDAw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViR0wg aXMgbm90IGVuYWJsZWQgYW5kIHNob3VsZCBiZSBza2lwcGVkIG9uIEFuZHJvaWQgKGh0dHA6Ly9j cmJ1Zy5jb20vMTM1ODc3KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvY2hyb21pdW1fYW5kcm9pZC5weToKKyAgICAgICAgKENocm9taXVtQW5kcm9pZFBv cnQuc2tpcHBlZF9sYXlvdXRfdGVzdHMpOgorCiAyMDEyLTA4LTI5ICBBbGV4IFNha2hhcnRjaG91 ayAgPGFsZXhzdEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBTdXBwb3J0IGhp Z2ggRElQIHBpeGVsIHRlc3RzIHdpdGggRHVtcFJlbmRlclRyZWUKZGlmZiAtLWdpdCBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fYW5kcm9pZC5weSBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fYW5kcm9p ZC5weQppbmRleCA1YzE3ZjU2NzM5NjVjZmJlMmYxOGNkZmI4MjhmZWI5YzNkMzk4MjllLi5kYTNh NmRjNDViNjczNGE5OWU1YTIwN2I5N2ZjYTVhZTllYTM2OTljIDEwMDY0NAotLS0gYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2FuZHJvaWQucHkKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9hbmRy b2lkLnB5CkBAIC0yNjAsMTAgKzI2MCwxMyBAQCBjbGFzcyBDaHJvbWl1bUFuZHJvaWRQb3J0KGNo cm9taXVtLkNocm9taXVtUG9ydCk6CiAKICAgICAgICAgIyBTa2lwIHdlYmdsIHRlc3RzOiBodHRw Oi8vY3JidWcuY29tLzEzNTg3Ny4KICAgICAgICAgZmFzdF9jYW52YXNfd2ViZ2xfdGVzdHMgPSBz ZWxmLl9yZWFsX3Rlc3RzKFsnZmFzdC9jYW52YXMvd2ViZ2wnXSkKKyAgICAgICAgY29tcG9zaXRp bmdfd2ViZ2xfdGVzdHMgPSBzZWxmLl9yZWFsX3Rlc3RzKFsnY29tcG9zaXRpbmcvd2ViZ2wnXSkK ICAgICAgICAgcmV0dXJuIChza2lwcGVkX3Rlc3RzIHwKICAgICAgICAgICAgICAgICBmYXN0X2Nh bnZhc193ZWJnbF90ZXN0cyB8CisgICAgICAgICAgICAgICAgY29tcG9zaXRpbmdfd2ViZ2xfdGVz dHMgfAogICAgICAgICAgICAgICAgIHNlbGYuX3JlYWxfdGVzdHMoWydodHRwL3Rlc3RzL2NhbnZh cy93ZWJnbCddKSB8Ci0gICAgICAgICAgICAgICAgc2V0KFsncGxhdGZvcm0vY2hyb21pdW0vdmly dHVhbC9ncHUvJyArIGYgZm9yIGYgaW4gZmFzdF9jYW52YXNfd2ViZ2xfdGVzdHNdKSkKKyAgICAg ICAgICAgICAgICBzZXQoWydwbGF0Zm9ybS9jaHJvbWl1bS92aXJ0dWFsL2dwdS8nICsgZiBmb3Ig ZiBpbiBmYXN0X2NhbnZhc193ZWJnbF90ZXN0c10pIHwKKyAgICAgICAgICAgICAgICBzZXQoWydw bGF0Zm9ybS9jaHJvbWl1bS92aXJ0dWFsL3RocmVhZGVkLycgKyBmIGZvciBmIGluIGNvbXBvc2l0 aW5nX3dlYmdsX3Rlc3RzXSkpCiAKICAgICBkZWYgY3JlYXRlX2RyaXZlcihzZWxmLCB3b3JrZXJf bnVtYmVyLCBub190aW1lb3V0PUZhbHNlKToKICAgICAgICAgIyBXZSBkb24ndCB3YW50IHRoZSBk ZWZhdWx0IERyaXZlclByb3h5IHdoaWNoIGlzIG5vdCBjb21wYXRpYmxlIHdpdGggb3VyIGRyaXZl ci4K 161571 2012-08-30 15:14:43 -0700 2012-08-30 15:57:30 -0700 Patch bug-95400-20120830151432.patch text/plain 2677 wangxianzhu U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MTk2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzdkNmJmYjQ4NDU0Mjc0YzUxMmQwMDUxYmZhNTJmZDA3 NjZkM2RjZS4uMjgxNGQ1OWNjOWVjN2E3ZWUzMDkzNmE5OWEyMzYzZmY2MjkwOGM1MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA4LTMwICBYaWFuemh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgW0Nocm9taXVtLUFuZHJvaWRdIFNraXAgY29tcG9zaXRpbmcvd2ViZ2wgYW5k IHBsYXRmb3JtL2Nocm9taXVtL3ZpcnR1YWwvdGhyZWFkZWQvY29tcG9zaXRpbmcvd2ViZ2wgdGVz dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1NDAw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViR0wg aXMgbm90IGVuYWJsZWQgYW5kIHNob3VsZCBiZSBza2lwcGVkIG9uIEFuZHJvaWQgKGh0dHA6Ly9j cmJ1Zy5jb20vMTM1ODc3KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvY2hyb21pdW1fYW5kcm9pZC5weToKKyAgICAgICAgKENocm9taXVtQW5kcm9pZFBv cnQuc2tpcHBlZF9sYXlvdXRfdGVzdHMpOgorCiAyMDEyLTA4LTMwICBQcmF0aWsgU29sYW5raSAg PHBzb2xhbmtpQGFwcGxlLmNvbT4KIAogICAgICAgICBvYmpjX21zZ1NlbmQgYW5kIElNUCBzaG91 bGQgYmUgY2FzdCBhcHByb3ByaWF0ZWx5IGJlZm9yZSB1c2luZwpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9hbmRyb2lkLnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9hbmRyb2lk LnB5CmluZGV4IDVjMTdmNTY3Mzk2NWNmYmUyZjE4Y2RmYjgyOGZlYjljM2QzOTgyOWUuLmE4Yjg4 MmI2Y2QxYTYwNDUyYmE1YjdhNjhmMWU4NTIwN2FhZmQ0MGIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fYW5kcm9pZC5weQorKysg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2FuZHJv aWQucHkKQEAgLTIzNCw3ICsyMzQsNyBAQCBjbGFzcyBDaHJvbWl1bUFuZHJvaWRQb3J0KGNocm9t aXVtLkNocm9taXVtUG9ydCk6CiAgICAgICAgICMgVGhpcyBtZXRob2QgaXMgbW9yZSBjb252ZW5p ZW50IHRvIHNraXAgd2hvbGUgZGlyZWN0b3JpZXMgdGhhbiBTS0lQIGluIFRlc3RFeHBlY3RhdGlv bnMKICAgICAgICAgIyBiZWNhdXNlIGl0cyBoaWdoZXIgcHJpb3JpdHkuCiAgICAgICAgICMgU3Rp bGwgdXNlIFRlc3RFeHBlY3RhdGlvbnMgdG8gc2tpcCBpbmRpdmlkdWFsIHRlc3RzIGFuZCBzbWFs bCBkaXJlY3Rvcmllcy4KLSAgICAgICAgc2tpcHBlZF90ZXN0cyA9IHNlbGYuX3JlYWxfdGVzdHMo WworICAgICAgICByZXR1cm4gc2V0KFsKICAgICAgICAgICAgICMgU2tpcCB0ZXN0cyBvZiBvdGhl ciBwbGF0Zm9ybXMgdG8gc2F2ZSB0aW1lLgogICAgICAgICAgICAgJ3BsYXRmb3JtL2d0aycsCiAg ICAgICAgICAgICAncGxhdGZvcm0vbWFjJywKQEAgLTI1NiwxNCArMjU2LDE0IEBAIGNsYXNzIENo cm9taXVtQW5kcm9pZFBvcnQoY2hyb21pdW0uQ2hyb21pdW1Qb3J0KToKIAogICAgICAgICAgICAg J2FjY2Vzc2liaWxpdHknLAogICAgICAgICAgICAgJ3BsYXRmb3JtL2Nocm9taXVtL2FjY2Vzc2li aWxpdHknLAotICAgICAgICBdKQogCi0gICAgICAgICMgU2tpcCB3ZWJnbCB0ZXN0czogaHR0cDov L2NyYnVnLmNvbS8xMzU4NzcuCi0gICAgICAgIGZhc3RfY2FudmFzX3dlYmdsX3Rlc3RzID0gc2Vs Zi5fcmVhbF90ZXN0cyhbJ2Zhc3QvY2FudmFzL3dlYmdsJ10pCi0gICAgICAgIHJldHVybiAoc2tp cHBlZF90ZXN0cyB8Ci0gICAgICAgICAgICAgICAgZmFzdF9jYW52YXNfd2ViZ2xfdGVzdHMgfAot ICAgICAgICAgICAgICAgIHNlbGYuX3JlYWxfdGVzdHMoWydodHRwL3Rlc3RzL2NhbnZhcy93ZWJn bCddKSB8Ci0gICAgICAgICAgICAgICAgc2V0KFsncGxhdGZvcm0vY2hyb21pdW0vdmlydHVhbC9n cHUvJyArIGYgZm9yIGYgaW4gZmFzdF9jYW52YXNfd2ViZ2xfdGVzdHNdKSkKKyAgICAgICAgICAg ICMgU2tpcCB3ZWJnbCB0ZXN0czogaHR0cDovL2NyYnVnLmNvbS8xMzU4NzcuCisgICAgICAgICAg ICAnY29tcG9zaXRpbmcvd2ViZ2wnLAorICAgICAgICAgICAgJ2Zhc3QvY2FudmFzL3dlYmdsJywK KyAgICAgICAgICAgICdodHRwL3Rlc3RzL2NhbnZhcy93ZWJnbCcsCisgICAgICAgICAgICAncGxh dGZvcm0vY2hyb21pdW0vdmlydHVhbC9ncHUvZmFzdC9jYW52YXMvd2ViZ2wnLAorICAgICAgICAg ICAgJ3BsYXRmb3JtL2Nocm9taXVtL3ZpcnR1YWwvdGhyZWFkZWQvY29tcG9zaXRpbmcvd2ViZ2wn LAorICAgICAgICBdKQogCiAgICAgZGVmIGNyZWF0ZV9kcml2ZXIoc2VsZiwgd29ya2VyX251bWJl ciwgbm9fdGltZW91dD1GYWxzZSk6CiAgICAgICAgICMgV2UgZG9uJ3Qgd2FudCB0aGUgZGVmYXVs dCBEcml2ZXJQcm94eSB3aGljaCBpcyBub3QgY29tcGF0aWJsZSB3aXRoIG91ciBkcml2ZXIuCg==