<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>95390</bug_id>
          
          <creation_ts>2012-08-29 15:39:03 -0700</creation_ts>
          <short_desc>rebaselining doesn&apos;t really work w/ multiple expectations files</short_desc>
          <delta_ts>2017-07-18 08:29:50 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dirk Pranke">dpranke</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>jchaffraix</cc>
    
    <cc>rniwa</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>707947</commentid>
    <comment_count>0</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-08-29 15:39:03 -0700</bug_when>
    <thetext>If, for example, you mark a test for REBASELINE in platform/chromium/TestExpectations, and there is an overriding line in the skia_test_expectations.txt file, webkit-patch rebaseline-expectations will not see the line with the REBASELINE. 

After r127057, at least we&apos;ll log a warning that we didn&apos;t find a REBASELINE, but we should either be smarter about this (e.g., log a warning that tests are shadowing others) or stop using rebaseline-expectations altogether ;).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>831350</commentid>
    <comment_count>1</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2013-02-12 15:31:58 -0800</bug_when>
    <thetext>changing subject from

&quot;expectation overrides can cause REBASELINE modifiers to be missed&quot;

to

&quot;rebaselining doesn&apos;t really work w/ multiple expectations files&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>903033</commentid>
    <comment_count>2</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2013-06-24 13:09:02 -0700</bug_when>
    <thetext>I don&apos;t expect to work on this in the webkit.org repo in the foreseeable future, so I&apos;m clearing the &apos;assigned_to&apos; field in case someone cares to take a look.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>