<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>95377</bug_id>
          
          <creation_ts>2012-08-29 14:05:16 -0700</creation_ts>
          <short_desc>[CMake] Suppress ANGLE compilation warnings</short_desc>
          <delta_ts>2012-08-30 18:55:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>95342</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Rob Buis">rwlbuis</reporter>
          <assigned_to name="Rob Buis">rwlbuis</assigned_to>
          <cc>gyuyoung.kim</cc>
    
    <cc>kangil.han</cc>
    
    <cc>mxie</cc>
    
    <cc>paroga</cc>
    
    <cc>rakuco</cc>
    
    <cc>tmpsantos</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>707839</commentid>
    <comment_count>0</comment_count>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-08-29 14:05:16 -0700</bug_when>
    <thetext>By compiling ANGLE into a static library (like wtf.a) we can set our compile rules for these files (partly C code) and so suppress warnings that we see now on ToT. One example of a warning that is hard to fix is the usage of -Wno-c++0x-compat on a C source.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>707853</commentid>
    <comment_count>1</comment_count>
      <attachid>161314</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-08-29 14:14:32 -0700</bug_when>
    <thetext>Created attachment 161314
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>707920</commentid>
    <comment_count>2</comment_count>
      <attachid>161314</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-08-29 15:08:16 -0700</bug_when>
    <thetext>Comment on attachment 161314
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161314&amp;action=review

&gt; Source/WebCore/CMakeLists.txt:2970
&gt; +    SET_TARGET_PROPERTIES (${ANGLESupport_LIBRARY_NAME} PROPERTIES COMPILE_FLAGS &quot;-fPIC -fvisibility=hidden -fno-exceptions -fno-strict-aliasing&quot;)

Doesn&apos;t this cause problems if one&apos;s not using gcc/clang?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>707922</commentid>
    <comment_count>3</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-08-29 15:09:20 -0700</bug_when>
    <thetext>(In reply to comment #0)
&gt; By compiling ANGLE into a static library (like wtf.a) we can set our compile rules for these files (partly C code) and so suppress warnings that we see now on ToT. One example of a warning that is hard to fix is the usage of -Wno-c++0x-compat on a C source.

Do you mean some of the .cpp files there are actually C source code?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>708076</commentid>
    <comment_count>4</comment_count>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-08-29 17:12:22 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (In reply to comment #0)
&gt; &gt; By compiling ANGLE into a static library (like wtf.a) we can set our compile rules for these files (partly C code) and so suppress warnings that we see now on ToT. One example of a warning that is hard to fix is the usage of -Wno-c++0x-compat on a C source.
&gt; 
&gt; Do you mean some of the .cpp files there are actually C source code?

I meant, ANGLE contain C sources, so using -Wno-c++0x-compat on them gives a warning. An example is ${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/atom.c.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>708077</commentid>
    <comment_count>5</comment_count>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-08-29 17:13:14 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (In reply to comment #0)
&gt; &gt; By compiling ANGLE into a static library (like wtf.a) we can set our compile rules for these files (partly C code) and so suppress warnings that we see now on ToT. One example of a warning that is hard to fix is the usage of -Wno-c++0x-compat on a C source.
&gt; 
&gt; Do you mean some of the .cpp files there are actually C source code?

(In reply to comment #2)
&gt; (From update of attachment 161314 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=161314&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/CMakeLists.txt:2970
&gt; &gt; +    SET_TARGET_PROPERTIES (${ANGLESupport_LIBRARY_NAME} PROPERTIES COMPILE_FLAGS &quot;-fPIC -fvisibility=hidden -fno-exceptions -fno-strict-aliasing&quot;)
&gt; 
&gt; Doesn&apos;t this cause problems if one&apos;s not using gcc/clang?

Possibly yes. I&apos;ll look into that tomorrow, thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>708153</commentid>
    <comment_count>6</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-08-29 18:14:30 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (In reply to comment #3)
&gt; &gt; (In reply to comment #0)
&gt; &gt; &gt; By compiling ANGLE into a static library (like wtf.a) we can set our compile rules for these files (partly C code) and so suppress warnings that we see now on ToT. One example of a warning that is hard to fix is the usage of -Wno-c++0x-compat on a C source.
&gt; &gt; 
&gt; &gt; Do you mean some of the .cpp files there are actually C source code?
&gt; 
&gt; I meant, ANGLE contain C sources, so using -Wno-c++0x-compat on them gives a warning. An example is ${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/atom.c.

Oh, I see. That makes sense; perhaps we should not set the target&apos;s COMPILE_FLAGS in WebKitHelper.cmake&apos;s WEBKIT_SET_EXTRA_COMPILER_FLAGS and just change CMAKE_C{XX}_FLAGS instead. Splitting ANGLE into a separate library is a good change regardless of that, though.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>708703</commentid>
    <comment_count>7</comment_count>
      <attachid>161490</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-08-30 09:20:14 -0700</bug_when>
    <thetext>Created attachment 161490
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>708781</commentid>
    <comment_count>8</comment_count>
      <attachid>161490</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-08-30 10:17:08 -0700</bug_when>
    <thetext>Comment on attachment 161490
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161490&amp;action=review

&gt; Source/cmake/WebKitHelpers.cmake:7
&gt; +    IF (${ARGC} MATCHES &quot;1&quot;)
&gt; +        SET (_allowCXXWarnings &quot;allow&quot;)
&gt; +    ENDIF ()

Now that we require CMake 2.8.3, we can parse keyword arguments more easily. I recommend taking a look at the CMakeParseArguments module, we could then accept something like WEBKIT_SET_EXTRA_COMPILER_FLAGS(foo IGNORE_WARNINGS FALSE).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>708794</commentid>
    <comment_count>9</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-08-30 10:28:32 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; we could then accept something like WEBKIT_SET_EXTRA_COMPILER_FLAGS(foo IGNORE_WARNINGS FALSE).

... Or even WEBKIT_SET_EXTRA_COMPILER_FLAGS(foo IGNORE_WARNINGS), which is more compact and makes more sense.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>708808</commentid>
    <comment_count>10</comment_count>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-08-30 10:35:58 -0700</bug_when>
    <thetext>(In reply to comment #9)
&gt; (In reply to comment #8)
&gt; &gt; we could then accept something like WEBKIT_SET_EXTRA_COMPILER_FLAGS(foo IGNORE_WARNINGS FALSE).
&gt; 
&gt; ... Or even WEBKIT_SET_EXTRA_COMPILER_FLAGS(foo IGNORE_WARNINGS), which is more compact and makes more sense.

I agree, this sounds like a lot cleaner way to do it, thanks. Patch upcoming.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>708856</commentid>
    <comment_count>11</comment_count>
      <attachid>161521</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-08-30 11:19:13 -0700</bug_when>
    <thetext>Created attachment 161521
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>708882</commentid>
    <comment_count>12</comment_count>
      <attachid>161521</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-08-30 11:54:55 -0700</bug_when>
    <thetext>Comment on attachment 161521
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161521&amp;action=review

&gt; Source/cmake/WebKitHelpers.cmake:4
&gt; +  SET(options IGNORECXX_WARNINGS)

Nit: Since there&apos;s only one argument right now it could be simpler to just pass it directly to CMAKE_PARSE_ARGUMENTS() instead of setting a variable for that.

&gt; Source/cmake/WebKitHelpers.cmake:5
&gt; +  CMAKE_PARSE_ARGUMENTS(&quot;OPTION&quot; &quot;${options}&quot; &quot;&quot; &quot;&quot; ${ARGN} )

You likely need to INCLUDE(CMakeParseArguments), for example at the beginning of the file, before using this macro. One minor nit is that there&apos;s an extra space character before the closing &apos;)&apos;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>708890</commentid>
    <comment_count>13</comment_count>
      <attachid>161528</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-08-30 12:09:28 -0700</bug_when>
    <thetext>Created attachment 161528
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>708906</commentid>
    <comment_count>14</comment_count>
      <attachid>161528</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2012-08-30 12:38:21 -0700</bug_when>
    <thetext>Comment on attachment 161528
Patch

rs=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>708945</commentid>
    <comment_count>15</comment_count>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-08-30 13:15:08 -0700</bug_when>
    <thetext>Committed r127178: &lt;http://trac.webkit.org/changeset/127178&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>161314</attachid>
            <date>2012-08-29 14:14:32 -0700</date>
            <delta_ts>2012-08-30 09:20:11 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-95377-20120829171653.patch</filename>
            <type>text/plain</type>
            <size>2729</size>
            <attacher name="Rob Buis">rwlbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MDQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmZlYzAzNzk5MjI2ODFh
ZTU4ZDBmYzMzODZlYzI5MjI1MWI3MzJjYS4uMTY3YTE4YzQ1MDliMmUzOTM1MmZmMjRmOWQyOWMw
NzAzMzdjNDYzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDEyLTA4LTI5ICBSb2Ig
QnVpcyAgPHJidWlzQHJpbS5jb20+CiAKKyAgICAgICAgW0NNYWtlXSBTdXBwcmVzcyBBTkdMRSBj
b21waWxhdGlvbiB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9OTUzNzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBDb21waWxlIEFOR0xFIHNvdXJjZXMgaW4gYSBzdGF0aWMgbGlicmFyeSwgYW5k
IG1ha2Ugc3VyZSB0aGUgY29tcGlsZSBmbGFncyBzdXBwcmVzcyB3YXJuaW5ncy4KKworICAgICAg
ICAqIENNYWtlTGlzdHMudHh0OgorCisyMDEyLTA4LTI5ICBSb2IgQnVpcyAgPHJidWlzQHJpbS5j
b20+CisKICAgICAgICAgW0JsYWNrQmVycnldIEFkanVzdCB3dGYgaW5jbHVkZSBoZWFkZXIgc3R5
bGUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1MzY4
CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dl
YkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNDI0OWIzZDYzMTE1MzA0NzUwYjViMDZhNTJhZGRj
ZTY3MmFiNmMzZi4uMTlkYjc3ZWMyNDk4NzJhYzU4YzZlYjkzY2I3MWFkYzhhMDNjNTAxNiAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNv
cmUvQ01ha2VMaXN0cy50eHQKQEAgLTI1NjIsMTggKzI1NjIsMTggQEAgSUYgKFdURl9VU0VfM0Rf
R1JBUEhJQ1MpCiAgICAgSUYgKEJJU09OX1ZFUlNJT04gRVFVQUwgIjIuNSIpCiAgICAgICAgICMg
Qmlzb24gMi41IGNhbiBub3QgY29tcGlsZSBnZW5lcmF0ZWQgZ2xzbGFuZy4KICAgICAgICAgIyBT
ZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzNDg3Ci0gICAgICAg
IExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUworICAgICAgICBMSVNUKEFQUEVORCBBTkdMRVN1
cHBvcnRfU09VUkNFUwogICAgICAgICAgICAgJHtUSElSRFBBUlRZX0RJUn0vQU5HTEUvc3JjL2Nv
bXBpbGVyL2dsc2xhbmdfbGV4LmNwcAogICAgICAgICAgICAgJHtUSElSRFBBUlRZX0RJUn0vQU5H
TEUvc3JjL2NvbXBpbGVyL2dsc2xhbmdfdGFiLmNwcAogICAgICAgICApCiAgICAgRUxTRSAoKQot
ICAgICAgICBMSVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKKyAgICAgICAgTElTVChBUFBFTkQg
QU5HTEVTdXBwb3J0X1NPVVJDRVMKICAgICAgICAgICAgICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNP
UkVfRElSfS9nbHNsYW5nLmNwcAogICAgICAgICAgICAgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09S
RV9ESVJ9L2dsc2xhbmdfdGFiLmNwcAogICAgICAgICApCiAgICAgRU5ESUYgKCkKIAotICAgIExJ
U1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUworICAgIExJU1QoQVBQRU5EIEFOR0xFU3VwcG9ydF9T
T1VSQ0VTCiAgICAgICAgICR7VEhJUkRQQVJUWV9ESVJ9L0FOR0xFL3NyYy9jb21waWxlci9CdWls
dEluRnVuY3Rpb25FbXVsYXRvci5jcHAKICAgICAgICAgJHtUSElSRFBBUlRZX0RJUn0vQU5HTEUv
c3JjL2NvbXBpbGVyL0NvZGVHZW5HTFNMLmNwcAogICAgICAgICAke1RISVJEUEFSVFlfRElSfS9B
TkdMRS9zcmMvY29tcGlsZXIvQ29tcGlsZXIuY3BwCkBAIC0yOTYyLDYgKzI5NjIsMTQgQEAgU0VU
X1RBUkdFVF9QUk9QRVJUSUVTKCR7V2ViQ29yZVRlc3RTdXBwb3J0X0xJQlJBUllfTkFNRX0gUFJP
UEVSVElFUyBGT0xERVIgIldlYkMKIEFERF9ERVBFTkRFTkNJRVMoJHtXZWJDb3JlX0xJQlJBUllf
TkFNRX0gJHtKYXZhU2NyaXB0Q29yZV9MSUJSQVJZX05BTUV9KQogQUREX0RFUEVOREVOQ0lFUygk
e1dlYkNvcmVUZXN0U3VwcG9ydF9MSUJSQVJZX05BTUV9ICR7V2ViQ29yZV9MSUJSQVJZX05BTUV9
KQogCitJRiAoV1RGX1VTRV8zRF9HUkFQSElDUykKKyAgICBTRVQoQU5HTEVTdXBwb3J0X0xJQlJB
UllfTkFNRSBBTkdMRVN1cHBvcnQpCisgICAgQUREX0xJQlJBUlkoJHtBTkdMRVN1cHBvcnRfTElC
UkFSWV9OQU1FfSBTVEFUSUMgJHtBTkdMRVN1cHBvcnRfU09VUkNFU30pCisgICAgU0VUX1RBUkdF
VF9QUk9QRVJUSUVTKCR7QU5HTEVTdXBwb3J0X0xJQlJBUllfTkFNRX0gUFJPUEVSVElFUyBGT0xE
RVIgIldlYkNvcmUiKQorICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfTElCUkFSSUVTICR7QU5HTEVT
dXBwb3J0X0xJQlJBUllfTkFNRX0pCisgICAgU0VUX1RBUkdFVF9QUk9QRVJUSUVTICgke0FOR0xF
U3VwcG9ydF9MSUJSQVJZX05BTUV9IFBST1BFUlRJRVMgQ09NUElMRV9GTEFHUyAiLWZQSUMgLWZ2
aXNpYmlsaXR5PWhpZGRlbiAtZm5vLWV4Y2VwdGlvbnMgLWZuby1zdHJpY3QtYWxpYXNpbmciKQor
RU5ESUYgKCkKKwogVEFSR0VUX0xJTktfTElCUkFSSUVTKCR7V2ViQ29yZV9MSUJSQVJZX05BTUV9
ICR7V2ViQ29yZV9MSUJSQVJJRVN9KQogCiBJRiAoV2ViQ29yZV9MSU5LX0ZMQUdTKQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>161490</attachid>
            <date>2012-08-30 09:20:14 -0700</date>
            <delta_ts>2012-08-30 11:19:09 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-95377-20120830122248.patch</filename>
            <type>text/plain</type>
            <size>5063</size>
            <attacher name="Rob Buis">rwlbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MDQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmZlYzAzNzk5MjI2ODFh
ZTU4ZDBmYzMzODZlYzI5MjI1MWI3MzJjYS4uZTA3NWY4Nzg2ZGVlMWZmNGNkOGZhMzFmZGQ1MWJj
ZTgxNTMwZWUxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA4LTMwICBSb2Ig
QnVpcyAgPHJidWlzQHJpbS5jb20+CisKKyAgICAgICAgW0NNYWtlXSBTdXBwcmVzcyBBTkdMRSBj
b21waWxhdGlvbiB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9OTUzNzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBDb21waWxlIEFOR0xFIHNvdXJjZXMgaW4gYSBzdGF0aWMgbGlicmFyeSwgYW5k
IG1ha2Ugc3VyZSB0aGUgY29tcGlsZSBmbGFncyBzdXBwcmVzcyB3YXJuaW5ncy4KKworICAgICAg
ICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDEyLTA4LTI5ICBSb2IgQnVpcyAgPHJidWlzQHJpbS5j
b20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEFkanVzdCB3dGYgaW5jbHVkZSBoZWFkZXIgc3R5
bGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dl
YkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNDI0OWIzZDYzMTE1MzA0NzUwYjViMDZhNTJhZGRj
ZTY3MmFiNmMzZi4uOWQ5ODAzZTg0ZmY3ZTYxMTQxNTU0NDkwYzdmMmQ4NTgzNGQ0ODMyMyAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNv
cmUvQ01ha2VMaXN0cy50eHQKQEAgLTI1NjIsMTggKzI1NjIsMTggQEAgSUYgKFdURl9VU0VfM0Rf
R1JBUEhJQ1MpCiAgICAgSUYgKEJJU09OX1ZFUlNJT04gRVFVQUwgIjIuNSIpCiAgICAgICAgICMg
Qmlzb24gMi41IGNhbiBub3QgY29tcGlsZSBnZW5lcmF0ZWQgZ2xzbGFuZy4KICAgICAgICAgIyBT
ZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzNDg3Ci0gICAgICAg
IExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUworICAgICAgICBMSVNUKEFQUEVORCBBTkdMRVN1
cHBvcnRfU09VUkNFUwogICAgICAgICAgICAgJHtUSElSRFBBUlRZX0RJUn0vQU5HTEUvc3JjL2Nv
bXBpbGVyL2dsc2xhbmdfbGV4LmNwcAogICAgICAgICAgICAgJHtUSElSRFBBUlRZX0RJUn0vQU5H
TEUvc3JjL2NvbXBpbGVyL2dsc2xhbmdfdGFiLmNwcAogICAgICAgICApCiAgICAgRUxTRSAoKQot
ICAgICAgICBMSVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKKyAgICAgICAgTElTVChBUFBFTkQg
QU5HTEVTdXBwb3J0X1NPVVJDRVMKICAgICAgICAgICAgICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNP
UkVfRElSfS9nbHNsYW5nLmNwcAogICAgICAgICAgICAgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09S
RV9ESVJ9L2dsc2xhbmdfdGFiLmNwcAogICAgICAgICApCiAgICAgRU5ESUYgKCkKIAotICAgIExJ
U1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUworICAgIExJU1QoQVBQRU5EIEFOR0xFU3VwcG9ydF9T
T1VSQ0VTCiAgICAgICAgICR7VEhJUkRQQVJUWV9ESVJ9L0FOR0xFL3NyYy9jb21waWxlci9CdWls
dEluRnVuY3Rpb25FbXVsYXRvci5jcHAKICAgICAgICAgJHtUSElSRFBBUlRZX0RJUn0vQU5HTEUv
c3JjL2NvbXBpbGVyL0NvZGVHZW5HTFNMLmNwcAogICAgICAgICAke1RISVJEUEFSVFlfRElSfS9B
TkdMRS9zcmMvY29tcGlsZXIvQ29tcGlsZXIuY3BwCkBAIC0yOTYyLDYgKzI5NjIsMTQgQEAgU0VU
X1RBUkdFVF9QUk9QRVJUSUVTKCR7V2ViQ29yZVRlc3RTdXBwb3J0X0xJQlJBUllfTkFNRX0gUFJP
UEVSVElFUyBGT0xERVIgIldlYkMKIEFERF9ERVBFTkRFTkNJRVMoJHtXZWJDb3JlX0xJQlJBUllf
TkFNRX0gJHtKYXZhU2NyaXB0Q29yZV9MSUJSQVJZX05BTUV9KQogQUREX0RFUEVOREVOQ0lFUygk
e1dlYkNvcmVUZXN0U3VwcG9ydF9MSUJSQVJZX05BTUV9ICR7V2ViQ29yZV9MSUJSQVJZX05BTUV9
KQogCitJRiAoV1RGX1VTRV8zRF9HUkFQSElDUykKKyAgICBTRVQoQU5HTEVTdXBwb3J0X0xJQlJB
UllfTkFNRSBBTkdMRVN1cHBvcnQpCisgICAgQUREX0xJQlJBUlkoJHtBTkdMRVN1cHBvcnRfTElC
UkFSWV9OQU1FfSBTVEFUSUMgJHtBTkdMRVN1cHBvcnRfU09VUkNFU30pCisgICAgU0VUX1RBUkdF
VF9QUk9QRVJUSUVTKCR7QU5HTEVTdXBwb3J0X0xJQlJBUllfTkFNRX0gUFJPUEVSVElFUyBGT0xE
RVIgIldlYkNvcmUiKQorICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfTElCUkFSSUVTICR7QU5HTEVT
dXBwb3J0X0xJQlJBUllfTkFNRX0pCisgICAgV0VCS0lUX1NFVF9FWFRSQV9DT01QSUxFUl9GTEFH
Uygke0FOR0xFU3VwcG9ydF9MSUJSQVJZX05BTUV9ICJBTkdMRSIpCitFTkRJRiAoKQorCiBUQVJH
RVRfTElOS19MSUJSQVJJRVMoJHtXZWJDb3JlX0xJQlJBUllfTkFNRX0gJHtXZWJDb3JlX0xJQlJB
UklFU30pCiAKIElGIChXZWJDb3JlX0xJTktfRkxBR1MpCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21h
a2UvV2ViS2l0SGVscGVycy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtl
CmluZGV4IGQ3OGQ2OTYwODA2ZWY5NzQ5Yjk3MWE1YWI3ZDQ0MWM0ODU5ZDM1NWQuLjQ5YTJiMzU5
M2JjYTc5ZjM0OTAzMjdjYzBlZWJmOTAyNDc3OGM5MzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFr
ZS9XZWJLaXRIZWxwZXJzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNt
YWtlCkBAIC0yLDYgKzIsOSBAQAogIyBDdXJyZW50bHksIG9ubHkgR0NDIGlzIHN1cHBvcnRlZC4K
IE1BQ1JPKFdFQktJVF9TRVRfRVhUUkFfQ09NUElMRVJfRkxBR1MgX3RhcmdldCkKICAgSUYgKENN
QUtFX0NPTVBJTEVSX0lTX0dOVUNYWCBPUiAiJHtDTUFLRV9DWFhfQ09NUElMRVJfSUR9IiBTVFJF
UVVBTCAiQ2xhbmciKQorICAgIElGICgke0FSR0N9IE1BVENIRVMgIjEiKQorICAgICAgICBTRVQg
KF9hbGxvd0NYWFdhcm5pbmdzICJhbGxvdyIpCisgICAgRU5ESUYgKCkKICAgICBHRVRfVEFSR0VU
X1BST1BFUlRZKE9MRF9DT01QSUxFX0ZMQUdTICR7X3RhcmdldH0gQ09NUElMRV9GTEFHUykKICAg
ICBJRiAoJHtPTERfQ09NUElMRV9GTEFHU30gU1RSRVFVQUwgIk9MRF9DT01QSUxFX0ZMQUdTLU5P
VEZPVU5EIikKICAgICAgICAgU0VUKE9MRF9DT01QSUxFX0ZMQUdTICIiKQpAQCAtMzMsMTEgKzM2
LDEzIEBAIE1BQ1JPKFdFQktJVF9TRVRfRVhUUkFfQ09NUElMRVJfRkxBR1MgX3RhcmdldCkKICAg
ICBTRVQoT0xEX0NPTVBJTEVfRkxBR1MgIi1mbm8tZXhjZXB0aW9ucyAtZm5vLXN0cmljdC1hbGlh
c2luZyAke09MRF9DT01QSUxFX0ZMQUdTfSIpCiAKICAgICAjIEVuYWJsZSB3YXJuaW5ncyBieSBk
ZWZhdWx0Ci0gICAgU0VUKE9MRF9DT01QSUxFX0ZMQUdTICItVyAtREFOT1RIRVJfQlJJQ0tfSU5f
VEhFIC1XYWxsIC1XZXh0cmEgLVdjYXN0LWFsaWduIC1XY2hhci1zdWJzY3JpcHRzIC1XZm9ybWF0
IC1XZm9ybWF0LXNlY3VyaXR5IC1XbWlzc2luZy1mb3JtYXQtYXR0cmlidXRlIC1Xbm8tZm9ybWF0
LXkyayAtV25vLXBhcmVudGhlc2VzIC1Xbm8tdW51c2VkLXBhcmFtZXRlciAtV3BvaW50ZXItYXJp
dGggIC1XcmV0dXJuLXR5cGUgLVd1bmRlZiAtV3dyaXRlLXN0cmluZ3MgJHtPTERfQ09NUElMRV9G
TEFHU30iKQorICAgIElGIChfYWxsb3dDWFhXYXJuaW5ncykKKyAgICAgICAgU0VUKE9MRF9DT01Q
SUxFX0ZMQUdTICItVyAtREFOT1RIRVJfQlJJQ0tfSU5fVEhFIC1XYWxsIC1XZXh0cmEgLVdjYXN0
LWFsaWduIC1XY2hhci1zdWJzY3JpcHRzIC1XZm9ybWF0IC1XZm9ybWF0LXNlY3VyaXR5IC1XbWlz
c2luZy1mb3JtYXQtYXR0cmlidXRlIC1Xbm8tZm9ybWF0LXkyayAtV25vLXBhcmVudGhlc2VzIC1X
bm8tdW51c2VkLXBhcmFtZXRlciAtV3BvaW50ZXItYXJpdGggIC1XcmV0dXJuLXR5cGUgLVd1bmRl
ZiAtV3dyaXRlLXN0cmluZ3MgJHtPTERfQ09NUElMRV9GTEFHU30iKQorICAgIEVORElGICgpCiAK
ICAgICAjIERpc2FibGUgQysrMHggY29tcGF0IHdhcm5pbmdzIGZvciBHQ0MgPj0gNC42LjAgdW50
aWwgd2UgYnVpbGQKICAgICAjIGNsZWFubHkgd2l0aCB0aGF0LgotICAgIElGIChOT1QgJHtDT01Q
SUxFUl9WRVJTSU9OfSBWRVJTSU9OX0xFU1MgIjQuNi4wIikKKyAgICBJRiAoX2FsbG93Q1hYV2Fy
bmluZ3MgQU5EIE5PVCAke0NPTVBJTEVSX1ZFUlNJT059IFZFUlNJT05fTEVTUyAiNC42LjAiKQog
ICAgICAgICBTRVQoT0xEX0NPTVBJTEVfRkxBR1MgIiR7T0xEX0NPTVBJTEVfRkxBR1N9IC1Xbm8t
YysrMHgtY29tcGF0IikKICAgICBFTkRJRiAoKQogCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9D
aGFuZ2VMb2cKaW5kZXggNDAxOTlkNWVjOTkzMWRmMDg2YmQ2ODdkZjA2OTYxNTZkNDdiNjQxNS4u
YTc4MjA1OWIyNWI4MzgzYmI2YTIyZjU2Y2ZjYjQ4MDk0NzZlYmVlYSAxMDA2NDQKLS0tIGEvQ2hh
bmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA4LTMwICBSb2Ig
QnVpcyAgPHJidWlzQHJpbS5jb20+CisKKyAgICAgICAgW0NNYWtlXSBTdXBwcmVzcyBBTkdMRSBj
b21waWxhdGlvbiB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9OTUzNzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBDaGFuZ2UgV0VCS0lUX1NFVF9FWFRSQV9DT01QSUxFUl9GTEFHUyBzbyBpdCBo
YXMgYW4gb3B0aW9uIHRvIHN1cHByZXNzIEMrKyB3YXJuaW5ncy4KKworICAgICAgICAqIFNvdXJj
ZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlOgorCiAyMDEyLTA4LTI5ICBUaGlhZ28gTWFjaWVp
cmEgIDx0aGlhZ28ubWFjaWVpcmFAaW50ZWwuY29tPgogCiAgICAgICAgIFRlbGwgZ2l0LWFyY2hp
dmUgdG8gbm90IGV4cG9ydCAuZ2l0YXR0cmlidXRlcyBhbmQgLmdpdGlnbm9yZQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>161521</attachid>
            <date>2012-08-30 11:19:13 -0700</date>
            <delta_ts>2012-08-30 12:09:24 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-95377-20120830142146.patch</filename>
            <type>text/plain</type>
            <size>5162</size>
            <attacher name="Rob Buis">rwlbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MDQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmZlYzAzNzk5MjI2ODFh
ZTU4ZDBmYzMzODZlYzI5MjI1MWI3MzJjYS4uZTA3NWY4Nzg2ZGVlMWZmNGNkOGZhMzFmZGQ1MWJj
ZTgxNTMwZWUxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA4LTMwICBSb2Ig
QnVpcyAgPHJidWlzQHJpbS5jb20+CisKKyAgICAgICAgW0NNYWtlXSBTdXBwcmVzcyBBTkdMRSBj
b21waWxhdGlvbiB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9OTUzNzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBDb21waWxlIEFOR0xFIHNvdXJjZXMgaW4gYSBzdGF0aWMgbGlicmFyeSwgYW5k
IG1ha2Ugc3VyZSB0aGUgY29tcGlsZSBmbGFncyBzdXBwcmVzcyB3YXJuaW5ncy4KKworICAgICAg
ICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDEyLTA4LTI5ICBSb2IgQnVpcyAgPHJidWlzQHJpbS5j
b20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEFkanVzdCB3dGYgaW5jbHVkZSBoZWFkZXIgc3R5
bGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dl
YkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNDI0OWIzZDYzMTE1MzA0NzUwYjViMDZhNTJhZGRj
ZTY3MmFiNmMzZi4uM2M1ZTM5YzQzNDk4OTQ2Nzg4MWI4ZjQ5OTQyM2IyMGUwYjhlMDc3YyAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNv
cmUvQ01ha2VMaXN0cy50eHQKQEAgLTI1NjIsMTggKzI1NjIsMTggQEAgSUYgKFdURl9VU0VfM0Rf
R1JBUEhJQ1MpCiAgICAgSUYgKEJJU09OX1ZFUlNJT04gRVFVQUwgIjIuNSIpCiAgICAgICAgICMg
Qmlzb24gMi41IGNhbiBub3QgY29tcGlsZSBnZW5lcmF0ZWQgZ2xzbGFuZy4KICAgICAgICAgIyBT
ZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzNDg3Ci0gICAgICAg
IExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUworICAgICAgICBMSVNUKEFQUEVORCBBTkdMRVN1
cHBvcnRfU09VUkNFUwogICAgICAgICAgICAgJHtUSElSRFBBUlRZX0RJUn0vQU5HTEUvc3JjL2Nv
bXBpbGVyL2dsc2xhbmdfbGV4LmNwcAogICAgICAgICAgICAgJHtUSElSRFBBUlRZX0RJUn0vQU5H
TEUvc3JjL2NvbXBpbGVyL2dsc2xhbmdfdGFiLmNwcAogICAgICAgICApCiAgICAgRUxTRSAoKQot
ICAgICAgICBMSVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKKyAgICAgICAgTElTVChBUFBFTkQg
QU5HTEVTdXBwb3J0X1NPVVJDRVMKICAgICAgICAgICAgICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNP
UkVfRElSfS9nbHNsYW5nLmNwcAogICAgICAgICAgICAgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09S
RV9ESVJ9L2dsc2xhbmdfdGFiLmNwcAogICAgICAgICApCiAgICAgRU5ESUYgKCkKIAotICAgIExJ
U1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUworICAgIExJU1QoQVBQRU5EIEFOR0xFU3VwcG9ydF9T
T1VSQ0VTCiAgICAgICAgICR7VEhJUkRQQVJUWV9ESVJ9L0FOR0xFL3NyYy9jb21waWxlci9CdWls
dEluRnVuY3Rpb25FbXVsYXRvci5jcHAKICAgICAgICAgJHtUSElSRFBBUlRZX0RJUn0vQU5HTEUv
c3JjL2NvbXBpbGVyL0NvZGVHZW5HTFNMLmNwcAogICAgICAgICAke1RISVJEUEFSVFlfRElSfS9B
TkdMRS9zcmMvY29tcGlsZXIvQ29tcGlsZXIuY3BwCkBAIC0yOTYyLDYgKzI5NjIsMTQgQEAgU0VU
X1RBUkdFVF9QUk9QRVJUSUVTKCR7V2ViQ29yZVRlc3RTdXBwb3J0X0xJQlJBUllfTkFNRX0gUFJP
UEVSVElFUyBGT0xERVIgIldlYkMKIEFERF9ERVBFTkRFTkNJRVMoJHtXZWJDb3JlX0xJQlJBUllf
TkFNRX0gJHtKYXZhU2NyaXB0Q29yZV9MSUJSQVJZX05BTUV9KQogQUREX0RFUEVOREVOQ0lFUygk
e1dlYkNvcmVUZXN0U3VwcG9ydF9MSUJSQVJZX05BTUV9ICR7V2ViQ29yZV9MSUJSQVJZX05BTUV9
KQogCitJRiAoV1RGX1VTRV8zRF9HUkFQSElDUykKKyAgICBTRVQoQU5HTEVTdXBwb3J0X0xJQlJB
UllfTkFNRSBBTkdMRVN1cHBvcnQpCisgICAgQUREX0xJQlJBUlkoJHtBTkdMRVN1cHBvcnRfTElC
UkFSWV9OQU1FfSBTVEFUSUMgJHtBTkdMRVN1cHBvcnRfU09VUkNFU30pCisgICAgU0VUX1RBUkdF
VF9QUk9QRVJUSUVTKCR7QU5HTEVTdXBwb3J0X0xJQlJBUllfTkFNRX0gUFJPUEVSVElFUyBGT0xE
RVIgIldlYkNvcmUiKQorICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfTElCUkFSSUVTICR7QU5HTEVT
dXBwb3J0X0xJQlJBUllfTkFNRX0pCisgICAgV0VCS0lUX1NFVF9FWFRSQV9DT01QSUxFUl9GTEFH
Uygke0FOR0xFU3VwcG9ydF9MSUJSQVJZX05BTUV9IElHTk9SRUNYWF9XQVJOSU5HUykKK0VORElG
ICgpCisKIFRBUkdFVF9MSU5LX0xJQlJBUklFUygke1dlYkNvcmVfTElCUkFSWV9OQU1FfSAke1dl
YkNvcmVfTElCUkFSSUVTfSkKIAogSUYgKFdlYkNvcmVfTElOS19GTEFHUykKZGlmZiAtLWdpdCBh
L1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdEhl
bHBlcnMuY21ha2UKaW5kZXggZDc4ZDY5NjA4MDZlZjk3NDliOTcxYTVhYjdkNDQxYzQ4NTlkMzU1
ZC4uOTY3MTc0NmI4ODgxNTBlYjVhNjk5MDRiYmM5MTgzMzNkMzEzOGE1ZiAxMDA2NDQKLS0tIGEv
U291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktp
dEhlbHBlcnMuY21ha2UKQEAgLTEsNiArMSw4IEBACiAjIFNldHMgZXh0cmEgY29tcGlsZSBmbGFn
cyBmb3IgYSB0YXJnZXQsIGRlcGVuZGluZyBvbiB0aGUgY29tcGlsZXIgYmVpbmcgdXNlZC4KICMg
Q3VycmVudGx5LCBvbmx5IEdDQyBpcyBzdXBwb3J0ZWQuCiBNQUNSTyhXRUJLSVRfU0VUX0VYVFJB
X0NPTVBJTEVSX0ZMQUdTIF90YXJnZXQpCisgIFNFVChvcHRpb25zIElHTk9SRUNYWF9XQVJOSU5H
UykKKyAgQ01BS0VfUEFSU0VfQVJHVU1FTlRTKCJPUFRJT04iICIke29wdGlvbnN9IiAiIiAiIiAk
e0FSR059ICkKICAgSUYgKENNQUtFX0NPTVBJTEVSX0lTX0dOVUNYWCBPUiAiJHtDTUFLRV9DWFhf
Q09NUElMRVJfSUR9IiBTVFJFUVVBTCAiQ2xhbmciKQogICAgIEdFVF9UQVJHRVRfUFJPUEVSVFko
T0xEX0NPTVBJTEVfRkxBR1MgJHtfdGFyZ2V0fSBDT01QSUxFX0ZMQUdTKQogICAgIElGICgke09M
RF9DT01QSUxFX0ZMQUdTfSBTVFJFUVVBTCAiT0xEX0NPTVBJTEVfRkxBR1MtTk9URk9VTkQiKQpA
QCAtMzMsMTEgKzM1LDEzIEBAIE1BQ1JPKFdFQktJVF9TRVRfRVhUUkFfQ09NUElMRVJfRkxBR1Mg
X3RhcmdldCkKICAgICBTRVQoT0xEX0NPTVBJTEVfRkxBR1MgIi1mbm8tZXhjZXB0aW9ucyAtZm5v
LXN0cmljdC1hbGlhc2luZyAke09MRF9DT01QSUxFX0ZMQUdTfSIpCiAKICAgICAjIEVuYWJsZSB3
YXJuaW5ncyBieSBkZWZhdWx0Ci0gICAgU0VUKE9MRF9DT01QSUxFX0ZMQUdTICItVyAtREFOT1RI
RVJfQlJJQ0tfSU5fVEhFIC1XYWxsIC1XZXh0cmEgLVdjYXN0LWFsaWduIC1XY2hhci1zdWJzY3Jp
cHRzIC1XZm9ybWF0IC1XZm9ybWF0LXNlY3VyaXR5IC1XbWlzc2luZy1mb3JtYXQtYXR0cmlidXRl
IC1Xbm8tZm9ybWF0LXkyayAtV25vLXBhcmVudGhlc2VzIC1Xbm8tdW51c2VkLXBhcmFtZXRlciAt
V3BvaW50ZXItYXJpdGggIC1XcmV0dXJuLXR5cGUgLVd1bmRlZiAtV3dyaXRlLXN0cmluZ3MgJHtP
TERfQ09NUElMRV9GTEFHU30iKQorICAgIElGIChOT1QgJHtPUFRJT05fSUdOT1JFQ1hYX1dBUk5J
TkdTfSkKKyAgICAgICAgU0VUKE9MRF9DT01QSUxFX0ZMQUdTICItVyAtREFOT1RIRVJfQlJJQ0tf
SU5fVEhFIC1XYWxsIC1XZXh0cmEgLVdjYXN0LWFsaWduIC1XY2hhci1zdWJzY3JpcHRzIC1XZm9y
bWF0IC1XZm9ybWF0LXNlY3VyaXR5IC1XbWlzc2luZy1mb3JtYXQtYXR0cmlidXRlIC1Xbm8tZm9y
bWF0LXkyayAtV25vLXBhcmVudGhlc2VzIC1Xbm8tdW51c2VkLXBhcmFtZXRlciAtV3BvaW50ZXIt
YXJpdGggIC1XcmV0dXJuLXR5cGUgLVd1bmRlZiAtV3dyaXRlLXN0cmluZ3MgJHtPTERfQ09NUElM
RV9GTEFHU30iKQorICAgIEVORElGICgpCiAKICAgICAjIERpc2FibGUgQysrMHggY29tcGF0IHdh
cm5pbmdzIGZvciBHQ0MgPj0gNC42LjAgdW50aWwgd2UgYnVpbGQKICAgICAjIGNsZWFubHkgd2l0
aCB0aGF0LgotICAgIElGIChOT1QgJHtDT01QSUxFUl9WRVJTSU9OfSBWRVJTSU9OX0xFU1MgIjQu
Ni4wIikKKyAgICBJRiAoTk9UICR7T1BUSU9OX0lHTk9SRUNYWF9XQVJOSU5HU30gQU5EIE5PVCAk
e0NPTVBJTEVSX1ZFUlNJT059IFZFUlNJT05fTEVTUyAiNC42LjAiKQogICAgICAgICBTRVQoT0xE
X0NPTVBJTEVfRkxBR1MgIiR7T0xEX0NPTVBJTEVfRkxBR1N9IC1Xbm8tYysrMHgtY29tcGF0IikK
ICAgICBFTkRJRiAoKQogCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXgg
NDAxOTlkNWVjOTkzMWRmMDg2YmQ2ODdkZjA2OTYxNTZkNDdiNjQxNS4uYTc4MjA1OWIyNWI4Mzgz
YmI2YTIyZjU2Y2ZjYjQ4MDk0NzZlYmVlYSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0No
YW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA4LTMwICBSb2IgQnVpcyAgPHJidWlzQHJp
bS5jb20+CisKKyAgICAgICAgW0NNYWtlXSBTdXBwcmVzcyBBTkdMRSBjb21waWxhdGlvbiB3YXJu
aW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTUz
NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFu
Z2UgV0VCS0lUX1NFVF9FWFRSQV9DT01QSUxFUl9GTEFHUyBzbyBpdCBoYXMgYW4gb3B0aW9uIHRv
IHN1cHByZXNzIEMrKyB3YXJuaW5ncy4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRI
ZWxwZXJzLmNtYWtlOgorCiAyMDEyLTA4LTI5ICBUaGlhZ28gTWFjaWVpcmEgIDx0aGlhZ28ubWFj
aWVpcmFAaW50ZWwuY29tPgogCiAgICAgICAgIFRlbGwgZ2l0LWFyY2hpdmUgdG8gbm90IGV4cG9y
dCAuZ2l0YXR0cmlidXRlcyBhbmQgLmdpdGlnbm9yZQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>161528</attachid>
            <date>2012-08-30 12:09:28 -0700</date>
            <delta_ts>2012-08-30 12:38:20 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-95377-20120830151201.patch</filename>
            <type>text/plain</type>
            <size>5199</size>
            <attacher name="Rob Buis">rwlbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MDQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmZlYzAzNzk5MjI2ODFh
ZTU4ZDBmYzMzODZlYzI5MjI1MWI3MzJjYS4uZTA3NWY4Nzg2ZGVlMWZmNGNkOGZhMzFmZGQ1MWJj
ZTgxNTMwZWUxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA4LTMwICBSb2Ig
QnVpcyAgPHJidWlzQHJpbS5jb20+CisKKyAgICAgICAgW0NNYWtlXSBTdXBwcmVzcyBBTkdMRSBj
b21waWxhdGlvbiB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9OTUzNzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBDb21waWxlIEFOR0xFIHNvdXJjZXMgaW4gYSBzdGF0aWMgbGlicmFyeSwgYW5k
IG1ha2Ugc3VyZSB0aGUgY29tcGlsZSBmbGFncyBzdXBwcmVzcyB3YXJuaW5ncy4KKworICAgICAg
ICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDEyLTA4LTI5ICBSb2IgQnVpcyAgPHJidWlzQHJpbS5j
b20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEFkanVzdCB3dGYgaW5jbHVkZSBoZWFkZXIgc3R5
bGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dl
YkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNDI0OWIzZDYzMTE1MzA0NzUwYjViMDZhNTJhZGRj
ZTY3MmFiNmMzZi4uM2M1ZTM5YzQzNDk4OTQ2Nzg4MWI4ZjQ5OTQyM2IyMGUwYjhlMDc3YyAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNv
cmUvQ01ha2VMaXN0cy50eHQKQEAgLTI1NjIsMTggKzI1NjIsMTggQEAgSUYgKFdURl9VU0VfM0Rf
R1JBUEhJQ1MpCiAgICAgSUYgKEJJU09OX1ZFUlNJT04gRVFVQUwgIjIuNSIpCiAgICAgICAgICMg
Qmlzb24gMi41IGNhbiBub3QgY29tcGlsZSBnZW5lcmF0ZWQgZ2xzbGFuZy4KICAgICAgICAgIyBT
ZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzNDg3Ci0gICAgICAg
IExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUworICAgICAgICBMSVNUKEFQUEVORCBBTkdMRVN1
cHBvcnRfU09VUkNFUwogICAgICAgICAgICAgJHtUSElSRFBBUlRZX0RJUn0vQU5HTEUvc3JjL2Nv
bXBpbGVyL2dsc2xhbmdfbGV4LmNwcAogICAgICAgICAgICAgJHtUSElSRFBBUlRZX0RJUn0vQU5H
TEUvc3JjL2NvbXBpbGVyL2dsc2xhbmdfdGFiLmNwcAogICAgICAgICApCiAgICAgRUxTRSAoKQot
ICAgICAgICBMSVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKKyAgICAgICAgTElTVChBUFBFTkQg
QU5HTEVTdXBwb3J0X1NPVVJDRVMKICAgICAgICAgICAgICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNP
UkVfRElSfS9nbHNsYW5nLmNwcAogICAgICAgICAgICAgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09S
RV9ESVJ9L2dsc2xhbmdfdGFiLmNwcAogICAgICAgICApCiAgICAgRU5ESUYgKCkKIAotICAgIExJ
U1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUworICAgIExJU1QoQVBQRU5EIEFOR0xFU3VwcG9ydF9T
T1VSQ0VTCiAgICAgICAgICR7VEhJUkRQQVJUWV9ESVJ9L0FOR0xFL3NyYy9jb21waWxlci9CdWls
dEluRnVuY3Rpb25FbXVsYXRvci5jcHAKICAgICAgICAgJHtUSElSRFBBUlRZX0RJUn0vQU5HTEUv
c3JjL2NvbXBpbGVyL0NvZGVHZW5HTFNMLmNwcAogICAgICAgICAke1RISVJEUEFSVFlfRElSfS9B
TkdMRS9zcmMvY29tcGlsZXIvQ29tcGlsZXIuY3BwCkBAIC0yOTYyLDYgKzI5NjIsMTQgQEAgU0VU
X1RBUkdFVF9QUk9QRVJUSUVTKCR7V2ViQ29yZVRlc3RTdXBwb3J0X0xJQlJBUllfTkFNRX0gUFJP
UEVSVElFUyBGT0xERVIgIldlYkMKIEFERF9ERVBFTkRFTkNJRVMoJHtXZWJDb3JlX0xJQlJBUllf
TkFNRX0gJHtKYXZhU2NyaXB0Q29yZV9MSUJSQVJZX05BTUV9KQogQUREX0RFUEVOREVOQ0lFUygk
e1dlYkNvcmVUZXN0U3VwcG9ydF9MSUJSQVJZX05BTUV9ICR7V2ViQ29yZV9MSUJSQVJZX05BTUV9
KQogCitJRiAoV1RGX1VTRV8zRF9HUkFQSElDUykKKyAgICBTRVQoQU5HTEVTdXBwb3J0X0xJQlJB
UllfTkFNRSBBTkdMRVN1cHBvcnQpCisgICAgQUREX0xJQlJBUlkoJHtBTkdMRVN1cHBvcnRfTElC
UkFSWV9OQU1FfSBTVEFUSUMgJHtBTkdMRVN1cHBvcnRfU09VUkNFU30pCisgICAgU0VUX1RBUkdF
VF9QUk9QRVJUSUVTKCR7QU5HTEVTdXBwb3J0X0xJQlJBUllfTkFNRX0gUFJPUEVSVElFUyBGT0xE
RVIgIldlYkNvcmUiKQorICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfTElCUkFSSUVTICR7QU5HTEVT
dXBwb3J0X0xJQlJBUllfTkFNRX0pCisgICAgV0VCS0lUX1NFVF9FWFRSQV9DT01QSUxFUl9GTEFH
Uygke0FOR0xFU3VwcG9ydF9MSUJSQVJZX05BTUV9IElHTk9SRUNYWF9XQVJOSU5HUykKK0VORElG
ICgpCisKIFRBUkdFVF9MSU5LX0xJQlJBUklFUygke1dlYkNvcmVfTElCUkFSWV9OQU1FfSAke1dl
YkNvcmVfTElCUkFSSUVTfSkKIAogSUYgKFdlYkNvcmVfTElOS19GTEFHUykKZGlmZiAtLWdpdCBh
L1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdEhl
bHBlcnMuY21ha2UKaW5kZXggZDc4ZDY5NjA4MDZlZjk3NDliOTcxYTVhYjdkNDQxYzQ4NTlkMzU1
ZC4uY2I3Nzc5NDBhZjMwYjg5Yjk4ZjJlMGI4ZjRmYjgzYmQ0ODc2MTNiMiAxMDA2NDQKLS0tIGEv
U291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktp
dEhlbHBlcnMuY21ha2UKQEAgLTEsNiArMSw5IEBACitJTkNMVURFKENNYWtlUGFyc2VBcmd1bWVu
dHMpCiAjIFNldHMgZXh0cmEgY29tcGlsZSBmbGFncyBmb3IgYSB0YXJnZXQsIGRlcGVuZGluZyBv
biB0aGUgY29tcGlsZXIgYmVpbmcgdXNlZC4KICMgQ3VycmVudGx5LCBvbmx5IEdDQyBpcyBzdXBw
b3J0ZWQuCiBNQUNSTyhXRUJLSVRfU0VUX0VYVFJBX0NPTVBJTEVSX0ZMQUdTIF90YXJnZXQpCisg
IFNFVChvcHRpb25zIElHTk9SRUNYWF9XQVJOSU5HUykKKyAgQ01BS0VfUEFSU0VfQVJHVU1FTlRT
KCJPUFRJT04iICJJR05PUkVDWFhfV0FSTklOR1MiICIiICIiICR7QVJHTn0pCiAgIElGIChDTUFL
RV9DT01QSUxFUl9JU19HTlVDWFggT1IgIiR7Q01BS0VfQ1hYX0NPTVBJTEVSX0lEfSIgU1RSRVFV
QUwgIkNsYW5nIikKICAgICBHRVRfVEFSR0VUX1BST1BFUlRZKE9MRF9DT01QSUxFX0ZMQUdTICR7
X3RhcmdldH0gQ09NUElMRV9GTEFHUykKICAgICBJRiAoJHtPTERfQ09NUElMRV9GTEFHU30gU1RS
RVFVQUwgIk9MRF9DT01QSUxFX0ZMQUdTLU5PVEZPVU5EIikKQEAgLTMzLDExICszNiwxMyBAQCBN
QUNSTyhXRUJLSVRfU0VUX0VYVFJBX0NPTVBJTEVSX0ZMQUdTIF90YXJnZXQpCiAgICAgU0VUKE9M
RF9DT01QSUxFX0ZMQUdTICItZm5vLWV4Y2VwdGlvbnMgLWZuby1zdHJpY3QtYWxpYXNpbmcgJHtP
TERfQ09NUElMRV9GTEFHU30iKQogCiAgICAgIyBFbmFibGUgd2FybmluZ3MgYnkgZGVmYXVsdAot
ICAgIFNFVChPTERfQ09NUElMRV9GTEFHUyAiLVcgLURBTk9USEVSX0JSSUNLX0lOX1RIRSAtV2Fs
bCAtV2V4dHJhIC1XY2FzdC1hbGlnbiAtV2NoYXItc3Vic2NyaXB0cyAtV2Zvcm1hdCAtV2Zvcm1h
dC1zZWN1cml0eSAtV21pc3NpbmctZm9ybWF0LWF0dHJpYnV0ZSAtV25vLWZvcm1hdC15MmsgLVdu
by1wYXJlbnRoZXNlcyAtV25vLXVudXNlZC1wYXJhbWV0ZXIgLVdwb2ludGVyLWFyaXRoICAtV3Jl
dHVybi10eXBlIC1XdW5kZWYgLVd3cml0ZS1zdHJpbmdzICR7T0xEX0NPTVBJTEVfRkxBR1N9IikK
KyAgICBJRiAoTk9UICR7T1BUSU9OX0lHTk9SRUNYWF9XQVJOSU5HU30pCisgICAgICAgIFNFVChP
TERfQ09NUElMRV9GTEFHUyAiLVcgLURBTk9USEVSX0JSSUNLX0lOX1RIRSAtV2FsbCAtV2V4dHJh
IC1XY2FzdC1hbGlnbiAtV2NoYXItc3Vic2NyaXB0cyAtV2Zvcm1hdCAtV2Zvcm1hdC1zZWN1cml0
eSAtV21pc3NpbmctZm9ybWF0LWF0dHJpYnV0ZSAtV25vLWZvcm1hdC15MmsgLVduby1wYXJlbnRo
ZXNlcyAtV25vLXVudXNlZC1wYXJhbWV0ZXIgLVdwb2ludGVyLWFyaXRoICAtV3JldHVybi10eXBl
IC1XdW5kZWYgLVd3cml0ZS1zdHJpbmdzICR7T0xEX0NPTVBJTEVfRkxBR1N9IikKKyAgICBFTkRJ
RiAoKQogCiAgICAgIyBEaXNhYmxlIEMrKzB4IGNvbXBhdCB3YXJuaW5ncyBmb3IgR0NDID49IDQu
Ni4wIHVudGlsIHdlIGJ1aWxkCiAgICAgIyBjbGVhbmx5IHdpdGggdGhhdC4KLSAgICBJRiAoTk9U
ICR7Q09NUElMRVJfVkVSU0lPTn0gVkVSU0lPTl9MRVNTICI0LjYuMCIpCisgICAgSUYgKE5PVCAk
e09QVElPTl9JR05PUkVDWFhfV0FSTklOR1N9IEFORCBOT1QgJHtDT01QSUxFUl9WRVJTSU9OfSBW
RVJTSU9OX0xFU1MgIjQuNi4wIikKICAgICAgICAgU0VUKE9MRF9DT01QSUxFX0ZMQUdTICIke09M
RF9DT01QSUxFX0ZMQUdTfSAtV25vLWMrKzB4LWNvbXBhdCIpCiAgICAgRU5ESUYgKCkKIApkaWZm
IC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDQwMTk5ZDVlYzk5MzFkZjA4NmJk
Njg3ZGYwNjk2MTU2ZDQ3YjY0MTUuLmE3ODIwNTliMjViODM4M2JiNmEyMmY1NmNmY2I0ODA5NDc2
ZWJlZWEgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx
NCBAQAorMjAxMi0wOC0zMCAgUm9iIEJ1aXMgIDxyYnVpc0ByaW0uY29tPgorCisgICAgICAgIFtD
TWFrZV0gU3VwcHJlc3MgQU5HTEUgY29tcGlsYXRpb24gd2FybmluZ3MKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1Mzc3CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlIFdFQktJVF9TRVRfRVhUUkFf
Q09NUElMRVJfRkxBR1Mgc28gaXQgaGFzIGFuIG9wdGlvbiB0byBzdXBwcmVzcyBDKysgd2Fybmlu
Z3MuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZToKKwogMjAx
Mi0wOC0yOSAgVGhpYWdvIE1hY2llaXJhICA8dGhpYWdvLm1hY2llaXJhQGludGVsLmNvbT4KIAog
ICAgICAgICBUZWxsIGdpdC1hcmNoaXZlIHRvIG5vdCBleHBvcnQgLmdpdGF0dHJpYnV0ZXMgYW5k
IC5naXRpZ25vcmUK
</data>
<flag name="review"
          id="172368"
          type_id="1"
          status="+"
          setter="tonikitoo"
    />
          </attachment>
      

    </bug>

</bugzilla>