95367 2012-08-29 12:32:19 -0700 [New Multicolumn] Implement hit testing of columns 2012-08-29 13:09:38 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt eric webkit.review.bot oldest_to_newest 707741 0 hyatt 2012-08-29 12:32:19 -0700 Implement nodeAtPoint for RenderMultiColumnSet. 707743 1 161283 hyatt 2012-08-29 12:33:58 -0700 Created attachment 161283 Patch 707746 2 webkit.review.bot 2012-08-29 12:37:24 -0700 Attachment 161283 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/rendering/RenderMultiColumnSet.cpp:273: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 707771 3 161283 simon.fraser 2012-08-29 12:57:05 -0700 Comment on attachment 161283 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161283&action=review > Source/WebCore/ChangeLog:9 > + Add an implementation of nodeAtPoint for RenderMultiColumnSet that works similarly to painting. > + Multiple calls get made as you walk through the columns to hitTestFlowThreadPortionInRegion. Would be nice to have some testcases, which you can do with elementFromPoint(). 707782 4 hyatt 2012-08-29 13:08:08 -0700 Note test cases exist that cover this stuff. They just use the old columns code. My approach has been to test them by hand just to make sure they'll pass when we flip the switch. At any rate, before any of this code can turned on, it will have to fully pass the entire multicolumn test suite that we already have checked in, so in that sense the code does have tests that are there and that will have to be passed. 707784 5 hyatt 2012-08-29 13:09:38 -0700 Fixed in r127037. 161283 2012-08-29 12:33:58 -0700 2012-08-29 12:57:05 -0700 Patch patch.txt text/plain 6029 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNzAyOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA4LTI5ICBEYXZpZCBI eWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KKworICAgICAgICBbTmV3IE11bHRpY29sdW1uXSBJbXBs ZW1lbnQgaGl0IHRlc3RpbmcgZm9yIGNvbHVtbnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTM2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhbiBpbXBsZW1lbnRhdGlvbiBvZiBub2RlQXRQb2lu dCBmb3IgUmVuZGVyTXVsdGlDb2x1bW5TZXQgdGhhdCB3b3JrcyBzaW1pbGFybHkgdG8gcGFpbnRp bmcuCisgICAgICAgIE11bHRpcGxlIGNhbGxzIGdldCBtYWRlIGFzIHlvdSB3YWxrIHRocm91Z2gg dGhlIGNvbHVtbnMgdG8gaGl0VGVzdEZsb3dUaHJlYWRQb3J0aW9uSW5SZWdpb24uCisKKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVyTXVsdGlDb2x1bW5TZXQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyTXVsdGlDb2x1bW5TZXQ6Om5vZGVBdFBvaW50KToKKyAgICAgICAgKFdlYkNvcmUp OgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtblNldC5oOgorICAgICAgICAo UmVuZGVyTXVsdGlDb2x1bW5TZXQpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJSZWdpb24u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyUmVnaW9uOjpub2RlQXRQb2ludCk6CisKIDIw MTItMDgtMjggIFNoYXduIFNpbmdoICA8c2hhd25zaW5naEBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgW2Nocm9taXVtXSBEbyBub3QgY2xpcCByb290IGxheWVyJ3Mgc3VidHJlZSB0byB2aWV3cG9y dApJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck11bHRpQ29sdW1uU2V0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTXVsdGlDb2x1 bW5TZXQuY3BwCShyZXZpc2lvbiAxMjcwMDgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTXVsdGlDb2x1bW5TZXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNCw5ICsyNCwxMSBA QAogICovCiAKICNpbmNsdWRlICJjb25maWcuaCIKKyNpbmNsdWRlICJSZW5kZXJNdWx0aUNvbHVt blNldC5oIgorCisjaW5jbHVkZSAiSGl0VGVzdFJlc3VsdC5oIgogI2luY2x1ZGUgIlBhaW50SW5m by5oIgogI2luY2x1ZGUgIlJlbmRlck11bHRpQ29sdW1uRmxvd1RocmVhZC5oIgotI2luY2x1ZGUg IlJlbmRlck11bHRpQ29sdW1uU2V0LmgiCiAjaW5jbHVkZSAiUmVuZGVyTXVsdGlDb2x1bW5CbG9j ay5oIgogCiB1c2luZyBzdGQ6Om1pbjsKQEAgLTI1Myw2ICsyNTUsNDkgQEAgdm9pZCBSZW5kZXJN dWx0aUNvbHVtblNldDo6cGFpbnRDb2x1bW5DbwogICAgIH0KIH0KIAorYm9vbCBSZW5kZXJNdWx0 aUNvbHVtblNldDo6bm9kZUF0UG9pbnQoY29uc3QgSGl0VGVzdFJlcXVlc3QmIHJlcXVlc3QsIEhp dFRlc3RSZXN1bHQmIHJlc3VsdCwgY29uc3QgSGl0VGVzdExvY2F0aW9uJiBsb2NhdGlvbkluQ29u dGFpbmVyLCBjb25zdCBMYXlvdXRQb2ludCYgYWNjdW11bGF0ZWRPZmZzZXQsIEhpdFRlc3RBY3Rp b24gYWN0aW9uKQoreworICAgIExheW91dFBvaW50IGFkanVzdGVkTG9jYXRpb24gPSBhY2N1bXVs YXRlZE9mZnNldCArIGxvY2F0aW9uKCk7CisKKyAgICAvLyBDaGVjayBvdXIgYm91bmRzIG5leHQu IEZvciB0aGlzIHB1cnBvc2UgYWx3YXlzIGFzc3VtZSB0aGF0IHdlIGNhbiBvbmx5IGJlIGhpdCBp biB0aGUKKyAgICAvLyBmb3JlZ3JvdW5kIHBoYXNlICh3aGljaCBpcyB0cnVlIGZvciByZXBsYWNl ZCBlbGVtZW50cyBsaWtlIGltYWdlcykuCisgICAgLy8gRklYTUU6IE9uY2Ugd2Ugc3VwcG9ydCBv dmVyZmxvdywgd2UgbmVlZCB0byBpbnRlcnNlY3Qgd2l0aCB0aGF0IGFuZCBub3Qgd2l0aCB0aGUg Ym91bmRzIHJlY3QuCisgICAgTGF5b3V0UmVjdCBib3VuZHNSZWN0ID0gYm9yZGVyQm94UmVjdElu UmVnaW9uKGxvY2F0aW9uSW5Db250YWluZXIucmVnaW9uKCkpOworICAgIGJvdW5kc1JlY3QubW92 ZUJ5KGFkanVzdGVkTG9jYXRpb24pOworICAgIGlmICghdmlzaWJsZVRvSGl0VGVzdGluZygpIHx8 IGFjdGlvbiAhPSBIaXRUZXN0Rm9yZWdyb3VuZCB8fCAhbG9jYXRpb25JbkNvbnRhaW5lci5pbnRl cnNlY3RzKGJvdW5kc1JlY3QpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgCisgICAgLy8g VGhlIHBvaW50IGlzIGluIG9uZSBzcGVjaWZpYyBjb2x1bW4uIFNpbmNlIGNvbHVtbnMgY2FuJ3Qg b3ZlcmxhcCwgd2UgZG9uJ3QgZXZlciBoYXZlIHRvIHRlc3QKKyAgICAvLyBtdWx0aXBsZSBjb2x1 bW5zLiBQdXQgdGhlIAorICAgIAorICAgIC8vIEZJWE1FOiBJdCB3b3VsZCBiZSBuaWNlIHRvIGp1 bXAgcmlnaHQgdG8gdGhlIHNwZWNpZmljIGNvbHVtbiBieSBqdXN0IGRvaW5nIG1hdGggb24gdGhl IHBvaW50LiAgU2luY2UgY29sdW1ucworICAgIC8vIGNhbid0IG92ZXJsYXAsIHdlIHNob3VsZG4n dCBoYXZlIHRvIHdhbGsgZXZlcnkgY29sdW1uIGxpa2UgdGhpcy4gVGhlIG9sZCBjb2x1bW4gY29k ZSB3YWxrZWQgYWxsIHRoZSBjb2x1bW5zLCB0aG91Z2gsCisgICAgLy8gc28gdGhpcyBpcyBubyB3 b3JzZS4gV2UnZCBoYXZlIHRvIHdhdGNoIG91dCBmb3IgcmVjdC1iYXNlZCBoaXQgdGVzdGluZywg dGhvdWdoLCB3aGljaCBhY3R1YWxseSBjb3VsZCBvdmVybGFwCisgICAgLy8gbXVsdGlwbGUgY29s dW1ucy4KKyAgICBMYXlvdXRVbml0IGNvbEdhcCA9IGNvbHVtbkdhcCgpOworICAgIHVuc2lnbmVk IGNvbENvdW50ID0gY29sdW1uQ291bnQoKTsKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwg Y29sQ291bnQ7IGkrKykgeworICAgICAgICAvLyBGaXJzdCB3ZSBnZXQgdGhlIGNvbHVtbiByZWN0 LCB3aGljaCBpcyBpbiBvdXIgbG9jYWwgY29vcmRpbmF0ZSBzcGFjZSwgYW5kIHdlIG1ha2UgaXQg cGh5c2ljYWwgYW5kIGFwcGx5CisgICAgICAgIC8vIHRoZSBwYWludCBvZmZzZXQgdG8gaXQuIFRo YXQgZ2l2ZXMgdXMgdGhlIHBoeXNpY2FsIGxvY2F0aW9uIHRoYXQgd2Ugd2FudCB0byBwYWludCB0 aGUgY29sdW1uIGF0LgorICAgICAgICBMYXlvdXRSZWN0IGNvbFJlY3QgPSBjb2x1bW5SZWN0QXQo aSk7CisgICAgICAgIGZsaXBGb3JXcml0aW5nTW9kZShjb2xSZWN0KTsKKyAgICAgICAgY29sUmVj dC5tb3ZlQnkoYWRqdXN0ZWRMb2NhdGlvbik7CisgICAgICAgIAorICAgICAgICAvLyBOZXh0IHdl IGdldCB0aGUgcG9ydGlvbiBvZiB0aGUgZmxvdyB0aHJlYWQgdGhhdCBjb3JyZXNwb25kcyB0byB0 aGlzIGNvbHVtbi4KKyAgICAgICAgTGF5b3V0UmVjdCBmbG93VGhyZWFkUG9ydGlvbiA9IGZsb3dU aHJlYWRQb3J0aW9uUmVjdEF0KGkpOworICAgICAgICAKKyAgICAgICAgLy8gTm93IGdldCB0aGUg b3ZlcmZsb3cgcmVjdCB0aGF0IGNvcnJlc3BvbmRzIHRvIHRoZSBjb2x1bW4uCisgICAgICAgIExh eW91dFJlY3QgZmxvd1RocmVhZE92ZXJmbG93UG9ydGlvbiA9IGZsb3dUaHJlYWRQb3J0aW9uT3Zl cmZsb3dSZWN0KGZsb3dUaHJlYWRQb3J0aW9uLCBpLCBjb2xDb3VudCwgY29sR2FwKTsKKworICAg ICAgICAvLyBEbyB0aGUgcGFpbnQgd2l0aCB0aGUgY29tcHV0ZWQgcmVjdHMuCisgICAgICAgIGlm IChmbG93VGhyZWFkKCktPmhpdFRlc3RGbG93VGhyZWFkUG9ydGlvbkluUmVnaW9uKHRoaXMsIGZs b3dUaHJlYWRQb3J0aW9uLCBmbG93VGhyZWFkT3ZlcmZsb3dQb3J0aW9uLCByZXF1ZXN0LCByZXN1 bHQsIGxvY2F0aW9uSW5Db250YWluZXIsIGNvbFJlY3QubG9jYXRpb24oKSkpCisgICAgICAgICAg ICByZXR1cm4gdHJ1ZTsKKyAgICB9CisgICAgCisgICAgdXBkYXRlSGl0VGVzdFJlc3VsdChyZXN1 bHQsIGxvY2F0aW9uSW5Db250YWluZXIucG9pbnQoKSAtIHRvTGF5b3V0U2l6ZShhZGp1c3RlZExv Y2F0aW9uKSk7CisgICAgcmV0dXJuICFyZXN1bHQuYWRkTm9kZVRvUmVjdEJhc2VkVGVzdFJlc3Vs dChub2RlKCksIGxvY2F0aW9uSW5Db250YWluZXIsIGJvdW5kc1JlY3QpOworfQorCiBjb25zdCBj aGFyKiBSZW5kZXJNdWx0aUNvbHVtblNldDo6cmVuZGVyTmFtZSgpIGNvbnN0CiB7ICAgIAogICAg IHJldHVybiAiUmVuZGVyTXVsdGlDb2x1bW5TZXQiOwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlck11bHRpQ29sdW1uU2V0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlck11bHRpQ29sdW1uU2V0LmgJKHJldmlzaW9uIDEyNzAwOCkKKysr IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtblNldC5oCSh3b3JraW5n IGNvcHkpCkBAIC02Niw2ICs2Niw3IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIGNvbXB1 dGVMb2dpY2FsSGVpZ2h0KCkgT1ZFUlJJREU7CiAKICAgICB2aXJ0dWFsIHZvaWQgcGFpbnRSZXBs YWNlZChQYWludEluZm8mLCBjb25zdCBMYXlvdXRQb2ludCYgcGFpbnRPZmZzZXQpIE9WRVJSSURF OworICAgIHZpcnR1YWwgYm9vbCBub2RlQXRQb2ludChjb25zdCBIaXRUZXN0UmVxdWVzdCYsIEhp dFRlc3RSZXN1bHQmLCBjb25zdCBIaXRUZXN0TG9jYXRpb24mLCBjb25zdCBMYXlvdXRQb2ludCYg YWNjdW11bGF0ZWRPZmZzZXQsIEhpdFRlc3RBY3Rpb24pIE9WRVJSSURFOwogCiAgICAgdmlydHVh bCBMYXlvdXRVbml0IGxvZ2ljYWxXaWR0aEZvckZsb3dUaHJlYWRDb250ZW50KCkgY29uc3QgT1ZF UlJJREUgeyByZXR1cm4gbV9jb21wdXRlZENvbHVtbldpZHRoOyB9CiAgICAgdmlydHVhbCBMYXlv dXRVbml0IGxvZ2ljYWxIZWlnaHRGb3JGbG93VGhyZWFkQ29udGVudCgpIGNvbnN0IE9WRVJSSURF IHsgcmV0dXJuIG1fY29tcHV0ZWRDb2x1bW5IZWlnaHQ7IH0gLy8gRklYTUU6IFdpbGwgYmUgd3Jv bmcgb25jZSB3ZSBoYXZlIG11bHRpcGxlIHNldHMuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyUmVnaW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyUmVnaW9uLmNwcAkocmV2aXNpb24gMTI3MDA4KQorKysgU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzMiw2ICsx MzIsNyBAQCBib29sIFJlbmRlclJlZ2lvbjo6bm9kZUF0UG9pbnQoY29uc3QgSGl0CiAKICAgICAv LyBDaGVjayBvdXIgYm91bmRzIG5leHQuIEZvciB0aGlzIHB1cnBvc2UgYWx3YXlzIGFzc3VtZSB0 aGF0IHdlIGNhbiBvbmx5IGJlIGhpdCBpbiB0aGUKICAgICAvLyBmb3JlZ3JvdW5kIHBoYXNlICh3 aGljaCBpcyB0cnVlIGZvciByZXBsYWNlZCBlbGVtZW50cyBsaWtlIGltYWdlcykuCisgICAgLy8g RklYTUU6IE9uY2Ugd2Ugc3VwcG9ydCBvdmVyZmxvdywgd2UgbmVlZCB0byBpbnRlcnNlY3Qgd2l0 aCB0aGF0IGFuZCBub3Qgd2l0aCB0aGUgYm91bmRzIHJlY3QuCiAgICAgTGF5b3V0UmVjdCBib3Vu ZHNSZWN0ID0gYm9yZGVyQm94UmVjdEluUmVnaW9uKGxvY2F0aW9uSW5Db250YWluZXIucmVnaW9u KCkpOwogICAgIGJvdW5kc1JlY3QubW92ZUJ5KGFkanVzdGVkTG9jYXRpb24pOwogICAgIGlmICh2 aXNpYmxlVG9IaXRUZXN0aW5nKCkgJiYgYWN0aW9uID09IEhpdFRlc3RGb3JlZ3JvdW5kICYmIGxv Y2F0aW9uSW5Db250YWluZXIuaW50ZXJzZWN0cyhib3VuZHNSZWN0KSkgewo=