95355 2012-08-29 09:44:27 -0700 [EFL][WK2] Keep activePopupMenu to call valueChangedForPopupMenu() outside showPopupMenu() 2012-09-02 19:03:56 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 707537 0 ryuan.choi 2012-08-29 09:44:27 -0700 Efl does not have a proper way to support nested loop so that applications may change values outside showPopupMenu. Like Qt port, WebKit2/Efl should keep activePopupMenu to change value of popup menu after showPopupMenu is finished. 707557 1 161255 ryuan.choi 2012-08-29 09:57:41 -0700 Created attachment 161255 Patch 709363 2 161255 gyuyoung.kim 2012-08-31 01:12:56 -0700 Comment on attachment 161255 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161255&action=review > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:192 > +static Eina_Bool selectItemAfterDelayed(void* data) Please use standard boolean instead of Eina_Bool. 709430 3 161255 gyuyoung.kim 2012-08-31 02:50:47 -0700 Comment on attachment 161255 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161255&action=review >> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:192 >> +static Eina_Bool selectItemAfterDelayed(void* data) > > Please use standard boolean instead of Eina_Bool. callback function needs to use Eina_Bool. please ignore my previous comment. 709452 4 161255 gyuyoung.kim 2012-08-31 03:20:18 -0700 Comment on attachment 161255 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161255&action=review > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:195 > + return false; Is ECORE_CALLBACK_CANCEL more clear ? 710362 5 161851 ryuan.choi 2012-09-02 17:10:46 -0700 Created attachment 161851 Patch 710363 6 ryuan.choi 2012-09-02 17:12:37 -0700 (In reply to comment #4) > (From update of attachment 161255 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=161255&action=review > > > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:195 > > + return false; > > Is ECORE_CALLBACK_CANCEL more clear ? Yes, it's more clear for efl folks. I fixed. 710372 7 161851 webkit.review.bot 2012-09-02 19:03:52 -0700 Comment on attachment 161851 Patch Clearing flags on attachment: 161851 Committed r127397: <http://trac.webkit.org/changeset/127397> 710373 8 webkit.review.bot 2012-09-02 19:03:56 -0700 All reviewed patches have been landed. Closing bug. 161255 2012-08-29 09:57:41 -0700 2012-09-02 17:10:40 -0700 Patch bug-95355-20120830015728.patch text/plain 3409 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MDAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzZkMDNlOTRlMjkzOTFl YjBjMTg4M2JjZWI4N2Y1N2U5MjRhYWI0OS4uMWFhZjM2Mzk0MTNhNmY2NWFjNWZiMTRkN2E5YTRi NmY5MjVjMjBiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA4LTI5ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEtl ZXAgYWN0aXZlUG9wdXBNZW51IHRvIGNhbGwgdmFsdWVDaGFuZ2VkRm9yUG9wdXBNZW51KCkgb3V0 c2lkZSBzaG93UG9wdXBNZW51KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk1MzU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRWZsIGRvZXMgbm90IGhhdmUgYSBwcm9wZXIgd2F5IHRvIHN1cHBvcnQgbmVz dGVkIGxvb3Agc28gdGhhdCBhcHBsaWNhdGlvbnMKKyAgICAgICAgbWF5IGNoYW5nZSB2YWx1ZSBh ZnRlciBzaG93UG9wdXBNZW51KCkgaXMgZmluaXNoZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHA6IEltcHJvdmVkIHRlc3QgY2FzZSB0byBj b3ZlciB0aGlzIGJ1Zy4KKyAgICAgICAgKHNlbGVjdEl0ZW1BZnRlckRlbGF5ZWQpOgorICAgICAg ICAoc2hvd1BvcHVwTWVudSk6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6 CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6c2hvd1BvcHVwTWVudSk6CisgICAgICAg IEd1YXJkIHdpdGggIVBMQVRGT1JNKEVGTCkgdG8ga2VlcCB0aGUgYWN0aXZlUG9wdXBNZW51IHZh bGlkIHRvIGNhbGwgdmFsdWVDaGFuZ2VkRm9yUG9wdXBNZW51CisgICAgICAgIG91dHNpZGUgc2hv d1BvcHVwTWVudSgpLgorCiAyMDEyLTA4LTI4ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25A aWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBFbmFibGUgdGhlIGVkZ2UgZGlzdGFuY2UgYW50 aS1hbGlhc2luZyBmb3IgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgbGF5ZXJzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmll dy5jcHAKaW5kZXggODhjZDZiOTFkNTgxNzdiNzVmMzhkNWMxZWViODlmYjgwMDc0ZDE3ZC4uZjBj YmNhNWRmNzlmYWZmMGRlMjBmYWE4MWRmM2NkZmExYTJiYjlkNCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl92aWV3LmNw cApAQCAtMTg5LDYgKzE4OSwxMiBAQCBURVNUX0YoRVdLMlVuaXRUZXN0QmFzZSwgZXdrX3ZpZXdf Zm9ybV9zdWJtaXNzaW9uX3JlcXVlc3QpCiAgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tf ZGVsKHdlYlZpZXcoKSwgImZvcm0sc3VibWlzc2lvbixyZXF1ZXN0Iiwgb25Gb3JtQWJvdXRUb0Jl U3VibWl0dGVkKTsKIH0KIAorc3RhdGljIEVpbmFfQm9vbCBzZWxlY3RJdGVtQWZ0ZXJEZWxheWVk KHZvaWQqIGRhdGEpCit7CisgICAgRVhQRUNUX1RSVUUoZXdrX3ZpZXdfcG9wdXBfbWVudV9zZWxl Y3Qoc3RhdGljX2Nhc3Q8RXZhc19PYmplY3QqPihkYXRhKSwgMCkpOworICAgIHJldHVybiBmYWxz ZTsKK30KKwogc3RhdGljIEVpbmFfQm9vbCBzaG93UG9wdXBNZW51KEV3a19WaWV3X1NtYXJ0X0Rh dGEqIHNtYXJ0RGF0YSwgRWluYV9SZWN0YW5nbGUsIEV3a19UZXh0X0RpcmVjdGlvbiwgZG91Ymxl LCBFaW5hX0xpc3QqIGxpc3QsIGludCBzZWxlY3RlZEluZGV4KQogewogICAgIEVYUEVDVF9FUShz ZWxlY3RlZEluZGV4LCAyKTsKQEAgLTIwOSw3ICsyMTUsNyBAQCBzdGF0aWMgRWluYV9Cb29sIHNo b3dQb3B1cE1lbnUoRXdrX1ZpZXdfU21hcnRfRGF0YSogc21hcnREYXRhLCBFaW5hX1JlY3Rhbmds ZSwgRQogICAgIEVYUEVDVF9FUShld2tfcG9wdXBfbWVudV9pdGVtX3R5cGVfZ2V0KGl0ZW0pLCBF V0tfUE9QVVBfTUVOVV9VTktOT1dOKTsKICAgICBFWFBFQ1RfU1RSRVEoZXdrX3BvcHVwX21lbnVf aXRlbV90ZXh0X2dldChpdGVtKSwgMCk7CiAKLSAgICBFWFBFQ1RfVFJVRShld2tfdmlld19wb3B1 cF9tZW51X3NlbGVjdChzbWFydERhdGEtPnNlbGYsIDApKTsKKyAgICBlY29yZV90aW1lcl9hZGQo MCwgc2VsZWN0SXRlbUFmdGVyRGVsYXllZCwgc21hcnREYXRhLT5zZWxmKTsKICAgICByZXR1cm4g dHJ1ZTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRl eCBjODhjNjY1NWE4ZTYxODBkY2JlN2ZlMGE0MWExNzU5NDAxODBlYjdkLi45YmRkODBlNDM1OTk1 MDM2ZDlkYzM2MjJmNWU0NmIxMWIwMTFiMTlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmNwcApAQCAtMjkxOCw4ICsyOTE4LDggQEAgdm9pZCBXZWJQYWdlUHJveHk6 OnNob3dQb3B1cE1lbnUoY29uc3QgSW50UmVjdCYgcmVjdCwgdWludDY0X3QgdGV4dERpcmVjdGlv biwgY28KIAogICAgIHByb3RlY3RlZEFjdGl2ZVBvcHVwTWVudS0+c2hvd1BvcHVwTWVudShyZWN0 LCBzdGF0aWNfY2FzdDxUZXh0RGlyZWN0aW9uPih0ZXh0RGlyZWN0aW9uKSwgbV9wYWdlU2NhbGVG YWN0b3IsIGl0ZW1zLCBkYXRhLCBzZWxlY3RlZEluZGV4KTsKIAotICAgIC8vIFNpbmNlIFF0IGRv ZXNuJ3QgdXNlIGEgbmVzdGVkIG1haW5sb29wIHRoZSBzaG93IHRoZSBwb3B1cCBhbmQgZ2V0IHRo ZSBhbnN3ZXIsIHdlIG5lZWQgdG8ga2VlcCB0aGUgY2xpZW50IHBvaW50ZXIgdmFsaWQuCi0jaWYg IVBMQVRGT1JNKFFUKQorICAgIC8vIFNpbmNlIFF0IGFuZCBFZmwgZG9lc24ndCB1c2UgYSBuZXN0 ZWQgbWFpbmxvb3AgdG8gc2hvdyB0aGUgcG9wdXAgYW5kIGdldCB0aGUgYW5zd2VyLCB3ZSBuZWVk IHRvIGtlZXAgdGhlIGNsaWVudCBwb2ludGVyIHZhbGlkLgorI2lmICFQTEFURk9STShRVCkgJiYg IVBMQVRGT1JNKEVGTCkKICAgICBwcm90ZWN0ZWRBY3RpdmVQb3B1cE1lbnUtPmludmFsaWRhdGUo KTsKICNlbmRpZgogICAgIHByb3RlY3RlZEFjdGl2ZVBvcHVwTWVudSA9IDA7Cg== 161851 2012-09-02 17:10:46 -0700 2012-09-02 19:03:52 -0700 Patch bug-95355-20120903091031.patch text/plain 3394 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3Mzk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNGFjYmE5ZTJhOTY1Y2Fk MDVjNjk2YzBjYWIxMTFjOWIxZWUwOGU4YS4uYTQzODA0MGNlMDBiODA0NWUyY2JhMmZlYTBiZjY5 OGQxMjJhNDE1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA5LTAyICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEtl ZXAgYWN0aXZlUG9wdXBNZW51IHRvIGNhbGwgdmFsdWVDaGFuZ2VkRm9yUG9wdXBNZW51KCkgb3V0 c2lkZSBzaG93UG9wdXBNZW51KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk1MzU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRWZsIGRvZXMgbm90IGhhdmUgYSBwcm9wZXIgd2F5IHRvIHN1cHBvcnQgbmVz dGVkIGxvb3Agc28gdGhhdCBhcHBsaWNhdGlvbnMKKyAgICAgICAgbWF5IGNoYW5nZSB2YWx1ZSBh ZnRlciBzaG93UG9wdXBNZW51KCkgaXMgZmluaXNoZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHA6IEltcHJvdmVkIHRlc3QgY2FzZSB0byBj b3ZlciB0aGlzIGJ1Zy4KKyAgICAgICAgKHNlbGVjdEl0ZW1BZnRlckRlbGF5ZWQpOgorICAgICAg ICAoc2hvd1BvcHVwTWVudSk6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6 CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6c2hvd1BvcHVwTWVudSk6CisgICAgICAg IEd1YXJkIHdpdGggIVBMQVRGT1JNKEVGTCkgdG8ga2VlcCB0aGUgYWN0aXZlUG9wdXBNZW51IHZh bGlkIHRvIGNhbGwgdmFsdWVDaGFuZ2VkRm9yUG9wdXBNZW51CisgICAgICAgIG91dHNpZGUgc2hv d1BvcHVwTWVudSgpLgorCiAyMDEyLTA5LTAyICBCeXVuZ3dvbyBMZWUgIDxidzgwLmxlZUBnbWFp bC5jb20+CiAKICAgICAgICAgW0VGTF0gQWRkIG1pc3Npbmcgc2VtaWNvbG9uIGF0IHRoZSBlbmQg b2Ygc29tZSBsaW5lcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL3Rlc3RzL3Rlc3RfZXdrMl92aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl92aWV3LmNwcAppbmRleCA4OGNkNmI5MWQ1ODE3N2I3NWYz OGQ1YzFlZWI4OWZiODAwNzRkMTdkLi40MjE3ZjcxM2RkZDc0MDVkOTVjMDE2YzAwZWQ0NzU0M2Zl NDgwMTliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0 cy90ZXN0X2V3azJfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l ZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwCkBAIC0xODksNiArMTg5LDEyIEBAIFRFU1RfRihF V0syVW5pdFRlc3RCYXNlLCBld2tfdmlld19mb3JtX3N1Ym1pc3Npb25fcmVxdWVzdCkKICAgICBl dmFzX29iamVjdF9zbWFydF9jYWxsYmFja19kZWwod2ViVmlldygpLCAiZm9ybSxzdWJtaXNzaW9u LHJlcXVlc3QiLCBvbkZvcm1BYm91dFRvQmVTdWJtaXR0ZWQpOwogfQogCitzdGF0aWMgRWluYV9C b29sIHNlbGVjdEl0ZW1BZnRlckRlbGF5ZWQodm9pZCogZGF0YSkKK3sKKyAgICBFWFBFQ1RfVFJV RShld2tfdmlld19wb3B1cF9tZW51X3NlbGVjdChzdGF0aWNfY2FzdDxFdmFzX09iamVjdCo+KGRh dGEpLCAwKSk7CisgICAgcmV0dXJuIEVDT1JFX0NBTExCQUNLX0NBTkNFTDsKK30KKwogc3RhdGlj IEVpbmFfQm9vbCBzaG93UG9wdXBNZW51KEV3a19WaWV3X1NtYXJ0X0RhdGEqIHNtYXJ0RGF0YSwg RWluYV9SZWN0YW5nbGUsIEV3a19UZXh0X0RpcmVjdGlvbiwgZG91YmxlLCBFaW5hX0xpc3QqIGxp c3QsIGludCBzZWxlY3RlZEluZGV4KQogewogICAgIEVYUEVDVF9FUShzZWxlY3RlZEluZGV4LCAy KTsKQEAgLTIwOSw3ICsyMTUsNyBAQCBzdGF0aWMgRWluYV9Cb29sIHNob3dQb3B1cE1lbnUoRXdr X1ZpZXdfU21hcnRfRGF0YSogc21hcnREYXRhLCBFaW5hX1JlY3RhbmdsZSwgRQogICAgIEVYUEVD VF9FUShld2tfcG9wdXBfbWVudV9pdGVtX3R5cGVfZ2V0KGl0ZW0pLCBFV0tfUE9QVVBfTUVOVV9V TktOT1dOKTsKICAgICBFWFBFQ1RfU1RSRVEoZXdrX3BvcHVwX21lbnVfaXRlbV90ZXh0X2dldChp dGVtKSwgMCk7CiAKLSAgICBFWFBFQ1RfVFJVRShld2tfdmlld19wb3B1cF9tZW51X3NlbGVjdChz bWFydERhdGEtPnNlbGYsIDApKTsKKyAgICBlY29yZV90aW1lcl9hZGQoMCwgc2VsZWN0SXRlbUFm dGVyRGVsYXllZCwgc21hcnREYXRhLT5zZWxmKTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCA5ODgxZWIyMGMxYjUz ZjllZjVjMmRiYjQwYjVhOGEzMjY5ZGQ0MjE0Li41YWVjYTU5MTVmNzdlNmEzNDc1NTgwMjAyOWI0 MWNjZGJmYjIyM2QzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFn ZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNw cApAQCAtMjkxOCw4ICsyOTE4LDggQEAgdm9pZCBXZWJQYWdlUHJveHk6OnNob3dQb3B1cE1lbnUo Y29uc3QgSW50UmVjdCYgcmVjdCwgdWludDY0X3QgdGV4dERpcmVjdGlvbiwgY28KIAogICAgIHBy b3RlY3RlZEFjdGl2ZVBvcHVwTWVudS0+c2hvd1BvcHVwTWVudShyZWN0LCBzdGF0aWNfY2FzdDxU ZXh0RGlyZWN0aW9uPih0ZXh0RGlyZWN0aW9uKSwgbV9wYWdlU2NhbGVGYWN0b3IsIGl0ZW1zLCBk YXRhLCBzZWxlY3RlZEluZGV4KTsKIAotICAgIC8vIFNpbmNlIFF0IGRvZXNuJ3QgdXNlIGEgbmVz dGVkIG1haW5sb29wIHRoZSBzaG93IHRoZSBwb3B1cCBhbmQgZ2V0IHRoZSBhbnN3ZXIsIHdlIG5l ZWQgdG8ga2VlcCB0aGUgY2xpZW50IHBvaW50ZXIgdmFsaWQuCi0jaWYgIVBMQVRGT1JNKFFUKQor ICAgIC8vIFNpbmNlIFF0IGFuZCBFZmwgZG9lc24ndCB1c2UgYSBuZXN0ZWQgbWFpbmxvb3AgdG8g c2hvdyB0aGUgcG9wdXAgYW5kIGdldCB0aGUgYW5zd2VyLCB3ZSBuZWVkIHRvIGtlZXAgdGhlIGNs aWVudCBwb2ludGVyIHZhbGlkLgorI2lmICFQTEFURk9STShRVCkgJiYgIVBMQVRGT1JNKEVGTCkK ICAgICBwcm90ZWN0ZWRBY3RpdmVQb3B1cE1lbnUtPmludmFsaWRhdGUoKTsKICNlbmRpZgogICAg IHByb3RlY3RlZEFjdGl2ZVBvcHVwTWVudSA9IDA7Cg==