95347 2012-08-29 08:20:30 -0700 [Texmap] CSS Transform flicks at the end of animation 2012-08-29 18:06:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rafael.lobo rafael.lobo abarth apavlov igor.oliveira noam webkit.review.bot oldest_to_newest 707463 0 rafael.lobo 2012-08-29 08:20:30 -0700 [Qt] CSS Transform flicks at the end of animation 707467 1 161231 rafael.lobo 2012-08-29 08:24:27 -0700 Created attachment 161231 Patch 707473 2 rafael.lobo 2012-08-29 08:28:53 -0700 Do you think this patch is good? I have no idea how I'm supposed to test this, as the flick happens too fast but not always. I've left a debugging printf by purpose to show where you should slow down to make this easier to see. 707507 3 161231 apavlov 2012-08-29 09:08:46 -0700 Comment on attachment 161231 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161231&action=review > Source/WebCore/platform/graphics/TiledBackingStore.cpp:128 > + printf("SLOW DOWN!!!"); Will you want to retain this in the landed patch?.. 707509 4 apavlov 2012-08-29 09:11:30 -0700 (In reply to comment #3) > Will you want to retain this in the landed patch?.. Aha, I see the patch is not up for review yet. So, does the fix affect all platforms? Do you have any idea if this issue occurs on other platforms as well? 707637 5 noam 2012-08-29 10:53:50 -0700 (In reply to comment #4) > (In reply to comment #3) > > Will you want to retain this in the landed patch?.. > > Aha, I see the patch is not up for review yet. So, does the fix affect all platforms? Do you have any idea if this issue occurs on other platforms as well? The fix will only affect Qt/GTK/EFL, other platforms don't compile in GraphicsLayerAnimation. 707638 6 161231 noam 2012-08-29 10:55:13 -0700 Comment on attachment 161231 Patch Good catch! I think this is the correct solution. 707668 7 161270 rafael.lobo 2012-08-29 11:15:02 -0700 Created attachment 161270 Patch 708133 8 161270 webkit.review.bot 2012-08-29 18:06:35 -0700 Comment on attachment 161270 Patch Clearing flags on attachment: 161270 Committed r127072: <http://trac.webkit.org/changeset/127072> 708134 9 webkit.review.bot 2012-08-29 18:06:39 -0700 All reviewed patches have been landed. Closing bug. 161231 2012-08-29 08:24:27 -0700 2012-08-29 11:14:57 -0700 Patch bug-95347-20120829122420.patch text/plain 3654 rafael.lobo U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2OTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDljZjExNDlhZTc2ZDY0 MmQ5YjhlMzQ5NzQ3NjBiNWIyYTBkMWU2Mi4uOGU4ZTQ0NDI2MGU3ZDVhNjZkZjhhMWI5YzAxMjc4 YzdhODlhZTk1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTI5ICBSYWZh ZWwgQnJhbmRhbyAgPHJhZmFlbC5sb2JvQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW1F0XSBD U1MgVHJhbnNmb3JtIGZsaWNrcyBhdCB0aGUgZW5kIG9mIGFuaW1hdGlvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTUzNDcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dy YXBoaWNzTGF5ZXJBbmltYXRpb24uY3BwOiBDaGVjayBpZiB0aGUgbGFzdCBsb29wIGhhcworICAg ICAgICBiZWVuIGNvbXBsZXRlZCBhbmQgdGhlbiB1c2UgMS4wIGFzIG5vcm1hbGl6ZWQgdmFsdWUg Zm9yIHRoZSBwcm9ncmVzcywgb3RoZXJ3aXNlCisgICAgICAgIGl0IHdvdWxkIHdvcmsgYXMgaWYg dGhlcmUgd2FzIGEgbmV3IGxvb3AgZm9yd2FyZCBhbmQgdGhlbiBjeWNsZSB0aGUgcHJvZ3Jlc3Mg dmFsdWUuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3Bw OgorCiAyMDEyLTA4LTI5ICBGbG9yaW4gTWFsaXRhICA8Zm1hbGl0YUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgSW5jb3JyZWN0IGxhcmdlLWFyZWEgY2xpcHBpbmcKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXJBbmltYXRpb24uY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllckFuaW1hdGlvbi5j cHAKaW5kZXggZTA4MTNkZmVjNzgxYzVjYzBhNjJiYWE1YzkwMmViOTg0ODVjODc1Yy4uM2FhMjVh YzQwYTRjOTFmMjg2NzhhMDE3MmNjYmIzODM5YmM2MzIyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllckFuaW1hdGlvbi5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllckFuaW1hdGlvbi5j cHAKQEAgLTM3LDcgKzM3LDcgQEAgc3RhdGljIGJvb2wgc2hvdWxkUmV2ZXJzZUFuaW1hdGlvblZh bHVlKEFuaW1hdGlvbjo6QW5pbWF0aW9uRGlyZWN0aW9uIGRpcmVjdGlvbiwKICAgICByZXR1cm4g ZmFsc2U7CiB9CiAKLXN0YXRpYyBkb3VibGUgbm9ybWFsaXplZEFuaW1hdGlvblZhbHVlKGRvdWJs ZSBydW5uaW5nVGltZSwgZG91YmxlIGR1cmF0aW9uLCBBbmltYXRpb246OkFuaW1hdGlvbkRpcmVj dGlvbiBkaXJlY3Rpb24pCitzdGF0aWMgZG91YmxlIG5vcm1hbGl6ZWRBbmltYXRpb25WYWx1ZShk b3VibGUgcnVubmluZ1RpbWUsIGRvdWJsZSBkdXJhdGlvbiwgQW5pbWF0aW9uOjpBbmltYXRpb25E aXJlY3Rpb24gZGlyZWN0aW9uLCBkb3VibGUgaXRlcmF0aW9uQ291bnQpCiB7CiAgICAgaWYgKCFk dXJhdGlvbikKICAgICAgICAgcmV0dXJuIDA7CkBAIC00NSw3ICs0NSw4IEBAIHN0YXRpYyBkb3Vi bGUgbm9ybWFsaXplZEFuaW1hdGlvblZhbHVlKGRvdWJsZSBydW5uaW5nVGltZSwgZG91YmxlIGR1 cmF0aW9uLCBBbmltCiAgICAgY29uc3QgaW50IGxvb3BDb3VudCA9IHJ1bm5pbmdUaW1lIC8gZHVy YXRpb247CiAgICAgY29uc3QgZG91YmxlIGxhc3RGdWxsTG9vcCA9IGR1cmF0aW9uICogZG91Ymxl KGxvb3BDb3VudCk7CiAgICAgY29uc3QgZG91YmxlIHJlbWFpbmRlciA9IHJ1bm5pbmdUaW1lIC0g bGFzdEZ1bGxMb29wOwotICAgIGNvbnN0IGRvdWJsZSBub3JtYWxpemVkID0gcmVtYWluZGVyIC8g ZHVyYXRpb247CisgICAgLy8gSWdub3JlIHJlbWFpbmRlciB3aGVuIHdlJ3ZlIHJlYWNoZWQgdGhl IGVuZCBvZiBhbmltYXRpb24uCisgICAgY29uc3QgZG91YmxlIG5vcm1hbGl6ZWQgPSAobG9vcENv dW50ID09IGl0ZXJhdGlvbkNvdW50KSA/IDEuMCA6IChyZW1haW5kZXIgLyBkdXJhdGlvbik7CiAK ICAgICByZXR1cm4gc2hvdWxkUmV2ZXJzZUFuaW1hdGlvblZhbHVlKGRpcmVjdGlvbiwgbG9vcENv dW50KSA/IDEgLSBub3JtYWxpemVkIDogbm9ybWFsaXplZDsKIH0KQEAgLTIxNCw3ICsyMTUsNyBA QCB2b2lkIEdyYXBoaWNzTGF5ZXJBbmltYXRpb246OmFwcGx5KENsaWVudCogY2xpZW50KQogICAg ICAgICByZXR1cm47CiAKICAgICBkb3VibGUgdG90YWxSdW5uaW5nVGltZSA9IG1fc3RhdGUgPT0g UGF1c2VkU3RhdGUgPyBtX3BhdXNlVGltZSA6IFdURjo6Y3VycmVudFRpbWUoKSAtIG1fc3RhcnRU aW1lOwotICAgIGRvdWJsZSBub3JtYWxpemVkVmFsdWUgPSBub3JtYWxpemVkQW5pbWF0aW9uVmFs dWUodG90YWxSdW5uaW5nVGltZSwgbV9hbmltYXRpb24tPmR1cmF0aW9uKCksIG1fYW5pbWF0aW9u LT5kaXJlY3Rpb24oKSk7CisgICAgZG91YmxlIG5vcm1hbGl6ZWRWYWx1ZSA9IG5vcm1hbGl6ZWRB bmltYXRpb25WYWx1ZSh0b3RhbFJ1bm5pbmdUaW1lLCBtX2FuaW1hdGlvbi0+ZHVyYXRpb24oKSwg bV9hbmltYXRpb24tPmRpcmVjdGlvbigpLCBtX2FuaW1hdGlvbi0+aXRlcmF0aW9uQ291bnQoKSk7 CiAKICAgICBpZiAobV9hbmltYXRpb24tPml0ZXJhdGlvbkNvdW50KCkgIT0gQW5pbWF0aW9uOjpJ dGVyYXRpb25Db3VudEluZmluaXRlICYmIHRvdGFsUnVubmluZ1RpbWUgPj0gbV9hbmltYXRpb24t PmR1cmF0aW9uKCkgKiBtX2FuaW1hdGlvbi0+aXRlcmF0aW9uQ291bnQoKSkgewogICAgICAgICBz ZXRTdGF0ZShTdG9wcGVkU3RhdGUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwCmluZGV4IGI0ODVkY2YxN2Y1ZWJlZjI5 YTk2NmVjYzYzZDZhMTkwODMyZDczMDQuLjAyNTE1OWM4NDAxYzBlOTQ3YmUyYjNkOTlhMzJlYTg1 ZDhlZmVjYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1Rp bGVkQmFja2luZ1N0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9UaWxlZEJhY2tpbmdTdG9yZS5jcHAKQEAgLTEyNSw2ICsxMjUsOCBAQCB2b2lkIFRpbGVkQmFj a2luZ1N0b3JlOjp1cGRhdGVUaWxlQnVmZmVycygpCiAgICAgICAgIG1fY2xpZW50LT50aWxlZEJh Y2tpbmdTdG9yZVBhaW50RW5kKHBhaW50ZWRBcmVhKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0K KyAgICBwcmludGYoIlNMT1cgRE9XTiEhISIpOworICAgIHVzbGVlcCgxMDAwMDApOwogCiAgICAg Ly8gRklYTUU6IEluIHNpbmdsZSB0aHJlYWRlZCBjYXNlLCB0aWxlIGJhY2sgYnVmZmVycyBjb3Vs ZCBiZSB1cGRhdGVkIGFzeW5jaHJvbm91c2x5IAogICAgIC8vIG9uZSBieSBvbmUgYW5kIHRoZW4g c3dhcHBlZCB0byBmcm9udCBpbiBvbmUgZ28uIFRoaXMgd291bGQgbWluaW1pemUgdGhlIHRpbWUg c3BlbnQK 161270 2012-08-29 11:15:02 -0700 2012-08-29 18:06:35 -0700 Patch bug-95347-20120829151454.patch text/plain 2882 rafael.lobo U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2OTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDljZjExNDlhZTc2ZDY0 MmQ5YjhlMzQ5NzQ3NjBiNWIyYTBkMWU2Mi4uMDI2YjVlNDYyNzBhMDMyNzg5MjI1ZWQyODMzMDBj YzdjZmUxZTI4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA4LTI5ICBSYWZh ZWwgQnJhbmRhbyAgPHJhZmFlbC5sb2JvQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW1RleG1h cF0gQ1NTIFRyYW5zZm9ybSBmbGlja3MgYXQgdGhlIGVuZCBvZiBhbmltYXRpb24KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1MzQ3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9HcmFwaGljc0xheWVyQW5pbWF0aW9uLmNwcDogQ2hlY2sgaWYgdGhlIGxhc3QgbG9vcCBoYXMK KyAgICAgICAgYmVlbiBjb21wbGV0ZWQgYW5kIHRoZW4gdXNlIDEuMCBhcyBub3JtYWxpemVkIHZh bHVlIGZvciB0aGUgcHJvZ3Jlc3MsIG90aGVyd2lzZQorICAgICAgICBpdCB3b3VsZCB3b3JrIGFz IGlmIHRoZXJlIHdhcyBhIG5ldyBsb29wIGZvcndhcmQgYW5kIHRoZW4gY3ljbGUgdGhlIHByb2dy ZXNzIHZhbHVlLgorCiAyMDEyLTA4LTI5ICBGbG9yaW4gTWFsaXRhICA8Zm1hbGl0YUBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgSW5jb3JyZWN0IGxhcmdlLWFyZWEgY2xpcHBpbmcKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXJBbmltYXRp b24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllckFu aW1hdGlvbi5jcHAKaW5kZXggZTA4MTNkZmVjNzgxYzVjYzBhNjJiYWE1YzkwMmViOTg0ODVjODc1 Yy4uM2FhMjVhYzQwYTRjOTFmMjg2NzhhMDE3MmNjYmIzODM5YmM2MzIyYSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllckFuaW1hdGlvbi5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllckFu aW1hdGlvbi5jcHAKQEAgLTM3LDcgKzM3LDcgQEAgc3RhdGljIGJvb2wgc2hvdWxkUmV2ZXJzZUFu aW1hdGlvblZhbHVlKEFuaW1hdGlvbjo6QW5pbWF0aW9uRGlyZWN0aW9uIGRpcmVjdGlvbiwKICAg ICByZXR1cm4gZmFsc2U7CiB9CiAKLXN0YXRpYyBkb3VibGUgbm9ybWFsaXplZEFuaW1hdGlvblZh bHVlKGRvdWJsZSBydW5uaW5nVGltZSwgZG91YmxlIGR1cmF0aW9uLCBBbmltYXRpb246OkFuaW1h dGlvbkRpcmVjdGlvbiBkaXJlY3Rpb24pCitzdGF0aWMgZG91YmxlIG5vcm1hbGl6ZWRBbmltYXRp b25WYWx1ZShkb3VibGUgcnVubmluZ1RpbWUsIGRvdWJsZSBkdXJhdGlvbiwgQW5pbWF0aW9uOjpB bmltYXRpb25EaXJlY3Rpb24gZGlyZWN0aW9uLCBkb3VibGUgaXRlcmF0aW9uQ291bnQpCiB7CiAg ICAgaWYgKCFkdXJhdGlvbikKICAgICAgICAgcmV0dXJuIDA7CkBAIC00NSw3ICs0NSw4IEBAIHN0 YXRpYyBkb3VibGUgbm9ybWFsaXplZEFuaW1hdGlvblZhbHVlKGRvdWJsZSBydW5uaW5nVGltZSwg ZG91YmxlIGR1cmF0aW9uLCBBbmltCiAgICAgY29uc3QgaW50IGxvb3BDb3VudCA9IHJ1bm5pbmdU aW1lIC8gZHVyYXRpb247CiAgICAgY29uc3QgZG91YmxlIGxhc3RGdWxsTG9vcCA9IGR1cmF0aW9u ICogZG91YmxlKGxvb3BDb3VudCk7CiAgICAgY29uc3QgZG91YmxlIHJlbWFpbmRlciA9IHJ1bm5p bmdUaW1lIC0gbGFzdEZ1bGxMb29wOwotICAgIGNvbnN0IGRvdWJsZSBub3JtYWxpemVkID0gcmVt YWluZGVyIC8gZHVyYXRpb247CisgICAgLy8gSWdub3JlIHJlbWFpbmRlciB3aGVuIHdlJ3ZlIHJl YWNoZWQgdGhlIGVuZCBvZiBhbmltYXRpb24uCisgICAgY29uc3QgZG91YmxlIG5vcm1hbGl6ZWQg PSAobG9vcENvdW50ID09IGl0ZXJhdGlvbkNvdW50KSA/IDEuMCA6IChyZW1haW5kZXIgLyBkdXJh dGlvbik7CiAKICAgICByZXR1cm4gc2hvdWxkUmV2ZXJzZUFuaW1hdGlvblZhbHVlKGRpcmVjdGlv biwgbG9vcENvdW50KSA/IDEgLSBub3JtYWxpemVkIDogbm9ybWFsaXplZDsKIH0KQEAgLTIxNCw3 ICsyMTUsNyBAQCB2b2lkIEdyYXBoaWNzTGF5ZXJBbmltYXRpb246OmFwcGx5KENsaWVudCogY2xp ZW50KQogICAgICAgICByZXR1cm47CiAKICAgICBkb3VibGUgdG90YWxSdW5uaW5nVGltZSA9IG1f c3RhdGUgPT0gUGF1c2VkU3RhdGUgPyBtX3BhdXNlVGltZSA6IFdURjo6Y3VycmVudFRpbWUoKSAt IG1fc3RhcnRUaW1lOwotICAgIGRvdWJsZSBub3JtYWxpemVkVmFsdWUgPSBub3JtYWxpemVkQW5p bWF0aW9uVmFsdWUodG90YWxSdW5uaW5nVGltZSwgbV9hbmltYXRpb24tPmR1cmF0aW9uKCksIG1f YW5pbWF0aW9uLT5kaXJlY3Rpb24oKSk7CisgICAgZG91YmxlIG5vcm1hbGl6ZWRWYWx1ZSA9IG5v cm1hbGl6ZWRBbmltYXRpb25WYWx1ZSh0b3RhbFJ1bm5pbmdUaW1lLCBtX2FuaW1hdGlvbi0+ZHVy YXRpb24oKSwgbV9hbmltYXRpb24tPmRpcmVjdGlvbigpLCBtX2FuaW1hdGlvbi0+aXRlcmF0aW9u Q291bnQoKSk7CiAKICAgICBpZiAobV9hbmltYXRpb24tPml0ZXJhdGlvbkNvdW50KCkgIT0gQW5p bWF0aW9uOjpJdGVyYXRpb25Db3VudEluZmluaXRlICYmIHRvdGFsUnVubmluZ1RpbWUgPj0gbV9h bmltYXRpb24tPmR1cmF0aW9uKCkgKiBtX2FuaW1hdGlvbi0+aXRlcmF0aW9uQ291bnQoKSkgewog ICAgICAgICBzZXRTdGF0ZShTdG9wcGVkU3RhdGUpOwo=