95343 2012-08-29 07:12:17 -0700 Web Inspector: Refactor InspectorFrontendClientLocal to remove ScriptState as member 2012-08-29 12:49:01 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vivekgalatage vivekgalatage apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 707422 0 vivekgalatage 2012-08-29 07:12:17 -0700 Patch to follow. 707425 1 161221 vivekgalatage 2012-08-29 07:18:40 -0700 Created attachment 161221 Patch 707762 2 161221 webkit.review.bot 2012-08-29 12:48:57 -0700 Comment on attachment 161221 Patch Clearing flags on attachment: 161221 Committed r127031: <http://trac.webkit.org/changeset/127031> 707763 3 webkit.review.bot 2012-08-29 12:49:01 -0700 All reviewed patches have been landed. Closing bug. 161221 2012-08-29 07:18:40 -0700 2012-08-29 12:48:57 -0700 Patch bug-95343-20120829194822.patch text/plain 3999 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNjk5OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA4LTI5ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFJlZmFjdG9yIEluc3BlY3RvckZyb250ZW5kQ2xpZW50TG9jYWwgdG8gcmVtb3ZlIFNjcmlw dFN0YXRlIGFzIG1lbWJlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTUzNDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgU2NyaXB0U3RhdGUgaXMgbm90IHJlcXVpcmVkIHRvIGJlIHN0b3JlZCBhcyBh IG1lbWJlciB0bworICAgICAgICBJbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsIGhlbmNlIHJl bW92aW5nIGl0IGFzIG1lbWJlci4KKworICAgICAgICBObyBuZXcgdGVzdHMgZHVlIHRvIGNvZGUg cmVmYWN0b3JpbmcuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRDbGll bnRMb2NhbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JGcm9udGVuZENsaWVudExv Y2FsOjpJbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsKToKKyAgICAgICAgKFdlYkNvcmU6Oklu c3BlY3RvckZyb250ZW5kQ2xpZW50TG9jYWw6On5JbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2Fs KToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckZyb250ZW5kQ2xpZW50TG9jYWw6OndpbmRv d09iamVjdENsZWFyZWQpOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZENs aWVudExvY2FsLmg6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKEluc3BlY3RvckZyb250 ZW5kQ2xpZW50TG9jYWwpOgorCiAyMDEyLTA4LTI5ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFR1cm4gd29ya3NwYWNlIGlu dG8gYSBjb250YWluZXIgb2YgVWlTb3VyY2VDb2RlcyBwdXQgaW4gZGlmZmVyZW50IHByb2plY3Rz LgpJbmRleDogU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kQ2xpZW50 TG9jYWwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JGcm9udGVuZENsaWVudExvY2FsLmNwcAkocmV2aXNpb24gMTI2NzUzKQorKysgU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kQ2xpZW50TG9jYWwuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC00OSw2ICs0OSw3IEBACiAjaW5jbHVkZSAiUGxhdGZvcm1TdHJpbmcuaCIKICNp bmNsdWRlICJTY3JpcHRGdW5jdGlvbkNhbGwuaCIKICNpbmNsdWRlICJTY3JpcHRPYmplY3QuaCIK KyNpbmNsdWRlICJTY3JpcHRTdGF0ZS5oIgogI2luY2x1ZGUgIlNldHRpbmdzLmgiCiAjaW5jbHVk ZSAiVGltZXIuaCIKICNpbmNsdWRlICJVc2VyR2VzdHVyZUluZGljYXRvci5oIgpAQCAtMTExLDcg KzExMiw2IEBAIHZvaWQgSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbDo6U2V0dGkKIEluc3Bl Y3RvckZyb250ZW5kQ2xpZW50TG9jYWw6Okluc3BlY3RvckZyb250ZW5kQ2xpZW50TG9jYWwoSW5z cGVjdG9yQ29udHJvbGxlciogaW5zcGVjdG9yQ29udHJvbGxlciwgUGFnZSogZnJvbnRlbmRQYWdl LCBQYXNzT3duUHRyPFNldHRpbmdzPiBzZXR0aW5ncykKICAgICA6IG1faW5zcGVjdG9yQ29udHJv bGxlcihpbnNwZWN0b3JDb250cm9sbGVyKQogICAgICwgbV9mcm9udGVuZFBhZ2UoZnJvbnRlbmRQ YWdlKQotICAgICwgbV9mcm9udGVuZFNjcmlwdFN0YXRlKDApCiAgICAgLCBtX3NldHRpbmdzKHNl dHRpbmdzKQogICAgICwgbV9mcm9udGVuZExvYWRlZChmYWxzZSkKIHsKQEAgLTEyNCw3ICsxMjQs NiBAQCBJbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsOjp+SW5zcGVjdG9yCiAgICAgaWYgKG1f ZnJvbnRlbmRIb3N0KQogICAgICAgICBtX2Zyb250ZW5kSG9zdC0+ZGlzY29ubmVjdENsaWVudCgp OwogICAgIG1fZnJvbnRlbmRQYWdlID0gMDsKLSAgICBtX2Zyb250ZW5kU2NyaXB0U3RhdGUgPSAw OwogICAgIG1faW5zcGVjdG9yQ29udHJvbGxlciA9IDA7CiB9CiAKQEAgLTEzMiwxMCArMTMxLDEw IEBAIHZvaWQgSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbDo6d2luZG8KIHsKICAgICBpZiAo bV9mcm9udGVuZEhvc3QpCiAgICAgICAgIG1fZnJvbnRlbmRIb3N0LT5kaXNjb25uZWN0Q2xpZW50 KCk7Ci0gICAgLy8gRklYTUU6IGRvbid0IGtlZXAgcmVmZXJlbmNlIHRvIHRoZSBzY3JpcHQgc3Rh dGUKLSAgICBtX2Zyb250ZW5kU2NyaXB0U3RhdGUgPSBzY3JpcHRTdGF0ZUZyb21QYWdlKGRlYnVn Z2VyV29ybGQoKSwgbV9mcm9udGVuZFBhZ2UpOworICAgIAorICAgIFNjcmlwdFN0YXRlKiBmcm9u dGVuZFNjcmlwdFN0YXRlID0gc2NyaXB0U3RhdGVGcm9tUGFnZShkZWJ1Z2dlcldvcmxkKCksIG1f ZnJvbnRlbmRQYWdlKTsKICAgICBtX2Zyb250ZW5kSG9zdCA9IEluc3BlY3RvckZyb250ZW5kSG9z dDo6Y3JlYXRlKHRoaXMsIG1fZnJvbnRlbmRQYWdlKTsKLSAgICBTY3JpcHRHbG9iYWxPYmplY3Q6 OnNldChtX2Zyb250ZW5kU2NyaXB0U3RhdGUsICJJbnNwZWN0b3JGcm9udGVuZEhvc3QiLCBtX2Zy b250ZW5kSG9zdC5nZXQoKSk7CisgICAgU2NyaXB0R2xvYmFsT2JqZWN0OjpzZXQoZnJvbnRlbmRT Y3JpcHRTdGF0ZSwgIkluc3BlY3RvckZyb250ZW5kSG9zdCIsIG1fZnJvbnRlbmRIb3N0LmdldCgp KTsKIH0KIAogdm9pZCBJbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsOjpmcm9udGVuZExvYWRl ZCgpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRDbGll bnRMb2NhbC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JGcm9udGVuZENsaWVudExvY2FsLmgJKHJldmlzaW9uIDEyNjc1MykKKysrIFNvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsLmgJKHdvcmtpbmcgY29w eSkKQEAgLTMzLDEyICszMywxMiBAQAogCiAjaW5jbHVkZSAiSW5zcGVjdG9yRnJvbnRlbmRDbGll bnQuaCIKICNpbmNsdWRlICJQbGF0Zm9ybVN0cmluZy5oIgotI2luY2x1ZGUgIlNjcmlwdFN0YXRl LmgiCiAjaW5jbHVkZSA8d3RmL0ZvcndhcmQuaD4KICNpbmNsdWRlIDx3dGYvTm9uY29weWFibGUu aD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitjbGFzcyBGcmFtZTsKIGNsYXNzIEluc3BlY3Rv ckNvbnRyb2xsZXI7CiBjbGFzcyBJbnNwZWN0b3JCYWNrZW5kRGlzcGF0Y2hUYXNrOwogY2xhc3Mg SW5zcGVjdG9yRnJvbnRlbmRIb3N0OwpAQCAtMTExLDggKzExMSw3IEBAIHByaXZhdGU6CiAKICAg ICBmcmllbmQgY2xhc3MgRnJvbnRlbmRNZW51UHJvdmlkZXI7CiAgICAgSW5zcGVjdG9yQ29udHJv bGxlciogbV9pbnNwZWN0b3JDb250cm9sbGVyOwotICAgIFBhZ2UqIG1fZnJvbnRlbmRQYWdlOwot ICAgIFNjcmlwdFN0YXRlKiBtX2Zyb250ZW5kU2NyaXB0U3RhdGU7CisgICAgUGFnZSogbV9mcm9u dGVuZFBhZ2U7ICAgIAogICAgIC8vIFRPRE8oeXVyeXMpOiB0aGlzIHJlZiBzaG91bGRuJ3QgYmUg bmVlZGVkLgogICAgIFJlZlB0cjxJbnNwZWN0b3JGcm9udGVuZEhvc3Q+IG1fZnJvbnRlbmRIb3N0 OwogICAgIE93blB0cjxJbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsOjpTZXR0aW5ncz4gbV9z ZXR0aW5nczsK