95338 2012-08-29 05:53:59 -0700 [BlackBerry] Eliminate build warnings 2012-08-30 05:36:51 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 charles.wei charles.wei fpizlo haraken webkit.review.bot oldest_to_newest 707378 0 charles.wei 2012-08-29 05:53:59 -0700 Comparison between signed and unsigned integers generates warnings. Need to cast them to the same type to eliminate the warnings. 707379 1 161205 charles.wei 2012-08-29 05:58:02 -0700 Created attachment 161205 Patch 707419 2 161205 haraken 2012-08-29 07:08:06 -0700 Comment on attachment 161205 Patch OK 707447 3 161205 buildbot 2012-08-29 07:51:35 -0700 Comment on attachment 161205 Patch Attachment 161205 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13682224 708324 4 161205 haraken 2012-08-29 22:50:24 -0700 Comment on attachment 161205 Patch r-ing due to pizlo's comment here (https://bugs.webkit.org/show_bug.cgi?id=95418#c4). Sorry for the wrong review. 708325 5 fpizlo 2012-08-29 22:53:12 -0700 (In reply to comment #4) > (From update of attachment 161205 [details]) > r-ing due to pizlo's comment here (https://bugs.webkit.org/show_bug.cgi?id=95418#c4). Sorry for the wrong review. No worries! Signed comparisons in C++ are so annoying! ;-) 708375 6 161415 charles.wei 2012-08-30 00:47:05 -0700 Created attachment 161415 Patch 708524 7 161415 webkit.review.bot 2012-08-30 05:36:48 -0700 Comment on attachment 161415 Patch Clearing flags on attachment: 161415 Committed r127128: <http://trac.webkit.org/changeset/127128> 708525 8 webkit.review.bot 2012-08-30 05:36:51 -0700 All reviewed patches have been landed. Closing bug. 161205 2012-08-29 05:58:02 -0700 2012-08-30 00:46:58 -0700 Patch bug-95338-20120829205751.patch text/plain 3505 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2OTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 YmQ5ZjA0ZThmNjgxMjRjY2NkOTcyNzQ0YWIzYTM2MDY0M2QzM2Y2Li5mMGY4ODE4YTQ1MDcxODU4 NDkxMjQ4NWEwM2Q5ZDZjN2QxMDMxMGM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxMi0wOC0yOSAgQ2hhcmxlcyBXZWkgIDxjaGFybGVzLndlaUB0b3JjaG1v YmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEVsaW1pbmF0ZSBidWlsZCB3YXJu aW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTUz MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBzdGF0 aWNfY2FzdCB0byB0aGUgc2FtZSB0eXBlIHRvIGVsaW1pbmF0ZSB0aGUgYnVpbGQgdGltZSB3YXJu aW5ncy4KKworICAgICAgICAqIGFzc2VtYmxlci9Bc3NlbWJsZXJCdWZmZXJXaXRoQ29uc3RhbnRQ b29sLmg6CisgICAgICAgIChKU0M6OkFzc2VtYmxlckJ1ZmZlcldpdGhDb25zdGFudFBvb2w6OmZs dXNoV2l0aG91dEJhcnJpZXIpOgorICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFS TS5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlckFSTTo6YnJhbmNoMzIpOgorICAgICAg ICAqIGRmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6Qnl0ZUNv ZGVQYXJzZXI6OmZpbmRBcmd1bWVudFBvc2l0aW9uRm9yTG9jYWwpOgorCiAyMDEyLTA4LTI4ICBH ZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkZWQgSlNTY29w ZTo6b2JqZWN0SW5TY29wZSgpLCBhbmQgcmVmYWN0b3JlZCBjYWxsZXJzIHRvIHVzZSBpdApkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9Bc3NlbWJsZXJCdWZmZXJX aXRoQ29uc3RhbnRQb29sLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0Fzc2Vt YmxlckJ1ZmZlcldpdGhDb25zdGFudFBvb2wuaAppbmRleCA0MzAxNDcyODAxMzA2MTNkMzEwYmZl MGM2YmJjYTRkY2Y3OGNiNWNmLi41Mzc3ZWYwYzdhMDgwZWRlY2EyMzAxMjVkYmM2ODRjNGFkOGRh MWU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0Fzc2VtYmxl ckJ1ZmZlcldpdGhDb25zdGFudFBvb2wuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNz ZW1ibGVyL0Fzc2VtYmxlckJ1ZmZlcldpdGhDb25zdGFudFBvb2wuaApAQCAtMjE1LDcgKzIxNSw3 IEBAIHB1YmxpYzoKICAgICB2b2lkIGZsdXNoV2l0aG91dEJhcnJpZXIoYm9vbCBpc0ZvcmNlZCA9 IGZhbHNlKQogICAgIHsKICAgICAgICAgLy8gRmx1c2ggaWYgY29uc3RhbnQgcG9vbCBpcyBtb3Jl IHRoYW4gNjAlIGZ1bGwgdG8gYXZvaWQgb3ZlcnVzZSBvZiB0aGlzIGZ1bmN0aW9uLgotICAgICAg ICBpZiAoaXNGb3JjZWQgfHwgNSAqIG1fbnVtQ29uc3RzID4gMyAqIG1heFBvb2xTaXplIC8gc2l6 ZW9mKHVpbnQzMl90KSkKKyAgICAgICAgaWYgKGlzRm9yY2VkIHx8IDUgKiBzdGF0aWNfY2FzdDx1 aW50MzJfdD4obV9udW1Db25zdHMpID4gMyAqIG1heFBvb2xTaXplIC8gc2l6ZW9mKHVpbnQzMl90 KSkKICAgICAgICAgICAgIGZsdXNoQ29uc3RhbnRQb29sKGZhbHNlKTsKICAgICB9CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0u aCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaApp bmRleCAyOTUzNTQxMTk2M2VkODEyNmZiMzZkYWMyNDNjZjQwNzhhMDYyZWUwLi5lM2IwYmU5ZGFh YWU1ZjRiNWE3ZWNiYmIwOTI4NWZiY2QwOGMyYWZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oCkBAIC01NTUsNyArNTU1LDcg QEAgcHVibGljOgogCiAgICAgSnVtcCBicmFuY2gzMihSZWxhdGlvbmFsQ29uZGl0aW9uIGNvbmQs IFJlZ2lzdGVySUQgbGVmdCwgVHJ1c3RlZEltbTMyIHJpZ2h0LCBpbnQgdXNlQ29uc3RhbnRQb29s ID0gMCkKICAgICB7Ci0gICAgICAgIEFSTVdvcmQgdG1wID0gKHJpZ2h0Lm1fdmFsdWUgPT0gMHg4 MDAwMDAwMCkgPyBBUk1Bc3NlbWJsZXI6OkludmFsaWRJbW1lZGlhdGUgOiBtX2Fzc2VtYmxlci5n ZXRPcDIoLXJpZ2h0Lm1fdmFsdWUpOworICAgICAgICBBUk1Xb3JkIHRtcCA9IChzdGF0aWNfY2Fz dDx1bnNpZ25lZD4ocmlnaHQubV92YWx1ZSkgPT0gMHg4MDAwMDAwMCkgPyBBUk1Bc3NlbWJsZXI6 OkludmFsaWRJbW1lZGlhdGUgOiBtX2Fzc2VtYmxlci5nZXRPcDIoLXJpZ2h0Lm1fdmFsdWUpOwog ICAgICAgICBpZiAodG1wICE9IEFSTUFzc2VtYmxlcjo6SW52YWxpZEltbWVkaWF0ZSkKICAgICAg ICAgICAgIG1fYXNzZW1ibGVyLmNtbihsZWZ0LCB0bXApOwogICAgICAgICBlbHNlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCmluZGV4IGRmMTlj MzA4MmQ3YzViYTJjNjU4ZDU5MjEyNDBlZjA2ZGMzODgzYTUuLjU2ZTQyZDRiMjk5Mjc3ZGQyNDlk ODc5ZDg5YWQzMmU4NmUwN2EzMzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHQnl0ZUNvZGVQYXJzZXIuY3BwCkBAIC0zNjUsNyArMzY1LDcgQEAgcHJpdmF0ZToKICAgICAg ICAgICAgIElubGluZUNhbGxGcmFtZSogaW5saW5lQ2FsbEZyYW1lID0gc3RhY2stPm1faW5saW5l Q2FsbEZyYW1lOwogICAgICAgICAgICAgaWYgKCFpbmxpbmVDYWxsRnJhbWUpCiAgICAgICAgICAg ICAgICAgYnJlYWs7Ci0gICAgICAgICAgICBpZiAob3BlcmFuZCA+PSBpbmxpbmVDYWxsRnJhbWUt PnN0YWNrT2Zmc2V0IC0gUmVnaXN0ZXJGaWxlOjpDYWxsRnJhbWVIZWFkZXJTaXplKQorICAgICAg ICAgICAgaWYgKHN0YXRpY19jYXN0PHVuc2lnbmVkPihvcGVyYW5kKSA+PSBpbmxpbmVDYWxsRnJh bWUtPnN0YWNrT2Zmc2V0IC0gUmVnaXN0ZXJGaWxlOjpDYWxsRnJhbWVIZWFkZXJTaXplKQogICAg ICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgaWYgKG9wZXJhbmQgPT0gaW5saW5l Q2FsbEZyYW1lLT5zdGFja09mZnNldCArIENhbGxGcmFtZTo6dGhpc0FyZ3VtZW50T2Zmc2V0KCkp CiAgICAgICAgICAgICAgICAgY29udGludWU7Cg== 161415 2012-08-30 00:47:05 -0700 2012-08-30 05:36:48 -0700 Patch bug-95338-20120830155656.patch text/plain 2593 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MDAxY2E4ZjgxNDY4ZmZkMmI3MmFmMmQ1ZTg2NGJhNGIzMmQ1YmI1Li5mZmRjNWQyZmJjZmI1YzMw N2RkNjZmNzA4ODUwNjZjNzc2NmE5NzMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxMi0wOC0zMCAgQ2hhcmxlcyBXZWkgIDxjaGFybGVzLndlaUB0b3JjaG1v YmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEVsaW1pbmF0ZSBidWlsZCB3YXJu aW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTUz MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBzdGF0 aWNfY2FzdCB0byB0aGUgc2FtZSB0eXBlIHRvIGVsaW1pbmF0ZSB0aGUgYnVpbGQgdGltZSB3YXJu aW5ncy4KKworICAgICAgICAqIGFzc2VtYmxlci9Bc3NlbWJsZXJCdWZmZXJXaXRoQ29uc3RhbnRQ b29sLmg6CisgICAgICAgIChKU0M6OkFzc2VtYmxlckJ1ZmZlcldpdGhDb25zdGFudFBvb2w6OmZs dXNoV2l0aG91dEJhcnJpZXIpOgorICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFS TS5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlckFSTTo6YnJhbmNoMzIpOgorCiAyMDEy LTA4LTI5ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAg ICAgUmVtb3ZlIHVzZSBvZiBDbGFzc0luZm8gZnJvbSBjb21waWxlR2V0QnlWYWxPbkFyZ3VtZW50 cyBhbmQgY29tcGlsZUdldEFyZ3VtZW50c0xlbmd0aApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2Fzc2VtYmxlci9Bc3NlbWJsZXJCdWZmZXJXaXRoQ29uc3RhbnRQb29sLmggYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0Fzc2VtYmxlckJ1ZmZlcldpdGhDb25zdGFu dFBvb2wuaAppbmRleCA0MzAxNDcyODAxMzA2MTNkMzEwYmZlMGM2YmJjYTRkY2Y3OGNiNWNmLi41 Mzc3ZWYwYzdhMDgwZWRlY2EyMzAxMjVkYmM2ODRjNGFkOGRhMWU3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0Fzc2VtYmxlckJ1ZmZlcldpdGhDb25zdGFudFBv b2wuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0Fzc2VtYmxlckJ1ZmZl cldpdGhDb25zdGFudFBvb2wuaApAQCAtMjE1LDcgKzIxNSw3IEBAIHB1YmxpYzoKICAgICB2b2lk IGZsdXNoV2l0aG91dEJhcnJpZXIoYm9vbCBpc0ZvcmNlZCA9IGZhbHNlKQogICAgIHsKICAgICAg ICAgLy8gRmx1c2ggaWYgY29uc3RhbnQgcG9vbCBpcyBtb3JlIHRoYW4gNjAlIGZ1bGwgdG8gYXZv aWQgb3ZlcnVzZSBvZiB0aGlzIGZ1bmN0aW9uLgotICAgICAgICBpZiAoaXNGb3JjZWQgfHwgNSAq IG1fbnVtQ29uc3RzID4gMyAqIG1heFBvb2xTaXplIC8gc2l6ZW9mKHVpbnQzMl90KSkKKyAgICAg ICAgaWYgKGlzRm9yY2VkIHx8IDUgKiBzdGF0aWNfY2FzdDx1aW50MzJfdD4obV9udW1Db25zdHMp ID4gMyAqIG1heFBvb2xTaXplIC8gc2l6ZW9mKHVpbnQzMl90KSkKICAgICAgICAgICAgIGZsdXNo Q29uc3RhbnRQb29sKGZhbHNlKTsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAppbmRleCAyOTUzNTQxMTk2M2VkODEy NmZiMzZkYWMyNDNjZjQwNzhhMDYyZWUwLi5lM2IwYmU5ZGFhYWU1ZjRiNWE3ZWNiYmIwOTI4NWZi Y2QwOGMyYWZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01h Y3JvQXNzZW1ibGVyQVJNLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N YWNyb0Fzc2VtYmxlckFSTS5oCkBAIC01NTUsNyArNTU1LDcgQEAgcHVibGljOgogCiAgICAgSnVt cCBicmFuY2gzMihSZWxhdGlvbmFsQ29uZGl0aW9uIGNvbmQsIFJlZ2lzdGVySUQgbGVmdCwgVHJ1 c3RlZEltbTMyIHJpZ2h0LCBpbnQgdXNlQ29uc3RhbnRQb29sID0gMCkKICAgICB7Ci0gICAgICAg IEFSTVdvcmQgdG1wID0gKHJpZ2h0Lm1fdmFsdWUgPT0gMHg4MDAwMDAwMCkgPyBBUk1Bc3NlbWJs ZXI6OkludmFsaWRJbW1lZGlhdGUgOiBtX2Fzc2VtYmxlci5nZXRPcDIoLXJpZ2h0Lm1fdmFsdWUp OworICAgICAgICBBUk1Xb3JkIHRtcCA9IChzdGF0aWNfY2FzdDx1bnNpZ25lZD4ocmlnaHQubV92 YWx1ZSkgPT0gMHg4MDAwMDAwMCkgPyBBUk1Bc3NlbWJsZXI6OkludmFsaWRJbW1lZGlhdGUgOiBt X2Fzc2VtYmxlci5nZXRPcDIoLXJpZ2h0Lm1fdmFsdWUpOwogICAgICAgICBpZiAodG1wICE9IEFS TUFzc2VtYmxlcjo6SW52YWxpZEltbWVkaWF0ZSkKICAgICAgICAgICAgIG1fYXNzZW1ibGVyLmNt bihsZWZ0LCB0bXApOwogICAgICAgICBlbHNlCg==