95317 2012-08-29 02:41:29 -0700 [BlackBerry] Move the handling of UserMedia requests to the client 2012-08-29 19:07:32 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 robin.webkit webkit-unassigned charles.wei dglazkov eric.carlson feature-media-reviews mifenton rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 707241 0 robin.webkit 2012-08-29 02:41:29 -0700 Move the logic for user media requests handling to the client, as it requires inputs from users. 707248 1 161166 robin.webkit 2012-08-29 02:53:22 -0700 Created attachment 161166 patch 707418 2 161166 webkit.review.bot 2012-08-29 07:05:07 -0700 Comment on attachment 161166 patch Rejecting attachment 161166 from commit-queue. New failing tests: CCLayerTreeHostTestAtomicCommitWithPartialUpdate.runMultiThread Full output: http://queues.webkit.org/results/13693245 707428 3 161166 webkit.review.bot 2012-08-29 07:31:52 -0700 Comment on attachment 161166 patch Attachment 161166 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13694241 New failing tests: CCLayerTreeHostTestAtomicCommitWithPartialUpdate.runMultiThread 708157 4 161166 robin.webkit 2012-08-29 18:20:22 -0700 Comment on attachment 161166 patch I believe new failing tests have nothing to do with this patch. 708210 5 161166 webkit.review.bot 2012-08-29 19:07:29 -0700 Comment on attachment 161166 patch Clearing flags on attachment: 161166 Committed r127083: <http://trac.webkit.org/changeset/127083> 708211 6 webkit.review.bot 2012-08-29 19:07:32 -0700 All reviewed patches have been landed. Closing bug. 161166 2012-08-29 02:53:22 -0700 2012-08-29 19:07:29 -0700 patch bug-95317-20120829175311.patch text/plain 6052 robin.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2OTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA5MjIxYzI4YmRiMGM4OWM0ZmQ0N2JiYzIwZmU0NDA3NTdhZTBjMjdlLi5lNDI3ZTk0M2Ri N2Q5YjhmNTJjZDM2OTgyY2VjNmIwMGM4MDQ5NjIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMi0wOC0yOSAgUm9iaW4gQ2FvICA8cm9iaW4uY2Fv QHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tCZXJyeV0gTW92ZSB0aGUgaGFu ZGxpbmcgb2YgVXNlck1lZGlhIHJlcXVlc3RzIHRvIHRoZSBjbGllbnQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1MzE3CisgICAgICAgIFBSICMxOTcy ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnRl cm5hbGx5IHJldmlld2VkIGJ5IEdlb3JnZSBTdGFpa29zLgorCisgICAgICAgIE1vdmUgdGhlIGxv Z2ljIGZvciB1c2VyIG1lZGlhIHJlcXVlc3RzIGhhbmRsaW5nIHRvIHRoZSBjbGllbnQsIGFzIGl0 IHJlcXVpcmVzCisgICAgICAgIGlucHV0cyBmcm9tIHVzZXJzLiBBbHNvIGFkZHMgYSBvcmlnaW4g ZmllbGQgdG8gV2ViVXNlck1lZGlhUmVxdWVzdC4KKworICAgICAgICAqIEFwaS9XZWJQYWdlQ2xp ZW50Lmg6CisgICAgICAgIChQbGF0Zm9ybSk6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvVXNl ck1lZGlhQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpVc2VyTWVkaWFDbGllbnRJ bXBsOjpVc2VyTWVkaWFDbGllbnRJbXBsKToKKyAgICAgICAgKFdlYkNvcmU6OlVzZXJNZWRpYUNs aWVudEltcGw6On5Vc2VyTWVkaWFDbGllbnRJbXBsKToKKyAgICAgICAgKFdlYkNvcmU6OlVzZXJN ZWRpYUNsaWVudEltcGw6OnJlcXVlc3RVc2VyTWVkaWEpOgorICAgICAgICAoV2ViQ29yZTo6VXNl ck1lZGlhQ2xpZW50SW1wbDo6Y2FuY2VsVXNlck1lZGlhUmVxdWVzdCk6CisgICAgICAgICogV2Vi Q29yZVN1cHBvcnQvVXNlck1lZGlhQ2xpZW50SW1wbC5oOgorICAgICAgICAoVXNlck1lZGlhQ2xp ZW50SW1wbCk6CisKIDIwMTItMDgtMjggIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RA Z21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjY5MTQuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaCBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNsaWVudC5oCmluZGV4IGJlNTc0 YTY1Yjk5MmE0NjNiMDY0MWVlNmFjODgxNjc5NTYyY2FjMGIuLmNlZjQzZDkzNzNjODYyYzE0Zjdi NTEwNzc4YjEwMGViNjNlYzU1NzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9BcGkvV2ViUGFnZUNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv V2ViUGFnZUNsaWVudC5oCkBAIC00Myw2ICs0Myw3IEBAIGNsYXNzIEdlb1RyYWNrZXJMaXN0ZW5l cjsKIGNsYXNzIEludFJlY3RSZWdpb247CiBjbGFzcyBOZXR3b3JrUmVxdWVzdDsKIGNsYXNzIE5l dHdvcmtTdHJlYW1GYWN0b3J5OworY2xhc3MgV2ViVXNlck1lZGlhUmVxdWVzdDsKIAogbmFtZXNw YWNlIEdyYXBoaWNzIHsKIGNsYXNzIFdpbmRvdzsKQEAgLTI2OSw2ICsyNzAsOSBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCB2b2lkIHJlZ2lzdGVyUHJvdG9jb2xIYW5kbGVyKGNvbnN0IFdlYlN0cmlu ZyYgLypzY2hlbWUqLywgY29uc3QgV2ViU3RyaW5nJiAvKmJhc2VVUkwqLywgY29uc3QgV2ViU3Ry aW5nJiAvKnVybCovLCBjb25zdCBXZWJTdHJpbmcmIC8qdGl0bGUqLykgPSAwOwogICAgIHZpcnR1 YWwgUHJvdG9jb2xIYW5kbGVyc1N0YXRlIGlzUHJvdG9jb2xIYW5kbGVyUmVnaXN0ZXJlZChjb25z dCBXZWJTdHJpbmcmIC8qc2NoZW1lKi8sIGNvbnN0IFdlYlN0cmluZyYgLypiYXNlVVJMKi8sIGNv bnN0IFdlYlN0cmluZyYgLyp1cmwqLykgPSAwOwogICAgIHZpcnR1YWwgdm9pZCB1bnJlZ2lzdGVy UHJvdG9jb2xIYW5kbGVyKGNvbnN0IFdlYlN0cmluZyYgLypzY2hlbWUqLywgY29uc3QgV2ViU3Ry aW5nJiAvKmJhc2VVUkwqLywgY29uc3QgV2ViU3RyaW5nJiAvKnVybCovKSA9IDA7CisKKyAgICB2 aXJ0dWFsIHZvaWQgcmVxdWVzdFVzZXJNZWRpYShjb25zdCBQbGF0Zm9ybTo6V2ViVXNlck1lZGlh UmVxdWVzdCYpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgY2FuY2VsVXNlck1lZGlhUmVxdWVzdChj b25zdCBQbGF0Zm9ybTo6V2ViVXNlck1lZGlhUmVxdWVzdCYpID0gMDsKIH07CiB9IC8vIG5hbWVz cGFjZSBXZWJLaXQKIH0gLy8gbmFtZXNwYWNlIEJsYWNrQmVycnkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9Vc2VyTWVkaWFDbGllbnRJbXBsLmNw cCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9Vc2VyTWVkaWFDbGll bnRJbXBsLmNwcAppbmRleCBhNGU0NWMyZTU1MmQ4NWU5ZmFhNTI2NjQ5ZGE0Y2IyYjI3MDM5ZGUz Li42YjA5ZjJhNjQxMTNiOWQ1ZGQyNDU1MmZiNzgzODIwOGI0MDY0YmIyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvVXNlck1lZGlhQ2xpZW50SW1w bC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L1VzZXJN ZWRpYUNsaWVudEltcGwuY3BwCkBAIC0yMSwxNCArMjEsMTggQEAKIAogI2lmIEVOQUJMRShNRURJ QV9TVFJFQU0pCiAjaW5jbHVkZSAiTWVkaWFTdHJlYW1EZXNjcmlwdG9yLmgiCisjaW5jbHVkZSAi U2NyaXB0RXhlY3V0aW9uQ29udGV4dC5oIgorI2luY2x1ZGUgIlNlY3VyaXR5T3JpZ2luLmgiCiAj aW5jbHVkZSAiV2ViUGFnZS5oIgorI2luY2x1ZGUgIldlYlBhZ2VDbGllbnQuaCIKIAogI2luY2x1 ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybVdlYk1lZGlhU3RyZWFtRGVzY3JpcHRvci5oPgotI2luY2x1 ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybVdlYlVzZXJNZWRpYS5oPgorI2luY2x1ZGUgPEJsYWNrQmVy cnlQbGF0Zm9ybVdlYlVzZXJNZWRpYVJlcXVlc3QuaD4KICNpbmNsdWRlIDx3dGYvSGFzaE1hcC5o PgogI2luY2x1ZGUgPHd0Zi9Pd25QdHIuaD4KICNpbmNsdWRlIDx3dGYvUGFzc093blB0ci5oPgog I2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KKyNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAK IHVzaW5nIG5hbWVzcGFjZSBCbGFja0JlcnJ5OjpQbGF0Zm9ybTsKIApAQCAtOTUsMTQgKzk5LDEz IEBAIHByaXZhdGU6CiAgICAgUmVmUHRyPFVzZXJNZWRpYVJlcXVlc3Q+IG1fcmVxdWVzdDsKIH07 CiAKLVVzZXJNZWRpYUNsaWVudEltcGw6OlVzZXJNZWRpYUNsaWVudEltcGwoQmxhY2tCZXJyeTo6 V2ViS2l0OjpXZWJQYWdlKikKLSAgICA6IG1fd2ViVXNlck1lZGlhKDApCitVc2VyTWVkaWFDbGll bnRJbXBsOjpVc2VyTWVkaWFDbGllbnRJbXBsKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZSog cGFnZSkKKyAgICA6IG1fcGFnZShwYWdlKQogewogfQogCiBVc2VyTWVkaWFDbGllbnRJbXBsOjp+ VXNlck1lZGlhQ2xpZW50SW1wbCgpCiB7Ci0gICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06OmRlbGV0 ZUd1YXJkZWRPYmplY3QobV93ZWJVc2VyTWVkaWEpOwogfQogCiB2b2lkIFVzZXJNZWRpYUNsaWVu dEltcGw6OnBhZ2VEZXN0cm95ZWQoKQpAQCAtMTE0LDcgKzExNyw4IEBAIHZvaWQgVXNlck1lZGlh Q2xpZW50SW1wbDo6cmVxdWVzdFVzZXJNZWRpYShQYXNzUmVmUHRyPFVzZXJNZWRpYVJlcXVlc3Q+ IHBycFJlcXVlCiAgICAgVXNlck1lZGlhUmVxdWVzdCogcmVxdWVzdCA9IHBycFJlcXVlc3QuZ2V0 KCk7CiAgICAgT3duUHRyPFdlYlVzZXJNZWRpYVJlcXVlc3RDbGllbnRJbXBsPiByZXF1ZXN0Q2xp ZW50ID0gYWRvcHRQdHIobmV3IFdlYlVzZXJNZWRpYVJlcXVlc3RDbGllbnRJbXBsKHBycFJlcXVl c3QpKTsKIAotICAgIHdlYlVzZXJNZWRpYSgpLT5yZXF1ZXN0VXNlck1lZGlhKFdlYlVzZXJNZWRp YVJlcXVlc3QocmVxdWVzdC0+YXVkaW8oKSwgcmVxdWVzdC0+dmlkZW8oKSwgcmVxdWVzdENsaWVu dC5nZXQoKSkpOworICAgIFNlY3VyaXR5T3JpZ2luKiBvcmlnaW4gPSByZXF1ZXN0LT5zY3JpcHRF eGVjdXRpb25Db250ZXh0KCktPnNlY3VyaXR5T3JpZ2luKCk7CisgICAgbV9wYWdlLT5jbGllbnQo KS0+cmVxdWVzdFVzZXJNZWRpYShXZWJVc2VyTWVkaWFSZXF1ZXN0KHJlcXVlc3QtPmF1ZGlvKCks IHJlcXVlc3QtPnZpZGVvKCksIG9yaWdpbi0+dG9TdHJpbmcoKS51dGY4KCkuZGF0YSgpLCByZXF1 ZXN0Q2xpZW50LmdldCgpKSk7CiAgICAgdXNlck1lZGlhUmVxdWVzdHNNYXAoKS5hZGQocmVxdWVz dCwgcmVxdWVzdENsaWVudC5yZWxlYXNlKCkpOwogfQogCkBAIC0xMjQsMTYgKzEyOCwxMCBAQCB2 b2lkIFVzZXJNZWRpYUNsaWVudEltcGw6OmNhbmNlbFVzZXJNZWRpYVJlcXVlc3QoVXNlck1lZGlh UmVxdWVzdCogcmVxdWVzdCkKICAgICBpZiAoaXQgPT0gdXNlck1lZGlhUmVxdWVzdHNNYXAoKS5l bmQoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgd2ViVXNlck1lZGlhKCktPmNhbmNlbFVzZXJN ZWRpYVJlcXVlc3QoV2ViVXNlck1lZGlhUmVxdWVzdChyZXF1ZXN0LT5hdWRpbygpLCByZXF1ZXN0 LT52aWRlbygpLCBpdC0+c2Vjb25kLmdldCgpKSk7CisgICAgU2VjdXJpdHlPcmlnaW4qIG9yaWdp biA9IHJlcXVlc3QtPnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKS0+c2VjdXJpdHlPcmlnaW4oKTsK KyAgICBtX3BhZ2UtPmNsaWVudCgpLT5jYW5jZWxVc2VyTWVkaWFSZXF1ZXN0KFdlYlVzZXJNZWRp YVJlcXVlc3QocmVxdWVzdC0+YXVkaW8oKSwgcmVxdWVzdC0+dmlkZW8oKSwgb3JpZ2luLT50b1N0 cmluZygpLnV0ZjgoKS5kYXRhKCksIGl0LT5zZWNvbmQuZ2V0KCkpKTsKICAgICB1c2VyTWVkaWFS ZXF1ZXN0c01hcCgpLnJlbW92ZShpdCk7CiB9CiAKLUJsYWNrQmVycnk6OlBsYXRmb3JtOjpXZWJV c2VyTWVkaWEqIFVzZXJNZWRpYUNsaWVudEltcGw6OndlYlVzZXJNZWRpYSgpCi17Ci0gICAgaWYg KCFtX3dlYlVzZXJNZWRpYSkKLSAgICAgICAgbV93ZWJVc2VyTWVkaWEgPSBuZXcgV2ViVXNlck1l ZGlhOwotICAgIHJldHVybiBtX3dlYlVzZXJNZWRpYTsKLX0KLQogfQogI2VuZGlmCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvVXNlck1lZGlhQ2xp ZW50SW1wbC5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L1VzZXJN ZWRpYUNsaWVudEltcGwuaAppbmRleCBhMzEyMzNiODYzNDBiYjBlZDJjZTVhMDUzYmNiMTlhNmNl ZDQ4MDllLi5mNzZjYjNkNTY5YjljN2U5Njc4MDQxNTA3Y2IwOTNiOTQzMmQ1Yjk3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvVXNlck1lZGlhQ2xp ZW50SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9V c2VyTWVkaWFDbGllbnRJbXBsLmgKQEAgLTMwLDEwICszMCw2IEBAIG5hbWVzcGFjZSBCbGFja0Jl cnJ5IHsKIG5hbWVzcGFjZSBXZWJLaXQgewogY2xhc3MgV2ViUGFnZTsKIH0KLQotbmFtZXNwYWNl IFBsYXRmb3JtIHsKLWNsYXNzIFdlYlVzZXJNZWRpYTsKLX0KIH0KIAogbmFtZXNwYWNlIFdlYkNv cmUgewpAQCAtNTEsOSArNDcsOCBAQCBwdWJsaWM6CiAKIHByaXZhdGU6CiAgICAgVXNlck1lZGlh Q2xpZW50SW1wbCgpOwotICAgIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpXZWJVc2VyTWVkaWEqIHdl YlVzZXJNZWRpYSgpOwogCi0gICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06OldlYlVzZXJNZWRpYSog bV93ZWJVc2VyTWVkaWE7CisgICAgQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlKiBtX3BhZ2U7 CiB9OwogCiB9Cg==