95315 2012-08-29 02:08:59 -0700 Web Inspector: unsafe static_cast in RetainedDOMInfo::IsEquivalent 2012-08-29 04:52:59 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 yurys yurys abarth alph apavlov bweinstein haraken japhet joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 707231 0 yurys 2012-08-29 02:08:59 -0700 Before casting v8::RetainedObjectInfo to WebCore::RetainedObjectInfo we should check if it is an instance of WebCore::RetainedObjectInfo as it may happen to be an instance of v8::internal::NativeGroupRetainedObjectInfo. This check can be accomplished by comparing labels of the two objects as the labels should be unique for retained groups. 707232 1 161163 yurys 2012-08-29 02:14:28 -0700 Created attachment 161163 Patch 707233 2 161163 loislo 2012-08-29 02:15:53 -0700 Comment on attachment 161163 Patch lgtm 707323 3 161163 webkit.review.bot 2012-08-29 04:52:56 -0700 Comment on attachment 161163 Patch Clearing flags on attachment: 161163 Committed r126989: <http://trac.webkit.org/changeset/126989> 707324 4 webkit.review.bot 2012-08-29 04:52:59 -0700 All reviewed patches have been landed. Closing bug. 161163 2012-08-29 02:14:28 -0700 2012-08-29 04:52:55 -0700 Patch bug-95315-20120829131418.patch text/plain 1752 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2OTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmE3NjU2Y2Q2NTBmYzJm ODU3ZWY4ZGIxNGZkMzQ1NWIyYzExZDM4MS4uYmQyMzA4OWJkYjg0OTFlMzJjOWNiYWUwODQzZDcz YTM0NDZhYjEzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTI5ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHVuc2FmZSBzdGF0aWNfY2FzdCBpbiBSZXRhaW5lZERPTUluZm86OklzRXF1aXZhbGVudAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTUzMTUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdz L3Y4L1JldGFpbmVkRE9NSW5mby5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXRhaW5lZERPTUlu Zm86OklzRXF1aXZhbGVudCk6IGNvbXBhcmUgcmV0YWluZWQgb2JqZWN0IGluZm8KKyAgICAgICAg bGFiZWxzIGJlZm9yZSBjYXN0aW5nIHY4OjpSZXRhaW5lZE9iamVjdEluZm8gdG8gV2ViQ29yZTo6 UmV0YWluZWRPYmplY3RJbmZvCisgICAgICAgIGFzIHRoZSB8b3RoZXJ8IG9iamVjdCBtYXkgbm90 IGJlIGEgZGVzY2VuZGFudCBvZiBXZWJDb3JlOjpSZXRhaW5lZE9iamVjdEluZm8uCisKIDIwMTIt MDgtMjkgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjY5NjMuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9SZXRhaW5lZERPTUluZm8uY3BwIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvUmV0YWluZWRET01JbmZvLmNwcAppbmRleCBiMTI5NjlmYzczZGY3ODk0MjRi NWJiMmUzYTgxMTQ3Zjg5ZWMzZmQ2Li42YmM3ZDgyZDAwNTllZGIxN2M3YTdlYThhY2UzNjk1YWEz Yzk0M2E5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9SZXRhaW5lZERP TUluZm8uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1JldGFpbmVkRE9NSW5m by5jcHAKQEAgLTUzLDcgKzUzLDExIEBAIHZvaWQgUmV0YWluZWRET01JbmZvOjpEaXNwb3NlKCkK IGJvb2wgUmV0YWluZWRET01JbmZvOjpJc0VxdWl2YWxlbnQodjg6OlJldGFpbmVkT2JqZWN0SW5m byogb3RoZXIpCiB7CiAgICAgQVNTRVJUKG90aGVyKTsKLSAgICByZXR1cm4gb3RoZXIgPT0gdGhp cyB8fCBzdGF0aWNfY2FzdDxXZWJDb3JlOjpSZXRhaW5lZE9iamVjdEluZm8qPihvdGhlciktPkdl dEVxdWl2YWxlbmNlQ2xhc3MoKSA9PSB0aGlzLT5HZXRFcXVpdmFsZW5jZUNsYXNzKCk7CisgICAg aWYgKG90aGVyID09IHRoaXMpCisgICAgICAgIHJldHVybiB0cnVlOworICAgIGlmIChzdHJjbXAo R2V0TGFiZWwoKSwgb3RoZXItPkdldExhYmVsKCkpKQorICAgICAgICByZXR1cm4gZmFsc2U7Cisg ICAgcmV0dXJuIHN0YXRpY19jYXN0PFdlYkNvcmU6OlJldGFpbmVkT2JqZWN0SW5mbyo+KG90aGVy KS0+R2V0RXF1aXZhbGVuY2VDbGFzcygpID09IHRoaXMtPkdldEVxdWl2YWxlbmNlQ2xhc3MoKTsK IH0KIAogaW50cHRyX3QgUmV0YWluZWRET01JbmZvOjpHZXRIYXNoKCkK