95293 2012-08-28 23:30:20 -0700 [chromium] Use floating point literals in expressions that initialize floats 2012-08-29 09:21:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth cc-bugs danakj dglazkov enne webkit.review.bot oldest_to_newest 707132 0 jamesr 2012-08-28 23:30:20 -0700 [chromium] Use floating point literals in expressions that initialize floats 707133 1 161144 jamesr 2012-08-28 23:32:49 -0700 Created attachment 161144 Patch 707148 2 161144 abarth 2012-08-28 23:54:06 -0700 Comment on attachment 161144 Patch This is technically against WebKit style, but given that this code is going to GTFO, this seems fine. 707218 3 161144 webkit.review.bot 2012-08-29 01:42:36 -0700 Comment on attachment 161144 Patch Attachment 161144 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13690106 New failing tests: CCLayerTreeHostTestAtomicCommitWithPartialUpdate.runMultiThread 707278 4 161144 webkit.review.bot 2012-08-29 03:51:53 -0700 Comment on attachment 161144 Patch Clearing flags on attachment: 161144 Committed r126981: <http://trac.webkit.org/changeset/126981> 707279 5 webkit.review.bot 2012-08-29 03:51:56 -0700 All reviewed patches have been landed. Closing bug. 707446 6 danakj 2012-08-29 07:51:17 -0700 For those of us not building with VS, should we always be using f suffix? It surprises me that these are the only double literal->float truncations in our code base, are these somehow special? 707465 7 abarth 2012-08-29 08:24:00 -0700 > For those of us not building with VS, should we always be using f suffix? Nope. > It surprises me that these are the only double literal->float truncations in our code base, are these somehow special? They're special because we're in the process of moving this code out of WebKit to a location where more warnings are enabled. 707471 8 danakj 2012-08-29 08:27:41 -0700 (In reply to comment #7) > > For those of us not building with VS, should we always be using f suffix? > > Nope. > > > It surprises me that these are the only double literal->float truncations in our code base, are these somehow special? > > They're special because we're in the process of moving this code out of WebKit to a location where more warnings are enabled. Right, I am wondering about future compositor code, not WebKit :) For example we have tons of things like FloatPoint(0.5, 0) in our tests. These are using a double literal for a float as well, but are not causing compiler warnings? 707519 9 jamesr 2012-08-29 09:21:47 -0700 The WebKit style is "use f if you need to force floating-point math". In this instances, we need to force floating point math or MSVS warns (somewhat correctly) that the narrowing conversion is lossly. Initializing to 0.5, 0 probably doesn't need anything since 0.5 and 0 are exactly representable as doubles and floats, so it's not lossy. I'm guessing that since 0.1, 0.01, and 0.95 do not have exact representations as doubles or floats, and the float representation is not equivalent to the double representation, the compiler is less happy. 161144 2012-08-28 23:32:49 -0700 2012-08-29 03:51:53 -0700 Patch bug-95293-20120828233240.patch text/plain 3038 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2OTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjc3NTNlNGZkM2VjNjFk ZGVmYWIyZjZmNjQ3MjQzMzgyODdiMThiZS4uMTJkZGZlYmI3NzQxOTE4OGM0ZDFmMWE5ZWRiZmQ0 YjQyNmE3Y2JhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTI4ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBV c2UgZmxvYXRpbmcgcG9pbnQgbGl0ZXJhbHMgaW4gZXhwcmVzc2lvbnMgdGhhdCBpbml0aWFsaXpl IGZsb2F0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTUyOTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBW aXN1YWwgc3R1ZGlvJ3MgQzQzMDUsIHdoaWNoIGlzIG9uIGZvciBzb21lIGNocm9taXVtIGNvZGUs IGNvbXBsYWlucyBhYm91dCB0aGVzZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL2NjL0NDTGF5ZXJTb3J0ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q0NMYXllclNv cnRlcjo6Y3JlYXRlR3JhcGhFZGdlcyk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vY2MvQ0NMYXllclRyZWVIb3N0SW1wbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQ0xh eWVyVHJlZUhvc3RJbXBsOjpzY3JvbGxCeSk6CisgICAgICAgIChXZWJDb3JlOjpDQ0xheWVyVHJl ZUhvc3RJbXBsOjpjb21wdXRlUGluY2hab29tRGVsdGFzKToKKwogMjAxMi0wOC0yOCAgVG9tIFNl cGV6ICA8dHNlcGV6QGNocm9taXVtLm9yZz4KIAogICAgICAgICBDU1AgZG9lc24ndCB0dXJuIG9m ZiBldmFsLCBldGMuIGluIFdlYiBXb3JrZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyU29ydGVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJTb3J0ZXIuY3BwCmlu ZGV4IGM1MjQwY2M0MTBkYWZmNGViMjEzNGMyYmYyZWZjNmY5OGNlMDg2MGIuLjQwZGQ3NzczNGI3 M2UyZjhjODA5ODM0ODgyNGQ1ZmQ4MGI4ZmY0OGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJTb3J0ZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJTb3J0ZXIu Y3BwCkBAIC0yNjQsNyArMjY0LDcgQEAgdm9pZCBDQ0xheWVyU29ydGVyOjpjcmVhdGVHcmFwaEVk Z2VzKCkKICNlbmRpZgogICAgIC8vIEZyYWN0aW9uIG9mIHRoZSB0b3RhbCB6UmFuZ2UgYmVsb3cg d2hpY2ggeiBkaWZmZXJlbmNlcwogICAgIC8vIGFyZSBub3QgY29uc2lkZXJlZCByZWxpYWJsZS4K LSAgICBjb25zdCBmbG9hdCB6VGhyZXNob2xkRmFjdG9yID0gMC4wMTsKKyAgICBjb25zdCBmbG9h dCB6VGhyZXNob2xkRmFjdG9yID0gMC4wMWY7CiAgICAgZmxvYXQgelRocmVzaG9sZCA9IG1felJh bmdlICogelRocmVzaG9sZEZhY3RvcjsKIAogICAgIGZvciAodW5zaWduZWQgbmEgPSAwOyBuYSA8 IG1fbm9kZXMuc2l6ZSgpOyBuYSsrKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdElt cGwuY3BwCmluZGV4IDkxODMzYWYxZjQzMzkzMmRmMjUwMGJkNDVkYmQxZThhYjdhYTM5ZGYuLmI3 YjAxZTY5NTk2ZDk0MzlhZGI4YTY1ZmY5MGQ2NWQ5Y2Y1OGRkNTkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdElt cGwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2Nj L0NDTGF5ZXJUcmVlSG9zdEltcGwuY3BwCkBAIC05NzYsNyArOTc2LDcgQEAgdm9pZCBDQ0xheWVy VHJlZUhvc3RJbXBsOjpzY3JvbGxCeShjb25zdCBJbnRQb2ludCYgdmlld3BvcnRQb2ludCwgY29u c3QgSW50U2l6ZSYKICAgICAgICAgICAgIGFwcGxpZWREZWx0YSA9IHNjcm9sbExheWVyV2l0aExv Y2FsRGVsdGEoKmxheWVySW1wbCwgcGVuZGluZ0RlbHRhKTsKIAogICAgICAgICAvLyBJZiB0aGUg bGF5ZXIgd2Fzbid0IGFibGUgdG8gbW92ZSwgdHJ5IHRoZSBuZXh0IG9uZSBpbiB0aGUgaGllcmFy Y2h5LgotICAgICAgICBmbG9hdCBtb3ZlVGhyZXNob2xkU3F1YXJlZCA9IDAuMSAqIDAuMTsKKyAg ICAgICAgZmxvYXQgbW92ZVRocmVzaG9sZFNxdWFyZWQgPSAwLjFmICogMC4xZjsKICAgICAgICAg aWYgKGFwcGxpZWREZWx0YS5kaWFnb25hbExlbmd0aFNxdWFyZWQoKSA8IG1vdmVUaHJlc2hvbGRT cXVhcmVkKQogICAgICAgICAgICAgY29udGludWU7CiAKQEAgLTEwNzgsNyArMTA3OCw3IEBAIHZv aWQgQ0NMYXllclRyZWVIb3N0SW1wbDo6Y29tcHV0ZVBpbmNoWm9vbURlbHRhcyhDQ1Njcm9sbEFu ZFNjYWxlU2V0KiBzY3JvbGxJbmZvCiAgICAgLy8gT25seSBzZW5kIGZha2Ugc2Nyb2xsL3pvb20g ZGVsdGFzIGlmIHdlJ3JlIHBpbmNoIHpvb21pbmcgb3V0IGJ5IGEKICAgICAvLyBzaWduaWZpY2Fu dCBhbW91bnQuIFRoaXMgYWxzbyBlbnN1cmVzIG9ubHkgb25lIGZha2UgZGVsdGEgc2V0IHdpbGwg YmUKICAgICAvLyBzZW50LgotICAgIGNvbnN0IGZsb2F0IHBpbmNoWm9vbU91dFNlbnNpdGl2aXR5 ID0gMC45NTsKKyAgICBjb25zdCBmbG9hdCBwaW5jaFpvb21PdXRTZW5zaXRpdml0eSA9IDAuOTVm OwogICAgIGlmIChtX3BhZ2VTY2FsZURlbHRhID4gcGluY2hab29tT3V0U2Vuc2l0aXZpdHkpCiAg ICAgICAgIHJldHVybjsKIAo=