95275 2012-08-28 18:16:08 -0700 [Chromium] Update some compositor trace events 2012-08-28 20:55:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbates jbates cc-bugs jamesr webkit.review.bot oldest_to_newest 706957 0 jbates 2012-08-28 18:16:08 -0700 [Chromium] Update some compositor trace events 706958 1 161107 jbates 2012-08-28 18:16:40 -0700 Created attachment 161107 Patch 706959 2 jbates 2012-08-28 18:17:08 -0700 ptal 706963 3 161107 jamesr 2012-08-28 18:21:16 -0700 Comment on attachment 161107 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161107&action=review > Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp:84 > - TRACE_EVENT1("cc", "CCFrameRateController::setActive", "active", active); > if (m_active == active) > return; > + TRACE_EVENT1("cc", "CCFrameRateController::setActive", "active", active); so is the thread code now working (https://bugs.webkit.org/show_bug.cgi?id=93918#c3) ? > Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp:331 > + TRACE_EVENT2("cc", "CCThreadProxy::onVSyncParametersChanged", "monotonicTimebase", monotonicTimebase, "intervalInSeconds", intervalInSeconds); Hm, the tracing code can take doubles? That's nice - but the type of the value parameter looks like unsigned long long to me. Do we need any casts? 706990 4 jbates 2012-08-28 19:02:47 -0700 (In reply to comment #3) > (From update of attachment 161107 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=161107&action=review > > > Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp:84 > > - TRACE_EVENT1("cc", "CCFrameRateController::setActive", "active", active); > > if (m_active == active) > > return; > > + TRACE_EVENT1("cc", "CCFrameRateController::setActive", "active", active); > > so is the thread code now working (https://bugs.webkit.org/show_bug.cgi?id=93918#c3) ? yeah, I found the issue a while ago. > > > Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp:331 > > + TRACE_EVENT2("cc", "CCThreadProxy::onVSyncParametersChanged", "monotonicTimebase", monotonicTimebase, "intervalInSeconds", intervalInSeconds); > > Hm, the tracing code can take doubles? That's nice - but the type of the value parameter looks like unsigned long long to me. Do we need any casts? double should go through - the macros reinterpret it to/from unsigned long long. 707038 5 161107 jamesr 2012-08-28 20:15:36 -0700 Comment on attachment 161107 Patch OK 707052 6 161107 webkit.review.bot 2012-08-28 20:55:20 -0700 Comment on attachment 161107 Patch Clearing flags on attachment: 161107 Committed r126954: <http://trac.webkit.org/changeset/126954> 707053 7 webkit.review.bot 2012-08-28 20:55:23 -0700 All reviewed patches have been landed. Closing bug. 161107 2012-08-28 18:16:40 -0700 2012-08-28 20:55:20 -0700 Patch bug-95275-20120828181631.patch text/plain 2540 jbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2MzZDY3MTAzYzJhZDkx ZWMxMTQ1M2IxOWRiM2QyOGJhYWFiMWZiZi4uNWUzYWNhYzA0NTZiZWFlODQ4MWVlMGNiM2M1OTZh ZDIzN2VmOTExYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTI4ICBKb2hu IEJhdGVzICA8amJhdGVzQGdvb2dsZS5jb20+CisKKyAgICAgICAgW0Nocm9taXVtXSBVcGRhdGUg c29tZSBjb21wb3NpdG9yIHRyYWNlIGV2ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTUyNzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDRnJh bWVSYXRlQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQ0ZyYW1lUmF0ZUNvbnRy b2xsZXI6OnNldEFjdGl2ZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v Y2MvQ0NUaHJlYWRQcm94eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQ1RocmVhZFByb3h5Ojpv blZTeW5jUGFyYW1ldGVyc0NoYW5nZWQpOgorCiAyMDEyLTA4LTIyICBBbmRyZXkgQWRhaWtpbiAg PGFhbmRyZXlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtXZWJHTF0g R2VuZXJpYyBmcmFtZXdvcmsgZHJhZnQgZm9yIHRyYWNraW5nIFdlYkdMIHJlc291cmNlcwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NG cmFtZVJhdGVDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL2NjL0NDRnJhbWVSYXRlQ29udHJvbGxlci5jcHAKaW5kZXggNWIwMGZlZjc5ZGRi ZTM4YjQwNzRkNTFkNGI0MjE2ZjMyMDQ1MmYwZi4uOWQ2ZmM5ZmFmZjlkM2IyZThjM2NlYzk0YzM4 NjNkMGNiMzBkNzZkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vY2MvQ0NGcmFtZVJhdGVDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0ZyYW1lUmF0ZUNvbnRyb2xsZXIu Y3BwCkBAIC03OSw5ICs3OSw5IEBAIENDRnJhbWVSYXRlQ29udHJvbGxlcjo6fkNDRnJhbWVSYXRl Q29udHJvbGxlcigpCiAKIHZvaWQgQ0NGcmFtZVJhdGVDb250cm9sbGVyOjpzZXRBY3RpdmUoYm9v bCBhY3RpdmUpCiB7Ci0gICAgVFJBQ0VfRVZFTlQxKCJjYyIsICJDQ0ZyYW1lUmF0ZUNvbnRyb2xs ZXI6OnNldEFjdGl2ZSIsICJhY3RpdmUiLCBhY3RpdmUpOwogICAgIGlmIChtX2FjdGl2ZSA9PSBh Y3RpdmUpCiAgICAgICAgIHJldHVybjsKKyAgICBUUkFDRV9FVkVOVDEoImNjIiwgIkNDRnJhbWVS YXRlQ29udHJvbGxlcjo6c2V0QWN0aXZlIiwgImFjdGl2ZSIsIGFjdGl2ZSk7CiAgICAgbV9hY3Rp dmUgPSBhY3RpdmU7CiAKICAgICBpZiAobV9pc1RpbWVTb3VyY2VUaHJvdHRsaW5nKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NUaHJl YWRQcm94eS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9j Yy9DQ1RocmVhZFByb3h5LmNwcAppbmRleCAyOTdiMTM1NjMyMDNhMzBmOTA1ZDRlNTYxNDY4ZGI1 MGRlMGUzYmJlLi4wNDU1OGZmOGE3YTc4ZjYwY2Y5MmQxODM1NGU4ZGVmZDIwNDNjY2ZiIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1Ro cmVhZFByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9jYy9DQ1RocmVhZFByb3h5LmNwcApAQCAtMzI4LDcgKzMyOCw3IEBAIHZvaWQgQ0NUaHJl YWRQcm94eTo6b25Td2FwQnVmZmVyc0NvbXBsZXRlT25JbXBsVGhyZWFkKCkKIHZvaWQgQ0NUaHJl YWRQcm94eTo6b25WU3luY1BhcmFtZXRlcnNDaGFuZ2VkKGRvdWJsZSBtb25vdG9uaWNUaW1lYmFz ZSwgZG91YmxlIGludGVydmFsSW5TZWNvbmRzKQogewogICAgIEFTU0VSVChpc0ltcGxUaHJlYWQo KSk7Ci0gICAgVFJBQ0VfRVZFTlQwKCJjYyIsICJDQ1RocmVhZFByb3h5OjpvblZTeW5jUGFyYW1l dGVyc0NoYW5nZWQiKTsKKyAgICBUUkFDRV9FVkVOVDIoImNjIiwgIkNDVGhyZWFkUHJveHk6Om9u VlN5bmNQYXJhbWV0ZXJzQ2hhbmdlZCIsICJtb25vdG9uaWNUaW1lYmFzZSIsIG1vbm90b25pY1Rp bWViYXNlLCAiaW50ZXJ2YWxJblNlY29uZHMiLCBpbnRlcnZhbEluU2Vjb25kcyk7CiAgICAgbV9z Y2hlZHVsZXJPbkltcGxUaHJlYWQtPnNldFRpbWViYXNlQW5kSW50ZXJ2YWwobW9ub3RvbmljVGlt ZWJhc2UsIGludGVydmFsSW5TZWNvbmRzKTsKIH0KIAo=