95266 2012-08-28 16:59:32 -0700 check-webkit-style gets confused when a function returns PassRefPtr 2015-01-06 14:42:07 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 achicu webkit-unassigned burg kling michelangelo oldest_to_newest 706888 0 achicu 2012-08-28 16:59:32 -0700 The following line confuses the style checker. I assume this is related to the patch context, as I cannot reproduce the issue without that specific patch. PassRefPtr<CustomFilterParameter> StyleResolver::parseCustomFilterTransformParameter(const String& name, CSSValueList* values) https://bugs.webkit.org/show_bug.cgi?id=71401#c8 Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3..." exit_code: 1 Source/WebCore/css/StyleResolver.cpp:5264: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Source/WebCore/css/StyleResolver.cpp:5273: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Total errors found: 2 in 20 files 1059172 1 burg 2015-01-06 14:42:07 -0800 PassRefPtr is deprecated, and this style check will be removed soon.