95265 2012-08-28 16:54:42 -0700 Added ANDROID_GDBSERVER definition for Ant 2012-09-03 11:36:46 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Android RESOLVED FIXED P2 Normal --- 1 michaelbai michaelbai abarth dglazkov japhet peter peter+ews webkit.review.bot oldest_to_newest 706885 0 michaelbai 2012-08-28 16:54:42 -0700 Added ANDROID_GDBSERVER definition, it will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN is only used for finding the gdbserver. 706904 1 161097 michaelbai 2012-08-28 17:11:07 -0700 Created attachment 161097 Patch 706999 2 161097 peter+ews 2012-08-28 19:22:46 -0700 Comment on attachment 161097 Patch Attachment 161097 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13683005 707262 3 peter 2012-08-29 03:16:24 -0700 Patch LGTM, but we can't land this yet. In the future you can consider using the "[Chromium]" prefix to bug titles for changes which only touch Chromium-specific code. There unfortunately is a three-way process to introduce new gyp variables, because of a circular dependency between Chromium and WebKit. The first step would be to introduce the variable in envsetup_functions.sh and add it to the GYP_DEFINES section. Then, after Chromium rolls into WebKit (which will happen roughly once per two days), this patch has to land. It should be fine to go in as it is. The last step is to wait until WebKit rolls into Chromium (which happens several times per day), after which you can start using the new variable. 709719 4 michaelbai 2012-08-31 09:33:02 -0700 Hi Peter, The chromium side CL was landed, Would you like help to commit this? 709724 5 peter 2012-08-31 09:41:41 -0700 I'll land this on Monday, as the relevant Chromium revision has to roll into WebKit as well. Adam/Nate, could you review this please? It looks good to me :-). 710181 6 161097 abarth 2012-09-01 00:43:41 -0700 Comment on attachment 161097 Patch Sure. rs=me 710720 7 161097 peter 2012-09-03 11:13:43 -0700 Comment on attachment 161097 Patch Thanks, Adam! This should work fine now. 710728 8 161097 webkit.review.bot 2012-09-03 11:36:42 -0700 Comment on attachment 161097 Patch Clearing flags on attachment: 161097 Committed r127430: <http://trac.webkit.org/changeset/127430> 710729 9 webkit.review.bot 2012-09-03 11:36:46 -0700 All reviewed patches have been landed. Closing bug. 161097 2012-08-28 17:11:07 -0700 2012-09-03 11:36:42 -0700 Patch bug-95265-20120828171058.patch text/plain 3902 michaelbai U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2OTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGQzMDZhNGVmZWUwMmJhN2RkNmY3Y2E4NmVjYTVkMjI1YmYzZGY1MmIuLjQ5MmRiMDRjMTY5Zjll ZDhmMTQ2YWZhMjEyNDkzNDkyM2FlM2I3MjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDgtMjggIFRhbyBCYWkgIDxtaWNoYWVsYmFpQGNocm9taXVt Lm9yZz4KKworICAgICAgICBBZGRlZCBBTkRST0lEX0dEQlNFUlZFUiBkZWZpbml0aW9uIGZvciBB bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1MjY1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQU5EUk9J RF9HREJTRVJWRVIgd2lsbCByZXBsYWNlIEFORFJPSURfVE9PTENIQUlOLCBiZWNhdXNlIHRoZSBB TkRST0lEX1RPT0xDSEFJTgorICAgICAgICBpcyBvbmx5IHVzZWQgZm9yIGZpbmRpbmcgdGhlIGdk YnNlcnZlci4KKworICAgICAgICAqIFdlYktpdFVuaXRUZXN0cy5neXA6CisKIDIwMTItMDgtMjgg IFcuIEphbWVzIE1hY0xlYW4gIDx3am1hY2xlYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtj aHJvbWl1bV0gRHJhc3RpY2FsbHkgc2hvcnRlbiB0aGUgbGluayBoaWdobGlnaHQgZHVyYXRpb24u CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdFVuaXRUZXN0cy5neXAg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdFVuaXRUZXN0cy5neXAKaW5kZXggYTc3Mzky ZWY0NTk1MTAwODE2OTNmMzdjMTdhNjQzMzlmMGQ4NThiOC4uZjZiMGVlZmI3Njc4MjBlNzBkNDIw NWVlM2M1MTUzMWEyZDQ0YmM0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9X ZWJLaXRVbml0VGVzdHMuZ3lwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0VW5p dFRlc3RzLmd5cApAQCAtMTkwLDYgKzE5MCw4IEBACiAgICAgICAgICAgICAgICAgICAgICAgICAn LS1hbnQtYXJncycsCiAgICAgICAgICAgICAgICAgICAgICAgICAnLURBTkRST0lEX1RPT0xDSEFJ Tj08KGFuZHJvaWRfdG9vbGNoYWluKScsCiAgICAgICAgICAgICAgICAgICAgICAgICAnLS1hbnQt YXJncycsCisgICAgICAgICAgICAgICAgICAgICAgICAnLURBTkRST0lEX0dEQlNFUlZFUj08KGFu ZHJvaWRfZ2Ric2VydmVyKScsCisgICAgICAgICAgICAgICAgICAgICAgICAnLS1hbnQtYXJncycs CiAgICAgICAgICAgICAgICAgICAgICAgICAnLURQUk9EVUNUX0RJUj08KGFudF9idWlsZF9vdXQp JywKICAgICAgICAgICAgICAgICAgICAgICAgICctLWFudC1hcmdzJywKICAgICAgICAgICAgICAg ICAgICAgICAgICctRENIUk9NSVVNX1NSQz08KGFudF9idWlsZF90b19jaHJvbWl1bV9zcmMpJywK ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyZWQ3 ZTNjMTJjZDE4OGJjNzg5MWExZmIzN2I2ZmY4YmY4ZjBlMmIxLi5iNThkZTJiNjdiODEyOTE2ODI0 ZTIwZjk2MTk5YjBjNzQ5NTY5MjNkIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDgtMjggIFRhbyBCYWkgIDxt aWNoYWVsYmFpQGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGRlZCBBTkRST0lEX0dEQlNFUlZF UiBkZWZpbml0aW9uIGZvciBBbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk1MjY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQU5EUk9JRF9HREJTRVJWRVIgd2lsbCByZXBsYWNlIEFORFJPSURfVE9PTENI QUlOLCBiZWNhdXNlIHRoZSBBTkRST0lEX1RPT0xDSEFJTgorICAgICAgICBpcyBvbmx5IHVzZWQg Zm9yIGZpbmRpbmcgdGhlIGdkYnNlcnZlci4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL0R1 bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZS5neXA6CisgICAgICAgICogVGVzdFdlYktp dEFQSS9UZXN0V2ViS2l0QVBJLmd5cC9UZXN0V2ViS2l0QVBJLmd5cDoKKwogMjAxMi0wOC0yNyAg Sm9uIExlZSAgPGpvbmxlZUBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIFRlc3RSdW5uZXIg QVBJIGZvciB3ZWIgbm90aWZpY2F0aW9ucwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRy ZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cCBiL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZS5neXAKaW5kZXggODI3N2Nl MzVmMmIwYWE4ZGY4NmVjOWMyM2VjOGIwYWFlMDA1YTA5YS4uM2Y3NDIyOTc4YzlmZGMzZmQzMTdh MzJiNzExNjBkMTI4ZjQ0ZWIxZSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvRHVt cFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cAorKysgYi9Ub29scy9EdW1wUmVuZGVy VHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwCkBAIC01MDcsNiArNTA3 LDggQEAKICAgICAgICAgICAgICAgICAgICAgICAgICctLWFudC1hcmdzJywKICAgICAgICAgICAg ICAgICAgICAgICAgICctREFORFJPSURfVE9PTENIQUlOPTwoYW5kcm9pZF90b29sY2hhaW4pJywK ICAgICAgICAgICAgICAgICAgICAgICAgICctLWFudC1hcmdzJywKKyAgICAgICAgICAgICAgICAg ICAgICAgICctREFORFJPSURfR0RCU0VSVkVSPTwoYW5kcm9pZF9nZGJzZXJ2ZXIpJywKKyAgICAg ICAgICAgICAgICAgICAgICAgICctLWFudC1hcmdzJywKICAgICAgICAgICAgICAgICAgICAgICAg ICctRFBST0RVQ1RfRElSPTwoYW50X2J1aWxkX291dCknLAogICAgICAgICAgICAgICAgICAgICAg ICAgJy0tYW50LWFyZ3MnLAogICAgICAgICAgICAgICAgICAgICAgICAgJy1EQ0hST01JVU1fU1JD PTwoYW50X2J1aWxkX3RvX2Nocm9taXVtX3NyYyknLApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0V2ViS2l0QVBJLmd5cC9UZXN0V2ViS2l0QVBJLmd5cCBiL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdFdlYktpdEFQSS5neXAvVGVzdFdlYktpdEFQSS5neXAKaW5kZXggODE5YTc5 ZDBkYmIyOGNhY2IzOGM2ZmRiZGM2NzY0NzFlYmZhMzk3Ny4uMzFkMzBlNTNlOWNkMzllYzg2N2Q0 ODRkNzEyNTNiNzhiYmZjNjA5OCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 V2ViS2l0QVBJLmd5cC9UZXN0V2ViS2l0QVBJLmd5cAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RXZWJLaXRBUEkuZ3lwL1Rlc3RXZWJLaXRBUEkuZ3lwCkBAIC0xNTAsNiArMTUwLDggQEAK ICAgICAgICAgICAgICAgICAgICAgICAgICctLWFudC1hcmdzJywKICAgICAgICAgICAgICAgICAg ICAgICAgICctREFORFJPSURfVE9PTENIQUlOPTwoYW5kcm9pZF90b29sY2hhaW4pJywKICAgICAg ICAgICAgICAgICAgICAgICAgICctLWFudC1hcmdzJywKKyAgICAgICAgICAgICAgICAgICAgICAg ICctREFORFJPSURfR0RCU0VSVkVSPTwoYW5kcm9pZF9nZGJzZXJ2ZXIpJywKKyAgICAgICAgICAg ICAgICAgICAgICAgICctLWFudC1hcmdzJywKICAgICAgICAgICAgICAgICAgICAgICAgICctRFBS T0RVQ1RfRElSPTwoYW50X2J1aWxkX291dCknLAogICAgICAgICAgICAgICAgICAgICAgICAgJy0t YW50LWFyZ3MnLAogICAgICAgICAgICAgICAgICAgICAgICAgJy1EQ0hST01JVU1fU1JDPTwoYW50 X2J1aWxkX3RvX2Nocm9taXVtX3NyYyknLAo=