95249 2012-08-28 14:46:50 -0700 [Mac] Add iconURL to WebNotification 2012-08-29 10:12:06 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac OS X 10.8 RESOLVED FIXED InRadar P2 Normal --- 77969 95232 1 jonlee jonlee ap jberlin webkit-bug-importer oldest_to_newest 706751 0 jonlee 2012-08-28 14:46:50 -0700 On the WK1 side WebNotification was missing an accessor to the notification's iconURL. It is already available on WK2. 706752 1 webkit-bug-importer 2012-08-28 14:47:02 -0700 <rdar://problem/12192060> 706758 2 161065 jonlee 2012-08-28 14:51:38 -0700 Created attachment 161065 Patch 707526 3 161065 ap 2012-08-29 09:32:39 -0700 Comment on attachment 161065 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161065&action=review > Source/WebKit/mac/WebView/WebNotification.mm:118 > + ASSERT(core(self)); > + return core(self)->iconURL(); I'm not sure if this kind of ASSERT is useful. We'd get a very unambiguous crash in actual code, so there is no need to help debugging by adding the assertion. 707572 4 jonlee 2012-08-29 10:06:16 -0700 (In reply to comment #3) > (From update of attachment 161065 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=161065&action=review > > > Source/WebKit/mac/WebView/WebNotification.mm:118 > > + ASSERT(core(self)); > > + return core(self)->iconURL(); > > I'm not sure if this kind of ASSERT is useful. We'd get a very unambiguous crash in actual code, so there is no need to help debugging by adding the assertion. I can remove it, as well as all the other instances in the file. 707587 5 jonlee 2012-08-29 10:12:06 -0700 Committed r127009: <http://trac.webkit.org/changeset/127009> 161065 2012-08-28 14:51:38 -0700 2012-08-29 09:32:39 -0700 Patch bug-95249-20120828145129.patch text/plain 1863 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2OTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggN2QxOTIzNDNm ZWYyY2M3N2EzYjI2ZTg5N2Y0YjFiNjMxYzQ4NjQ3My4uZThjMjlmMzU3ODFjZDE0MTZkYzdkNzNi MzczM2RkZmQwNTY4NTYzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEy LTA4LTI4ICBKb24gTGVlICA8am9ubGVlQGFwcGxlLmNvbT4KKworICAgICAgICBbTWFjXSBBZGQg aWNvblVSTCB0byBXZWJOb3RpZmljYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk1MjQ5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMjE5MjA2 MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdl YlZpZXcvV2ViTm90aWZpY2F0aW9uLmg6IEV4cG9zZSBpY29uVVJMLgorICAgICAgICAqIFdlYlZp ZXcvV2ViTm90aWZpY2F0aW9uLm1tOgorICAgICAgICAoLVtXZWJOb3RpZmljYXRpb24gaWNvblVS TF0pOgorCiAyMDEyLTA4LTI4ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWls LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTI2OTE0LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJOb3RpZmljYXRpb24uaCBiL1NvdXJj ZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViTm90aWZpY2F0aW9uLmgKaW5kZXggZmI5YzUwZTVkM2E3 ZDJiNGMzOTVlZjQ2MzAwMzU3M2FjMmVjZjEyNC4uNDkyNTU2OTBiZTlhMDAyMzYyNjMxY2RiNWE1 MTUxNThhYjVhNDE5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJO b3RpZmljYXRpb24uaAorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYk5vdGlmaWNh dGlvbi5oCkBAIC0zNyw2ICszNyw3IEBACiAtIChOU1N0cmluZyAqKXRpdGxlOwogLSAoTlNTdHJp bmcgKilib2R5OwogLSAoTlNTdHJpbmcgKil0YWc7CistIChOU1N0cmluZyAqKWljb25VUkw7CiAt IChXZWJTZWN1cml0eU9yaWdpbiAqKW9yaWdpbjsKIC0gKHVpbnQ2NF90KW5vdGlmaWNhdGlvbklE OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYk5vdGlmaWNhdGlv bi5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViTm90aWZpY2F0aW9uLm1tCmluZGV4 IDZhMTIzZjZlZTkxNzYwM2Q2MWYxZjk2YzFlMDEzZTc0ODM3OTNkZTAuLmJlODJmZDcxNjQ1NjUz ZDBmOWUwMzI4YjZjY2Q5ODI0NGU4MWViZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFj L1dlYlZpZXcvV2ViTm90aWZpY2F0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZp ZXcvV2ViTm90aWZpY2F0aW9uLm1tCkBAIC0xMTEsNiArMTExLDE2IEBAIE5vdGlmaWNhdGlvbiog Y29yZShXZWJOb3RpZmljYXRpb24gKm5vdGlmaWNhdGlvbikKICNlbmRpZgogfQogCistIChOU1N0 cmluZyAqKWljb25VUkwKK3sKKyNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykgfHwgRU5BQkxFKExF R0FDWV9OT1RJRklDQVRJT05TKQorICAgIEFTU0VSVChjb3JlKHNlbGYpKTsKKyAgICByZXR1cm4g Y29yZShzZWxmKS0+aWNvblVSTCgpOworI2Vsc2UKKyAgICByZXR1cm4gbmlsOworI2VuZGlmCit9 CisKIC0gKFdlYlNlY3VyaXR5T3JpZ2luICopb3JpZ2luCiB7CiAjaWYgRU5BQkxFKE5PVElGSUNB VElPTlMpIHx8IEVOQUJMRShMRUdBQ1lfTk9USUZJQ0FUSU9OUykK