95246 2012-08-28 14:28:16 -0700 filesystem-url-in-iframe test is flaky 2012-10-09 17:18:42 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pdr abarth abarth eric jchaffraix mkwst webkit.review.bot oldest_to_newest 706733 0 pdr 2012-08-28 14:28:16 -0700 filesystem-url-in-iframe is flaky and we should mark it as so in the short term. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=http%2Ftests%2Fsecurity%2FmixedContent%2Ffilesystem-url-in-iframe.html ​mkwst@chromium.org, can we rewrite this to behave better so we don't lose long-term test coverage? 706745 1 pdr 2012-08-28 14:40:42 -0700 Marked as flaky: http://trac.webkit.org/changeset/126929 738271 2 167865 abarth 2012-10-09 15:41:42 -0700 Created attachment 167865 Patch 738319 3 167865 eric 2012-10-09 16:39:23 -0700 Comment on attachment 167865 Patch Flaky tests, I slay thee! 738351 4 167865 webkit.review.bot 2012-10-09 17:18:39 -0700 Comment on attachment 167865 Patch Clearing flags on attachment: 167865 Committed r130830: <http://trac.webkit.org/changeset/130830> 738352 5 webkit.review.bot 2012-10-09 17:18:42 -0700 All reviewed patches have been landed. Closing bug. 167865 2012-10-09 15:41:42 -0700 2012-10-09 17:18:39 -0700 Patch bug-95246-20121009154042.patch text/plain 4055 abarth SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEzMDgyMSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEwLTA5ICBBZGFtIEJhcnRoICA8YWJh cnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgZmlsZXN5c3RlbS11cmwtaW4taWZyYW1lIHRlc3Qg aXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk1MjQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhpcyB0ZXN0IHdhcyBhc3N1bWluZyB0aGF0IHRoZSBuYXZpZ2F0aW9uIHdvdWxkIGNvbXBsZXRl IGJlZm9yZSB0aGUKKyAgICAgICAgYXN5bmMgSmF2YVNjcmlwdCBleGVjdXRlZCwgd2hpY2ggaXMg dHJ1ZSB1c3VhbGx5IChidXQgbm90IGFsd2F5cykuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL3Nl Y3VyaXR5L21peGVkQ29udGVudC9maWxlc3lzdGVtLXVybC1pbi1pZnJhbWUuaHRtbDoKKyAgICAg ICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEyLTEwLTA5ICBM ZXZpIFdlaW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2Vk IGdhcmRlbmluZy4gVXBkYXRpbmcgdGVzdCBleHBlY3RhdGlvbnMgYWZ0ZXIgcjEzMDgxMS4KSW5k ZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvbWl4ZWRDb250ZW50L2ZpbGVzeXN0 ZW0tdXJsLWluLWlmcmFtZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVz dHMvc2VjdXJpdHkvbWl4ZWRDb250ZW50L2ZpbGVzeXN0ZW0tdXJsLWluLWlmcmFtZS5odG1sCShy ZXZpc2lvbiAxMzA4MDYpCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L21peGVk Q29udGVudC9maWxlc3lzdGVtLXVybC1pbi1pZnJhbWUuaHRtbAkod29ya2luZyBjb3B5KQpAQCAt OSwzNiArOSwzNyBAQAogPC9wPgogCiA8c2NyaXB0PgotaWYgKGxvY2F0aW9uLnByb3RvY29sICE9 ICdodHRwczonKQotICAgIGxvY2F0aW9uID0gJ2h0dHBzOi8vMTI3LjAuMC4xOjg0NDMvc2VjdXJp dHkvbWl4ZWRDb250ZW50L2ZpbGVzeXN0ZW0tdXJsLWluLWlmcmFtZS5odG1sJzsKLQogaWYgKHdp bmRvdy50ZXN0UnVubmVyKSB7CiAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CiAgICAgdGVz dFJ1bm5lci5kdW1wQ2hpbGRGcmFtZXNBc1RleHQoKTsKICAgICB0ZXN0UnVubmVyLndhaXRVbnRp bERvbmUoKTsKIH0KIAotdmFyIGlmcmFtZSA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2lmcmFt ZScpOwotaWZyYW1lLm9ubG9hZCA9IGZ1bmN0aW9uICgpIHsKLSAgICBpZiAod2luZG93LnRlc3RS dW5uZXIpCi0gICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOwotfTsKK2lmIChsb2NhdGlv bi5wcm90b2NvbCAhPSAnaHR0cHM6JykKKyAgICBsb2NhdGlvbiA9ICdodHRwczovLzEyNy4wLjAu MTo4NDQzL3NlY3VyaXR5L21peGVkQ29udGVudC9maWxlc3lzdGVtLXVybC1pbi1pZnJhbWUuaHRt bCc7CitlbHNlIHsKKyAgICB2YXIgaWZyYW1lID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcignaWZy YW1lJyk7CisgICAgaWZyYW1lLm9ubG9hZCA9IGZ1bmN0aW9uICgpIHsKKyAgICAgICAgaWYgKHdp bmRvdy50ZXN0UnVubmVyKQorICAgICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7Cisg ICAgfTsKIAotLy8gT3BlbmluZyBhIGZpbGUgc3lzdGVtIHdpdGggdGVtcG9yYXJ5IHN0b3JhZ2UK LXdpbmRvdy53ZWJraXRSZXF1ZXN0RmlsZVN5c3RlbShURU1QT1JBUlksIDEwMjQqMTAyNCAvKjFN QiovLCBmdW5jdGlvbihmcykgewotICAgIGZzLnJvb3QuZ2V0RmlsZSgndGVzdC5odG1sJywge2Ny ZWF0ZTogdHJ1ZX0sIGZ1bmN0aW9uKGZpbGVFbnRyeSkgewotICAgICAgICBmaWxlRW50cnkuY3Jl YXRlV3JpdGVyKGZ1bmN0aW9uKGZpbGVXcml0ZXIpIHsKLSAgICAgICAgICAgIGZpbGVXcml0ZXIu b253cml0ZWVuZCA9IGZ1bmN0aW9uKGUpIHsKLSAgICAgICAgICAgICAgICBhbGVydCgnUEFTUyAo MS8yKTogRmlsZSB3cml0dGVuJyk7Ci0gICAgICAgICAgICAgICAgaWZyYW1lLnNyYyA9IGZpbGVF bnRyeS50b1VSTCgndGV4dC9odG1sJyk7Ci0gICAgICAgICAgICB9OworICAgIC8vIE9wZW5pbmcg YSBmaWxlIHN5c3RlbSB3aXRoIHRlbXBvcmFyeSBzdG9yYWdlCisgICAgd2luZG93LndlYmtpdFJl cXVlc3RGaWxlU3lzdGVtKFRFTVBPUkFSWSwgMTAyNCoxMDI0IC8qMU1CKi8sIGZ1bmN0aW9uKGZz KSB7CisgICAgICAgIGZzLnJvb3QuZ2V0RmlsZSgndGVzdC5odG1sJywge2NyZWF0ZTogdHJ1ZX0s IGZ1bmN0aW9uKGZpbGVFbnRyeSkgeworICAgICAgICAgICAgZmlsZUVudHJ5LmNyZWF0ZVdyaXRl cihmdW5jdGlvbihmaWxlV3JpdGVyKSB7CisgICAgICAgICAgICAgICAgZmlsZVdyaXRlci5vbndy aXRlZW5kID0gZnVuY3Rpb24oZSkgeworICAgICAgICAgICAgICAgICAgICBhbGVydCgnUEFTUyAo MS8yKTogRmlsZSB3cml0dGVuJyk7CisgICAgICAgICAgICAgICAgICAgIGlmcmFtZS5zcmMgPSBm aWxlRW50cnkudG9VUkwoJ3RleHQvaHRtbCcpOworICAgICAgICAgICAgICAgIH07CiAKLSAgICAg ICAgICAgIC8vIENyZWF0ZSBhIG5ldyBCbG9iIGFuZCB3cml0ZSBpdCB0byBsb2cudHh0LgotICAg ICAgICAgICAgdmFyIGIgPSBuZXcgQmxvYihbJ1BBU1MgKDIvMik6IEZpbGUgZGlzcGxheWVkJ10s IHsgdHlwZTogJ3RleHQvaHRtbCcgfSk7Ci0gICAgICAgICAgICBmaWxlV3JpdGVyLndyaXRlKGIp OworICAgICAgICAgICAgICAgIC8vIENyZWF0ZSBhIG5ldyBCbG9iIGFuZCB3cml0ZSBpdCB0byBs b2cudHh0LgorICAgICAgICAgICAgICAgIHZhciBiID0gbmV3IEJsb2IoWydQQVNTICgyLzIpOiBG aWxlIGRpc3BsYXllZCddLCB7IHR5cGU6ICd0ZXh0L2h0bWwnIH0pOworICAgICAgICAgICAgICAg IGZpbGVXcml0ZXIud3JpdGUoYik7CisgICAgICAgICAgICB9KTsKICAgICAgICAgfSk7CiAgICAg fSk7Ci19KTsKK30KIDwvc2NyaXB0PgogPC9ib2R5PgogPC9odG1sPgpJbmRleDogTGF5b3V0VGVz dHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCShyZXZpc2lvbiAxMzA4 MDkpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCSh3 b3JraW5nIGNvcHkpCkBAIC0zNzMyLDkgKzM3MzIsNiBAQCB3ZWJraXQub3JnL2IvOTQ0OTIgWyBM aW51eCBXaW4gXSBjc3MzL2ZpCiB3ZWJraXQub3JnL2IvOTQ0OTIgWyBMaW51eCBXaW4gXSBjc3Mz L2ZpbHRlcnMvY3VzdG9tL2ZpbHRlci1yZXBhaW50LWN1c3RvbS5odG1sIFsgSW1hZ2VPbmx5RmFp bHVyZSBdCiB3ZWJraXQub3JnL2IvOTQ0OTIgWyBMaW51eCBXaW4gXSBjc3MzL2ZpbHRlcnMvY3Vz dG9tL2ZpbHRlci1yZXBhaW50LWN1c3RvbS1yb3RhdGVkLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJl IF0KIAotIyBGbGFreQotd2Via2l0Lm9yZy9iLzk1MjQ2IGh0dHAvdGVzdHMvc2VjdXJpdHkvbWl4 ZWRDb250ZW50L2ZpbGVzeXN0ZW0tdXJsLWluLWlmcmFtZS5odG1sIFsgRmFpbHVyZSBQYXNzIF0K LQogd2Via2l0Lm9yZy9iLzk1NTgxIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvemVyby1sZW5n dGgtcmVzcG9uc2UuaHRtbCBbIFBhc3MgVGltZW91dCBdCiB3ZWJraXQub3JnL2IvOTU1ODEgaHR0 cC90ZXN0cy9taXNjL2phdmFzY3JpcHQtdXJsLXN0b3AtbG9hZGVycy5odG1sIFsgUGFzcyBUaW1l b3V0IF0KIAo=