95245 2012-08-28 14:17:33 -0700 PutById uses DataLabel32, not DataLabelCompact 2012-08-29 16:53:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough oldest_to_newest 706724 0 barraclough 2012-08-28 14:17:33 -0700 JIT::resetPatchPutById calls the the wrong thing on x86-64 – this is moot right now, since they currently both do the same thing, but if we were to ever make compact mean 8-bit this could be a real problem. Also, don't rely on the object still being in eax on entry to the transition stub – this isn't very robust. 706726 1 barraclough 2012-08-28 14:20:57 -0700 Fixed in r126928 706891 2 barraclough 2012-08-28 17:00:41 -0700 Rolled back out in r126938 :-( 707937 3 161332 barraclough 2012-08-29 15:26:55 -0700 Created attachment 161332 Fix 708059 4 barraclough 2012-08-29 16:52:16 -0700 Re-reviewed by ggaren, relanded in r127066. 161332 2012-08-29 15:26:55 -0700 2012-08-29 16:53:20 -0700 Fix 95245.patch text/plain 3696 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI3MDU2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBA CisyMDEyLTA4LTI5ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4K KworICAgICAgICBQdXRCeUlkIHVzZXMgRGF0YUxhYmVsMzIsIG5vdCBEYXRhTGFiZWxDb21wYWN0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTI0NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEpJVDo6cmVz ZXRQYXRjaFB1dEJ5SWQgY2FsbHMgdGhlIHRoZSB3cm9uZyB0aGluZyBvbiB4ODYtNjQg4oCTIHRo aXMgaXMgbW9vdCByaWdodCBub3csCisgICAgICAgIHNpbmNlIHRoZXkgY3VycmVudGx5IGJvdGgg ZG8gdGhlIHNhbWUgdGhpbmcsIGJ1dCBpZiB3ZSB3ZXJlIHRvIGV2ZXIgbWFrZSBjb21wYWN0IG1l YW4KKyAgICAgICAgOC1iaXQgdGhpcyBjb3VsZCBiZSBhIHJlYWwgcHJvYmxlbS4gQWxzbywgcmVs eWluZyBvbiB0aGUgb2JqZWN0IHN0aWxsIGJlaW5nIGluIGVheAorICAgICAgICBvbiBlbnRyeSB0 byB0aGUgdHJhbnNpdGlvbiBzdHViIGlzbid0IHZlcnkgcm9idXN0IC0gYWRkZWQgbm9uQXJnR1BS MSB0byBhdCBsZWFzdCBtYWtlCisgICAgICAgIHRoaXMgZXhwbGljaXQuCisKKyAgICAgICAgKiBq aXQvSklUUHJvcGVydHlBY2Nlc3MuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRTbG93X29w X3B1dF9ieV9pZCk6CisgICAgICAgICAgICAtIGNvcHkgcmVnVDAgdG8gbm9uQXJnR1BSMQorICAg ICAgICAoSlNDOjpKSVQ6OnByaXZhdGVDb21waWxlUHV0QnlJZFRyYW5zaXRpb24pOgorICAgICAg ICAgICAgLSBEYXRhTGFiZWxDb21wYWN0IC0+IERhdGFMYWJlbDMyCisgICAgICAgIChKU0M6OkpJ VDo6cmVzZXRQYXRjaFB1dEJ5SWQpOgorICAgICAgICAgICAgLSByZWxvYWQgcmVnVDAgZnJvbSBu b25BcmdHUFIxCisgICAgICAgICogaml0L0pTSW50ZXJmYWNlSklULmg6CisgICAgICAgIChKU0lu dGVyZmFjZUpJVCk6CisgICAgICAgICAgICAtIGFkZGVkIG5vbkFyZ0dQUjEKKwogMjAxMi0wOC0y OCAgWW9uZyBMaSAgPHlvbGlAcmltLmNvbT4KIAogICAgICAgICBFeGVjdXRhYmxlQWxsb2NhdG9y IHNob3VsZCBiZSBkZXN0cnVjdGVkIGFmdGVyIEhlYXAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qaXQvSklUUHJvcGVydHlBY2Nlc3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9qaXQvSklUUHJvcGVydHlBY2Nlc3MuY3BwCShyZXZpc2lvbiAxMjY5MzgpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFByb3BlcnR5QWNjZXNzLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNDkzLDYgKzQ5Myw3IEBAIHZvaWQgSklUOjplbWl0U2xvd19vcF9wdXRfYnlf aWQoSW5zdHJ1Y3QKICAgICBzdHViQ2FsbC5hZGRBcmd1bWVudChyZWdUMCk7CiAgICAgc3R1YkNh bGwuYWRkQXJndW1lbnQoVHJ1c3RlZEltbVB0cihpZGVudCkpOwogICAgIHN0dWJDYWxsLmFkZEFy Z3VtZW50KHJlZ1QxKTsKKyAgICBtb3ZlKHJlZ1QwLCBub25BcmdHUFIxKTsKICAgICBDYWxsIGNh bGwgPSBzdHViQ2FsbC5jYWxsKCk7CiAKICAgICAvLyBUcmFjayB0aGUgbG9jYXRpb24gb2YgdGhl IGNhbGw7IHRoaXMgd2lsbCBiZSB1c2VkIHRvIHJlY292ZXIgcGF0Y2ggaW5mb3JtYXRpb24uCkBA IC01MzcsNiArNTM4LDggQEAgdm9pZCBKSVQ6OmNvbXBpbGVHZXREaXJlY3RPZmZzZXQoSlNPYmpl YwogCiB2b2lkIEpJVDo6cHJpdmF0ZUNvbXBpbGVQdXRCeUlkVHJhbnNpdGlvbihTdHJ1Y3R1cmVT dHViSW5mbyogc3R1YkluZm8sIFN0cnVjdHVyZSogb2xkU3RydWN0dXJlLCBTdHJ1Y3R1cmUqIG5l d1N0cnVjdHVyZSwgUHJvcGVydHlPZmZzZXQgY2FjaGVkT2Zmc2V0LCBTdHJ1Y3R1cmVDaGFpbiog Y2hhaW4sIFJldHVybkFkZHJlc3NQdHIgcmV0dXJuQWRkcmVzcywgYm9vbCBkaXJlY3QpCiB7Cisg ICAgbW92ZShub25BcmdHUFIxLCByZWdUMCk7CisKICAgICBKdW1wTGlzdCBmYWlsdXJlQ2FzZXM7 CiAgICAgLy8gQ2hlY2sgZWF4IGlzIGFuIG9iamVjdCBvZiB0aGUgcmlnaHQgU3RydWN0dXJlLgog ICAgIGZhaWx1cmVDYXNlcy5hcHBlbmQoZW1pdEp1bXBJZk5vdEpTQ2VsbChyZWdUMCkpOwpAQCAt MTE2Miw3ICsxMTY1LDcgQEAgdm9pZCBKSVQ6OnJlc2V0UGF0Y2hQdXRCeUlkKFJlcGF0Y2hCdWZm ZQogICAgIGVsc2UKICAgICAgICAgcmVwYXRjaEJ1ZmZlci5yZWxpbmsoc3R1YkluZm8tPmNhbGxS ZXR1cm5Mb2NhdGlvbiwgY3RpX29wX3B1dF9ieV9pZCk7CiAgICAgcmVwYXRjaEJ1ZmZlci5yZXBh dGNoKHN0dWJJbmZvLT5ob3RQYXRoQmVnaW4uZGF0YUxhYmVsUHRyQXRPZmZzZXQoc3R1YkluZm8t PnBhdGNoLmJhc2VsaW5lLnUucHV0LnN0cnVjdHVyZVRvQ29tcGFyZSksIHJlaW50ZXJwcmV0X2Nh c3Q8dm9pZCo+KC0xKSk7Ci0gICAgcmVwYXRjaEJ1ZmZlci5yZXBhdGNoKHN0dWJJbmZvLT5ob3RQ YXRoQmVnaW4uZGF0YUxhYmVsQ29tcGFjdEF0T2Zmc2V0KHN0dWJJbmZvLT5wYXRjaC5iYXNlbGlu ZS51LnB1dC5kaXNwbGFjZW1lbnRMYWJlbCksIDApOworICAgIHJlcGF0Y2hCdWZmZXIucmVwYXRj aChzdHViSW5mby0+aG90UGF0aEJlZ2luLmRhdGFMYWJlbDMyQXRPZmZzZXQoc3R1YkluZm8tPnBh dGNoLmJhc2VsaW5lLnUucHV0LmRpc3BsYWNlbWVudExhYmVsKSwgMCk7CiB9CiAKICNlbmRpZiAv LyBVU0UoSlNWQUxVRTY0KQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KU0ludGVy ZmFjZUpJVC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSlNJbnRl cmZhY2VKSVQuaAkocmV2aXNpb24gMTI2OTM4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9KU0ludGVyZmFjZUpJVC5oCSh3b3JraW5nIGNvcHkpCkBAIC03NSw2ICs3NSw4IEBAIG5hbWVz cGFjZSBKU0MgewogICAgICAgICBzdGF0aWMgY29uc3QgRlBSZWdpc3RlcklEIGZwUmVnVDEgPSBY ODZSZWdpc3RlcnM6OnhtbTE7CiAgICAgICAgIHN0YXRpYyBjb25zdCBGUFJlZ2lzdGVySUQgZnBS ZWdUMiA9IFg4NlJlZ2lzdGVyczo6eG1tMjsKICAgICAgICAgc3RhdGljIGNvbnN0IEZQUmVnaXN0 ZXJJRCBmcFJlZ1QzID0gWDg2UmVnaXN0ZXJzOjp4bW0zOworCisgICAgICAgIHN0YXRpYyBjb25z dCBSZWdpc3RlcklEIG5vbkFyZ0dQUjEgPSBYODZSZWdpc3RlcnM6OmVheDsgLy8gcmVnVDAKICNl bGlmIENQVShYODYpCiAgICAgICAgIHN0YXRpYyBjb25zdCBSZWdpc3RlcklEIHJldHVyblZhbHVl UmVnaXN0ZXIgPSBYODZSZWdpc3RlcnM6OmVheDsKICAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lz dGVySUQgY2FjaGVkUmVzdWx0UmVnaXN0ZXIgPSBYODZSZWdpc3RlcnM6OmVheDsK