<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>95231</bug_id>
          
          <creation_ts>2012-08-28 12:36:52 -0700</creation_ts>
          <short_desc>Add directory generated by Eclipse to .gitignore</short_desc>
          <delta_ts>2012-08-28 15:59:03 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mario Sanchez Prada">mario</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>kling</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>706623</commentid>
    <comment_count>0</comment_count>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2012-08-28 12:36:52 -0700</bug_when>
    <thetext>Add .settings directory, used to store project specific settings in Eclipse, and also by some plugins (e.g. CDT) to .gitignore.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>706633</commentid>
    <comment_count>1</comment_count>
      <attachid>161036</attachid>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2012-08-28 12:40:12 -0700</bug_when>
    <thetext>Created attachment 161036
Patch proposal

Adding Andreas Kling as reviewer as he already reviewed a similar patch some time ago (see bug 79463)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>706635</commentid>
    <comment_count>2</comment_count>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2012-08-28 12:40:58 -0700</bug_when>
    <thetext>Now actually adding Andreas Kling to CC...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>706651</commentid>
    <comment_count>3</comment_count>
      <attachid>161036</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2012-08-28 12:57:33 -0700</bug_when>
    <thetext>Comment on attachment 161036
Patch proposal

Boom, r+!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>706692</commentid>
    <comment_count>4</comment_count>
      <attachid>161036</attachid>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2012-08-28 13:52:23 -0700</bug_when>
    <thetext>Comment on attachment 161036
Patch proposal

Thanks</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>706814</commentid>
    <comment_count>5</comment_count>
      <attachid>161036</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-28 15:59:00 -0700</bug_when>
    <thetext>Comment on attachment 161036
Patch proposal

Clearing flags on attachment: 161036

Committed r126936: &lt;http://trac.webkit.org/changeset/126936&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>706815</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-28 15:59:03 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>161036</attachid>
            <date>2012-08-28 12:40:12 -0700</date>
            <delta_ts>2012-08-28 15:58:59 -0700</delta_ts>
            <desc>Patch proposal</desc>
            <filename>0001-2012-08-28-Mario-Sanchez-Prada-msanchez-igalia.com.patch</filename>
            <type>text/plain</type>
            <size>1193</size>
            <attacher name="Mario Sanchez Prada">mario</attacher>
            
              <data encoding="base64">RnJvbSAwODQzZjlhNDU1NjU5MmU1ZjU5ODRjMzM2NGMzNmFmN2Q2YmYwYmM5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu
Y29tPgpEYXRlOiBUdWUsIDI4IEF1ZyAyMDEyIDIxOjM5OjAyICswMjAwClN1YmplY3Q6IFtQQVRD
SF0gMjAxMi0wOC0yOCAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+
CgogICAgICAgIEFkZCBkaXJlY3RvcnkgZ2VuZXJhdGVkIGJ5IEVjbGlwc2UgdG8gLmdpdGlnbm9y
ZQogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTIzMQoK
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgKiAuZ2l0aWdub3Jl
OiBJZ25vcmUgLnNldHRpbmdzIGRpcmVjdG9yeS4KLS0tCiAuZ2l0aWdub3JlIHwgMSArCiBDaGFu
Z2VMb2cgIHwgOSArKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKQoK
ZGlmZiAtLWdpdCBhLy5naXRpZ25vcmUgYi8uZ2l0aWdub3JlCmluZGV4IDE2YzczOWUuLmYwMGNh
OTQgMTAwNjQ0Ci0tLSBhLy5naXRpZ25vcmUKKysrIGIvLmdpdGlnbm9yZQpAQCAtMTE2LDMgKzEx
Niw0IEBAIHRhZ3MKICMgSWdub3JlIEVjbGlwc2UgZmlsZXM6CiAucHJvamVjdAogLmNwcm9qZWN0
Cisuc2V0dGluZ3MKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBlZTI4
M2YyLi5hNjllZGJjIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0x
LDMgKzEsMTIgQEAKKzIwMTItMDgtMjggIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBp
Z2FsaWEuY29tPgorCisgICAgICAgIEFkZCBkaXJlY3RvcnkgZ2VuZXJhdGVkIGJ5IEVjbGlwc2Ug
dG8gLmdpdGlnbm9yZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9OTUyMzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICAqIC5naXRpZ25vcmU6IElnbm9yZSAuc2V0dGluZ3MgZGlyZWN0b3J5LgorCiAyMDEyLTA4
LTI3ICBSb2IgQnVpcyAgPHJidWlzQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIHJl
bW92ZSAtZm5vLXJ0dGkgb3B0aW9uIGluIENNQUtFX0NfRkxBR1MKLS0gCjEuNy4xMS4yCgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>