9523 2006-06-21 00:07:08 -0700 More Win32 build bustage 2006-06-21 03:59:58 -0700 1 1 1 Unclassified WebKit New Bugs 420+ PC Windows XP RESOLVED FIXED P2 Normal --- 1 bengoodger webkit-unassigned oldest_to_newest 46508 0 bengoodger 2006-06-21 00:07:08 -0700 A bunch of files were added and removed: *Event.h/cpp and friends *RenderSelect.h/cpp Also: shouldInterruptJavaScript implementation does not match pure virtual base class signature, causing msvc to complain. 46511 1 8938 bengoodger 2006-06-21 00:13:57 -0700 Created attachment 8938 patch Adds/removes files from WebCore.vcproj and adjusts shouldInterruptJavaScript signature (alternatively, the impl should not be const, let me know) ChangeLog entry: * WebCore.vcproj/WebCore/WebCore.vcproj: Add DeprecatedRenderSelect.cpp/h Remove RenderSelect.cpp/h Add BeforeUnloadEvent, Clipboard, ClipboardEvent, Event, KeyboardEvent, MouseEvent, MouseRelatedEvent, MutationEvent, RegisteredEventListener, UIEvent, UIEventWithKeyState, WheelEvent .h/.cpp Remove dom2_eventsimpl.h/cpp * WebCore/bridge/win/FrameWin.cpp (WebCore::shouldInterruptJavaScript): This method is supposed to be implemented on FrameWin * WebCore/page/Frame.h (WebCore::Frame): abstract method should match const-ness of implementation 46514 2 8938 mjs 2006-06-21 01:01:02 -0700 Comment on attachment 8938 patch r=me 46521 3 bengoodger 2006-06-21 01:21:49 -0700 Actually, this should probably make the windows impl non-const since otherwise this will break Mac builds (as dwf points out in #webkit) If someone checks this in tonight, they should make this correction (my tree that I did this patch in is at work) 46531 4 ddkilzer 2006-06-21 03:59:58 -0700 Committed by Adele in r14941. 8938 2006-06-21 00:13:57 -0700 2006-06-21 01:01:02 -0700 patch goat.diff text/plain 5330 bengoodger SW5kZXg6IFdlYkNvcmUvV2ViQ29yZS52Y3Byb2ovV2ViQ29yZS9XZWJDb3JlLnZjcHJvag0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQ0KLS0tIFdlYkNvcmUvV2ViQ29yZS52Y3Byb2ovV2ViQ29yZS9XZWJDb3JlLnZjcHJv agkocmV2aXNpb24gMTQ5MzApDQorKysgV2ViQ29yZS9XZWJDb3JlLnZjcHJvai9XZWJDb3JlL1dl YkNvcmUudmNwcm9qCSh3b3JraW5nIGNvcHkpDQpAQCAtMjgzMSw2ICsyODMxLDIyIEBADQogCQkJ CT4NCiAJCQk8L0ZpbGU+DQogCQkJPEZpbGUNCisJCQkJUmVsYXRpdmVQYXRoPSIuLlwuLlxyZW5k ZXJpbmdcRGVwcmVjYXRlZFJlbmRlclNlbGVjdC5jcHAiDQorCQkJCT4NCisJCQk8L0ZpbGU+DQor CQkJPEZpbGUNCisJCQkJUmVsYXRpdmVQYXRoPSIuLlwuLlxyZW5kZXJpbmdcRGVwcmVjYXRlZFJl bmRlclNlbGVjdC5oIg0KKwkJCQk+DQorCQkJPC9GaWxlPg0KKwkJCTxGaWxlDQorCQkJCVJlbGF0 aXZlUGF0aD0iLi5cLi5ccmVuZGVyaW5nXERlcHJlY2F0ZWRTbGlkZXIuY3BwIg0KKwkJCQk+DQor CQkJPC9GaWxlPg0KKwkJCTxGaWxlDQorCQkJCVJlbGF0aXZlUGF0aD0iLi5cLi5ccmVuZGVyaW5n XERlcHJlY2F0ZWRTbGlkZXIuaCINCisJCQkJPg0KKwkJCTwvRmlsZT4NCisJCQk8RmlsZQ0KIAkJ CQlSZWxhdGl2ZVBhdGg9Ii4uXC4uXHJlbmRlcmluZ1xFbGxpcHNpc0JveC5jcHAiDQogCQkJCT4N CiAJCQk8L0ZpbGU+DQpAQCAtMzEyMywyMiArMzEzOSw2IEBADQogCQkJCT4NCiAJCQk8L0ZpbGU+ DQogCQkJPEZpbGUNCi0JCQkJUmVsYXRpdmVQYXRoPSIuLlwuLlxyZW5kZXJpbmdcUmVuZGVyU2Vs ZWN0LmNwcCINCi0JCQkJPg0KLQkJCTwvRmlsZT4NCi0JCQk8RmlsZQ0KLQkJCQlSZWxhdGl2ZVBh dGg9Ii4uXC4uXHJlbmRlcmluZ1xSZW5kZXJTZWxlY3QuaCINCi0JCQkJPg0KLQkJCTwvRmlsZT4N Ci0JCQk8RmlsZQ0KLQkJCQlSZWxhdGl2ZVBhdGg9Ii4uXC4uXHJlbmRlcmluZ1xEZXByZWNhdGVk U2xpZGVyLmNwcCINCi0JCQkJPg0KLQkJCTwvRmlsZT4NCi0JCQk8RmlsZQ0KLQkJCQlSZWxhdGl2 ZVBhdGg9Ii4uXC4uXHJlbmRlcmluZ1xEZXByZWNhdGVkU2xpZGVyLmgiDQotCQkJCT4NCi0JCQk8 L0ZpbGU+DQotCQkJPEZpbGUNCiAJCQkJUmVsYXRpdmVQYXRoPSIuLlwuLlxyZW5kZXJpbmdcUmVu ZGVyVGFibGUuY3BwIg0KIAkJCQk+DQogCQkJPC9GaWxlPg0KQEAgLTM0NDcsNiArMzQ0NywxNCBA QA0KIAkJCQk+DQogCQkJPC9GaWxlPg0KIAkJCTxGaWxlDQorCQkJCVJlbGF0aXZlUGF0aD0iLi5c Li5cZG9tXEJlZm9yZVVubG9hZEV2ZW50LmNwcCINCisJCQkJPg0KKwkJCTwvRmlsZT4NCisJCQk8 RmlsZQ0KKwkJCQlSZWxhdGl2ZVBhdGg9Ii4uXC4uXGRvbVxCZWZvcmVVbmxvYWRFdmVudC5oIg0K KwkJCQk+DQorCQkJPC9GaWxlPg0KKwkJCTxGaWxlDQogCQkJCVJlbGF0aXZlUGF0aD0iLi5cLi5c ZG9tXENEQVRBU2VjdGlvbi5jcHAiDQogCQkJCT4NCiAJCQk8L0ZpbGU+DQpAQCAtMzQ3MSw2ICsz NDc5LDE4IEBADQogCQkJCT4NCiAJCQk8L0ZpbGU+DQogCQkJPEZpbGUNCisJCQkJUmVsYXRpdmVQ YXRoPSIuLlwuLlxkb21cQ2xpcGJvYXJkLmgiDQorCQkJCT4NCisJCQk8L0ZpbGU+DQorCQkJPEZp bGUNCisJCQkJUmVsYXRpdmVQYXRoPSIuLlwuLlxkb21cQ2xpcGJvYXJkRXZlbnQuY3BwIg0KKwkJ CQk+DQorCQkJPC9GaWxlPg0KKwkJCTxGaWxlDQorCQkJCVJlbGF0aXZlUGF0aD0iLi5cLi5cZG9t XENsaXBib2FyZEV2ZW50LmgiDQorCQkJCT4NCisJCQk8L0ZpbGU+DQorCQkJPEZpbGUNCiAJCQkJ UmVsYXRpdmVQYXRoPSIuLlwuLlxkb21cQ29tbWVudC5jcHAiDQogCQkJCT4NCiAJCQk8L0ZpbGU+ DQpAQCAtMzUyMywxNCArMzU0Myw2IEBADQogCQkJCT4NCiAJCQk8L0ZpbGU+DQogCQkJPEZpbGUN Ci0JCQkJUmVsYXRpdmVQYXRoPSIuLlwuLlxkb21cZG9tMl9ldmVudHNpbXBsLmNwcCINCi0JCQkJ Pg0KLQkJCTwvRmlsZT4NCi0JCQk8RmlsZQ0KLQkJCQlSZWxhdGl2ZVBhdGg9Ii4uXC4uXGRvbVxk b20yX2V2ZW50c2ltcGwuaCINCi0JCQkJPg0KLQkJCTwvRmlsZT4NCi0JCQk8RmlsZQ0KIAkJCQlS ZWxhdGl2ZVBhdGg9Ii4uXC4uXGRvbVxET01JbXBsZW1lbnRhdGlvbi5jcHAiDQogCQkJCT4NCiAJ CQk8L0ZpbGU+DQpAQCAtMzU3MSw2ICszNTgzLDE0IEBADQogCQkJCT4NCiAJCQk8L0ZpbGU+DQog CQkJPEZpbGUNCisJCQkJUmVsYXRpdmVQYXRoPSIuLlwuLlxkb21cRXZlbnQuY3BwIg0KKwkJCQk+ DQorCQkJPC9GaWxlPg0KKwkJCTxGaWxlDQorCQkJCVJlbGF0aXZlUGF0aD0iLi5cLi5cZG9tXEV2 ZW50LmgiDQorCQkJCT4NCisJCQk8L0ZpbGU+DQorCQkJPEZpbGUNCiAJCQkJUmVsYXRpdmVQYXRo PSIuLlwuLlxkb21cRXZlbnRMaXN0ZW5lci5oIg0KIAkJCQk+DQogCQkJPC9GaWxlPg0KQEAgLTM1 OTUsNiArMzYxNSwxNCBAQA0KIAkJCQk+DQogCQkJPC9GaWxlPg0KIAkJCTxGaWxlDQorCQkJCVJl bGF0aXZlUGF0aD0iLi5cLi5cZG9tXEtleWJvYXJkRXZlbnQuY3BwIg0KKwkJCQk+DQorCQkJPC9G aWxlPg0KKwkJCTxGaWxlDQorCQkJCVJlbGF0aXZlUGF0aD0iLi5cLi5cZG9tXEtleWJvYXJkRXZl bnQuaCINCisJCQkJPg0KKwkJCTwvRmlsZT4NCisJCQk8RmlsZQ0KIAkJCQlSZWxhdGl2ZVBhdGg9 Ii4uXC4uXGRvbVxNYXBwZWRBdHRyaWJ1dGUuY3BwIg0KIAkJCQk+DQogCQkJPC9GaWxlPg0KQEAg LTM2MDcsNiArMzYzNSwzMCBAQA0KIAkJCQk+DQogCQkJPC9GaWxlPg0KIAkJCTxGaWxlDQorCQkJ CVJlbGF0aXZlUGF0aD0iLi5cLi5cZG9tXE1vdXNlRXZlbnQuY3BwIg0KKwkJCQk+DQorCQkJPC9G aWxlPg0KKwkJCTxGaWxlDQorCQkJCVJlbGF0aXZlUGF0aD0iLi5cLi5cZG9tXE1vdXNlRXZlbnQu aCINCisJCQkJPg0KKwkJCTwvRmlsZT4NCisJCQk8RmlsZQ0KKwkJCQlSZWxhdGl2ZVBhdGg9Ii4u XC4uXGRvbVxNb3VzZVJlbGF0ZWRFdmVudC5jcHAiDQorCQkJCT4NCisJCQk8L0ZpbGU+DQorCQkJ PEZpbGUNCisJCQkJUmVsYXRpdmVQYXRoPSIuLlwuLlxkb21cTW91c2VSZWxhdGVkRXZlbnQuaCIN CisJCQkJPg0KKwkJCTwvRmlsZT4NCisJCQk8RmlsZQ0KKwkJCQlSZWxhdGl2ZVBhdGg9Ii4uXC4u XGRvbVxNdXRhdGlvbkV2ZW50LmNwcCINCisJCQkJPg0KKwkJCTwvRmlsZT4NCisJCQk8RmlsZQ0K KwkJCQlSZWxhdGl2ZVBhdGg9Ii4uXC4uXGRvbVxNdXRhdGlvbkV2ZW50LmgiDQorCQkJCT4NCisJ CQk8L0ZpbGU+DQorCQkJPEZpbGUNCiAJCQkJUmVsYXRpdmVQYXRoPSIuLlwuLlxkb21cTmFtZWRB dHRyTWFwLmNwcCINCiAJCQkJPg0KIAkJCTwvRmlsZT4NCkBAIC0zNzE1LDYgKzM3NjcsMTQgQEAN CiAJCQkJPg0KIAkJCTwvRmlsZT4NCiAJCQk8RmlsZQ0KKwkJCQlSZWxhdGl2ZVBhdGg9Ii4uXC4u XGRvbVxSZWdpc3RlcmVkRXZlbnRMaXN0ZW5lci5jcHAiDQorCQkJCT4NCisJCQk8L0ZpbGU+DQor CQkJPEZpbGUNCisJCQkJUmVsYXRpdmVQYXRoPSIuLlwuLlxkb21cUmVnaXN0ZXJlZEV2ZW50TGlz dGVuZXIuaCINCisJCQkJPg0KKwkJCTwvRmlsZT4NCisJCQk8RmlsZQ0KIAkJCQlSZWxhdGl2ZVBh dGg9Ii4uXC4uXGRvbVxTdHlsZWRFbGVtZW50LmNwcCINCiAJCQkJPg0KIAkJCTwvRmlsZT4NCkBA IC0zNzQ3LDYgKzM4MDcsMjYgQEANCiAJCQkJPg0KIAkJCTwvRmlsZT4NCiAJCQk8RmlsZQ0KKwkJ CQlSZWxhdGl2ZVBhdGg9Ii4uXC4uXGRvbVxVSUV2ZW50LmNwcCINCisJCQkJPg0KKwkJCTwvRmls ZT4NCisJCQk8RmlsZQ0KKwkJCQlSZWxhdGl2ZVBhdGg9Ii4uXC4uXGRvbVxVSUV2ZW50LmgiDQor CQkJCT4NCisJCQk8L0ZpbGU+DQorCQkJPEZpbGUNCisJCQkJUmVsYXRpdmVQYXRoPSIuLlwuLlxk b21cVUlFdmVudFdpdGhLZXlTdGF0ZS5oIg0KKwkJCQk+DQorCQkJPC9GaWxlPg0KKwkJCTxGaWxl DQorCQkJCVJlbGF0aXZlUGF0aD0iLi5cLi5cZG9tXFdoZWVsRXZlbnQuY3BwIg0KKwkJCQk+DQor CQkJPC9GaWxlPg0KKwkJCTxGaWxlDQorCQkJCVJlbGF0aXZlUGF0aD0iLi5cLi5cZG9tXFdoZWVs RXZlbnQuaCINCisJCQkJPg0KKwkJCTwvRmlsZT4NCisJCQk8RmlsZQ0KIAkJCQlSZWxhdGl2ZVBh dGg9Ii4uXC4uXGRvbVx4bWxfdG9rZW5pemVyLmNwcCINCiAJCQkJPg0KIAkJCTwvRmlsZT4NCklu ZGV4OiBXZWJDb3JlL2JyaWRnZS93aW4vRnJhbWVXaW4uY3BwDQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2Vi Q29yZS9icmlkZ2Uvd2luL0ZyYW1lV2luLmNwcAkocmV2aXNpb24gMTQ5MzEpDQorKysgV2ViQ29y ZS9icmlkZ2Uvd2luL0ZyYW1lV2luLmNwcAkod29ya2luZyBjb3B5KQ0KQEAgLTEwNSw3ICsxMDUs NyBAQA0KICAgICByZXR1cm4gTWVzc2FnZUJveCh2aWV3KCktPndpbmRvd0hhbmRsZSgpLCB0ZXh0 LmNoYXJhY3RlcnMoKSwgTCJKYXZhU2NyaXB0IEFsZXJ0IiwgTUJfT0tDQU5DRUwpID09IElET0s7 CiB9CiAKLWJvb2wgc2hvdWxkSW50ZXJydXB0SmF2YVNjcmlwdCgpIGNvbnN0Citib29sIEZyYW1l V2luOjpzaG91bGRJbnRlcnJ1cHRKYXZhU2NyaXB0KCkgY29uc3QKIHsKICAgICAvLyBGSVhNRTog VGhpcyBzaG91bGQgYmUgaW1wbGVtZW50ZWQKICAgICByZXR1cm4gZmFsc2U7CkluZGV4OiBXZWJD b3JlL3BhZ2UvRnJhbWUuaA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYkNvcmUvcGFnZS9GcmFtZS5oCShy ZXZpc2lvbiAxNDkzMCkNCisrKyBXZWJDb3JlL3BhZ2UvRnJhbWUuaAkod29ya2luZyBjb3B5KQ0K QEAgLTUzNCw3ICs1MzQsNyBAQA0KICAgdmlydHVhbCB2b2lkIHJ1bkphdmFTY3JpcHRBbGVydChj b25zdCBTdHJpbmcmIG1lc3NhZ2UpID0gMDsKICAgdmlydHVhbCBib29sIHJ1bkphdmFTY3JpcHRD b25maXJtKGNvbnN0IFN0cmluZyYgbWVzc2FnZSkgPSAwOwogICB2aXJ0dWFsIGJvb2wgcnVuSmF2 YVNjcmlwdFByb21wdChjb25zdCBTdHJpbmcmIG1lc3NhZ2UsIGNvbnN0IFN0cmluZyYgZGVmYXVs dFZhbHVlLCBTdHJpbmcmIHJlc3VsdCkgPSAwOyAgCi0gIHZpcnR1YWwgYm9vbCBzaG91bGRJbnRl cnJ1cHRKYXZhU2NyaXB0KCkgPSAwOworICB2aXJ0dWFsIGJvb2wgc2hvdWxkSW50ZXJydXB0SmF2 YVNjcmlwdCgpIGNvbnN0ID0gMDsKICAgdmlydHVhbCBib29sIGxvY2F0aW9uYmFyVmlzaWJsZSgp ID0gMDsKICAgdmlydHVhbCBib29sIG1lbnViYXJWaXNpYmxlKCkgPSAwOwogICB2aXJ0dWFsIGJv b2wgcGVyc29uYWxiYXJWaXNpYmxlKCkgPSAwOwo=