95228 2012-08-28 12:19:26 -0700 [WK2] Expose process model as API 2012-08-28 13:38:46 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap darin oldest_to_newest 706605 0 ap 2012-08-28 12:19:26 -0700 Patch forthcoming. 706608 1 161030 ap 2012-08-28 12:24:11 -0700 Created attachment 161030 proposed patch 706661 2 ap 2012-08-28 13:09:50 -0700 Committed <http://trac.webkit.org/changeset/126918>. 706674 3 161030 darin 2012-08-28 13:28:07 -0700 Comment on attachment 161030 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=161030&action=review > Source/WebKit2/UIProcess/WebContext.cpp:262 > + // Guard against API misuse. > + if (!m_processes.isEmpty()) > + CRASH(); Seems really harsh! Why not just return and do nothing? 706684 4 ap 2012-08-28 13:38:46 -0700 Silently ignoring the call would result in client developer wasting time to figure out what went wrong. I don't see any downside to crashing here, even if it may look a little unusual. 161030 2012-08-28 12:24:11 -0700 2012-08-28 13:28:07 -0700 proposed patch ExposeProcessModel.txt text/plain 5983 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNjkxMSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA4LTI4ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIEV4cG9zZSBwcm9j ZXNzIG1vZGVsIGFzIEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTUyMjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS0FQSUNhc3QuaDoKKyAgICAgICAgKFdlYktpdDo6 dG9Qcm9jZXNzTW9kZWwpOgorICAgICAgICAoV2ViS2l0Ojp0b0FQSSk6CisgICAgICAgIENvbnZl cnQgUHJvY2Vzc01vZGVsIHZhbHVlcy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS0Nv bnRleHQuY3BwOgorICAgICAgICAoV0tDb250ZXh0U2V0UHJvY2Vzc01vZGVsKToKKyAgICAgICAg KFdLQ29udGV4dEdldFByb2Nlc3NNb2RlbCk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dL Q29udGV4dC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcDogKFdlYktpdDo6 V2ViQ29udGV4dDo6c2V0UHJvY2Vzc01vZGVsKToKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQ29u dGV4dC5oOgorICAgICAgICBBZGRlZCBhIHNldHRlciBhbmQgYSBnZXR0ZXIuIFNldHRpbmcgcHJv Y2VzcyBtb2RlbCBpcyBvbmx5IGFsbG93ZWQgd2hlbiB0aGVyZSBhcmUKKyAgICAgICAgbm8gcHJv Y2Vzc2VzIHlldCAtIHRoYXQncyBjaGVja2VkIHdpdGggYSBDUkFTSCB0byBndWFyYW50ZWUgdGhh dCBjbGllbnRzIHVzaW5nCisgICAgICAgIHByb2R1Y3Rpb24gYnVpbGRzIG9mIFdlYktpdDIgZG9u J3QgbWlzc3RlcC4KKwogMjAxMi0wOC0yOCAgSm9uIExlZSAgPGpvbmxlZUBhcHBsZS5jb20+CiAK ICAgICAgICAgW1dLMl0gQnVncyBpbiBtYWludGVuYW5jZSBvZiBpbnRlcm5hbCBzdGF0ZSB3aGVu IHVzZXIgZGVjaWRlcyB3aGV0aGVyIHRvIGdyYW50IG5vdGlmaWNhdGlvbiBwZXJtaXNzaW9ucwpJ bmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcAkocmV2aXNpb24gMTI2 NzY5KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0yNTUsNiArMjU1LDE1IEBAIHZvaWQgV2ViQ29udGV4dDo6aW5pdGlhbGl6ZURv d25sb2FkQ2xpZW4KICAgICBtX2Rvd25sb2FkQ2xpZW50LmluaXRpYWxpemUoY2xpZW50KTsKIH0K IAordm9pZCBXZWJDb250ZXh0OjpzZXRQcm9jZXNzTW9kZWwoUHJvY2Vzc01vZGVsIHByb2Nlc3NN b2RlbCkKK3sKKyAgICAvLyBHdWFyZCBhZ2FpbnN0IEFQSSBtaXN1c2UuCisgICAgaWYgKCFtX3By b2Nlc3Nlcy5pc0VtcHR5KCkpCisgICAgICAgIENSQVNIKCk7CisKKyAgICBtX3Byb2Nlc3NNb2Rl bCA9IHByb2Nlc3NNb2RlbDsKK30KKwogV2ViUHJvY2Vzc1Byb3h5KiBXZWJDb250ZXh0OjpkZXBy ZWNhdGVkU2hhcmVkUHJvY2VzcygpCiB7CiAgICAgQVNTRVJUKG1fcHJvY2Vzc01vZGVsID09IFBy b2Nlc3NNb2RlbFNoYXJlZFNlY29uZGFyeVByb2Nlc3MpOwpJbmRleDogU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYkNvbnRleHQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViQ29udGV4dC5oCShyZXZpc2lvbiAxMjY3NjkpCisrKyBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvV2ViQ29udGV4dC5oCSh3b3JraW5nIGNvcHkpCkBAIC04OSw2ICs4OSw3IEBAIHB1 YmxpYzoKICAgICB2b2lkIGluaXRpYWxpemVIaXN0b3J5Q2xpZW50KGNvbnN0IFdLQ29udGV4dEhp c3RvcnlDbGllbnQqKTsKICAgICB2b2lkIGluaXRpYWxpemVEb3dubG9hZENsaWVudChjb25zdCBX S0NvbnRleHREb3dubG9hZENsaWVudCopOwogCisgICAgdm9pZCBzZXRQcm9jZXNzTW9kZWwoUHJv Y2Vzc01vZGVsKTsgLy8gQ2FuIG9ubHkgYmUgY2FsbGVkIHdoZW4gdGhlcmUgYXJlIG5vIHByb2Nl c3NlcyBydW5uaW5nLgogICAgIFByb2Nlc3NNb2RlbCBwcm9jZXNzTW9kZWwoKSBjb25zdCB7IHJl dHVybiBtX3Byb2Nlc3NNb2RlbDsgfQogCiAgICAgLy8gRklYTUUgKE11bHRpLVdlYlByb2Nlc3Mp OiBSZW1vdmUuIE5vIGNvZGUgc2hvdWxkIGFzc3VtZSB0aGF0IHRoZXJlIGlzIGEgc2hhcmVkIHBy b2Nlc3MuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tBUElDYXN0LmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQVBJQ2FzdC5o CShyZXZpc2lvbiAxMjY3NjkpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tB UElDYXN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTMwLDYgKzMwLDcgQEAKICNpbmNsdWRlICJDYWNo ZU1vZGVsLmgiCiAjaW5jbHVkZSAiRm9udFNtb290aGluZ0xldmVsLmgiCiAjaW5jbHVkZSAiSFRU UENvb2tpZUFjY2VwdFBvbGljeS5oIgorI2luY2x1ZGUgIlByb2Nlc3NNb2RlbC5oIgogI2luY2x1 ZGUgIlJlc291cmNlQ2FjaGVzVG9DbGVhci5oIgogI2luY2x1ZGUgIldlYkdyYW1tYXJEZXRhaWwu aCIKICNpbmNsdWRlICJXS0NvbnRleHQuaCIKQEAgLTE3NCw2ICsxNzUsMzEgQEAgaW5saW5lIFdL Q2FjaGVNb2RlbCB0b0FQSShDYWNoZU1vZGVsIGNhYwogICAgIHJldHVybiBrV0tDYWNoZU1vZGVs RG9jdW1lbnRWaWV3ZXI7CiB9CiAKK2lubGluZSBQcm9jZXNzTW9kZWwgdG9Qcm9jZXNzTW9kZWwo V0tQcm9jZXNzTW9kZWwgd2tQcm9jZXNzTW9kZWwpCit7CisgICAgc3dpdGNoICh3a1Byb2Nlc3NN b2RlbCkgeworICAgIGNhc2Uga1dLUHJvY2Vzc01vZGVsU2hhcmVkU2Vjb25kYXJ5UHJvY2VzczoK KyAgICAgICAgcmV0dXJuIFByb2Nlc3NNb2RlbFNoYXJlZFNlY29uZGFyeVByb2Nlc3M7CisgICAg Y2FzZSBrV0tQcm9jZXNzTW9kZWxNdWx0aXBsZVNlY29uZGFyeVByb2Nlc3NlczoKKyAgICAgICAg cmV0dXJuIFByb2Nlc3NNb2RlbE11bHRpcGxlU2Vjb25kYXJ5UHJvY2Vzc2VzOworICAgIH0KKwor ICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJldHVybiBQcm9jZXNzTW9kZWxTaGFyZWRT ZWNvbmRhcnlQcm9jZXNzOworfQorCitpbmxpbmUgV0tQcm9jZXNzTW9kZWwgdG9BUEkoUHJvY2Vz c01vZGVsIHByb2Nlc3NNb2RlbCkKK3sKKyAgICBzd2l0Y2ggKHByb2Nlc3NNb2RlbCkgeworICAg IGNhc2UgUHJvY2Vzc01vZGVsU2hhcmVkU2Vjb25kYXJ5UHJvY2VzczoKKyAgICAgICAgcmV0dXJu IGtXS1Byb2Nlc3NNb2RlbFNoYXJlZFNlY29uZGFyeVByb2Nlc3M7CisgICAgY2FzZSBQcm9jZXNz TW9kZWxNdWx0aXBsZVNlY29uZGFyeVByb2Nlc3NlczoKKyAgICAgICAgcmV0dXJuIGtXS1Byb2Nl c3NNb2RlbE11bHRpcGxlU2Vjb25kYXJ5UHJvY2Vzc2VzOworICAgIH0KKyAgICAKKyAgICByZXR1 cm4ga1dLUHJvY2Vzc01vZGVsU2hhcmVkU2Vjb25kYXJ5UHJvY2VzczsKK30KKwogaW5saW5lIEZv bnRTbW9vdGhpbmdMZXZlbCB0b0ZvbnRTbW9vdGhpbmdMZXZlbChXS0ZvbnRTbW9vdGhpbmdMZXZl bCB3a0xldmVsKQogewogICAgIHN3aXRjaCAod2tMZXZlbCkgewpJbmRleDogU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dC5jcHAJKHJldmlzaW9uIDEyNjc2OSkKKysr IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xMjAsNiArMTIwLDE2IEBAIFdLQ2FjaGVNb2RlbCBXS0NvbnRleHRHZXRDYWNoZU1v ZGVsKFdLQ28KICAgICByZXR1cm4gdG9BUEkodG9JbXBsKGNvbnRleHRSZWYpLT5jYWNoZU1vZGVs KCkpOwogfQogCit2b2lkIFdLQ29udGV4dFNldFByb2Nlc3NNb2RlbChXS0NvbnRleHRSZWYgY29u dGV4dFJlZiwgV0tQcm9jZXNzTW9kZWwgcHJvY2Vzc01vZGVsKQoreworICAgIHRvSW1wbChjb250 ZXh0UmVmKS0+c2V0UHJvY2Vzc01vZGVsKHRvUHJvY2Vzc01vZGVsKHByb2Nlc3NNb2RlbCkpOwor fQorCitXS1Byb2Nlc3NNb2RlbCBXS0NvbnRleHRHZXRQcm9jZXNzTW9kZWwoV0tDb250ZXh0UmVm IGNvbnRleHRSZWYpCit7CisgICAgcmV0dXJuIHRvQVBJKHRvSW1wbChjb250ZXh0UmVmKS0+cHJv Y2Vzc01vZGVsKCkpOworfQorCiB2b2lkIFdLQ29udGV4dFNldEFsd2F5c1VzZXNDb21wbGV4VGV4 dENvZGVQYXRoKFdLQ29udGV4dFJlZiBjb250ZXh0UmVmLCBib29sIGFsd2F5c1VzZUNvbXBsZXhU ZXh0Q29kZVBhdGgpCiB7CiAgICAgdG9JbXBsKGNvbnRleHRSZWYpLT5zZXRBbHdheXNVc2VzQ29t cGxleFRleHRDb2RlUGF0aChhbHdheXNVc2VDb21wbGV4VGV4dENvZGVQYXRoKTsKSW5kZXg6IFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHQuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0LmgJKHJldmlzaW9uIDEyNjc2 OSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHQuaAkod29ya2lu ZyBjb3B5KQpAQCAtMTIzLDYgKzEyMywxMiBAQCB0eXBlZGVmIHN0cnVjdCBXS0NvbnRleHRDb25u ZWN0aW9uQ2xpZW50CiAKIGVudW0geyBrV0tDb250ZXh0Q29ubmVjdGlvbkNsaWVudEN1cnJlbnRW ZXJzaW9uID0gMCB9OwogCitlbnVtIHsKKyAgICBrV0tQcm9jZXNzTW9kZWxTaGFyZWRTZWNvbmRh cnlQcm9jZXNzID0gMCwKKyAgICBrV0tQcm9jZXNzTW9kZWxNdWx0aXBsZVNlY29uZGFyeVByb2Nl c3NlcyA9IDEKK307Cit0eXBlZGVmIHVpbnQzMl90IFdLUHJvY2Vzc01vZGVsOworCiBXS19FWFBP UlQgV0tUeXBlSUQgV0tDb250ZXh0R2V0VHlwZUlEKCk7CiAKIFdLX0VYUE9SVCBXS0NvbnRleHRS ZWYgV0tDb250ZXh0Q3JlYXRlKCk7CkBAIC0xNDMsNiArMTQ5LDkgQEAgV0tfRVhQT1JUIHZvaWQg V0tDb250ZXh0QWRkVmlzaXRlZExpbmsoVwogV0tfRVhQT1JUIHZvaWQgV0tDb250ZXh0U2V0Q2Fj aGVNb2RlbChXS0NvbnRleHRSZWYgY29udGV4dCwgV0tDYWNoZU1vZGVsIGNhY2hlTW9kZWwpOwog V0tfRVhQT1JUIFdLQ2FjaGVNb2RlbCBXS0NvbnRleHRHZXRDYWNoZU1vZGVsKFdLQ29udGV4dFJl ZiBjb250ZXh0KTsKIAorV0tfRVhQT1JUIHZvaWQgV0tDb250ZXh0U2V0UHJvY2Vzc01vZGVsKFdL Q29udGV4dFJlZiBjb250ZXh0LCBXS1Byb2Nlc3NNb2RlbCBwcm9jZXNzTW9kZWwpOworV0tfRVhQ T1JUIFdLUHJvY2Vzc01vZGVsIFdLQ29udGV4dEdldFByb2Nlc3NNb2RlbChXS0NvbnRleHRSZWYg Y29udGV4dCk7CisKIFdLX0VYUE9SVCB2b2lkIFdLQ29udGV4dFN0YXJ0TWVtb3J5U2FtcGxlcihX S0NvbnRleHRSZWYgY29udGV4dCwgV0tEb3VibGVSZWYgaW50ZXJ2YWwpOwogV0tfRVhQT1JUIHZv aWQgV0tDb250ZXh0U3RvcE1lbW9yeVNhbXBsZXIoV0tDb250ZXh0UmVmIGNvbnRleHQpOwogCg==