95220 2012-08-28 11:14:26 -0700 [WK2] Bugs in maintenance of internal state when user decides whether to grant notification permissions 2012-08-28 11:30:32 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jonlee jonlee jberlin webkit-bug-importer oldest_to_newest 706538 0 jonlee 2012-08-28 11:14:26 -0700 When a user decides to grant/deny a website permission to post notifications, internal state was not being updated appropriately. 706539 1 webkit-bug-importer 2012-08-28 11:14:43 -0700 <rdar://problem/12189895> 706544 2 161019 jonlee 2012-08-28 11:21:09 -0700 Created attachment 161019 Patch 706557 3 161019 jberlin 2012-08-28 11:26:09 -0700 Comment on attachment 161019 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161019&action=review > Source/WebKit2/ChangeLog:9 > + A couple of the maps maintained by the request manager should have been cleaned up when the user decided. When the user decided what? 706562 4 161019 jonlee 2012-08-28 11:27:56 -0700 Comment on attachment 161019 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161019&action=review >> Source/WebKit2/ChangeLog:9 >> + A couple of the maps maintained by the request manager should have been cleaned up when the user decided. > > When the user decided what? ... to grant notification permissions. Updated. 706567 5 jonlee 2012-08-28 11:30:32 -0700 Committed r126903: <http://trac.webkit.org/changeset/126903> 161019 2012-08-28 11:21:09 -0700 2012-08-28 11:27:55 -0700 Patch bug-95220-20120828112100.patch text/plain 2512 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2OTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTk5MTJkNzY1NzhiN2I5 MmIyNDM4MTc3NzIzZDFiNmJiNWU1NTUyNC4uZDQ0OTNkNjMyN2JhYWE0MDljMmFiNjA5N2U5NTAy MzA1NDhjYmVhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEyLTA4LTI4ICBKb24g TGVlICA8am9ubGVlQGFwcGxlLmNvbT4KIAorICAgICAgICBbV0syXSBCdWdzIGluIG1haW50ZW5h bmNlIG9mIGludGVybmFsIHN0YXRlIHdoZW4gdXNlciBkZWNpZGVzIHdoZXRoZXIgdG8gZ3JhbnQg bm90aWZpY2F0aW9uIHBlcm1pc3Npb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05NTIyMAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTIxODk4OTU+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQSBjb3Vw bGUgb2YgdGhlIG1hcHMgbWFpbnRhaW5lZCBieSB0aGUgcmVxdWVzdCBtYW5hZ2VyIHNob3VsZCBo YXZlIGJlZW4gY2xlYW5lZCB1cCB3aGVuIHRoZSB1c2VyIGRlY2lkZWQuCisgICAgICAgIEFsc28s IHRoZSB3ZWIgcHJvY2VzcycgY29weSBvZiB0aGUgcGVybWlzc2lvbnMgd2FzIG5vdCB1cGRhdGVk IGFwcHJvcHJpYXRlbHkuIFRoaXMgbWVhbnQgdGhhdCBpbiB0aGUKKyAgICAgICAgcGVybWlzc2lv biBjYWxsYmFjaywgTm90aWZpY2F0aW9uLnBlcm1pc3Npb24gd2FzIG5vdCB0aGUgc2FtZSB2YWx1 ZSBhcyB0aGUgcGVybWlzc2lvbiB2YWx1ZSBpbmNsdWRlZCBhcworICAgICAgICB0aGUgZmlyc3Qg cGFyYW1ldGVyIG9mIHRoZSBjYWxsYmFjay4KKworICAgICAgICBUaGlzIGZpcnN0IHN1cmZhY2Vk IGFzIHBhcnQgb2YgdGhlIHdvcmsgdG8gYnJpbmcgTWFjIHN1cHBvcnQgZm9yIHdlYiBub3RpZmlj YXRpb25zLiBJIGhhdmUgYSB0ZXN0IHRoYXQKKyAgICAgICAgd2lsbCBjaGVjayBmb3IgcmVncmVz c2lvbnMgaW4gdGhpcyBhcmVhLCBvbmNlIGFsbCBvZiB0aGF0IGhhcyBiZWVuIGNoZWNrZWQgaW4g KGJ1ZyA3Nzk2OSkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMvTm90aWZp Y2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Tm90 aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyOjpkaWRSZWNlaXZlTm90aWZpY2F0aW9u UGVybWlzc2lvbkRlY2lzaW9uKToKKworMjAxMi0wOC0yOCAgSm9uIExlZSAgPGpvbmxlZUBhcHBs ZS5jb20+CisKICAgICAgICAgW1dLMl0gQWRkIFNQSSBmb3IgaW5qZWN0ZWQgYnVuZGxlIHRvIG1h bnVhbGx5IHNldCBwZXJtaXNzaW9ucwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTUxMjcKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyMTgyNjM1Pgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Ob3RpZmljYXRpb25zL05vdGlm aWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL05vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2Vy LmNwcAppbmRleCBlMGZlZDA5MTFlMGYxMTM5ODhiZjRlMTA1NTU1YmE4ZTFlZTEwMGE5Li4yMmU1 MGI5YjQzMzVkN2VlZmJjY2EzMjYyMjY3OWZiY2U5YTVlZWMwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uUGVybWlzc2lvblJl cXVlc3RNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05vdGlmaWNh dGlvbnMvTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyLmNwcApAQCAtMTUxLDYg KzE1MSwxMSBAQCB2b2lkIE5vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlcjo6ZGlk UmVjZWl2ZU5vdGlmaWNhdGlvblBlcm1pc3Npb25EZWNpcwogICAgIGlmICghaXNSZXF1ZXN0SURW YWxpZChyZXF1ZXN0SUQpKQogICAgICAgICByZXR1cm47CiAKKyAgICBSZWZQdHI8V2ViQ29yZTo6 U2VjdXJpdHlPcmlnaW4+IG9yaWdpbiA9IG1faWRUb09yaWdpbk1hcC50YWtlKHJlcXVlc3RJRCk7 CisgICAgbV9vcmlnaW5Ub0lETWFwLnJlbW92ZShvcmlnaW4pOworCisgICAgV2ViUHJvY2Vzczo6 c2hhcmVkKCkubm90aWZpY2F0aW9uTWFuYWdlcigpLmRpZFVwZGF0ZU5vdGlmaWNhdGlvbkRlY2lz aW9uKG9yaWdpbi0+dG9TdHJpbmcoKSwgYWxsb3dlZCk7CisKICNpZiBFTkFCTEUoTEVHQUNZX05P VElGSUNBVElPTlMpCiAgICAgUmVmUHRyPFZvaWRDYWxsYmFjaz4gdm9pZENhbGxiYWNrID0gbV9p ZFRvVm9pZENhbGxiYWNrTWFwLnRha2UocmVxdWVzdElEKTsKICAgICBpZiAodm9pZENhbGxiYWNr KSB7Cg==