95206 2012-08-28 08:28:24 -0700 [chromium] Split some ASSERT(a && b && c) statements into separate lines. 2012-08-28 09:48:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 husky webkit-unassigned cc-bugs husky jamesr piman webkit.review.bot oldest_to_newest 706375 0 husky 2012-08-28 08:28:24 -0700 [chromium] Split some ASSERT(a && b && c) statements into separate lines. 706378 1 160990 husky 2012-08-28 08:30:00 -0700 Created attachment 160990 Patch 706381 2 husky 2012-08-28 08:33:16 -0700 Context: I'm hitting some of these assertions in the Android content shell 706443 3 160990 webkit.review.bot 2012-08-28 09:48:40 -0700 Comment on attachment 160990 Patch Clearing flags on attachment: 160990 Committed r126889: <http://trac.webkit.org/changeset/126889> 706444 4 webkit.review.bot 2012-08-28 09:48:43 -0700 All reviewed patches have been landed. Closing bug. 160990 2012-08-28 08:30:00 -0700 2012-08-28 09:48:40 -0700 Patch bug-95206-20120828162951.patch text/plain 5017 husky U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2ODc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODc0NTI2YWNhNzViYTRi MDQzZDFiNTVkNzc2MmZiZGNlNmU4YmFiNy4uZTJlNGFlZDVhODk4NDgyNWVmNzY3ODFjZDJlZGFj NWUyNzkxZjQ2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA4LTI4ICBJYWlu IE1lcnJpY2sgIDxodXNreUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBTcGxp dCBzb21lIEFTU0VSVChhICYmIGIgJiYgYykgc3RhdGVtZW50cyBpbnRvIHNlcGFyYXRlIGxpbmVz LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTUyMDYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIG1h a2VzIGZvciBlYXNpZXIgZGVidWdnaW5nLCBhcyB5b3UgY2FuIGltbWVkaWF0ZWx5IHNlZSB3aGlj aCBjbGF1c2UKKyAgICAgICAgaGFzIGZhaWxlZC4KKworICAgICAgICBObyBjaGFuZ2UgaW4gYmVo YXZpb3IsIG5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9jYy9DQ1Jlc291cmNlUHJvdmlkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q0NSZXNvdXJjZVByb3ZpZGVyOjpkZWxldGVSZXNvdXJjZSk6CisgICAgICAgIChXZWJDb3JlOjpD Q1Jlc291cmNlUHJvdmlkZXI6OnVwbG9hZCk6CisgICAgICAgIChXZWJDb3JlOjpDQ1Jlc291cmNl UHJvdmlkZXI6OmxvY2tGb3JSZWFkKToKKyAgICAgICAgKFdlYkNvcmU6OkNDUmVzb3VyY2VQcm92 aWRlcjo6dW5sb2NrRm9yUmVhZCk6CisgICAgICAgIChXZWJDb3JlOjpDQ1Jlc291cmNlUHJvdmlk ZXI6OmxvY2tGb3JXcml0ZSk6CisgICAgICAgIChXZWJDb3JlOjpDQ1Jlc291cmNlUHJvdmlkZXI6 OnVubG9ja0ZvcldyaXRlKToKKyAgICAgICAgKFdlYkNvcmU6OkNDUmVzb3VyY2VQcm92aWRlcjo6 dHJhbnNmZXJSZXNvdXJjZSk6CisKIDIwMTItMDgtMjggIFBhcnRoIFBhdGVsICA8cGFycGF0ZWxA cmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gUmVtb3ZpbmcgdW5uZWNlc3NhcnkgaW5j bHVkZSBvZiBDbGFzcyBCbGFja0JlcnJ5UGxhdGZvcm1DbGllbnQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUmVzb3VyY2VQcm92aWRl ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1Jl c291cmNlUHJvdmlkZXIuY3BwCmluZGV4IDNhYWQxNDdjYTY0NDczN2Q0ZTJmY2ZkOTNhZWM3ODEy ZTJlMjAxZjguLmZjM2JmZTdlMTVmMGE3YmIwM2FmNTdkZTU2OGJmYWNkNmE5NDUxODggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUmVz b3VyY2VQcm92aWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vY2MvQ0NSZXNvdXJjZVByb3ZpZGVyLmNwcApAQCAtMTU0LDcgKzE1NCw5IEBAIHZv aWQgQ0NSZXNvdXJjZVByb3ZpZGVyOjpkZWxldGVSZXNvdXJjZShSZXNvdXJjZUlkIGlkKQogewog ICAgIEFTU0VSVChDQ1Byb3h5Ojppc0ltcGxUaHJlYWQoKSk7CiAgICAgUmVzb3VyY2VNYXA6Oml0 ZXJhdG9yIGl0ID0gbV9yZXNvdXJjZXMuZmluZChpZCk7Ci0gICAgQVNTRVJUKGl0ICE9IG1fcmVz b3VyY2VzLmVuZCgpICYmICFpdC0+c2Vjb25kLmxvY2tlZEZvcldyaXRlICYmICFpdC0+c2Vjb25k LmxvY2tGb3JSZWFkQ291bnQpOworICAgIEFTU0VSVChpdCAhPSBtX3Jlc291cmNlcy5lbmQoKSk7 CisgICAgQVNTRVJUKCFpdC0+c2Vjb25kLmxvY2tlZEZvcldyaXRlKTsKKyAgICBBU1NFUlQoIWl0 LT5zZWNvbmQubG9ja0ZvclJlYWRDb3VudCk7CiAKICAgICBpZiAoaXQtPnNlY29uZC5nbElkICYm ICFpdC0+c2Vjb25kLmV4dGVybmFsKSB7CiAgICAgICAgIFdlYkdyYXBoaWNzQ29udGV4dDNEKiBj b250ZXh0M2QgPSBtX2NvbnRleHQtPmNvbnRleHQzRCgpOwpAQCAtMTkwLDcgKzE5MiwxMCBAQCB2 b2lkIENDUmVzb3VyY2VQcm92aWRlcjo6dXBsb2FkKFJlc291cmNlSWQgaWQsIGNvbnN0IHVpbnQ4 X3QqIGltYWdlLCBjb25zdCBJbnRSZQogewogICAgIEFTU0VSVChDQ1Byb3h5Ojppc0ltcGxUaHJl YWQoKSk7CiAgICAgUmVzb3VyY2VNYXA6Oml0ZXJhdG9yIGl0ID0gbV9yZXNvdXJjZXMuZmluZChp ZCk7Ci0gICAgQVNTRVJUKGl0ICE9IG1fcmVzb3VyY2VzLmVuZCgpICYmICFpdC0+c2Vjb25kLmxv Y2tlZEZvcldyaXRlICYmICFpdC0+c2Vjb25kLmxvY2tGb3JSZWFkQ291bnQgJiYgIWl0LT5zZWNv bmQuZXh0ZXJuYWwpOworICAgIEFTU0VSVChpdCAhPSBtX3Jlc291cmNlcy5lbmQoKSk7CisgICAg QVNTRVJUKCFpdC0+c2Vjb25kLmxvY2tlZEZvcldyaXRlKTsKKyAgICBBU1NFUlQoIWl0LT5zZWNv bmQubG9ja0ZvclJlYWRDb3VudCk7CisgICAgQVNTRVJUKCFpdC0+c2Vjb25kLmV4dGVybmFsKTsK IAogICAgIGlmIChpdC0+c2Vjb25kLmdsSWQpIHsKICAgICAgICAgV2ViR3JhcGhpY3NDb250ZXh0 M0QqIGNvbnRleHQzZCA9IG1fY29udGV4dC0+Y29udGV4dDNEKCk7CkBAIC0yMzgsNyArMjQzLDgg QEAgY29uc3QgQ0NSZXNvdXJjZVByb3ZpZGVyOjpSZXNvdXJjZSogQ0NSZXNvdXJjZVByb3ZpZGVy Ojpsb2NrRm9yUmVhZChSZXNvdXJjZUlkIGkKIHsKICAgICBBU1NFUlQoQ0NQcm94eTo6aXNJbXBs VGhyZWFkKCkpOwogICAgIFJlc291cmNlTWFwOjppdGVyYXRvciBpdCA9IG1fcmVzb3VyY2VzLmZp bmQoaWQpOwotICAgIEFTU0VSVChpdCAhPSBtX3Jlc291cmNlcy5lbmQoKSAmJiAhaXQtPnNlY29u ZC5sb2NrZWRGb3JXcml0ZSk7CisgICAgQVNTRVJUKGl0ICE9IG1fcmVzb3VyY2VzLmVuZCgpKTsK KyAgICBBU1NFUlQoIWl0LT5zZWNvbmQubG9ja2VkRm9yV3JpdGUpOwogICAgIGl0LT5zZWNvbmQu bG9ja0ZvclJlYWRDb3VudCsrOwogICAgIHJldHVybiAmaXQtPnNlY29uZDsKIH0KQEAgLTI0Nyw3 ICsyNTMsOCBAQCB2b2lkIENDUmVzb3VyY2VQcm92aWRlcjo6dW5sb2NrRm9yUmVhZChSZXNvdXJj ZUlkIGlkKQogewogICAgIEFTU0VSVChDQ1Byb3h5Ojppc0ltcGxUaHJlYWQoKSk7CiAgICAgUmVz b3VyY2VNYXA6Oml0ZXJhdG9yIGl0ID0gbV9yZXNvdXJjZXMuZmluZChpZCk7Ci0gICAgQVNTRVJU KGl0ICE9IG1fcmVzb3VyY2VzLmVuZCgpICYmIGl0LT5zZWNvbmQubG9ja0ZvclJlYWRDb3VudCA+ IDApOworICAgIEFTU0VSVChpdCAhPSBtX3Jlc291cmNlcy5lbmQoKSk7CisgICAgQVNTRVJUKGl0 LT5zZWNvbmQubG9ja0ZvclJlYWRDb3VudCA+IDApOwogICAgIGl0LT5zZWNvbmQubG9ja0ZvclJl YWRDb3VudC0tOwogfQogCkBAIC0yNTUsNyArMjYyLDEwIEBAIGNvbnN0IENDUmVzb3VyY2VQcm92 aWRlcjo6UmVzb3VyY2UqIENDUmVzb3VyY2VQcm92aWRlcjo6bG9ja0ZvcldyaXRlKFJlc291cmNl SWQKIHsKICAgICBBU1NFUlQoQ0NQcm94eTo6aXNJbXBsVGhyZWFkKCkpOwogICAgIFJlc291cmNl TWFwOjppdGVyYXRvciBpdCA9IG1fcmVzb3VyY2VzLmZpbmQoaWQpOwotICAgIEFTU0VSVChpdCAh PSBtX3Jlc291cmNlcy5lbmQoKSAmJiAhaXQtPnNlY29uZC5sb2NrZWRGb3JXcml0ZSAmJiAhaXQt PnNlY29uZC5sb2NrRm9yUmVhZENvdW50ICYmICFpdC0+c2Vjb25kLmV4dGVybmFsKTsKKyAgICBB U1NFUlQoaXQgIT0gbV9yZXNvdXJjZXMuZW5kKCkpOworICAgIEFTU0VSVCghaXQtPnNlY29uZC5s b2NrZWRGb3JXcml0ZSk7CisgICAgQVNTRVJUKCFpdC0+c2Vjb25kLmxvY2tGb3JSZWFkQ291bnQp OworICAgIEFTU0VSVCghaXQtPnNlY29uZC5leHRlcm5hbCk7CiAgICAgaXQtPnNlY29uZC5sb2Nr ZWRGb3JXcml0ZSA9IHRydWU7CiAgICAgcmV0dXJuICZpdC0+c2Vjb25kOwogfQpAQCAtMjY0LDcg KzI3NCw5IEBAIHZvaWQgQ0NSZXNvdXJjZVByb3ZpZGVyOjp1bmxvY2tGb3JXcml0ZShSZXNvdXJj ZUlkIGlkKQogewogICAgIEFTU0VSVChDQ1Byb3h5Ojppc0ltcGxUaHJlYWQoKSk7CiAgICAgUmVz b3VyY2VNYXA6Oml0ZXJhdG9yIGl0ID0gbV9yZXNvdXJjZXMuZmluZChpZCk7Ci0gICAgQVNTRVJU KGl0ICE9IG1fcmVzb3VyY2VzLmVuZCgpICYmIGl0LT5zZWNvbmQubG9ja2VkRm9yV3JpdGUgJiYg IWl0LT5zZWNvbmQuZXh0ZXJuYWwpOworICAgIEFTU0VSVChpdCAhPSBtX3Jlc291cmNlcy5lbmQo KSk7CisgICAgQVNTRVJUKGl0LT5zZWNvbmQubG9ja2VkRm9yV3JpdGUpOworICAgIEFTU0VSVCgh aXQtPnNlY29uZC5leHRlcm5hbCk7CiAgICAgaXQtPnNlY29uZC5sb2NrZWRGb3JXcml0ZSA9IGZh bHNlOwogfQogCkBAIC01MDUsNyArNTE3LDEwIEBAIGJvb2wgQ0NSZXNvdXJjZVByb3ZpZGVyOjp0 cmFuc2ZlclJlc291cmNlKFdlYkdyYXBoaWNzQ29udGV4dDNEKiBjb250ZXh0LCBSZXNvdXJjCiB7 CiAgICAgQVNTRVJUKENDUHJveHk6OmlzSW1wbFRocmVhZCgpKTsKICAgICBSZXNvdXJjZU1hcDo6 Y29uc3RfaXRlcmF0b3IgaXQgPSBtX3Jlc291cmNlcy5maW5kKGlkKTsKLSAgICBBU1NFUlQoaXQg IT0gbV9yZXNvdXJjZXMuZW5kKCkgJiYgIWl0LT5zZWNvbmQubG9ja2VkRm9yV3JpdGUgJiYgIWl0 LT5zZWNvbmQubG9ja0ZvclJlYWRDb3VudCAmJiAhaXQtPnNlY29uZC5leHRlcm5hbCk7CisgICAg QVNTRVJUKGl0ICE9IG1fcmVzb3VyY2VzLmVuZCgpKTsKKyAgICBBU1NFUlQoIWl0LT5zZWNvbmQu bG9ja2VkRm9yV3JpdGUpOworICAgIEFTU0VSVCghaXQtPnNlY29uZC5sb2NrRm9yUmVhZENvdW50 KTsKKyAgICBBU1NFUlQoIWl0LT5zZWNvbmQuZXh0ZXJuYWwpOwogICAgIGlmIChpdC0+c2Vjb25k LmV4cG9ydGVkKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgcmVzb3VyY2UtPmlkID0gaWQ7 Cg==