95203 2012-08-28 07:54:41 -0700 Dotted borders not drawn with rounded dots 2024-08-05 18:45:07 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified ASSIGNED Gtk, InRadar P2 Normal --- 25737 1 martin.leutelt mmaxfield bruno.abinader dbates gustavo mmaxfield mrobinson simon.fraser oldest_to_newest 706343 0 martin.leutelt 2012-08-28 07:54:41 -0700 As per CSS spec here http://www.w3.org/TR/css3-background/#border-style dotted borders should be drawn with rounded dots. Websites for testing: http://www.w3schools.com/cssref/tryit.asp?filename=trycss_border-style http://dev.harnos.at/webkit/border-bug/ 706365 1 160987 martin.leutelt 2012-08-28 08:18:31 -0700 Created attachment 160987 Proposed patch 708765 2 mrobinson 2012-08-30 10:05:57 -0700 I think when evaluating this patch it would be very useful to see how it affects pixel results. Many pixel results are out of date so here's my suggestion: 1. Run pixel tests and update all results. 2. Run pixel results again and detect which results change. 3. Attach only results that changed to your patch. Be sure to run tests with the jhbuild environment by running $ Tools/Scripts/update-webkitgtk-libs before you build. 709509 3 161671 martin.leutelt 2012-08-31 05:22:02 -0700 Created attachment 161671 Patch with updated expected results 710708 4 mrobinson 2012-09-03 10:22:25 -0700 A couple things worry me about this patch: 1. It doesn't look like any other WebKit browsers that I tested (Chromium and Safari on Mac) and Firefox use rounded dots. 2. This patch changes the behavior for content not rendered according to the CSS spec as well. 710845 5 martin.leutelt 2012-09-04 00:04:46 -0700 Thanks for your comments. on 1: For Chromium I already submitted a patch (https://bugs.webkit.org/show_bug.cgi?id=94917). I'm waiting on some comments there. The patch for the Qt port has already been landed (https://bugs.webkit.org/show_bug.cgi?id=92383). I can't build the mac port so I won't be able to submit a patch for that. To track all those patches I guess we should use this one (https://bugs.webkit.org/show_bug.cgi?id=25737). Firefox uses rounded dots but also not according to the css spec. on 2: Could you give me some example for a case where the patch would lead to some unexpected outcome? 976953 6 161671 andersca 2014-02-05 11:12:44 -0800 Comment on attachment 161671 Patch with updated expected results Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag. 1203931 7 mmaxfield 2016-06-20 16:20:00 -0700 <rdar://problem/3175114> 2050807 8 simon.fraser 2024-08-05 18:45:07 -0700 I don't think this is particularly easy 160987 2012-08-28 08:18:31 -0700 2012-08-31 05:22:02 -0700 Proposed patch 0001-Gtk-Dotted-borders-not-drawn-with-rounded-dots.patch text/plain 7937 martin.leutelt RnJvbSAyYTlkYzA4ZWU2NGQ0NTA5YTU0NTc5NmY2MjVkMGEwNzJkOGM1NWJiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gTGV1dGVsdCA8bWFydGluLmxldXRlbHRAYmFzeXNr b20uY29tPgpEYXRlOiBUdWUsIDI4IEF1ZyAyMDEyIDE3OjAxOjQwICswMjAwClN1YmplY3Q6IFtQ QVRDSF0gW0d0a10gRG90dGVkIGJvcmRlcnMgbm90IGRyYXduIHdpdGggcm91bmRlZCBkb3RzCiBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTUyMDMKClRoZSBkb3RzIGlu IGJvcmRlcnMgd2l0aCBkb3R0ZWQgc3R5bGUgd2VyZSBwcmV2aW91c2x5IGRyYXduIHdpdGgKcmVj dGFuZ3VsYXIgZG90cy4gVGhlIENTUyBzcGVjIHNwZWNpZmllcyB0aGF0IHRoZSBkb3RzIHNob3Vs ZApiZSByb3VuZGVkIGRvdHMuIFRoaXMgcGF0Y2ggZml4ZXMgdGhpcyBiZWhhdmlvciBmb3IgdGhl IEd0ayBwb3J0LgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAg ICAgICAgICAgIHwgICAxOSArKysrCiAuLi4vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0 Q2Fpcm8uY3BwICAgICAgICB8ICAgOTAgKysrKysrKysrKysrKysrKy0tLS0KIDIgZmlsZXMgY2hh bmdlZCwgOTIgaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGVi MmE5MjYuLmQ4ZmZjMjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMi0wOC0yOCAg TWFydGluIExldXRlbHQgIDxtYXJ0aW4ubGV1dGVsdEBiYXN5c2tvbS5jb20+CisKKyAgICAgICAg W0d0a10gRG90dGVkIGJvcmRlcnMgbm90IGRyYXduIHdpdGggcm91bmRlZCBkb3RzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTIwMworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBkb3RzIGluIGJvcmRl cnMgd2l0aCBkb3R0ZWQgc3R5bGUgd2VyZSBwcmV2aW91c2x5IGRyYXduIHdpdGgKKyAgICAgICAg cmVjdGFuZ3VsYXIgZG90cy4gVGhlIENTUyBzcGVjIHNwZWNpZmllcyB0aGF0IHRoZSBkb3RzIHNo b3VsZAorICAgICAgICBiZSByb3VuZGVkIGRvdHMuIFRoaXMgcGF0Y2ggZml4ZXMgdGhpcyBiZWhh dmlvciBmb3IgdGhlIEd0ayBwb3J0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgY292ZXJlZCBi eSBleGlzdGluZyBvbmVzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3Jh cGhpY3NDb250ZXh0Q2Fpcm8uY3BwOgorICAgICAgICAoV2ViQ29yZTo6ZmlsbENpcmNsZVdpdGhD b2xvcik6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OmRyYXdMaW5lRW5k cG9pbnRzRm9yU3R5bGUpOgorICAgICAgICAoV2ViQ29yZTo6ZHJhd0xpbmVPbkNhaXJvQ29udGV4 dCk6CisKIDIwMTItMDgtMjcgIE1pa2hhaWwgUG96ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtv dkBpbnRlbC5jb20+CiAKICAgICAgICAgUmVuYW1lIFJlZ2lzdGVyUHJvdG9jb2xIYW5kbGVyIEFQ SSB0byBOYXZpZ2F0b3JDb250ZW50VXRpbHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcApp bmRleCAyMDNkOGYzLi5hYTA0MzFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwCkBA IC04MSw2ICs4MSwxNSBAQCBzdGF0aWMgaW5saW5lIHZvaWQgZmlsbFJlY3RXaXRoQ29sb3IoY2Fp cm9fdCogY3IsIGNvbnN0IEZsb2F0UmVjdCYgcmVjdCwgY29uc3QgQwogICAgIGNhaXJvX2ZpbGwo Y3IpOwogfQogCitzdGF0aWMgaW5saW5lIHZvaWQgZmlsbENpcmNsZVdpdGhDb2xvcihjYWlyb190 KiBjciwgZmxvYXQgeCwgZmxvYXQgeSwgZmxvYXQgcmFkaXVzLCBjb25zdCBDb2xvciYgY29sb3Ip Cit7CisgICAgaWYgKCFjb2xvci5hbHBoYSgpKQorICAgICAgICByZXR1cm47CisgICAgc2V0U291 cmNlUkdCQUZyb21Db2xvcihjciwgY29sb3IpOworICAgIGNhaXJvX2FyYyhjciwgeCwgeSwgcmFk aXVzLCAwLCAyICogTV9QSSk7CisgICAgY2Fpcm9fZmlsbChjcik7Cit9CisKIHN0YXRpYyB2b2lk IGFkZENvbnZleFBvbHlnb25Ub0NvbnRleHQoY2Fpcm9fdCogY29udGV4dCwgc2l6ZV90IG51bVBv aW50cywgY29uc3QgRmxvYXRQb2ludCogcG9pbnRzKQogewogICAgIGNhaXJvX21vdmVfdG8oY29u dGV4dCwgcG9pbnRzWzBdLngoKSwgcG9pbnRzWzBdLnkoKSk7CkBAIC0yNzgsNiArMjg3LDQwIEBA IHN0YXRpYyBkb3VibGUgY2FsY3VsYXRlU3Ryb2tlUGF0dGVybk9mZnNldChpbnQgZGlzdGFuY2Us IGludCBwYXR0ZXJuV2lkdGgpCiAgICAgcmV0dXJuIDA7CiB9CiAKK3N0YXRpYyB2b2lkIGRyYXdM aW5lRW5kcG9pbnRzRm9yU3R5bGUoY2Fpcm9fdCogY29udGV4dCwgY29uc3QgRmxvYXRQb2ludCYg cG9pbnQxLCBjb25zdCBGbG9hdFBvaW50JiBwb2ludDIsIGZsb2F0IHdpZHRoLCBib29sIGlzVmVy dGljYWxMaW5lLCBTdHJva2VTdHlsZSBzdHlsZSwgQ29sb3IgY29sb3IpCit7CisgICAgRmxvYXRS ZWN0IGZpcnN0UmVjdChwb2ludDEsIEZsb2F0U2l6ZSh3aWR0aCwgd2lkdGgpKTsKKyAgICBGbG9h dFJlY3Qgc2Vjb25kUmVjdChwb2ludDIsIEZsb2F0U2l6ZSh3aWR0aCwgd2lkdGgpKTsKKyAgICBp ZiAoaXNWZXJ0aWNhbExpbmUpIHsKKyAgICAgICAgZmlyc3RSZWN0Lm1vdmUoLXdpZHRoIC8gMiwg LXdpZHRoKTsKKyAgICAgICAgc2Vjb25kUmVjdC5tb3ZlKC13aWR0aCAvIDIsIDApOworICAgIH0g ZWxzZSB7CisgICAgICAgIGZpcnN0UmVjdC5tb3ZlKC13aWR0aCwgLXdpZHRoIC8gMik7CisgICAg ICAgIHNlY29uZFJlY3QubW92ZSgwLCAtd2lkdGggLyAyKTsKKyAgICB9CisKKyAgICBpZiAoc3R5 bGUgPT0gRGFzaGVkU3Ryb2tlKSB7CisgICAgICAgIC8vIERvIGEgcmVjdCBmaWxsIG9mIG91ciBl bmRwb2ludHMuIFRoaXMgZW5zdXJlcyB3ZSBhbHdheXMgaGF2ZSB0aGUKKyAgICAgICAgLy8gYXBw ZWFyYW5jZSBvZiBiZWluZyBhIGJvcmRlci4KKyAgICAgICAgZmlsbFJlY3RXaXRoQ29sb3IoY29u dGV4dCwgZmlyc3RSZWN0LCBjb2xvcik7CisgICAgICAgIGZpbGxSZWN0V2l0aENvbG9yKGNvbnRl eHQsIHNlY29uZFJlY3QsIGNvbG9yKTsKKyAgICB9CisKKyAgICBpZiAoc3R5bGUgPT0gRG90dGVk U3Ryb2tlKSB7CisgICAgICAgIC8vIGNhaXJvX2FyYyBkb2Vzbid0IHdvcmsgaWYgdGhlIGNpcmNs ZSBvbmx5IGNvdmVycyBvbmUgcGl4ZWwgc28gd2UgZmFsbCBiYWNrIHRvCisgICAgICAgIC8vIGRy YXdpbmcgYSByZWN0IGluIHRoYXQgY2FzZS4KKyAgICAgICAgaWYgKHdpZHRoIDwgMikgeworICAg ICAgICAgICAgZmlsbFJlY3RXaXRoQ29sb3IoY29udGV4dCwgZmlyc3RSZWN0LCBjb2xvcik7Cisg ICAgICAgICAgICBmaWxsUmVjdFdpdGhDb2xvcihjb250ZXh0LCBzZWNvbmRSZWN0LCBjb2xvcik7 CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAvLyBFbmFibGUgQUEgZm9yIGJvcmRlcnMg d2l0aCBhIHRoaWNrbmVzcyB0aGF0IGlzIHN1ZmZpY2llbnQgdG8gbWFrZSBhIG5vdGljZWFibGUg ZGlmZmVyZW5jZQorICAgICAgICAgICAgY2Fpcm9fc2V0X2FudGlhbGlhcyhjb250ZXh0LCBDQUlS T19BTlRJQUxJQVNfREVGQVVMVCk7CisgICAgICAgICAgICBmaWxsQ2lyY2xlV2l0aENvbG9yKGNv bnRleHQsIGZpcnN0UmVjdC54KCkgKyB3aWR0aCAvIDIsIGZpcnN0UmVjdC55KCkgKyB3aWR0aCAv IDIsIHdpZHRoIC8gMiwgY29sb3IpOworICAgICAgICAgICAgZmlsbENpcmNsZVdpdGhDb2xvcihj b250ZXh0LCBzZWNvbmRSZWN0LngoKSArIHdpZHRoIC8gMiwgc2Vjb25kUmVjdC55KCkgKyB3aWR0 aCAvIDIsIHdpZHRoIC8gMiwgY29sb3IpOworICAgICAgICB9CisgICAgfQorfQorCiBzdGF0aWMg dm9pZCBkcmF3TGluZU9uQ2Fpcm9Db250ZXh0KEdyYXBoaWNzQ29udGV4dCogZ3JhcGhpY3NDb250 ZXh0LCBjYWlyb190KiBjb250ZXh0LCBjb25zdCBGbG9hdFBvaW50JiBwb2ludDEsIGNvbnN0IEZs b2F0UG9pbnQmIHBvaW50MikKIHsKICAgICBTdHJva2VTdHlsZSBzdHlsZSA9IGdyYXBoaWNzQ29u dGV4dC0+c3Ryb2tlU3R5bGUoKTsKQEAgLTMwMCwyNiArMzQzLDM5IEBAIHN0YXRpYyB2b2lkIGRy YXdMaW5lT25DYWlyb0NvbnRleHQoR3JhcGhpY3NDb250ZXh0KiBncmFwaGljc0NvbnRleHQsIGNh aXJvX3QqIGNvCiAgICAgRmxvYXRQb2ludCBwb2ludDJPblBpeGVsQm91bmRhcmllcyA9IHBvaW50 MjsKICAgICBHcmFwaGljc0NvbnRleHQ6OmFkanVzdExpbmVUb1BpeGVsQm91bmRhcmllcyhwb2lu dDFPblBpeGVsQm91bmRhcmllcywgcG9pbnQyT25QaXhlbEJvdW5kYXJpZXMsIHN0cm9rZVRoaWNr bmVzcywgc3R5bGUpOwogCi0gICAgY2Fpcm9fc2V0X2FudGlhbGlhcyhjb250ZXh0LCBDQUlST19B TlRJQUxJQVNfTk9ORSk7CiAgICAgaWYgKHBhdHRlcm5XaWR0aCkgewotICAgICAgICAvLyBEbyBh IHJlY3QgZmlsbCBvZiBvdXIgZW5kcG9pbnRzLiAgVGhpcyBlbnN1cmVzIHdlIGFsd2F5cyBoYXZl IHRoZQotICAgICAgICAvLyBhcHBlYXJhbmNlIG9mIGJlaW5nIGEgYm9yZGVyLiAgV2UgdGhlbiBk cmF3IHRoZSBhY3R1YWwgZG90dGVkL2Rhc2hlZCBsaW5lLgotICAgICAgICBGbG9hdFJlY3QgZmly c3RSZWN0KHBvaW50MU9uUGl4ZWxCb3VuZGFyaWVzLCBGbG9hdFNpemUoc3Ryb2tlVGhpY2tuZXNz LCBzdHJva2VUaGlja25lc3MpKTsKLSAgICAgICAgRmxvYXRSZWN0IHNlY29uZFJlY3QocG9pbnQy T25QaXhlbEJvdW5kYXJpZXMsIEZsb2F0U2l6ZShzdHJva2VUaGlja25lc3MsIHN0cm9rZVRoaWNr bmVzcykpOwotICAgICAgICBpZiAoaXNWZXJ0aWNhbExpbmUpIHsKLSAgICAgICAgICAgIGZpcnN0 UmVjdC5tb3ZlKC1zdHJva2VUaGlja25lc3MgLyAyLCAtc3Ryb2tlVGhpY2tuZXNzKTsKLSAgICAg ICAgICAgIHNlY29uZFJlY3QubW92ZSgtc3Ryb2tlVGhpY2tuZXNzIC8gMiwgMCk7Ci0gICAgICAg IH0gZWxzZSB7Ci0gICAgICAgICAgICBmaXJzdFJlY3QubW92ZSgtc3Ryb2tlVGhpY2tuZXNzLCAt c3Ryb2tlVGhpY2tuZXNzIC8gMik7Ci0gICAgICAgICAgICBzZWNvbmRSZWN0Lm1vdmUoMCwgLXN0 cm9rZVRoaWNrbmVzcyAvIDIpOworICAgICAgICBkcmF3TGluZUVuZHBvaW50c0ZvclN0eWxlKGNv bnRleHQsIHBvaW50MU9uUGl4ZWxCb3VuZGFyaWVzLCBwb2ludDJPblBpeGVsQm91bmRhcmllcywg c3Ryb2tlVGhpY2tuZXNzLCBpc1ZlcnRpY2FsTGluZSwgc3R5bGUsIHN0cm9rZUNvbG9yKTsKKwor ICAgICAgICBpZiAoc3R5bGUgPT0gRGFzaGVkU3Ryb2tlKSB7CisgICAgICAgICAgICBjYWlyb19z ZXRfYW50aWFsaWFzKGNvbnRleHQsIENBSVJPX0FOVElBTElBU19OT05FKTsKKyAgICAgICAgICAg IGludCBkaXN0YW5jZSA9IChpc1ZlcnRpY2FsTGluZSA/IChwb2ludDIueSgpIC0gcG9pbnQxLnko KSkgOiAocG9pbnQyLngoKSAtIHBvaW50MS54KCkpKSAtIDIgKiBzdHJva2VUaGlja25lc3M7Cisg ICAgICAgICAgICBkb3VibGUgcGF0dGVybk9mZnNldCA9IGNhbGN1bGF0ZVN0cm9rZVBhdHRlcm5P ZmZzZXQoZGlzdGFuY2UsIHBhdHRlcm5XaWR0aCk7CisgICAgICAgICAgICBkb3VibGUgcGF0dGVy bldpZHRoQXNEb3VibGUgPSBwYXR0ZXJuV2lkdGg7CisgICAgICAgICAgICBjYWlyb19zZXRfZGFz aChjb250ZXh0LCAmcGF0dGVybldpZHRoQXNEb3VibGUsIDEsIHBhdHRlcm5PZmZzZXQpOwogICAg ICAgICB9Ci0gICAgICAgIGZpbGxSZWN0V2l0aENvbG9yKGNvbnRleHQsIGZpcnN0UmVjdCwgc3Ry b2tlQ29sb3IpOwotICAgICAgICBmaWxsUmVjdFdpdGhDb2xvcihjb250ZXh0LCBzZWNvbmRSZWN0 LCBzdHJva2VDb2xvcik7CiAKLSAgICAgICAgaW50IGRpc3RhbmNlID0gKGlzVmVydGljYWxMaW5l ID8gKHBvaW50Mi55KCkgLSBwb2ludDEueSgpKSA6IChwb2ludDIueCgpIC0gcG9pbnQxLngoKSkp IC0gMiAqIHN0cm9rZVRoaWNrbmVzczsKLSAgICAgICAgZG91YmxlIHBhdHRlcm5PZmZzZXQgPSBj YWxjdWxhdGVTdHJva2VQYXR0ZXJuT2Zmc2V0KGRpc3RhbmNlLCBwYXR0ZXJuV2lkdGgpOwotICAg ICAgICBkb3VibGUgcGF0dGVybldpZHRoQXNEb3VibGUgPSBwYXR0ZXJuV2lkdGg7Ci0gICAgICAg IGNhaXJvX3NldF9kYXNoKGNvbnRleHQsICZwYXR0ZXJuV2lkdGhBc0RvdWJsZSwgMSwgcGF0dGVy bk9mZnNldCk7CisgICAgICAgIGlmIChzdHlsZSA9PSBEb3R0ZWRTdHJva2UpIHsKKyAgICAgICAg ICAgIGNhaXJvX3NldF9saW5lX2NhcChjb250ZXh0LCBDQUlST19MSU5FX0NBUF9ST1VORCk7Cisg ICAgICAgICAgICBkb3VibGUgbGluZUVsZW1lbnRMZW5ndGggPSAwOworICAgICAgICAgICAgZG91 YmxlIGxpbmVFbGVtZW50RGlzdGFuY2UgPSAyICogc3Ryb2tlVGhpY2tuZXNzOworICAgICAgICAg ICAgaWYgKGlzVmVydGljYWxMaW5lKSB7CisgICAgICAgICAgICAgICAgaWYgKHN0cm9rZVRoaWNr bmVzcyA8IDIpIHsKKyAgICAgICAgICAgICAgICAgICAgLy8gVmVydGljYWwgbGluZXMgd2l0aCBs ZW5ndGggMCBhcmVuJ3QgZHJhd24gc28gd2UgaGFuZGxlIHRoYXQgY2FzZSBoZXJlCisgICAgICAg ICAgICAgICAgICAgIGxpbmVFbGVtZW50TGVuZ3RoID0gMTsKKyAgICAgICAgICAgICAgICAgICAg Ly8gV2UgYWxzbyBoYXZlIHRvIHNldCB0aGUgZGlzdGFuY2UsIG90aGVyd2lzZSB0aGUgZG90cyBh cmUgdG9vIGZhciBhcGFydAorICAgICAgICAgICAgICAgICAgICBsaW5lRWxlbWVudERpc3RhbmNl ID0gMTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgcG9pbnQxT25QaXhlbEJv dW5kYXJpZXMuc2V0WShwb2ludDFPblBpeGVsQm91bmRhcmllcy55KCkgLSBzdHJva2VUaGlja25l c3MgLyAyKTsKKyAgICAgICAgICAgICAgICBwb2ludDJPblBpeGVsQm91bmRhcmllcy5zZXRZKHBv aW50Mk9uUGl4ZWxCb3VuZGFyaWVzLnkoKSArIHN0cm9rZVRoaWNrbmVzcyAvIDIpOworICAgICAg ICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICBwb2ludDFPblBpeGVsQm91bmRhcmllcy5z ZXRYKHBvaW50MU9uUGl4ZWxCb3VuZGFyaWVzLngoKSAtIHN0cm9rZVRoaWNrbmVzcyAvIDIpOwor ICAgICAgICAgICAgICAgIHBvaW50Mk9uUGl4ZWxCb3VuZGFyaWVzLnNldFgocG9pbnQyT25QaXhl bEJvdW5kYXJpZXMueCgpICsgc3Ryb2tlVGhpY2tuZXNzIC8gMik7CisgICAgICAgICAgICB9Cisg ICAgICAgICAgICBpbnQgZGlzdGFuY2UgPSAoaXNWZXJ0aWNhbExpbmUgPyAocG9pbnQyLnkoKSAt IHBvaW50MS55KCkpIDogKHBvaW50Mi54KCkgLSBwb2ludDEueCgpKSk7CisgICAgICAgICAgICBk b3VibGUgcGF0dGVybk9mZnNldCA9IGNhbGN1bGF0ZVN0cm9rZVBhdHRlcm5PZmZzZXQoZGlzdGFu Y2UsIHBhdHRlcm5XaWR0aCk7CisgICAgICAgICAgICBkb3VibGUgZGFzaGVzW10gPSB7IGxpbmVF bGVtZW50TGVuZ3RoLCBsaW5lRWxlbWVudERpc3RhbmNlIH07CisgICAgICAgICAgICBjYWlyb19z ZXRfZGFzaChjb250ZXh0LCBkYXNoZXMsIDIsIHBhdHRlcm5PZmZzZXQpOworICAgICAgICB9CiAg ICAgfQogCiAgICAgc2V0U291cmNlUkdCQUZyb21Db2xvcihjb250ZXh0LCBzdHJva2VDb2xvcik7 Ci0tIAoxLjcuMy40Cgo= 161671 2012-08-31 05:22:02 -0700 2014-02-05 11:12:44 -0800 Patch with updated expected results 0001-Cairo-Dotted-borders-not-drawn-with-rounded-dots.patch text/plain 0 martin.leutelt