95197 2012-08-28 07:10:07 -0700 Incorrect large-area clipping 2012-08-30 00:52:33 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 95431 95432 1 fmalita fmalita eric jberlin krit pdr schenney webkit.review.bot zimmermann oldest_to_newest 706307 0 160968 fmalita 2012-08-28 07:10:07 -0700 Created attachment 160968 Incorrect clipping CR issue: http://code.google.com/p/chromium/issues/detail?id=144630 This bug manifests when the following conditions are met: a) the clipping is handled via masking (forcing it via clip-path on a clip-path in the test) and b) the clip area is larger than 4096 (absolute size) in one dimension and c) the path repaint rect has a non-zero offset During mask ImageBuffer allocation the size is limited to 4096x4096 max. This introduces a non-trivial scaling component, which needs to be accounted for in the translation also. Note that this also affects masking, which uses the came ImageBuffer allocation logic. 706311 1 160969 fmalita 2012-08-28 07:11:57 -0700 Created attachment 160969 Incorrect masking 706315 2 fmalita 2012-08-28 07:20:43 -0700 (In reply to comment #0) > During mask ImageBuffer allocation the size is limited to 4096x4096 max. This introduces a non-trivial scaling component, which needs to be accounted for in the translation also. I think the order of matrix ops in SVGRenderingContext::createImageBuffer() is wrong: * imageContext->translate() * imageContext->concatCTM)() * imageContext->scale() Since this is a viewport transformation (where the viewport is the image buffer and world coords == abs coords), the scaling transform should be pushed before translation: P' = S(T(P)) = S * T * P Some quick testing validates this, patch coming soon. 706367 3 160988 fmalita 2012-08-28 08:21:46 -0700 Created attachment 160988 Patch 707251 4 160988 zimmermann 2012-08-29 02:55:31 -0700 Comment on attachment 160988 Patch r=me, this was obviously wrong. 707352 5 160988 webkit.review.bot 2012-08-29 05:24:26 -0700 Comment on attachment 160988 Patch Clearing flags on attachment: 160988 Committed r126993: <http://trac.webkit.org/changeset/126993> 707353 6 webkit.review.bot 2012-08-29 05:24:29 -0700 All reviewed patches have been landed. Closing bug. 707848 7 jberlin 2012-08-29 14:12:10 -0700 This test started failing on Mac at the point it was added: http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r126993%20(2333)/results.html Can you please check the results and see if they are expected for Mac? Otherwise I will need to roll this out. 707880 8 fmalita 2012-08-29 14:31:51 -0700 (In reply to comment #7) > This test started failing on Mac at the point it was added: > > http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r126993%20(2333)/results.html > > Can you please check the results and see if they are expected for Mac? Otherwise I will need to roll this out. Yes, the results are good. Unfortunately there's a small subpixel artifact on the edge which makes it different. I'll update it to try to avoid that. 707928 9 fmalita 2012-08-29 15:16:00 -0700 I've tweaked the reftest mask to hopefully take care of it: http://trac.webkit.org/changeset/127056 If that doesn't do it, we may need to switch this test to image results and possibly investigate why that bleeding happens. 708039 10 jberlin 2012-08-29 16:38:57 -0700 (In reply to comment #9) > I've tweaked the reftest mask to hopefully take care of it: http://trac.webkit.org/changeset/127056 > > If that doesn't do it, we may need to switch this test to image results and possibly investigate why that bleeding happens. Looks like r127056 took care of it. Thanks :) 160968 2012-08-28 07:10:07 -0700 2012-08-28 07:10:07 -0700 Incorrect clipping clip.svg image/svg+xml 522 fmalita PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRw Oi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIiB3aWR0aD0iMTIyODgiIGhlaWdodD0iMjAwIj4KICA8 ZGVmcz4KICAgIDxjbGlwUGF0aCBpZD0iY2xpcDAiPgogICAgICA8cGF0aCBkPSJNIDAgMCBWIDEw MCBIIDEyMjg4IFYgMCBaIj48L3BhdGg+CiAgICA8L2NsaXBQYXRoPgoKICAgIDxjbGlwUGF0aCBp ZD0iY2xpcDEiIGNsaXAtcGF0aD0idXJsKCNjbGlwMCkiPgogICAgICA8cGF0aCBkPSJNIDEwMCAw IEggMjAwIFYgMjAwIEggODI5MiBWIDAgWiIvPgogICAgPC9jbGlwUGF0aD4KICA8L2RlZnM+Cgog IDxnPgogICAgPHJlY3QgY2xpcC1wYXRoPSJ1cmwoI2NsaXAxKSIgZmlsbD0iZ3JlZW4iIHg9IjAi IHk9IjAiIHdpZHRoPSIxMjI4OCIgaGVpZ2h0PSIyMDAiLz4KICAgIDxyZWN0IGZpbGw9Im5vbmUi IHN0cm9rZT0icmVkIiB4PSIyMDAiIHdpZHRoPSI4MDkyIiBoZWlnaHQ9IjEwMCIvPgogIDwvZz4K Cjwvc3ZnPgoK 160969 2012-08-28 07:11:57 -0700 2012-08-28 07:11:57 -0700 Incorrect masking mask.svg image/svg+xml 445 fmalita PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRw Oi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIiB3aWR0aD0iMTIyODgiIGhlaWdodD0iMjAwIj4KICA8 ZGVmcz4KICAgIDxtYXNrIGlkPSJtYXNrIj4KICAgICAgPHJlY3QgeD0iMTAwIiB3aWR0aD0iMSIg aGVpZ2h0PSIxIiBmaWxsPSJibGFjayIvPgogICAgICA8cmVjdCB4PSIyMDAiIHdpZHRoPSI4MTky IiBoZWlnaHQ9IjEwMCIgZmlsbD0id2hpdGUiLz4KICAgIDwvbWFzaz4KICA8L2RlZnM+CgogIDxn PgogICAgPHJlY3Qgd2lkdGg9IjEyMjg4IiBoZWlnaHQ9IjIwMCIgZmlsbD0iZ3JlZW4iIG1hc2s9 InVybCgjbWFzaykiLz4KICAgIDxyZWN0IHg9IjIwMCIgd2lkdGg9IjgxOTIiIGhlaWdodD0iMTAw IiBmaWxsPSJub25lIiBzdHJva2U9InJlZCIvPgogIDwvZz4KICAKPC9zdmc+Cg== 160988 2012-08-28 08:21:46 -0700 2012-08-29 05:24:26 -0700 Patch bug-95197-20120828112137.patch text/plain 4849 fmalita U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2ODcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjNkZTZlMmVhMjljMGZm MWZhMTNhMWVlYzk3ZjA4MjBlMmIyZGJkZi4uZTYzYjkyMmNkNWJlY2YzNGEyM2RmNWRlODJiNzMx ZmUyZTY0NDNiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA4LTI4ICBGbG9y aW4gTWFsaXRhICA8Zm1hbGl0YUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW5jb3JyZWN0IGxh cmdlLWFyZWEgY2xpcHBpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk1MTk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSW1hZ2VCdWZmZXJzIGFsbG9jYXRlZCBmb3IgY2xpcHBpbmcgYW5kIG1hc2tpbmcg YXJlIGNsYW1wZWQgdG8ga01heEltYWdlQnVmZmVyU2l6ZSBtYXgKKyAgICAgICAgKDQwOTZ4NDA5 NikuIEluIG9yZGVyIHRvIHByb3Blcmx5IGFjY291bnQgZm9yIHRoZSBzY2FsaW5nIGZhY3RvciBp bnRyb2R1Y2VkIGJ5IHRoaXMKKyAgICAgICAgY2xhbXBpbmcsIHRoZSByZXBhaW50UmVjdCB0cmFu c2xhdGlvbiBjb21wb25lbnQgbmVlZHMgdG8gYmUgcHVzaGVkIGFmdGVyIHRoZSBzY2FsaW5nCisg ICAgICAgIHRyYW5zZm9ybS4KKworICAgICAgICBUZXN0czogc3ZnL2N1c3RvbS9jbGFtcGVkLW1h c2tpbmctY2xpcHBpbmctZXhwZWN0ZWQuc3ZnCisgICAgICAgICAgICAgICBzdmcvY3VzdG9tL2Ns YW1wZWQtbWFza2luZy1jbGlwcGluZy5zdmcKKworICAgICAgICAqIHJlbmRlcmluZy9zdmcvU1ZH UmVuZGVyaW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdSZW5kZXJpbmdDb250 ZXh0OjpjcmVhdGVJbWFnZUJ1ZmZlcik6CisKIDIwMTItMDgtMjggIFN1a29sc2FrIFNha3NodXdv bmcgIDxzdWtvbHNha0BnbWFpbC5jb20+CiAKICAgICAgICAgQ3Jhc2ggaW4gRWRpdGluZ1N0eWxl OjptZXJnZVN0eWxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NW R1JlbmRlcmluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdS ZW5kZXJpbmdDb250ZXh0LmNwcAppbmRleCBlMmFkYjMwNjMzYTQyZDdmMzc5Y2FlZmMxMWViYTdj M2Q1YzY2MTEwLi4xMzYzMTVlNjkxYzQwOTBiNWIzMjA3MmQ0YzBkNmIwYWE2YWI0YTQxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR1JlbmRlcmluZ0NvbnRleHQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHUmVuZGVyaW5nQ29udGV4 dC5jcHAKQEAgLTIwNSwxNCArMjA1LDEwIEBAIGJvb2wgU1ZHUmVuZGVyaW5nQ29udGV4dDo6Y3Jl YXRlSW1hZ2VCdWZmZXIoY29uc3QgRmxvYXRSZWN0JiB0YXJnZXRSZWN0LCBjb25zdCBBCiAgICAg R3JhcGhpY3NDb250ZXh0KiBpbWFnZUNvbnRleHQgPSBpbWFnZS0+Y29udGV4dCgpOwogICAgIEFT U0VSVChpbWFnZUNvbnRleHQpOwogCi0gICAgLy8gVGhpcyBpcyBkb25lIGluIGFic29sdXRlIGNv b3JkaW5hdGVzLgotICAgIGltYWdlQ29udGV4dC0+dHJhbnNsYXRlKC1wYWludFJlY3QueCgpLCAt cGFpbnRSZWN0LnkoKSk7Ci0KLSAgICBpbWFnZUNvbnRleHQtPmNvbmNhdENUTShhYnNvbHV0ZVRy YW5zZm9ybSk7Ci0KLSAgICAvLyBUaGlzIGhhcHBlbnMgaW4gbG9jYWwgY29vcmRpbmF0ZXMuCiAg ICAgaW1hZ2VDb250ZXh0LT5zY2FsZShGbG9hdFNpemUoc3RhdGljX2Nhc3Q8ZmxvYXQ+KGNsYW1w ZWRTaXplLndpZHRoKCkpIC8gcGFpbnRSZWN0LndpZHRoKCksCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgc3RhdGljX2Nhc3Q8ZmxvYXQ+KGNsYW1wZWRTaXplLmhlaWdodCgpKSAv IHBhaW50UmVjdC5oZWlnaHQoKSkpOworICAgIGltYWdlQ29udGV4dC0+dHJhbnNsYXRlKC1wYWlu dFJlY3QueCgpLCAtcGFpbnRSZWN0LnkoKSk7CisgICAgaW1hZ2VDb250ZXh0LT5jb25jYXRDVE0o YWJzb2x1dGVUcmFuc2Zvcm0pOwogCiAgICAgaW1hZ2VCdWZmZXIgPSBpbWFnZS5yZWxlYXNlKCk7 CiAgICAgcmV0dXJuIHRydWU7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODYxZjQ4YTkzYTkxNjM1M2E0ZTQ2OTIzZjExMmEz YTkxZWU0YjAyYi4uMTIzZTZmODNjNDYyYzdhZWIyODAyZmEzYmViNzI5Nzc3ZTA2Y2JjOCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA4LTI4ICBGbG9yaW4gTWFsaXRhICA8Zm1hbGl0YUBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW5jb3JyZWN0IGxhcmdlLWFyZWEgY2xpcHBpbmcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1MTk3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdmcvY3VzdG9t L2NsYW1wZWQtbWFza2luZy1jbGlwcGluZy1leHBlY3RlZC5zdmc6IEFkZGVkLgorICAgICAgICAq IHN2Zy9jdXN0b20vY2xhbXBlZC1tYXNraW5nLWNsaXBwaW5nLnN2ZzogQWRkZWQuCisKIDIwMTIt MDgtMjggIFRoaWFnbyBNYXJjb3MgUC4gU2FudG9zICA8dGhpYWdvLnNhbnRvc0BpbnRlbC5jb20+ CiAKICAgICAgICAgRGF0YWxpc3QgUlRMIHRlc3QgZmFpbHMgb24gcG9ydHMgdGhhdCBoYXZlIHBy b2dyZXNzIGluZGljYXRvciBvbiB0aGUgcmFuZ2UgZ3Jvb3ZlCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9zdmcvY3VzdG9tL2NsYW1wZWQtbWFza2luZy1jbGlwcGluZy1leHBlY3RlZC5zdmcgYi9M YXlvdXRUZXN0cy9zdmcvY3VzdG9tL2NsYW1wZWQtbWFza2luZy1jbGlwcGluZy1leHBlY3RlZC5z dmcKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uODgxOTA0YTFlNjA4ZTlmNWY2M2U4NzY5YzgwM2VjMmU2NzlmODcwNgot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vY2xhbXBlZC1tYXNraW5n LWNsaXBwaW5nLWV4cGVjdGVkLnN2ZwpAQCAtMCwwICsxLDQgQEAKKzxzdmcgeG1sbnM9Imh0dHA6 Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB3aWR0aD0iMTAwMDAiIGhlaWdodD0iNDAwIj4KKyAgICA8 cmVjdCB4PSIxMDAiIHdpZHRoPSIxMDAiIGhlaWdodD0iMTAwIiBmaWxsPSJncmVlbiIvPgorICAg IDxyZWN0IHg9IjMwMCIgd2lkdGg9IjEwMCIgaGVpZ2h0PSIxMDAiIGZpbGw9ImdyZWVuIi8+Cis8 L3N2Zz4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vY2xhbXBlZC1tYXNraW5n LWNsaXBwaW5nLnN2ZyBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vY2xhbXBlZC1tYXNraW5nLWNs aXBwaW5nLnN2ZwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43MjY1ZTJhMDM3YWVlM2MyZmZjMmJjMTE2ZWU5MTcwYTY5 N2NhZWNmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9jbGFtcGVk LW1hc2tpbmctY2xpcHBpbmcuc3ZnCkBAIC0wLDAgKzEsMzMgQEAKKzxzdmcgeG1sbnM9Imh0dHA6 Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB3aWR0aD0iMTAwMDAiIGhlaWdodD0iNDAwIj4KKyAgPCEt LSB0ZXN0IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTUxOTcg LS0+CisgIDxkZWZzPgorICAgIDxtYXNrIGlkPSJtYXNrIj4KKyAgICAgIDwhLS0gZm9yY2luZyBh IHJlcGFpbnRSZWN0IG9mZnNldCAtLT4KKyAgICAgIDxyZWN0IHg9IjEwMCIgd2lkdGg9IjEiIGhl aWdodD0iMSIgZmlsbD0iYmxhY2siLz4KKyAgICAgIDxyZWN0IHg9IjIwMCIgd2lkdGg9IjgwOTIi IGhlaWdodD0iMTAwIiBmaWxsPSJ3aGl0ZSIvPgorICAgIDwvbWFzaz4KKworICAgIDxjbGlwUGF0 aCBpZD0iY2xpcDEiPgorICAgICAgPCEtLSBmb3JjaW5nIGNsaXBwaW5nIHZpYSBtYXNraW5nIC0t PgorICAgICAgPHBhdGggZD0iTSAwIDAgViAxMDAgSCAxMDAwMCBWIDAgWiIvPgorICAgIDwvY2xp cFBhdGg+CisKKyAgICA8Y2xpcFBhdGggaWQ9ImNsaXAyIiBjbGlwLXBhdGg9InVybCgjY2xpcDEp Ij4KKyAgICAgIDxwYXRoIGQ9Ik0gMTAwIDAgSCAyMDAgViAyMDAgSCA4MjkyIFYgMCBaIi8+Cisg ICAgPC9jbGlwUGF0aD4KKworICAgIDxtYXNrIGlkPSJjcm9wIj4KKyAgICAgIDxyZWN0IHdpZHRo PSIzMDAiIGhlaWdodD0iMTAwIiBmaWxsPSJ3aGl0ZSIvPgorICAgIDwvbWFzaz4KKyAgPC9kZWZz PgorCisgIDxnIG1hc2s9InVybCgjY3JvcCkiIHRyYW5zZm9ybT0idHJhbnNsYXRlKC0xMDAsIDAp Ij4KKyAgICA8cmVjdCB3aWR0aD0iMTAwMDAiIGhlaWdodD0iNDAwIiBmaWxsPSJyZWQiIG1hc2s9 InVybCgjbWFzaykiLz4KKyAgICA8cmVjdCB4PSIyMDAiIHdpZHRoPSIxMDAiIGhlaWdodD0iMTAw IiBmaWxsPSJncmVlbiIvPgorICA8L2c+CisKKyAgPGcgbWFzaz0idXJsKCNjcm9wKSIgdHJhbnNm b3JtPSJ0cmFuc2xhdGUoMTAwLCAwKSI+CisgICAgPHJlY3Qgd2lkdGg9IjEwMDAwIiBoZWlnaHQ9 IjQwMCIgZmlsbD0icmVkIiBjbGlwLXBhdGg9InVybCgjY2xpcDIpIi8+CisgICAgPHJlY3QgeD0i MjAwIiB3aWR0aD0iMTAwIiBoZWlnaHQ9IjEwMCIgZmlsbD0iZ3JlZW4iLz4KKyAgPC9nPgorPC9z dmc+Cg==