95192 2012-08-28 06:12:04 -0700 [BlackBerry] Checkerboard observed after pinch zooming page with AC layers 2012-08-28 08:58:02 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anilsson anilsson anilsson anlo mifenton tonikitoo webkit.review.bot oldest_to_newest 706273 0 anilsson 2012-08-28 06:12:04 -0700 It turns out the LayerTiler was passing transformed ("pixel") coordinates to GraphicsLayerClient::contentsVisible(), and that method expects untransformed ("document") coordinates. When the scale was not 1.0, this was comparing apples and oranges. PR 199177 706347 1 160982 anilsson 2012-08-28 08:02:05 -0700 Created attachment 160982 Patch 706402 2 160982 webkit.review.bot 2012-08-28 08:57:59 -0700 Comment on attachment 160982 Patch Clearing flags on attachment: 160982 Committed r126885: <http://trac.webkit.org/changeset/126885> 706403 3 webkit.review.bot 2012-08-28 08:58:02 -0700 All reviewed patches have been landed. Closing bug. 160982 2012-08-28 08:02:05 -0700 2012-08-28 08:57:59 -0700 Patch bug-95192-20120828170155.patch text/plain 5809 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTAzZDM1ZTgwZWQ5YTM0 ZTFkMzFhOTc0NGFkZGQ0Y2MzMGQwMGZlNS4uYjM0YmY4ZjE1Y2M0OTk0NzhlNWRhMTFjNjVlNjEz YmUyZTg5YTcyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDEyLTA4LTI4ICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gQ2hl Y2tlcmJvYXJkIG9ic2VydmVkIGFmdGVyIHBpbmNoIHpvb21pbmcgcGFnZSB3aXRoIEFDIGxheWVy cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTUxOTIK KworICAgICAgICBQUiAxOTkxNzcKKyAgICAgICAgVGhlIExheWVyVGlsZXIgd2FzIHBhc3Npbmcg dHJhbnNmb3JtZWQgKCJwaXhlbCIpIGNvb3JkaW5hdGVzIHRvCisgICAgICAgIEdyYXBoaWNzTGF5 ZXJDbGllbnQ6OmNvbnRlbnRzVmlzaWJsZSgpLCBhbmQgdGhhdCBtZXRob2QgZXhwZWN0cworICAg ICAgICB1bnRyYW5zZm9ybWVkICgiZG9jdW1lbnQiKSBjb29yZGluYXRlcy4gV2hlbiB0aGUgc2Nh bGUgd2FzIG5vdCAxLjAsCisgICAgICAgIHRoaXMgd2FzIGNvbXBhcmluZyBhcHBsZXMgYW5kIG9y YW5nZXMuCisKKyAgICAgICAgRml4ZWQgYnkgcGFja2FnaW5nIHVwIHRoZSB0cmFuc2Zvcm1hdGlv biBjb2RlIGludG8gYSByZXVzYWJsZSBtZXRob2QKKyAgICAgICAgYW5kIG1hcHBpbmcgdGhlICJw aXhlbCIgdGlsZSByZWN0IHRvICJkb2N1bWVudCIgY29vcmRpbmF0ZXMgYmVmb3JlIHRoZQorICAg ICAgICB2aXNpYmlsaXR5IHRlc3RpbmcuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm90IGN1cnJlbnRseSB0ZXN0YWJsZSBieSB0aGUgQmxhY2tCZXJy eSB0ZXN0aW5nIGluZnJhc3RydWN0dXJlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv YmxhY2tiZXJyeS9MYXllclRpbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheWVyVGlsZXI6 OnNob3VsZFBlcmZvcm1SZW5kZXJKb2IpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Js YWNrYmVycnkvTGF5ZXJXZWJLaXRUaHJlYWQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJX ZWJLaXRUaHJlYWQ6OnBhaW50Q29udGVudHMpOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJXZWJL aXRUaHJlYWQ6Om1hcEZyb21UcmFuc2Zvcm1lZCk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVyV2ViS2l0VGhyZWFkLmg6Cisg ICAgICAgIChMYXllcldlYktpdFRocmVhZCk6CisKIDIwMTItMDgtMjEgIEFydmlkIE5pbHNzb24g IDxhbmlsc3NvbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBXZWJHTCBBcXVhcml1 bSBmYWlscyB0byByZW5kZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJUaWxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVyVGlsZXIuY3BwCmluZGV4IDlmNWM2YWYzZTg1MDYx YTk3MmQwNDMxMWJlOTAzMTVlOTViNWUwZGEuLjYwNjQ2NTAzMDA0MWYxYjViYjM4NDc3MDcyZjJj ZWE5YjJiYTY3ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2JsYWNrYmVycnkvTGF5ZXJUaWxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllclRpbGVyLmNwcApAQCAtMzI3LDcgKzMyNyw3IEBAIGJv b2wgTGF5ZXJUaWxlcjo6c2hvdWxkUGVyZm9ybVJlbmRlckpvYihjb25zdCBUaWxlSW5kZXgmIGlu ZGV4LCBib29sIGFsbG93UHJlZmlsCiAgICAgLy8gT3IgaWYgdGhleSBhcmUgdmlzaWJsZSBhY2Nv cmRpbmcgdG8gdGhlIHN0YXRlIHRoYXQncyBhYm91dCB0byBiZQogICAgIC8vIGNvbW1pdHRlZC4g V2UgZG8gYSB2aXNpYmlsaXR5IHRlc3QgdXNpbmcgdGhlIGN1cnJlbnQgdHJhbnNmb3JtIHN0YXRl LgogICAgIEludFJlY3QgY29udGVudFJlY3QgPSByZWN0Rm9yVGlsZShpbmRleCwgbV9wZW5kaW5n VGV4dHVyZVNpemUpOwotICAgIHJldHVybiBtX2xheWVyLT5jb250ZW50c1Zpc2libGUoY29udGVu dFJlY3QpOworICAgIHJldHVybiBtX2xheWVyLT5jb250ZW50c1Zpc2libGUoTGF5ZXJXZWJLaXRU aHJlYWQ6Om1hcEZyb21UcmFuc2Zvcm1lZChjb250ZW50UmVjdCwgbV9jb250ZW50c1NjYWxlKSk7 CiB9CiAKIHZvaWQgTGF5ZXJUaWxlcjo6YWRkVGV4dHVyZUpvYihjb25zdCBUZXh0dXJlSm9iJiBq b2IpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2Jl cnJ5L0xheWVyV2ViS2l0VGhyZWFkLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2JsYWNrYmVycnkvTGF5ZXJXZWJLaXRUaHJlYWQuY3BwCmluZGV4IDQ1NDVjYWIxN2Y3MmJk ZDUyZWQwNzUzZGFlOTllOTI3MjgzOWQ2ZWUuLjQyYjhiZWQ1ODU0NDhmMGU3YzcwZGZkYjQ2Mzg4 YzM2ZWU4MDhmNDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2JsYWNrYmVycnkvTGF5ZXJXZWJLaXRUaHJlYWQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJXZWJLaXRUaHJlYWQuY3BwCkBAIC0xMDgs NyArMTA4LDcgQEAgU2tCaXRtYXAgTGF5ZXJXZWJLaXRUaHJlYWQ6OnBhaW50Q29udGVudHMoY29u c3QgSW50UmVjdCYgY29udGVudHNSZWN0LCBkb3VibGUgc2MKICAgICBPd25QdHI8SW5zdHJ1bWVu dGVkUGxhdGZvcm1DYW52YXM+IGNhbnZhczsKIAogICAgIGlmIChkcmF3c0NvbnRlbnQoKSkgeyAv LyBMYXllciBjb250ZW50cyBtdXN0IGJlIGRyYXduIGludG8gYSBjYW52YXMuCi0gICAgICAgIElu dFJlY3QgdW50cmFuc2Zvcm1lZENvbnRlbnRzUmVjdCA9IGNvbnRlbnRzUmVjdDsKKyAgICAgICAg SW50UmVjdCB1bnRyYW5zZm9ybWVkQ29udGVudHNSZWN0ID0gbWFwRnJvbVRyYW5zZm9ybWVkKGNv bnRlbnRzUmVjdCwgc2NhbGUpOwogCiAgICAgICAgIFNrQml0bWFwIGNhbnZhc0JpdG1hcDsKICAg ICAgICAgY2FudmFzQml0bWFwLnNldENvbmZpZyhTa0JpdG1hcDo6a0FSR0JfODg4OF9Db25maWcs IGNvbnRlbnRzUmVjdC53aWR0aCgpLCBjb250ZW50c1JlY3QuaGVpZ2h0KCkpOwpAQCAtMTIzLDE4 ICsxMjMsOCBAQCBTa0JpdG1hcCBMYXllcldlYktpdFRocmVhZDo6cGFpbnRDb250ZW50cyhjb25z dCBJbnRSZWN0JiBjb250ZW50c1JlY3QsIGRvdWJsZSBzYwogICAgICAgICBHcmFwaGljc0NvbnRl eHQgZ3JhcGhpY3NDb250ZXh0KCZza2lhQ29udGV4dCk7CiAgICAgICAgIGdyYXBoaWNzQ29udGV4 dC50cmFuc2xhdGUoLWNvbnRlbnRzUmVjdC54KCksIC1jb250ZW50c1JlY3QueSgpKTsKIAotICAg ICAgICBpZiAoc2NhbGUgIT0gMS4wKSB7Ci0gICAgICAgICAgICBUcmFuc2Zvcm1hdGlvbk1hdHJp eCBtYXRyaXg7Ci0gICAgICAgICAgICBtYXRyaXguc2NhbGUoMS4wIC8gc2NhbGUpOwotICAgICAg ICAgICAgdW50cmFuc2Zvcm1lZENvbnRlbnRzUmVjdCA9IG1hdHJpeC5tYXBSZWN0KGNvbnRlbnRz UmVjdCk7Ci0KLSAgICAgICAgICAgIC8vIFdlIGV4dHJhY3QgZnJvbSB0aGUgY29udGVudHNSZWN0 IGJ1dCBkcmF3IGEgc2xpZ2h0bHkgbGFyZ2VyIHJlZ2lvbiB0aGFuCi0gICAgICAgICAgICAvLyB3 ZSB3ZXJlIHRvbGQgdG8sIGluIG9yZGVyIHRvIGF2b2lkIHBpeGVscyBiZWluZyByZW5kZXJlZCBv bmx5IHBhcnRpYWxseS4KLSAgICAgICAgICAgIGNvbnN0IGludCBhdExlYXN0T25lRGV2aWNlUGl4 ZWwgPSBzdGF0aWNfY2FzdDxpbnQ+KGNlaWxmKDEuMCAvIHNjYWxlKSk7Ci0gICAgICAgICAgICB1 bnRyYW5zZm9ybWVkQ29udGVudHNSZWN0LmluZmxhdGUoYXRMZWFzdE9uZURldmljZVBpeGVsKTsK LQorICAgICAgICBpZiAoc2NhbGUgIT0gMS4wKQogICAgICAgICAgICAgZ3JhcGhpY3NDb250ZXh0 LnNjYWxlKEZsb2F0U2l6ZShzY2FsZSwgc2NhbGUpKTsKLSAgICAgICAgfQogCiAgICAgICAgIC8v IFJlbmRlckxheWVyQmFja2luZyBkb2Vzbid0IGFsd2F5cyBjbGlwLCBzbyB3ZSBuZWVkIHRvIGRv IHRoaXMgYnkgb3Vyc2VsdmVzLgogICAgICAgICBncmFwaGljc0NvbnRleHQuY2xpcCh1bnRyYW5z Zm9ybWVkQ29udGVudHNSZWN0KTsKQEAgLTUzMiw2ICs1MjIsMjQgQEAgdm9pZCBMYXllcldlYktp dFRocmVhZDo6cmVsZWFzZUxheWVyUmVzb3VyY2VzKCkKICAgICAgICAgcmVwbGljYUxheWVyKCkt PnJlbGVhc2VMYXllclJlc291cmNlcygpOwogfQogCitJbnRSZWN0IExheWVyV2ViS2l0VGhyZWFk OjptYXBGcm9tVHJhbnNmb3JtZWQoY29uc3QgSW50UmVjdCYgY29udGVudHNSZWN0LCBkb3VibGUg c2NhbGUpCit7CisgICAgSW50UmVjdCB1bnRyYW5zZm9ybWVkQ29udGVudHNSZWN0ID0gY29udGVu dHNSZWN0OworCisgICAgaWYgKHNjYWxlICE9IDEuMCkgeworICAgICAgICBUcmFuc2Zvcm1hdGlv bk1hdHJpeCBtYXRyaXg7CisgICAgICAgIG1hdHJpeC5zY2FsZSgxLjAgLyBzY2FsZSk7CisgICAg ICAgIHVudHJhbnNmb3JtZWRDb250ZW50c1JlY3QgPSBtYXRyaXgubWFwUmVjdChjb250ZW50c1Jl Y3QpOworCisgICAgICAgIC8vIFdlIGV4dHJhY3QgZnJvbSB0aGUgY29udGVudHNSZWN0IGJ1dCBk cmF3IGEgc2xpZ2h0bHkgbGFyZ2VyIHJlZ2lvbiB0aGFuCisgICAgICAgIC8vIHdlIHdlcmUgdG9s ZCB0bywgaW4gb3JkZXIgdG8gYXZvaWQgcGl4ZWxzIGJlaW5nIHJlbmRlcmVkIG9ubHkgcGFydGlh bGx5LgorICAgICAgICBjb25zdCBpbnQgYXRMZWFzdE9uZURldmljZVBpeGVsID0gc3RhdGljX2Nh c3Q8aW50PihjZWlsZigxLjAgLyBzY2FsZSkpOworICAgICAgICB1bnRyYW5zZm9ybWVkQ29udGVu dHNSZWN0LmluZmxhdGUoYXRMZWFzdE9uZURldmljZVBpeGVsKTsKKyAgICB9CisKKyAgICByZXR1 cm4gdW50cmFuc2Zvcm1lZENvbnRlbnRzUmVjdDsKK30KKwogfQogCiAjZW5kaWYgLy8gVVNFKEFD Q0VMRVJBVEVEX0NPTVBPU0lUSU5HKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllcldlYktpdFRocmVhZC5oIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllcldlYktpdFRocmVhZC5oCmluZGV4 IDk5ZmYxYTNmNmFhZjFiZmJlMWZiZDZiNmU2YjAzZmUxODY2NWQ5NjUuLjM0YmQ2NzY1ZjAzMWM2 YjZiMDAxNGE4OWRmYWRhZTRmYTYxYjVjMjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJXZWJLaXRUaHJlYWQuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVyV2ViS2l0VGhyZWFk LmgKQEAgLTE2Miw2ICsxNjIsOCBAQCBwdWJsaWM6CiAKICAgICB2b2lkIHJlbGVhc2VMYXllclJl c291cmNlcygpOwogCisgICAgc3RhdGljIEludFJlY3QgbWFwRnJvbVRyYW5zZm9ybWVkKGNvbnN0 IEludFJlY3QmLCBkb3VibGUgc2NhbGUpOworCiBwcm90ZWN0ZWQ6CiAgICAgTGF5ZXJXZWJLaXRU aHJlYWQoTGF5ZXJUeXBlLCBHcmFwaGljc0xheWVyQmxhY2tCZXJyeSogb3duZXIpOwogCg==