95173 2012-08-27 23:54:17 -0700 [EFL][WK2] Add necessary include directories in WebKit2 2012-09-11 00:48:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 95342 0 zhigang.gong webkit-unassigned gyuyoung.kim hausmann kangil.han rakuco ryuan.choi webkit.review.bot oldest_to_newest 706123 0 zhigang.gong 2012-08-27 23:54:17 -0700 Add necessary include directories in WebKit2 706129 1 160918 zhigang.gong 2012-08-28 00:03:15 -0700 Created attachment 160918 Patch 706130 2 webkit.review.bot 2012-08-28 00:06:15 -0700 Attachment 160918 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebKit2/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/WebKit2/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Source/WebKit2/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Source/WebKit2/ChangeLog:12: Line contains tab character. [whitespace/tab] [5] Source/WebKit2/ChangeLog:13: Line contains tab character. [whitespace/tab] [5] Source/WebKit2/ChangeLog:15: Line contains tab character. [whitespace/tab] [5] Source/WebKit2/ChangeLog:16: Line contains tab character. [whitespace/tab] [5] Total errors found: 7 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 706139 3 160920 zhigang.gong 2012-08-28 00:19:16 -0700 Created attachment 160920 Patch 706327 4 160920 hausmann 2012-08-28 07:36:10 -0700 Comment on attachment 160920 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160920&action=review > Source/WebKit2/ChangeLog:8 > + Commit f9d4da... modify the TextureMapperGL.h to include I think that you may want to replace the git sha1 with the SVN revision here. 706432 5 zhigang.gong 2012-08-28 09:45:06 -0700 *** Bug 95165 has been marked as a duplicate of this bug. *** 707016 6 161118 zhigang.gong 2012-08-28 19:27:22 -0700 Created attachment 161118 Patch 709422 7 zhigang.gong 2012-08-31 02:39:35 -0700 (In reply to comment #4) > (From update of attachment 160920 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=160920&action=review > > > Source/WebKit2/ChangeLog:8 > > + Commit f9d4da... modify the TextureMapperGL.h to include > > I think that you may want to replace the git sha1 with the SVN revision here. I modified the change log and resubmitted the patch. Any comment? 712848 8 ryuan.choi 2012-09-05 21:26:53 -0700 LGTM. I want this patch and another patch that adds `#include "WebPreferences.h"` in ewk_view.cpp. 714477 9 kangil.han 2012-09-07 06:57:55 -0700 zhigang: would you please ask hausmann for r+? 714483 10 zhigang.gong 2012-09-07 07:04:48 -0700 hausmann， would you please help to review this patch? thx. 714489 11 ryuan.choi 2012-09-07 07:13:32 -0700 (In reply to comment #10) > hausmann， > would you please help to review this patch? thx. Hopefully, we can get r+. Or, you can rquest cq? after changing "Reviewed by NOBODY (OOPS!)." to "Unreviewed build fix" because this is to fix build break. 714509 12 zhigang.gong 2012-09-07 07:34:18 -0700 (In reply to comment #11) > (In reply to comment #10) > > hausmann， > > would you please help to review this patch? thx. > > Hopefully, we can get r+. > > Or, you can rquest cq? after changing "Reviewed by NOBODY (OOPS!)." to "Unreviewed build fix" because this is to fix build break. I will have to do that once i back to work on Mon, as I am not at my development machine now. 714572 13 161118 hausmann 2012-09-07 09:02:21 -0700 Comment on attachment 161118 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161118&action=review > Source/WebKit2/CMakeLists.txt:115 > + "${THIRDPARTY_DIR}/ANGLE/include" I ran into this just a few days ago. Adding ANGLE/include to your include search path means that if you are compiling your code in a platform where EGL and GLES2 are the chosen system wide GL APIs, then an #include <EGL/egl.h> in WebKit2 will end up including ANGLE's EGL header file instead of your system wide one. The same applies to GLES2 inclusions. Do you really need this include or can you limit this change to just the include/GLSLANG line below? 715685 14 163031 zhigang.gong 2012-09-09 20:55:32 -0700 Created attachment 163031 Patch 715688 15 163031 gyuyoung.kim 2012-09-09 21:02:08 -0700 Comment on attachment 163031 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163031&action=review You don't need to request r? for unreviewed build fix. > Source/WebKit2/ChangeLog:3 > + Add necessary include directories in WebKit2 It is good to add [EFL][WK2] prefix to bug title. 716739 16 163031 gyuyoung.kim 2012-09-10 17:56:49 -0700 Comment on attachment 163031 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163031&action=review > Source/WebKit2/CMakeLists.txt:114 > +IF (WTF_USE_3D_GRAPHICS) I think WebKit2/PlatformEfl.cmake is proper place because this build break occurs at EFL port only now. 716795 17 zhigang.gong 2012-09-10 20:43:21 -0700 (In reply to comment #16) > (From update of attachment 163031 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=163031&action=review > > > Source/WebKit2/CMakeLists.txt:114 > > +IF (WTF_USE_3D_GRAPHICS) > > I think WebKit2/PlatformEfl.cmake is proper place because this build break occurs at EFL port only now. Hmm, IMO, it may be not a EFL port only problem even it just triggers problem on EFL platform now. The root cause is that when TEXTURE_MAPPER is enabled, some source files in WebKit2 include TextureMapperGL.h --> GraphicsContext3D -->trigger build problem. And as I know, TEXTURE_MAPPER is not EFL only， right? And those files which include TextureMapperGL.h are also not all for EFL platform only, for example the ShareableSurface.cpp. Any further comments? 716803 18 163031 gyuyoung.kim 2012-09-10 20:57:33 -0700 Comment on attachment 163031 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163031&action=review >>> Source/WebKit2/CMakeLists.txt:114 >>> +IF (WTF_USE_3D_GRAPHICS) >> >> I think WebKit2/PlatformEfl.cmake is proper place because this build break occurs at EFL port only now. > > Hmm, IMO, it may be not a EFL port only problem even it just triggers problem on EFL platform now. The root cause is that when TEXTURE_MAPPER is enabled, some source files in WebKit2 include TextureMapperGL.h --> GraphicsContext3D -->trigger build problem. And as I know, TEXTURE_MAPPER is not EFL only， right? And those files which include TextureMapperGL.h are also not all for EFL platform only, for example the ShareableSurface.cpp. > > Any further comments? Of course, it seems to me all ports (EFL, blackberry and wince) will need to include "GLSLANG" directory if they need to use WEBGL(3D_GRAPHICS) But, blackberry and wince ports don't start to support WK2 yet. So, I would remain to add this to EFL private file until they need to use the "GLSLANG". Because, there will may something stuff further. In WK1 case, blackberry port also include this directory in PlatformBlackBerry.cmake. http://trac.webkit.org/browser/trunk/Source/WebKit/PlatformBlackBerry.cmake#L120 716847 19 zhigang.gong 2012-09-10 22:21:02 -0700 (In reply to comment #18) > (From update of attachment 163031 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=163031&action=review > > >>> Source/WebKit2/CMakeLists.txt:114 > >>> +IF (WTF_USE_3D_GRAPHICS) > >> > >> I think WebKit2/PlatformEfl.cmake is proper place because this build break occurs at EFL port only now. > > > > Hmm, IMO, it may be not a EFL port only problem even it just triggers problem on EFL platform now. The root cause is that when TEXTURE_MAPPER is enabled, some source files in WebKit2 include TextureMapperGL.h --> GraphicsContext3D -->trigger build problem. And as I know, TEXTURE_MAPPER is not EFL only， right? And those files which include TextureMapperGL.h are also not all for EFL platform only, for example the ShareableSurface.cpp. > > > > Any further comments? > > Of course, it seems to me all ports (EFL, blackberry and wince) will need to include "GLSLANG" directory if they need to use WEBGL(3D_GRAPHICS) > But, blackberry and wince ports don't start to support WK2 yet. So, I would remain to add this to EFL private file until they need to use the "GLSLANG". Because, there will may something stuff further. > > In WK1 case, blackberry port also include this directory in PlatformBlackBerry.cmake. > http://trac.webkit.org/browser/trunk/Source/WebKit/PlatformBlackBerry.cmake#L120 I agree with you now. Will submit a new version soon. 716849 20 163279 zhigang.gong 2012-09-10 22:22:36 -0700 Created attachment 163279 Patch 716851 21 163279 gyuyoung.kim 2012-09-10 22:23:54 -0700 Comment on attachment 163279 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163279&action=review > Source/WebKit2/ChangeLog:3 > + Add necessary include directories in WebKit2 Please add [EFL][WK2] prefix to here as well. 716862 22 163283 zhigang.gong 2012-09-10 22:39:57 -0700 Created attachment 163283 Patch 716867 23 163283 gyuyoung.kim 2012-09-10 22:46:08 -0700 Comment on attachment 163283 Patch LGTM, thank. :-) 716917 24 163283 webkit.review.bot 2012-09-11 00:48:35 -0700 Comment on attachment 163283 Patch Clearing flags on attachment: 163283 Committed r128154: <http://trac.webkit.org/changeset/128154> 716918 25 webkit.review.bot 2012-09-11 00:48:40 -0700 All reviewed patches have been landed. Closing bug. 160918 2012-08-28 00:03:15 -0700 2012-08-28 00:19:06 -0700 Patch bug-95173-20120828150211.patch text/plain 1672 zhigang.gong U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2ODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTRkZTMxYWM4N2RlZTQ5 ODFkZjZhMzdiNzVkMTkwYWJhYzIwZTMwOC4uMzhiNGJjYmM3OTdhNzI3NmFhYzk0YzYxNzZhZmU1 ZjZhOGQ2MzRjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA4LTI3ICBaaGln YW5nIEdvbmcgIDx6aGlnYW5nLmdvbmdAbGludXguaW50ZWwuY29tPgorCisgICAgICAgIEFkZCBu ZWNlc3NhcnkgaW5jbHVkZSBkaXJlY3RvcmllcyBpbiBXZWJLaXQyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTE3MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbW1pdCBmOWQ0ZGFkZi4uLiBtb2RpZnkg dGhlIFRleHR1cmVNYXBwZXJHTC5oIHRvIGluY2x1ZGUKKwlHcmFwaGljc0NvbnRleHQzRC5oLiBB bmQgd2hlbiBlbmFibGUgVEVYVFVSRV9NQVBQRVIsCisJZmlsZSBXZWJLaXQyL1NoYXJlZC9TaGFy ZWFibGVTdXJmYWNlLmNwcCB3aWxsIGluY2x1ZGUKKwlUZXh0dXJlTWFwcGVyR0wuaCB0aGVuIGRl cGVuZHMgb24gR3JhcGhpY3NDb250ZXh0M0QuaAorCXRodXMgaXQgbmVlZCB0byBhZGQgdGhvc2Ug QU5HTEUgZGlyZWN0b3JpZXMgdG8gdGhlCisJQ01ha2VMaXN0cy50eHQuIE90aGVyd2lzZSwgdGhl IGJ1aWxkIHdpbGwgZmFpbC4KKworCVRvIHRyaWdnZXIgdGhpcyBwcm9ibGVtIGJ5IHVzaW5nIHRo ZSBmb2xsb3dpbmcgY29tbWFuZDoKKwkuL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0IC0tZWZs IC0tM2QtcmVuZGVyaW5nIC0tdGlsZWQtYmFja2luZy1zdG9yZQorCisgICAgICAgICogQ01ha2VM aXN0cy50eHQ6CisKIDIwMTItMDgtMjcgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RA Z21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjY4MzYuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJLaXQy L0NNYWtlTGlzdHMudHh0CmluZGV4IGM0M2RkNGFjOGVhZjYzZTJlZjk2ZGM4YzMyMjUwYmExYWY5 ZjE4MzguLjM0Y2M0YzMyYmU3OTk1NTBmOTg2MjczNTQ3OWQ1ZTY4N2Y5ZDI3MGUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJLaXQyL0NN YWtlTGlzdHMudHh0CkBAIC0xMTAsNiArMTEwLDEzIEBAIFNFVChXZWJLaXQyX0lOQ0xVREVfRElS RUNUT1JJRVMKICAgICAiJHtDTUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2UiCiApCiAKK0lGIChXVEZf VVNFXzNEX0dSQVBISUNTKQorICAgIExJU1QoQVBQRU5EIFdlYktpdDJfSU5DTFVERV9ESVJFQ1RP UklFUworICAgICAgICAiJHtUSElSRFBBUlRZX0RJUn0vQU5HTEUvaW5jbHVkZSIKKyAgICAgICAg IiR7VEhJUkRQQVJUWV9ESVJ9L0FOR0xFL2luY2x1ZGUvR0xTTEFORyIKKyAgICApCitFTkRJRiAo KQorCiBTRVQoV2ViS2l0Ml9TT1VSQ0VTCiAgICAgUGxhdGZvcm0vTG9nZ2luZy5jcHAKICAgICBQ bGF0Zm9ybS9Nb2R1bGUuY3BwCg== 160920 2012-08-28 00:19:16 -0700 2012-08-28 19:27:14 -0700 Patch bug-95173-20120828151810.patch text/plain 1719 zhigang.gong U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2ODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTRkZTMxYWM4N2RlZTQ5 ODFkZjZhMzdiNzVkMTkwYWJhYzIwZTMwOC4uOTM5ZDhiOGEzYmQyMzA2OWQ5MWQxNzlkNDdjYWMy YWU3MDliM2I4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA4LTI4ICBaaGln YW5nIEdvbmcgIDx6aGlnYW5nLmdvbmdAbGludXguaW50ZWwuY29tPgorCisgICAgICAgIEFkZCBu ZWNlc3NhcnkgaW5jbHVkZSBkaXJlY3RvcmllcyBpbiBXZWJLaXQyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTE3MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbW1pdCBmOWQ0ZGEuLi4gbW9kaWZ5IHRo ZSBUZXh0dXJlTWFwcGVyR0wuaCB0byBpbmNsdWRlCisgICAgICAgIEdyYXBoaWNzQ29udGV4dDNE LmguIEFuZCB3aGVuIGVuYWJsZSBURVhUVVJFX01BUFBFUiwKKyAgICAgICAgZmlsZSBXZWJLaXQy L1NoYXJlZC9TaGFyZWFibGVTdXJmYWNlLmNwcCB3aWxsIGluY2x1ZGUKKyAgICAgICAgVGV4dHVy ZU1hcHBlckdMLmggdGhlbiBkZXBlbmRzIG9uIEdyYXBoaWNzQ29udGV4dDNELmgKKyAgICAgICAg dGh1cyBpdCBuZWVkIHRvIGFkZCB0aG9zZSBBTkdMRSBkaXJlY3RvcmllcyB0byB0aGUKKyAgICAg ICAgQ01ha2VMaXN0cy50eHQuIE90aGVyd2lzZSwgdGhlIGJ1aWxkIHdpbGwgZmFpbC4KKworICAg ICAgICBUbyB0cmlnZ2VyIHRoaXMgcHJvYmxlbSBieSB1c2luZyB0aGUgZm9sbG93aW5nIGNvbW1h bmQ6CisgICAgICAgIC4vVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQgLS1lZmwgLS0zZC1yZW5k ZXJpbmcgLS10aWxlZC1iYWNraW5nLXN0b3JlCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoK KwogMjAxMi0wOC0yNyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEyNjgzNi4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0 cy50eHQKaW5kZXggYzQzZGQ0YWM4ZWFmNjNlMmVmOTZkYzhjMzIyNTBiYTFhZjlmMTgzOC4uMzRj YzRjMzJiZTc5OTU1MGY5ODYyNzM1NDc5ZDVlNjg3ZjlkMjcwZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50 eHQKQEAgLTExMCw2ICsxMTAsMTMgQEAgU0VUKFdlYktpdDJfSU5DTFVERV9ESVJFQ1RPUklFUwog ICAgICIke0NNQUtFX1NPVVJDRV9ESVJ9L1NvdXJjZSIKICkKIAorSUYgKFdURl9VU0VfM0RfR1JB UEhJQ1MpCisgICAgTElTVChBUFBFTkQgV2ViS2l0Ml9JTkNMVURFX0RJUkVDVE9SSUVTCisgICAg ICAgICIke1RISVJEUEFSVFlfRElSfS9BTkdMRS9pbmNsdWRlIgorICAgICAgICAiJHtUSElSRFBB UlRZX0RJUn0vQU5HTEUvaW5jbHVkZS9HTFNMQU5HIgorICAgICkKK0VORElGICgpCisKIFNFVChX ZWJLaXQyX1NPVVJDRVMKICAgICBQbGF0Zm9ybS9Mb2dnaW5nLmNwcAogICAgIFBsYXRmb3JtL01v ZHVsZS5jcHAK 161118 2012-08-28 19:27:22 -0700 2012-09-09 20:17:24 -0700 Patch bug-95173-20120829102614.patch text/plain 1776 zhigang.gong U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2ODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTRkZTMxYWM4N2RlZTQ5 ODFkZjZhMzdiNzVkMTkwYWJhYzIwZTMwOC4uYjRiMTY4NzQ5MDJjZTBjMWQzMzM2YmUyYzI5Y2E3 ZGIwZTdhZjAzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA4LTI4ICBaaGln YW5nIEdvbmcgIDx6aGlnYW5nLmdvbmdAbGludXguaW50ZWwuY29tPgorCisgICAgICAgIEFkZCBu ZWNlc3NhcnkgaW5jbHVkZSBkaXJlY3RvcmllcyBpbiBXZWJLaXQyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTE3MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHJldmlzaW9uIHIxMjY2OTQ6IE1vdmUgVGV4 dHVyZU1hcHBlckdMIHRvIHVzZQorICAgICAgICBHcmFwaGljc0NvbnRleHQzRC4gbW9kaWZ5IHRo ZSBUZXh0dXJlTWFwcGVyR0wuaCB0byBpbmNsdWRlCisgICAgICAgIEdyYXBoaWNzQ29udGV4dDNE LmguIEFuZCB3aGVuIGVuYWJsZSBURVhUVVJFX01BUFBFUiwKKyAgICAgICAgZmlsZSBXZWJLaXQy L1NoYXJlZC9TaGFyZWFibGVTdXJmYWNlLmNwcCB3aWxsIGluY2x1ZGUKKyAgICAgICAgVGV4dHVy ZU1hcHBlckdMLmggdGhlbiBkZXBlbmRzIG9uIEdyYXBoaWNzQ29udGV4dDNELmgKKyAgICAgICAg dGh1cyBpdCBuZWVkIHRvIGFkZCB0aG9zZSBBTkdMRSBkaXJlY3RvcmllcyB0byB0aGUKKyAgICAg ICAgQ01ha2VMaXN0cy50eHQuIE90aGVyd2lzZSwgdGhlIGJ1aWxkIHdpbGwgZmFpbC4KKworICAg ICAgICBUbyB0cmlnZ2VyIHRoaXMgcHJvYmxlbSBieSB1c2luZyB0aGUgZm9sbG93aW5nIGNvbW1h bmQ6CisgICAgICAgIC4vVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQgLS1lZmwgLS0zZC1yZW5k ZXJpbmcgLS10aWxlZC1iYWNraW5nLXN0b3JlCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoK KwogMjAxMi0wOC0yNyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEyNjgzNi4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0 cy50eHQKaW5kZXggYzQzZGQ0YWM4ZWFmNjNlMmVmOTZkYzhjMzIyNTBiYTFhZjlmMTgzOC4uMzRj YzRjMzJiZTc5OTU1MGY5ODYyNzM1NDc5ZDVlNjg3ZjlkMjcwZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50 eHQKQEAgLTExMCw2ICsxMTAsMTMgQEAgU0VUKFdlYktpdDJfSU5DTFVERV9ESVJFQ1RPUklFUwog ICAgICIke0NNQUtFX1NPVVJDRV9ESVJ9L1NvdXJjZSIKICkKIAorSUYgKFdURl9VU0VfM0RfR1JB UEhJQ1MpCisgICAgTElTVChBUFBFTkQgV2ViS2l0Ml9JTkNMVURFX0RJUkVDVE9SSUVTCisgICAg ICAgICIke1RISVJEUEFSVFlfRElSfS9BTkdMRS9pbmNsdWRlIgorICAgICAgICAiJHtUSElSRFBB UlRZX0RJUn0vQU5HTEUvaW5jbHVkZS9HTFNMQU5HIgorICAgICkKK0VORElGICgpCisKIFNFVChX ZWJLaXQyX1NPVVJDRVMKICAgICBQbGF0Zm9ybS9Mb2dnaW5nLmNwcAogICAgIFBsYXRmb3JtL01v ZHVsZS5jcHAK 163031 2012-09-09 20:55:32 -0700 2012-09-10 22:22:27 -0700 Patch bug-95173-20120910115322.patch text/plain 1760 zhigang.gong U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNGMxNDhmZjEzM2MzZWZl MThkZDdjZDA4ZGE2ZTE3M2MzNzc1NTYyNi4uYmM3MjgyMDE2MTM5MmM1OWYxMTUxN2RkMWUwNDgx NGZiYWIwYWExOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA5LTA5ICBaaGln YW5nIEdvbmcgIDx6aGlnYW5nLmdvbmdAbGludXguaW50ZWwuY29tPgorCisgICAgICAgIEFkZCBu ZWNlc3NhcnkgaW5jbHVkZSBkaXJlY3RvcmllcyBpbiBXZWJLaXQyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTE3MworCisgICAgICAgIFVucmV2aWV3 ZWQgYnVpbGQgZml4LgorCisgICAgICAgIHJldmlzaW9uIHIxMjY2OTQ6IE1vdmUgVGV4dHVyZU1h cHBlckdMIHRvIHVzZQorICAgICAgICBHcmFwaGljc0NvbnRleHQzRC4gbW9kaWZ5IHRoZSBUZXh0 dXJlTWFwcGVyR0wuaCB0byBpbmNsdWRlCisgICAgICAgIEdyYXBoaWNzQ29udGV4dDNELmguIEFu ZCB3aGVuIGVuYWJsZSBURVhUVVJFX01BUFBFUiwKKyAgICAgICAgZmlsZSBXZWJLaXQyL1NoYXJl ZC9TaGFyZWFibGVTdXJmYWNlLmNwcCB3aWxsIGluY2x1ZGUKKyAgICAgICAgVGV4dHVyZU1hcHBl ckdMLmggdGhlbiBkZXBlbmRzIG9uIEdyYXBoaWNzQ29udGV4dDNELmgKKyAgICAgICAgdGh1cyBp dCBuZWVkIHRvIGFkZCB0aG9zZSBBTkdMRSBkaXJlY3RvcmllcyB0byB0aGUKKyAgICAgICAgQ01h a2VMaXN0cy50eHQuIE90aGVyd2lzZSwgdGhlIGJ1aWxkIHdpbGwgZmFpbC4KKworICAgICAgICBU byB0cmlnZ2VyIHRoaXMgcHJvYmxlbSBieSB1c2luZyB0aGUgZm9sbG93aW5nIGNvbW1hbmQ6Cisg ICAgICAgIC4vVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQgLS1lZmwgLS0zZC1yZW5kZXJpbmcg LS10aWxlZC1iYWNraW5nLXN0b3JlCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKwogMjAx Mi0wOS0wOSAgRW1pbCBBIEVrbHVuZCAgPGVhZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVu YW1lIE5vZGU6OmdldFJlY3QvZ2V0UGl4ZWxTbmFwcGVkUmVjdCBhbmQgcmVtb3ZlIENvbnRhaW5l ck5vZGU6OmdldFJlY3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NNYWtlTGlzdHMudHh0 IGIvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQKaW5kZXggZjJiYTc0NzFiZjRlN2FmZDdl YTViOGMyYWU2Y2M1YzUzMmI5NGQxNy4uNWYyMTJlODU1ZTAyMTNjN2ZlOTVkYmRlMjNlNzBhMWE5 MTFiMWE3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQKKysrIGIv U291cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQKQEAgLTExMSw2ICsxMTEsMTIgQEAgU0VUKFdl YktpdDJfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICIke0NNQUtFX1NPVVJDRV9ESVJ9L1NvdXJj ZSIKICkKIAorSUYgKFdURl9VU0VfM0RfR1JBUEhJQ1MpCisgICAgTElTVChBUFBFTkQgV2ViS2l0 Ml9JTkNMVURFX0RJUkVDVE9SSUVTCisgICAgICAgICIke1RISVJEUEFSVFlfRElSfS9BTkdMRS9p bmNsdWRlL0dMU0xBTkciCisgICAgKQorRU5ESUYgKCkKKwogU0VUKFdlYktpdDJfU09VUkNFUwog ICAgIFBsYXRmb3JtL0xvZ2dpbmcuY3BwCiAgICAgUGxhdGZvcm0vTW9kdWxlLmNwcAo= 163279 2012-09-10 22:22:36 -0700 2012-09-10 22:39:47 -0700 Patch bug-95173-20120911132021.patch text/plain 1916 zhigang.gong U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNGMxNDhmZjEzM2MzZWZl MThkZDdjZDA4ZGE2ZTE3M2MzNzc1NTYyNi4uYWI1NWRhYjI4MDdjOTcxNjhkYTA4YjRjOGExODNi ODJhM2UwZTFhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA5LTA5ICBaaGln YW5nIEdvbmcgIDx6aGlnYW5nLmdvbmdAbGludXguaW50ZWwuY29tPgorCisgICAgICAgIEFkZCBu ZWNlc3NhcnkgaW5jbHVkZSBkaXJlY3RvcmllcyBpbiBXZWJLaXQyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTE3MworCisgICAgICAgIFVucmV2aWV3 ZWQgYnVpbGQgZml4LgorCisgICAgICAgIHJldmlzaW9uIHIxMjY2OTQ6IE1vdmUgVGV4dHVyZU1h cHBlckdMIHRvIHVzZQorICAgICAgICBHcmFwaGljc0NvbnRleHQzRC4gbW9kaWZ5IHRoZSBUZXh0 dXJlTWFwcGVyR0wuaCB0byBpbmNsdWRlCisgICAgICAgIEdyYXBoaWNzQ29udGV4dDNELmguIEFu ZCB3aGVuIGVuYWJsZSBURVhUVVJFX01BUFBFUiwKKyAgICAgICAgZmlsZSBXZWJLaXQyL1NoYXJl ZC9TaGFyZWFibGVTdXJmYWNlLmNwcCB3aWxsIGluY2x1ZGUKKyAgICAgICAgVGV4dHVyZU1hcHBl ckdMLmggdGhlbiBkZXBlbmRzIG9uIEdyYXBoaWNzQ29udGV4dDNELmgKKyAgICAgICAgdGh1cyBp dCBuZWVkIHRvIGFkZCBBTkdMRSBkaXJlY3Rvci4gQXMgY3VycmVudGx5LCB0aGlzCisgICAgICAg IHByb2JsZW0gb25seSBhZmZlY3QgRUZMIHBsYXRmb3JtLCBhY2NvcmRpbmcgdG8gR3l1eW91bmcg S2ltJ3MKKyAgICAgICAgc3VnZ2VzdGlvbiwgd2UgYWRkIHRoaXMgaW5jbHVkZSBkaXIgaW50byBF RkwgcHJpdmF0ZSBmaWxlCisgICAgICAgIFBsYXRmb3JtRWZsLmNtYWtlLiBPdGhlcndpc2UsIHRo ZSBidWlsZCB3aWxsIGZhaWwuCisKKyAgICAgICAgVG8gdHJpZ2dlciB0aGlzIHByb2JsZW0gYnkg dXNpbmcgdGhlIGZvbGxvd2luZyBjb21tYW5kOgorICAgICAgICAuL1Rvb2xzL1NjcmlwdHMvYnVp bGQtd2Via2l0IC0tZWZsIC0tM2QtcmVuZGVyaW5nIC0tdGlsZWQtYmFja2luZy1zdG9yZQorCisg ICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMTItMDktMDkgIEVtaWwgQSBFa2x1bmQgIDxl YWVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbmFtZSBOb2RlOjpnZXRSZWN0L2dldFBpeGVs U25hcHBlZFJlY3QgYW5kIHJlbW92ZSBDb250YWluZXJOb2RlOjpnZXRSZWN0CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUVmbC5jbWFrZSBiL1NvdXJjZS9XZWJLaXQyL1BsYXRm b3JtRWZsLmNtYWtlCmluZGV4IGI0OTI0N2ZkOGFjZjE2MTEzNjAyMmU3ODViNDJkNTRjY2RjMGUx MTkuLjA4YzhjZmY0YTZhODc5NGM0NWI1YmJkMzQ1NDNjNWJmYzI1YzA5ZDIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtRWZsLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXQyL1Bs YXRmb3JtRWZsLmNtYWtlCkBAIC0xNTYsNiArMTU2LDEyIEBAIExJU1QoQVBQRU5EIFdlYktpdDJf SU5DTFVERV9ESVJFQ1RPUklFUwogICAgICR7V1RGX0RJUn0KICkKIAorSUYgKFdURl9VU0VfM0Rf R1JBUEhJQ1MpCisgICAgTElTVChBUFBFTkQgV2ViS2l0Ml9JTkNMVURFX0RJUkVDVE9SSUVTCisg ICAgICAgICIke1RISVJEUEFSVFlfRElSfS9BTkdMRS9pbmNsdWRlL0dMU0xBTkciCisgICAgKQor RU5ESUYgKCkKKwogTElTVChBUFBFTkQgV2ViS2l0Ml9MSUJSQVJJRVMKICAgICAke0NBSVJPX0xJ QlJBUklFU30KICAgICAke0VDT1JFX1hfTElCUkFSSUVTfQo= 163283 2012-09-10 22:39:57 -0700 2012-09-11 00:48:35 -0700 Patch bug-95173-20120911133742.patch text/plain 1925 zhigang.gong U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNGMxNDhmZjEzM2MzZWZl MThkZDdjZDA4ZGE2ZTE3M2MzNzc1NTYyNi4uMDhlMjE5NDNkNDg1YmEwZmNhODhjOTkzZjZmMzI1 NDYzZTRmYmFmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA5LTA5ICBaaGln YW5nIEdvbmcgIDx6aGlnYW5nLmdvbmdAbGludXguaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxd W1dLMl0gQWRkIG5lY2Vzc2FyeSBpbmNsdWRlIGRpcmVjdG9yeSBpbiBXZWJLaXQyCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTE3MworCisgICAgICAg IFVucmV2aWV3ZWQgYnVpbGQgZml4LgorCisgICAgICAgIHJldmlzaW9uIHIxMjY2OTQ6IE1vdmUg VGV4dHVyZU1hcHBlckdMIHRvIHVzZQorICAgICAgICBHcmFwaGljc0NvbnRleHQzRC4gbW9kaWZ5 IHRoZSBUZXh0dXJlTWFwcGVyR0wuaCB0byBpbmNsdWRlCisgICAgICAgIEdyYXBoaWNzQ29udGV4 dDNELmguIEFuZCB3aGVuIGVuYWJsZSBURVhUVVJFX01BUFBFUiwKKyAgICAgICAgZmlsZSBXZWJL aXQyL1NoYXJlZC9TaGFyZWFibGVTdXJmYWNlLmNwcCB3aWxsIGluY2x1ZGUKKyAgICAgICAgVGV4 dHVyZU1hcHBlckdMLmggdGhlbiBkZXBlbmRzIG9uIEdyYXBoaWNzQ29udGV4dDNELmgKKyAgICAg ICAgdGh1cyBpdCBuZWVkIHRvIGFkZCBBTkdMRSBkaXJlY3Rvci4gQXMgY3VycmVudGx5LCB0aGlz CisgICAgICAgIHByb2JsZW0gb25seSBhZmZlY3QgRUZMIHBsYXRmb3JtLCBhY2NvcmRpbmcgdG8g R3l1eW91bmcgS2ltJ3MKKyAgICAgICAgc3VnZ2VzdGlvbiwgd2UgYWRkIHRoaXMgaW5jbHVkZSBk aXIgaW50byBFRkwgcHJpdmF0ZSBmaWxlCisgICAgICAgIFBsYXRmb3JtRWZsLmNtYWtlLiBPdGhl cndpc2UsIHRoZSBidWlsZCB3aWxsIGZhaWwuCisKKyAgICAgICAgVG8gdHJpZ2dlciB0aGlzIHBy b2JsZW0gYnkgdXNpbmcgdGhlIGZvbGxvd2luZyBjb21tYW5kOgorICAgICAgICAuL1Rvb2xzL1Nj cmlwdHMvYnVpbGQtd2Via2l0IC0tZWZsIC0tM2QtcmVuZGVyaW5nIC0tdGlsZWQtYmFja2luZy1z dG9yZQorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMTItMDktMDkgIEVtaWwgQSBF a2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbmFtZSBOb2RlOjpnZXRSZWN0 L2dldFBpeGVsU25hcHBlZFJlY3QgYW5kIHJlbW92ZSBDb250YWluZXJOb2RlOjpnZXRSZWN0CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUVmbC5jbWFrZSBiL1NvdXJjZS9XZWJL aXQyL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IGI0OTI0N2ZkOGFjZjE2MTEzNjAyMmU3ODViNDJk NTRjY2RjMGUxMTkuLjA4YzhjZmY0YTZhODc5NGM0NWI1YmJkMzQ1NDNjNWJmYzI1YzA5ZDIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtRWZsLmNtYWtlCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1BsYXRmb3JtRWZsLmNtYWtlCkBAIC0xNTYsNiArMTU2LDEyIEBAIExJU1QoQVBQRU5E IFdlYktpdDJfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICR7V1RGX0RJUn0KICkKIAorSUYgKFdU Rl9VU0VfM0RfR1JBUEhJQ1MpCisgICAgTElTVChBUFBFTkQgV2ViS2l0Ml9JTkNMVURFX0RJUkVD VE9SSUVTCisgICAgICAgICIke1RISVJEUEFSVFlfRElSfS9BTkdMRS9pbmNsdWRlL0dMU0xBTkci CisgICAgKQorRU5ESUYgKCkKKwogTElTVChBUFBFTkQgV2ViS2l0Ml9MSUJSQVJJRVMKICAgICAk e0NBSVJPX0xJQlJBUklFU30KICAgICAke0VDT1JFX1hfTElCUkFSSUVTfQo=