95170 2012-08-27 23:09:18 -0700 [WK2] Use explicit constructor in PageClientImpl 2012-08-28 22:09:47 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kangil.han kangil.han cgarcia gustavo gyuyoung.kim mrobinson webkit.review.bot oldest_to_newest 706091 0 kangil.han 2012-08-27 23:09:18 -0700 Added explicit keyword to constructor in PageClientImpl. 706092 1 160906 kangil.han 2012-08-27 23:10:56 -0700 Created attachment 160906 patch 706094 2 webkit.review.bot 2012-08-27 23:13:19 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 706992 3 160906 mrobinson 2012-08-28 19:06:24 -0700 Comment on attachment 160906 patch Nowhere in the patch or the bug do you explain why you are making this change... Does it fix or prevent any bugs? 706997 4 kangil.han 2012-08-28 19:18:22 -0700 (In reply to comment #3) > (From update of attachment 160906 [details]) > Nowhere in the patch or the bug do you explain why you are making this change... Does it fix or prevent any bugs? Yes, you are right. I didn't explain why explicit keyword is needed in this patch. I will get back with updated changelog! Thanks! 707030 5 161119 kangil.han 2012-08-28 19:40:50 -0700 Created attachment 161119 patch Done! 707088 6 161119 webkit.review.bot 2012-08-28 22:09:43 -0700 Comment on attachment 161119 patch Clearing flags on attachment: 161119 Committed r126958: <http://trac.webkit.org/changeset/126958> 707089 7 webkit.review.bot 2012-08-28 22:09:47 -0700 All reviewed patches have been landed. Closing bug. 160906 2012-08-27 23:10:56 -0700 2012-08-28 19:40:50 -0700 patch explicit_page_client_impl.txt text/plain 1818 kangil.han ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlZGQ1Njg5Li40MzZiYTkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDgtMjcgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgorCisg ICAgICAgIFtXSzJdW0dUS11bTUFDXSBVc2UgZXhwbGljaXQgY29uc3RydWN0b3IgaW4gUGFnZUNs aWVudEltcGwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05NTE3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZGVkIGV4cGxpY2l0IGtleXdvcmQgdG8gY29uc3RydWN0b3IgaW4gUGFnZUNsaWVudEltcGwu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5oOgorICAgICAg ICAoUGFnZUNsaWVudEltcGwpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1BhZ2VDbGll bnRJbXBsLmg6CisgICAgICAgIChQYWdlQ2xpZW50SW1wbCk6CisKIDIwMTItMDgtMjcgIFNpbW9u IEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBGb3JjZSBS ZXBhaW50IHdvcmsgd2l0aCB0aWxlZCBiYWNraW5nIHN0b3JlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5oIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuaAppbmRleCA3MmZjMzQ1Li42YmU4 OTExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xp ZW50SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGll bnRJbXBsLmgKQEAgLTUxLDcgKzUxLDcgQEAgcHVibGljOgogICAgIEd0a1dpZGdldCogdmlld1dp ZGdldCgpIHsgcmV0dXJuIG1fdmlld1dpZGdldDsgfQogCiBwcml2YXRlOgotICAgIFBhZ2VDbGll bnRJbXBsKEd0a1dpZGdldCopOworICAgIGV4cGxpY2l0IFBhZ2VDbGllbnRJbXBsKEd0a1dpZGdl dCopOwogCiAgICAgdmlydHVhbCBQYXNzT3duUHRyPERyYXdpbmdBcmVhUHJveHk+IGNyZWF0ZURy YXdpbmdBcmVhUHJveHkoKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0Vmlld05lZWRzRGlzcGxheShj b25zdCBXZWJDb3JlOjpJbnRSZWN0Jik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL21hYy9QYWdlQ2xpZW50SW1wbC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9tYWMvUGFnZUNsaWVudEltcGwuaAppbmRleCA5OGRhN2VjLi5kZDhhNDc1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9QYWdlQ2xpZW50SW1wbC5oCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1BhZ2VDbGllbnRJbXBsLmgKQEAg LTQ4LDcgKzQ4LDcgQEAgcHVibGljOgogICAgIHZvaWQgdmlld1dpbGxNb3ZlVG9Bbm90aGVyV2lu ZG93KCk7CiAKIHByaXZhdGU6Ci0gICAgUGFnZUNsaWVudEltcGwoV0tWaWV3Kik7CisgICAgZXhw bGljaXQgUGFnZUNsaWVudEltcGwoV0tWaWV3Kik7CiAKICAgICB2aXJ0dWFsIFBhc3NPd25QdHI8 RHJhd2luZ0FyZWFQcm94eT4gY3JlYXRlRHJhd2luZ0FyZWFQcm94eSgpOwogICAgIHZpcnR1YWwg dm9pZCBzZXRWaWV3TmVlZHNEaXNwbGF5KGNvbnN0IFdlYkNvcmU6OkludFJlY3QmKTsK 161119 2012-08-28 19:40:50 -0700 2012-08-28 22:09:43 -0700 patch explicit_page_client_impl_2.txt text/plain 1851 kangil.han ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlZGQ1Njg5Li4wYTY3MzVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDgtMjggIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgorCisg ICAgICAgIFtXSzJdIFVzZSBleHBsaWNpdCBjb25zdHJ1Y3RvciBpbiBQYWdlQ2xpZW50SW1wbC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1MTcwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgZXhw bGljaXQga2V5d29yZCBpbiBjb25zdHJ1Y3RvciBvZiBQYWdlQ2xpZW50SW1wbCBpbiBvcmRlciB0 byBhdm9pZCBpbXBsaWNpdCB0eXBlIGNvbnZlcnNpb24uCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5oOgorICAgICAgICAoUGFnZUNsaWVudEltcGwpOgorICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1BhZ2VDbGllbnRJbXBsLmg6CisgICAgICAgIChQYWdl Q2xpZW50SW1wbCk6CisKIDIwMTItMDgtMjcgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBh cHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBGb3JjZSBSZXBhaW50IHdvcmsgd2l0aCB0aWxlZCBi YWNraW5nIHN0b3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay9QYWdlQ2xpZW50SW1wbC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFn ZUNsaWVudEltcGwuaAppbmRleCA3MmZjMzQ1Li42YmU4OTExIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5oCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmgKQEAgLTUxLDcgKzUxLDcg QEAgcHVibGljOgogICAgIEd0a1dpZGdldCogdmlld1dpZGdldCgpIHsgcmV0dXJuIG1fdmlld1dp ZGdldDsgfQogCiBwcml2YXRlOgotICAgIFBhZ2VDbGllbnRJbXBsKEd0a1dpZGdldCopOworICAg IGV4cGxpY2l0IFBhZ2VDbGllbnRJbXBsKEd0a1dpZGdldCopOwogCiAgICAgdmlydHVhbCBQYXNz T3duUHRyPERyYXdpbmdBcmVhUHJveHk+IGNyZWF0ZURyYXdpbmdBcmVhUHJveHkoKTsKICAgICB2 aXJ0dWFsIHZvaWQgc2V0Vmlld05lZWRzRGlzcGxheShjb25zdCBXZWJDb3JlOjpJbnRSZWN0Jik7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9QYWdlQ2xpZW50 SW1wbC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvUGFnZUNsaWVudEltcGwu aAppbmRleCA5OGRhN2VjLi5kZDhhNDc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL21hYy9QYWdlQ2xpZW50SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvbWFjL1BhZ2VDbGllbnRJbXBsLmgKQEAgLTQ4LDcgKzQ4LDcgQEAgcHVibGljOgog ICAgIHZvaWQgdmlld1dpbGxNb3ZlVG9Bbm90aGVyV2luZG93KCk7CiAKIHByaXZhdGU6Ci0gICAg UGFnZUNsaWVudEltcGwoV0tWaWV3Kik7CisgICAgZXhwbGljaXQgUGFnZUNsaWVudEltcGwoV0tW aWV3Kik7CiAKICAgICB2aXJ0dWFsIFBhc3NPd25QdHI8RHJhd2luZ0FyZWFQcm94eT4gY3JlYXRl RHJhd2luZ0FyZWFQcm94eSgpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRWaWV3TmVlZHNEaXNwbGF5 KGNvbnN0IFdlYkNvcmU6OkludFJlY3QmKTsK