95151 2012-08-27 16:11:48 -0700 [V8] V8DOMWindowShell::installDOMWindow is subtle and should explain itself more 2012-08-27 17:50:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 94909 1 abarth abarth eric haraken japhet webkit.review.bot oldest_to_newest 705833 0 abarth 2012-08-27 16:11:48 -0700 [V8] V8DOMWindowShell::installDOMWindow is subtle and should explain itself more 705841 1 160844 abarth 2012-08-27 16:14:49 -0700 Created attachment 160844 Patch 705869 2 160844 haraken 2012-08-27 16:43:50 -0700 Comment on attachment 160844 Patch Looks ok. 705914 3 160844 abarth 2012-08-27 17:22:10 -0700 Comment on attachment 160844 Patch Thanks! 705935 4 160844 webkit.review.bot 2012-08-27 17:50:34 -0700 Comment on attachment 160844 Patch Clearing flags on attachment: 160844 Committed r126829: <http://trac.webkit.org/changeset/126829> 705936 5 webkit.review.bot 2012-08-27 17:50:38 -0700 All reviewed patches have been landed. Closing bug. 160844 2012-08-27 16:14:49 -0700 2012-08-27 17:50:34 -0700 Patch bug-95151-20120827161441.patch text/plain 5607 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2Nzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGQ5ZDMxOWEyODM5ZTUw ZDMwOTI1ZTZkYTA3MzUxNjkwMTMwMDFiZi4uNTZlZmRkYTAwNDRkMzUzNjIzMDIxYjc0NDRlYmMz ODVhNDVmZDQxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEyLTA4LTI3ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgW1Y4XSBWOERPTVdpbmRvd1No ZWxsOjppbnN0YWxsRE9NV2luZG93IGlzIHN1YnRsZSBhbmQgc2hvdWxkIGV4cGxhaW4gaXRzZWxm IG1vcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1 MTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhp cyBwYXRjaCBhZGRzIHNvbWUgdGV4dCB0byBWOERPTVdpbmRvd1NoZWxsOjppbnN0YWxsRE9NV2lu ZG93IHRoYXQKKyAgICAgICAgZXhwbGFpbmluZyB3aGF0IHRoaXMgY29kZSBpcyBkb2luZy4gSSd2 ZSBhbHNvIHJlbmFtZWQgc29tZSB2YXJpYWJsZXMKKyAgICAgICAgYW5kIGNyZWF0ZWQgYSBoZWxw ZXIgZnVuY3Rpb24gaW4gYW4gYXR0ZW1wdCB0byBtYWtlIGl0IGNsZWFyZXIgd2hhdCdzCisgICAg ICAgIGdvaW5nIG9uLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5j cHA6CisgICAgICAgIChXZWJDb3JlOjp0b0lubmVyR2xvYmFsT2JqZWN0KToKKyAgICAgICAgKFdl YkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6VjhET01XaW5kb3dTaGVsbDo6aW5zdGFsbERPTVdp bmRvdyk6CisgICAgICAgIChXZWJDb3JlOjpWOERPTVdpbmRvd1NoZWxsOjp1cGRhdGVEb2N1bWVu dFByb3BlcnR5KToKKworMjAxMi0wOC0yNyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn PgorCiAgICAgICAgIFtWOF0gVjhET01XaW5kb3dTaGVsbDo6c2V0Q29udGV4dCBoYXMgbm8gY2Fs bGVycwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTUx NDcKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XaW5kb3dT aGVsbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmNw cAppbmRleCBmYTllMDJkNTJhODk5ODg3YTFmOTYxNWFhYjg1ZTU5ODEyMjc2NDFlLi40ZGZjZTcw OWFhOWQxZmMxZjgzYjE4YWQ4MDQxMjAyYzM3MjdhYjUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmNwcApAQCAtMTcwLDYgKzE3MCwxMSBAQCBz dGF0aWMgdm9pZCBjaGVja0RvY3VtZW50V3JhcHBlcih2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHdy YXBwZXIsIERvY3VtZW50KiBkb2N1bQogICAgIEFTU0VSVCghZG9jdW1lbnQtPmlzSFRNTERvY3Vt ZW50KCkgfHwgKFY4RG9jdW1lbnQ6OnRvTmF0aXZlKHY4OjpIYW5kbGU8djg6Ok9iamVjdD46OkNh c3Qod3JhcHBlci0+R2V0UHJvdG90eXBlKCkpKSA9PSBkb2N1bWVudCkpOwogfQogCitzdGF0aWMg djg6OkhhbmRsZTx2ODo6T2JqZWN0PiB0b0lubmVyR2xvYmFsT2JqZWN0KHY4OjpIYW5kbGU8djg6 OkNvbnRleHQ+IGNvbnRleHQpCit7CisgICAgcmV0dXJuIHY4OjpIYW5kbGU8djg6Ok9iamVjdD46 OkNhc3QoY29udGV4dC0+R2xvYmFsKCktPkdldFByb3RvdHlwZSgpKTsKK30KKwogUGFzc1JlZlB0 cjxWOERPTVdpbmRvd1NoZWxsPiBWOERPTVdpbmRvd1NoZWxsOjpjcmVhdGUoRnJhbWUqIGZyYW1l KQogewogICAgIHJldHVybiBhZG9wdFJlZihuZXcgVjhET01XaW5kb3dTaGVsbChmcmFtZSkpOwpA QCAtMzcwLDI0ICszNzUsMzIgQEAgdjg6OlBlcnNpc3RlbnQ8djg6OkNvbnRleHQ+IFY4RE9NV2lu ZG93U2hlbGw6OmNyZWF0ZU5ld0NvbnRleHQodjg6OkhhbmRsZTx2ODo6T2IKIAogYm9vbCBWOERP TVdpbmRvd1NoZWxsOjppbnN0YWxsRE9NV2luZG93KHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+IGNv bnRleHQsIERPTVdpbmRvdyogd2luZG93KQogewotICAgIC8vIENyZWF0ZSBhIG5ldyBKUyB3aW5k b3cgb2JqZWN0IGFuZCB1c2UgaXQgYXMgdGhlIHByb3RvdHlwZSBmb3IgdGhlICBzaGFkb3cgZ2xv YmFsIG9iamVjdC4KLSAgICB2ODo6SGFuZGxlPHY4OjpGdW5jdGlvbj4gd2luZG93Q29uc3RydWN0 b3IgPSBWOERPTVdyYXBwZXI6OmNvbnN0cnVjdG9yRm9yVHlwZSgmVjhET01XaW5kb3c6OmluZm8s IHdpbmRvdyk7Ci0gICAgdjg6OkxvY2FsPHY4OjpPYmplY3Q+IGpzV2luZG93ID0gVjhPYmplY3RD b25zdHJ1Y3Rvcjo6bmV3SW5zdGFuY2Uod2luZG93Q29uc3RydWN0b3IpOwotICAgIC8vIEJhaWwg b3V0IGlmIGFsbG9jYXRpb24gZmFpbGVkLgotICAgIGlmIChqc1dpbmRvdy5Jc0VtcHR5KCkpCisg ICAgdjg6OkxvY2FsPHY4OjpPYmplY3Q+IHdpbmRvd1dyYXBwZXIgPSBWOE9iamVjdENvbnN0cnVj dG9yOjpuZXdJbnN0YW5jZShWOERPTVdyYXBwZXI6OmNvbnN0cnVjdG9yRm9yVHlwZSgmVjhET01X aW5kb3c6OmluZm8sIHdpbmRvdykpOworICAgIGlmICh3aW5kb3dXcmFwcGVyLklzRW1wdHkoKSkK ICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgVjhET01XaW5kb3c6Omluc3RhbGxQZXJDb250 ZXh0UHJvcGVydGllcyhqc1dpbmRvdywgd2luZG93KTsKLQotICAgIC8vIFdyYXAgdGhlIHdpbmRv dy4KLSAgICBWOERPTVdyYXBwZXI6OnNldERPTVdyYXBwZXIoanNXaW5kb3csICZWOERPTVdpbmRv dzo6aW5mbywgd2luZG93KTsKLSAgICBWOERPTVdyYXBwZXI6OnNldERPTVdyYXBwZXIodjg6Okhh bmRsZTx2ODo6T2JqZWN0Pjo6Q2FzdChqc1dpbmRvdy0+R2V0UHJvdG90eXBlKCkpLCAmVjhET01X aW5kb3c6OmluZm8sIHdpbmRvdyk7Ci0gICAgVjhET01XcmFwcGVyOjpzZXRKU1dyYXBwZXJGb3JE T01PYmplY3QoUGFzc1JlZlB0cjxET01XaW5kb3c+KHdpbmRvdyksIGpzV2luZG93KTsKLQotICAg IC8vIEluc2VydCB0aGUgd2luZG93IGluc3RhbmNlIGFzIHRoZSBwcm90b3R5cGUgb2YgdGhlIHNo YWRvdyBvYmplY3QuCi0gICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiB2OFJlYWxHbG9iYWwgPSB2 ODo6SGFuZGxlPHY4OjpPYmplY3Q+OjpDYXN0KGNvbnRleHQtPkdsb2JhbCgpLT5HZXRQcm90b3R5 cGUoKSk7Ci0gICAgVjhET01XcmFwcGVyOjpzZXRET01XcmFwcGVyKHY4UmVhbEdsb2JhbCwgJlY4 RE9NV2luZG93OjppbmZvLCB3aW5kb3cpOwotICAgIHY4UmVhbEdsb2JhbC0+U2V0UHJvdG90eXBl KGpzV2luZG93KTsKKyAgICBWOERPTVdpbmRvdzo6aW5zdGFsbFBlckNvbnRleHRQcm9wZXJ0aWVz KHdpbmRvd1dyYXBwZXIsIHdpbmRvdyk7CisKKyAgICBWOERPTVdyYXBwZXI6OnNldERPTVdyYXBw ZXIod2luZG93V3JhcHBlciwgJlY4RE9NV2luZG93OjppbmZvLCB3aW5kb3cpOworICAgIFY4RE9N V3JhcHBlcjo6c2V0RE9NV3JhcHBlcih2ODo6SGFuZGxlPHY4OjpPYmplY3Q+OjpDYXN0KHdpbmRv d1dyYXBwZXItPkdldFByb3RvdHlwZSgpKSwgJlY4RE9NV2luZG93OjppbmZvLCB3aW5kb3cpOwor ICAgIFY4RE9NV3JhcHBlcjo6c2V0SlNXcmFwcGVyRm9yRE9NT2JqZWN0KFBhc3NSZWZQdHI8RE9N V2luZG93Pih3aW5kb3cpLCB3aW5kb3dXcmFwcGVyKTsKKworICAgIC8vIEluc3RhbGwgdGhlIHdp bmRvd1dyYXBwZXIgYXMgdGhlIHByb3RvdHlwZSBvZiB0aGUgaW5uZXJHbG9iYWxPYmplY3QuCisg ICAgLy8gVGhlIGZ1bGwgc3RydWN0dXJlIG9mIHRoZSBnbG9iYWwgb2JqZWN0IGlzIGFzIGZvbGxv d3M6CisgICAgLy8KKyAgICAvLyBvdXRlckdsb2JhbE9iamVjdCAoRW1wdHkgb2JqZWN0LCByZW1h aW5zIGFmdGVyIG5hdmlnYXRpb24pCisgICAgLy8gICAtLSBoYXMgcHJvdG90eXBlIC0tPiBpbm5l ckdsb2JhbE9iamVjdCAoSG9sZHMgZ2xvYmFsIHZhcmlhYmxlcywgY2hhbmdlcyBkdXJpbmcgbmF2 aWdhdGlvbikKKyAgICAvLyAgIC0tIGhhcyBwcm90b3R5cGUgLS0+IERPTVdpbmRvdyBpbnN0YW5j ZQorICAgIC8vICAgLS0gaGFzIHByb3RvdHlwZSAtLT4gV2luZG93LnByb3RvdHlwZQorICAgIC8v ICAgLS0gaGFzIHByb3RvdHlwZSAtLT4gT2JqZWN0LnByb3RvdHlwZQorICAgIC8vCisgICAgLy8g Tm90ZTogTXVjaCBvZiB0aGlzIHByb3RvdHlwZSBzdHJ1Y3R1cmUgaXMgaGlkZGVuIGZyb20gd2Vi IGNvbnRlbnQuIFRoZQorICAgIC8vICAgICAgIG91dGVyLCBpbm5lciwgYW5kIERPTVdpbmRvdyBp bnN0YW5jZSBhbGwgYXBwZWFyIHRvIGJlIHRoZSBzYW1lCisgICAgLy8gICAgICAgSmF2YVNjcmlw dCBvYmplY3QuCisgICAgLy8KKyAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGlubmVyR2xvYmFs T2JqZWN0ID0gdG9Jbm5lckdsb2JhbE9iamVjdChjb250ZXh0KTsKKyAgICBWOERPTVdyYXBwZXI6 OnNldERPTVdyYXBwZXIoaW5uZXJHbG9iYWxPYmplY3QsICZWOERPTVdpbmRvdzo6aW5mbywgd2lu ZG93KTsKKyAgICBpbm5lckdsb2JhbE9iamVjdC0+U2V0UHJvdG90eXBlKHdpbmRvd1dyYXBwZXIp OwogICAgIHJldHVybiB0cnVlOwogfQogCkBAIC00MTcsMTEgKzQzMCwxMCBAQCB2b2lkIFY4RE9N V2luZG93U2hlbGw6OnVwZGF0ZURvY3VtZW50UHJvcGVydHkoKQogICAgIEFTU0VSVChkb2N1bWVu dFdyYXBwZXItPklzT2JqZWN0KCkpOwogICAgIG1fY29udGV4dC0+R2xvYmFsKCktPkZvcmNlU2V0 KHY4OjpTdHJpbmc6Ok5ldygiZG9jdW1lbnQiKSwgZG9jdW1lbnRXcmFwcGVyLCBzdGF0aWNfY2Fz dDx2ODo6UHJvcGVydHlBdHRyaWJ1dGU+KHY4OjpSZWFkT25seSB8IHY4OjpEb250RGVsZXRlKSk7 CiAKLSAgICAvLyBXZSBhbHNvIHN0YXNoIGEgcmVmZXJlbmNlIHRvIHRoZSBkb2N1bWVudCBvbiB0 aGUgcmVhbCBnbG9iYWwgb2JqZWN0IHNvIHRoYXQKKyAgICAvLyBXZSBhbHNvIHN0YXNoIGEgcmVm ZXJlbmNlIHRvIHRoZSBkb2N1bWVudCBvbiB0aGUgaW5uZXIgZ2xvYmFsIG9iamVjdCBzbyB0aGF0 CiAgICAgLy8gRE9NV2luZG93IG9iamVjdHMgd2Ugb2J0YWluIGZyb20gSmF2YVNjcmlwdCByZWZl cmVuY2VzIGFyZSBndWFyYW50ZWVkIHRvIGhhdmUKICAgICAvLyBsaXZlIERvY3VtZW50IG9iamVj dHMuCi0gICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiB2OFJlYWxHbG9iYWwgPSB2ODo6SGFuZGxl PHY4OjpPYmplY3Q+OjpDYXN0KG1fY29udGV4dC0+R2xvYmFsKCktPkdldFByb3RvdHlwZSgpKTsK LSAgICB2OFJlYWxHbG9iYWwtPlNldEhpZGRlblZhbHVlKFY4SGlkZGVuUHJvcGVydHlOYW1lOjpk b2N1bWVudCgpLCBkb2N1bWVudFdyYXBwZXIpOworICAgIHRvSW5uZXJHbG9iYWxPYmplY3QobV9j b250ZXh0LmdldCgpKS0+U2V0SGlkZGVuVmFsdWUoVjhIaWRkZW5Qcm9wZXJ0eU5hbWU6OmRvY3Vt ZW50KCksIGRvY3VtZW50V3JhcHBlcik7CiB9CiAKIHZvaWQgVjhET01XaW5kb3dTaGVsbDo6Y2xl YXJEb2N1bWVudFByb3BlcnR5KCkK