95145 2012-08-27 15:44:37 -0700 Delete checks for impossible conditions in V8DOMWindowShell 2012-08-27 16:28:46 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 94909 1 abarth abarth eric haraken japhet webkit.review.bot oldest_to_newest 705796 0 abarth 2012-08-27 15:44:37 -0700 Delete checks for impossible conditions in V8DOMWindowShell 705800 1 160832 abarth 2012-08-27 15:45:50 -0700 Created attachment 160832 Patch 705803 2 160832 eric 2012-08-27 15:46:35 -0700 Comment on attachment 160832 Patch LGTM. 705858 3 160832 webkit.review.bot 2012-08-27 16:28:43 -0700 Comment on attachment 160832 Patch Clearing flags on attachment: 160832 Committed r126817: <http://trac.webkit.org/changeset/126817> 705859 4 webkit.review.bot 2012-08-27 16:28:46 -0700 All reviewed patches have been landed. Closing bug. 160832 2012-08-27 15:45:50 -0700 2012-08-27 16:28:43 -0700 Patch bug-95145-20120827154542.patch text/plain 5588 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2Nzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzllN2RmZDhkMWVlMGE3 NzQ4OWJhMmVkNjk0Zjk5NWM1ZGU2OWZlMS4uNTllNzU2ZTQ0OGVmNDQzYWM0YjhjOGU4MWEwMDQx ZDcwM2M5NWQwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEyLTA4LTI3ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgRGVsZXRlIGNoZWNrcyBmb3Ig aW1wb3NzaWJsZSBjb25kaXRpb25zIGluIFY4RE9NV2luZG93U2hlbGwKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1MTQ1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlc2Ugc2l0dWF0aW9ucyBkbyBub3Qg b2NjdXIuIFdlIGRvbid0IG5lZWQgdG8gY2hlY2sgZm9yIHRoZW0uCisKKyAgICAgICAgKiBiaW5k aW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENv bnRyb2xsZXI6OnVwZGF0ZURvY3VtZW50KToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERPTVdp bmRvd1NoZWxsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4RE9NV2luZG93U2hlbGw6OmNyZWF0 ZU5ld0NvbnRleHQpOgorICAgICAgICAoV2ViQ29yZTo6VjhET01XaW5kb3dTaGVsbDo6dXBkYXRl RG9jdW1lbnRQcm9wZXJ0eSk6CisgICAgICAgIChXZWJDb3JlOjpWOERPTVdpbmRvd1NoZWxsOjpz ZXRTZWN1cml0eVRva2VuKToKKyAgICAgICAgKFdlYkNvcmU6OlY4RE9NV2luZG93U2hlbGw6OnVw ZGF0ZURvY3VtZW50KToKKyAgICAgICAgKiBwYWdlL0ZyYW1lLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkZyYW1lOjpzZXREb2N1bWVudCk6CisgICAgICAgICAgICAtIHVwZGF0ZURvY3VtZW50IHVz ZWQgdG8ganVzdCByZXR1cm4gZWFybHkgd2hlbiBtX2RvYyB3YXMgMC4gTm93IHdlCisgICAgICAg ICAgICAgIGRvbid0IGV2ZW4gYm90aGVyIHRvIGNhbGwgaXQuCisKKzIwMTItMDgtMjcgIEFkYW0g QmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwogICAgICAgICBbVjhdIElubGluZSBWOERPTVdp bmRvd1NoZWxsOjpjbGVhckRvY3VtZW50V3JhcHBlcgogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTUxMzMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmNwcAppbmRleCBkYTkzOTg0ZWQ3NmMwNDgyMDM1ZDc0 OThhZTdmMDI3MWY5Njc5ZjgzLi40MWJiZWE4YjJmOGRiNzU2YTgxNThhYjMwNmUzMzg2ZmQxZTZi Y2IwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRDb250cm9s bGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRDb250cm9sbGVy LmNwcApAQCAtMjkzLDkgKzI5Myw2IEBAIHZvaWQgU2NyaXB0Q29udHJvbGxlcjo6YXR0YWNoRGVi dWdnZXIoSlNET01XaW5kb3dTaGVsbCogc2hlbGwsIEpTQzo6RGVidWdnZXIqIGRlCiAKIHZvaWQg U2NyaXB0Q29udHJvbGxlcjo6dXBkYXRlRG9jdW1lbnQoKQogewotICAgIGlmICghbV9mcmFtZS0+ ZG9jdW1lbnQoKSkKLSAgICAgICAgcmV0dXJuOwotCiAgICAgZm9yIChTaGVsbE1hcDo6aXRlcmF0 b3IgaXRlciA9IG1fd2luZG93U2hlbGxzLmJlZ2luKCk7IGl0ZXIgIT0gbV93aW5kb3dTaGVsbHMu ZW5kKCk7ICsraXRlcikgewogICAgICAgICBKU0xvY2tIb2xkZXIgbG9jayhpdGVyLT5maXJzdC0+ Z2xvYmFsRGF0YSgpKTsKICAgICAgICAgaXRlci0+c2Vjb25kLT53aW5kb3coKS0+dXBkYXRlRG9j dW1lbnQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2lu ZG93U2hlbGwuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVs bC5jcHAKaW5kZXggYjMxMzJlMzJhYzY1ZTBhNmY2OTdhNWIwNTgxNWJkM2U5ZmIyMjcwMC4uNzZi MWJjODkxNzI0YzVhZjJmYTI0M2Q4ZWVlYjU3NzIxYzZmZmE1NiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5jcHAKQEAgLTMzMSw2ICszMzEsNyBA QCB2ODo6UGVyc2lzdGVudDx2ODo6Q29udGV4dD4gVjhET01XaW5kb3dTaGVsbDo6Y3JlYXRlTmV3 Q29udGV4dCh2ODo6SGFuZGxlPHY4OjpPYgogICAgIHY4OjpQZXJzaXN0ZW50PHY4OjpDb250ZXh0 PiByZXN1bHQ7CiAKICAgICAvLyBUaGUgYWN0aXZlRG9jdW1lbnRMb2FkZXIgcG9pbnRlciBjb3Vs ZCBiZSAwIGR1cmluZyBmcmFtZSBzaHV0ZG93bi4KKyAgICAvLyBGSVhNRTogQ2FuIHdlIHJlbW92 ZSB0aGlzIGNoZWNrPwogICAgIGlmICghbV9mcmFtZS0+bG9hZGVyKCktPmFjdGl2ZURvY3VtZW50 TG9hZGVyKCkpCiAgICAgICAgIHJldHVybiByZXN1bHQ7CiAKQEAgLTQwNiwxOSArNDA3LDYgQEAg dm9pZCBWOERPTVdpbmRvd1NoZWxsOjp1cGRhdGVEb2N1bWVudFByb3BlcnR5KCkKICAgICAvLyBG SVhNRTogU2hvdWxkIHdlIHVzZSBhIG5ldyBMb2NhbCBoYW5kbGUgaGVyZT8KICAgICB2ODo6Q29u dGV4dDo6U2NvcGUgY29udGV4dFNjb3BlKG1fY29udGV4dC5nZXQoKSk7CiAKLSAgICAvLyBJZiB0 aGUgZG9jdW1lbnQgaGFzIG5vIGZyYW1lLCBOb2RlVG9WOE9iamVjdCBtaWdodCBnZXQgdGhlCi0g ICAgLy8gZG9jdW1lbnQgd3JhcHBlciBmb3IgYSBkb2N1bWVudCB0aGF0IGlzIGFib3V0IHRvIGJl IGRlbGV0ZWQuCi0gICAgLy8gSWYgdGhlIEZvcmNlU2V0IGJlbG93IGNhdXNlcyBhIGdhcmJhZ2Ug Y29sbGVjdGlvbiwgdGhlIGRvY3VtZW50Ci0gICAgLy8gbWlnaHQgZ2V0IGRlbGV0ZWQgYW5kIHRo ZSBnbG9iYWwgaGFuZGxlIGZvciB0aGUgZG9jdW1lbnQKLSAgICAvLyB3cmFwcGVyIGNsZWFyZWQu IFVzaW5nIHRoZSBjbGVhcmVkIGdsb2JhbCBoYW5kbGUgd2lsbCBsZWFkIHRvCi0gICAgLy8gY3Jh c2hlcy4gSW4gdGhpcyBjYXNlIHdlIGNsZWFyIHRoZSBjYWNoZSBhbmQgbGV0IHRoZSBET01XaW5k b3cKLSAgICAvLyBhY2Nlc3NvciBoYW5kbGUgYWNjZXNzIHRvIHRoZSBkb2N1bWVudC4KLSAgICAv LyBGSVhNRTogVGhpcyBzaG91bGQgbm90IGJlIHBvc3NpYmxlIGFueW1vcmUuCi0gICAgaWYgKCFt X2ZyYW1lLT5kb2N1bWVudCgpLT5mcmFtZSgpKSB7Ci0gICAgICAgIGNsZWFyRG9jdW1lbnRQcm9w ZXJ0eSgpOwotICAgICAgICByZXR1cm47Ci0gICAgfQotCiAgICAgdjg6OkhhbmRsZTx2ODo6VmFs dWU+IGRvY3VtZW50V3JhcHBlciA9IHRvVjgobV9mcmFtZS0+ZG9jdW1lbnQoKSk7CiAgICAgQVNT RVJUKGRvY3VtZW50V3JhcHBlciA9PSBtX2RvY3VtZW50LmdldCgpIHx8IG1fZG9jdW1lbnQuaXNF bXB0eSgpKTsKICAgICBpZiAobV9kb2N1bWVudC5pc0VtcHR5KCkpCkBAIC00NTEsMTIgKzQzOSw2 IEBAIHZvaWQgVjhET01XaW5kb3dTaGVsbDo6c2V0U2VjdXJpdHlUb2tlbigpCiB7CiAgICAgRG9j dW1lbnQqIGRvY3VtZW50ID0gbV9mcmFtZS0+ZG9jdW1lbnQoKTsKIAotICAgIC8vIEZJWE1FOiBU aGlzIHNob3VsZG4ndCBiZSBwb3NzaWJsZSBhbnltb3JlLgotICAgIGlmICghZG9jdW1lbnQpIHsK LSAgICAgICAgbV9jb250ZXh0LT5Vc2VEZWZhdWx0U2VjdXJpdHlUb2tlbigpOwotICAgICAgICBy ZXR1cm47Ci0gICAgfQotCiAgICAgLy8gQXNrIHRoZSBkb2N1bWVudCdzIFNlY3VyaXR5T3JpZ2lu IHRvIGdlbmVyYXRlIGEgc2VjdXJpdHkgdG9rZW4uCiAgICAgLy8gSWYgdHdvIHRva2VucyBhcmUg ZXF1YWwsIHRoZW4gdGhlIFNlY3VyaXR5T3JpZ2lucyBjYW5BY2Nlc3MgZWFjaCBvdGhlci4KICAg ICAvLyBJZiB0d28gdG9rZW5zIGFyZSBub3QgZXF1YWwsIHRoZW4gd2UgaGF2ZSB0byBjYWxsIGNh bkFjY2Vzcy4KQEAgLTQ4NSwyNCArNDY3LDExIEBAIHZvaWQgVjhET01XaW5kb3dTaGVsbDo6c2V0 U2VjdXJpdHlUb2tlbigpCiAKIHZvaWQgVjhET01XaW5kb3dTaGVsbDo6dXBkYXRlRG9jdW1lbnQo KQogewotICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZG4ndCBiZSBwb3NzaWJsZSBhbnltb3JlLgot ICAgIGlmICghbV9mcmFtZS0+ZG9jdW1lbnQoKSkKLSAgICAgICAgcmV0dXJuOwotCiAgICAgaWYg KG1fZ2xvYmFsLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuOwotCi0gICAgLy8gVGhlcmUgaXMg YW4gZXhpc3RpbmcgSmF2YVNjcmlwdCB3cmFwcGVyIGZvciB0aGUgZ2xvYmFsIG9iamVjdAotICAg IC8vIG9mIHRoaXMgZnJhbWUuIEphdmFTY3JpcHQgY29kZSBpbiBvdGhlciBmcmFtZXMgbWlnaHQg aG9sZCBhCi0gICAgLy8gcmVmZXJlbmNlIHRvIHRoaXMgd3JhcHBlci4gV2UgZWFnZXJseSBpbml0 aWFsaXplIHRoZSBKYXZhU2NyaXB0Ci0gICAgLy8gY29udGV4dCBmb3IgdGhlIG5ldyBkb2N1bWVu dCB0byBtYWtlIHByb3BlcnR5IGFjY2VzcyBvbiB0aGUKLSAgICAvLyBnbG9iYWwgb2JqZWN0IHdy YXBwZXIgc3VjY2VlZC4KICAgICBpZiAoIWluaXRpYWxpemVJZk5lZWRlZCgpKQogICAgICAgICBy ZXR1cm47Ci0KLSAgICAvLyBXZSBoYXZlIGEgbmV3IGRvY3VtZW50IGFuZCB3ZSBuZWVkIHRvIHVw ZGF0ZSB0aGUgY2FjaGUuCiAgICAgdXBkYXRlRG9jdW1lbnRQcm9wZXJ0eSgpOwotCiAgICAgdXBk YXRlU2VjdXJpdHlPcmlnaW4oKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFn ZS9GcmFtZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAppbmRleCAxODc0ZGRl ZjJlMWQxNjQ0Njg1ZmEyMGYxOTkwNDE3NTQyZWYzOTgyLi5jOGUzYmZmNTIwMjRjYTBiMWU1Njdh M2QwNGZlMTk0ZTNiNzkxNTlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcApAQCAtMzAzLDExICszMDMs MTAgQEAgdm9pZCBGcmFtZTo6c2V0RG9jdW1lbnQoUGFzc1JlZlB0cjxEb2N1bWVudD4gbmV3RG9j KQogICAgIGlmIChtX2RvYyAmJiAhbV9kb2MtPmF0dGFjaGVkKCkpCiAgICAgICAgIG1fZG9jLT5h dHRhY2goKTsKIAotICAgIC8vIFVwZGF0ZSB0aGUgY2FjaGVkICdkb2N1bWVudCcgcHJvcGVydHks IHdoaWNoIGlzIG5vdyBzdGFsZS4KLSAgICBtX3NjcmlwdC51cGRhdGVEb2N1bWVudCgpOwotCi0g ICAgaWYgKG1fZG9jKQorICAgIGlmIChtX2RvYykgeworICAgICAgICBtX3NjcmlwdC51cGRhdGVE b2N1bWVudCgpOwogICAgICAgICBtX2RvYy0+dXBkYXRlVmlld3BvcnRBcmd1bWVudHMoKTsKKyAg ICB9CiAKICAgICBpZiAobV9wYWdlICYmIG1fcGFnZS0+bWFpbkZyYW1lKCkgPT0gdGhpcykgewog ICAgICAgICBub3RpZnlDaHJvbWVDbGllbnRXaGVlbEV2ZW50SGFuZGxlckNvdW50Q2hhbmdlZCgp Owo=