95132 2012-08-27 15:01:04 -0700 [V8] Improve the names of some private functions of V8DOMWindowShell.cpp 2012-08-27 15:45:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 94909 1 abarth abarth eric haraken japhet webkit.review.bot oldest_to_newest 705716 0 abarth 2012-08-27 15:01:04 -0700 [V8] Improve the names of some private functions of V8DOMWindowShell.cpp 705722 1 160817 abarth 2012-08-27 15:02:39 -0700 Created attachment 160817 Patch 705798 2 160817 webkit.review.bot 2012-08-27 15:45:15 -0700 Comment on attachment 160817 Patch Clearing flags on attachment: 160817 Committed r126811: <http://trac.webkit.org/changeset/126811> 705799 3 webkit.review.bot 2012-08-27 15:45:18 -0700 All reviewed patches have been landed. Closing bug. 160817 2012-08-27 15:02:39 -0700 2012-08-27 15:45:15 -0700 Patch bug-95132-20120827150231.patch text/plain 7568 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2Nzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODNmZjg5Y2I3NzMzOGU5 YmU1ZWViNjljMjY5MjZmNGRjM2EzMTczYy4uNWZjYTlmZDNiYWNkODlkZGVmZTA4ODE0YjRmZWZm NzBiMGYyNjhkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMyIEBACiAyMDEyLTA4LTI3ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgW1Y4XSBJbXByb3ZlIHRoZSBu YW1lcyBvZiBzb21lIHByaXZhdGUgZnVuY3Rpb25zIG9mIFY4RE9NV2luZG93U2hlbGwuY3BwCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTEzMgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFY4RE9NV2luZG93 U2hlbGwgaGFzIGEgY29uY2VwdCBvZiBhICJEb2N1bWVudFdyYXBwZXJDYWNoZSIsIGJ1dCB0aGF0 J3MKKyAgICAgICAgbW9yZSBlYXNpbHkgdW5kZXJzdG9vZCBhcyB0aGUgImRvY3VtZW50IiBwcm9w ZXJ0eSBvZiB0aGUgV2luZG93LiBUaGlzCisgICAgICAgIHBhdGNoIHJlbmFtZXMgYSBjb3VwbGUg ZnVuY3Rpb25zIHRvIG1ha2UgdGhpcyBjbGVhcmVyLgorCisgICAgICAgIFRoaXMgcGF0Y2ggYXMg cmVuYW1lcyBkaXNwb3NlQ29udGV4dEhhbmRsZXMgdG8gZGlzcG9zZUNvbnRleHQgYmVjYXVzZQor ICAgICAgICB0aGF0J3Mgd2hhdCdzIGFjdHVhbGx5IGhhcHBlbmluZy4KKworICAgICAgICAqIGJp bmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhET01X aW5kb3dTaGVsbDo6aXNDb250ZXh0SW5pdGlhbGl6ZWQpOgorICAgICAgICAoV2ViQ29yZTo6VjhE T01XaW5kb3dTaGVsbDo6ZGlzcG9zZUNvbnRleHQpOgorICAgICAgICAoV2ViQ29yZTo6VjhET01X aW5kb3dTaGVsbDo6Y2xlYXJGb3JDbG9zZSk6CisgICAgICAgIChXZWJDb3JlOjpWOERPTVdpbmRv d1NoZWxsOjpjbGVhckZvck5hdmlnYXRpb24pOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAg IChXZWJDb3JlOjpWOERPTVdpbmRvd1NoZWxsOjppbml0aWFsaXplSWZOZWVkZWQpOgorICAgICAg ICAoV2ViQ29yZTo6VjhET01XaW5kb3dTaGVsbDo6dXBkYXRlRG9jdW1lbnRQcm9wZXJ0eSk6Cisg ICAgICAgIChXZWJDb3JlOjpWOERPTVdpbmRvd1NoZWxsOjpjbGVhckRvY3VtZW50UHJvcGVydHkp OgorICAgICAgICAoV2ViQ29yZTo6VjhET01XaW5kb3dTaGVsbDo6dXBkYXRlRG9jdW1lbnQpOgor ICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuaDoKKyAgICAgICAgKFY4RE9N V2luZG93U2hlbGwpOgorCisyMDEyLTA4LTI3ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v cmc+CisKICAgICAgICAgW1Y4XSBDbGVhbiB1cCBWOERPTVdpbmRvd1NoZWxsJ3MgZmluZEZyYW1l CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTEzMAog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxs LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuY3BwCmlu ZGV4IDI2YTBkM2M0YTA2ODliM2JlZTZjMzM3M2IyNjczZGU1MjVhY2EzODUuLjgxNWFiM2Q1ZDUx ZGZmMGMxN2FmZjhlOTNmN2JhN2FmZTNlNWNlNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuY3BwCkBAIC0xODIsMTMgKzE4MiwxMSBAQCBWOERP TVdpbmRvd1NoZWxsOjpWOERPTVdpbmRvd1NoZWxsKEZyYW1lKiBmcmFtZSkKIAogYm9vbCBWOERP TVdpbmRvd1NoZWxsOjppc0NvbnRleHRJbml0aWFsaXplZCgpCiB7Ci0gICAgLy8gbV9jb250ZXh0 LCBtX2dsb2JhbCwgYW5kIG1fd3JhcHBlckJvaWxlcnBsYXRlcyBzaG91bGQKLSAgICAvLyBhbGwg YmUgbm9uLWVtcHR5IGlmIGlmIG1fY29udGV4dCBpcyBub24tZW1wdHkuCiAgICAgQVNTRVJUKG1f Y29udGV4dC5pc0VtcHR5KCkgfHwgIW1fZ2xvYmFsLmlzRW1wdHkoKSk7CiAgICAgcmV0dXJuICFt X2NvbnRleHQuaXNFbXB0eSgpOwogfQogCi12b2lkIFY4RE9NV2luZG93U2hlbGw6OmRpc3Bvc2VD b250ZXh0SGFuZGxlcygpCit2b2lkIFY4RE9NV2luZG93U2hlbGw6OmRpc3Bvc2VDb250ZXh0KCkK IHsKICAgICBpZiAoIW1fY29udGV4dC5pc0VtcHR5KCkpIHsKICAgICAgICAgbV9mcmFtZS0+bG9h ZGVyKCktPmNsaWVudCgpLT53aWxsUmVsZWFzZVNjcmlwdENvbnRleHQobV9jb250ZXh0LmdldCgp LCAwKTsKQEAgLTIxNiw3ICsyMTQsNyBAQCB2b2lkIFY4RE9NV2luZG93U2hlbGw6OmNsZWFyRm9y Q2xvc2UoKQogCiAgICAgdjg6OkhhbmRsZVNjb3BlIGhhbmRsZVNjb3BlOwogICAgIGNsZWFyRG9j dW1lbnRXcmFwcGVyKCk7Ci0gICAgZGlzcG9zZUNvbnRleHRIYW5kbGVzKCk7CisgICAgZGlzcG9z ZUNvbnRleHQoKTsKIH0KIAogdm9pZCBWOERPTVdpbmRvd1NoZWxsOjpjbGVhckZvck5hdmlnYXRp b24oKQpAQCAtMjMzLDEzICsyMzEsMTMgQEAgdm9pZCBWOERPTVdpbmRvd1NoZWxsOjpjbGVhckZv ck5hdmlnYXRpb24oKQogICAgIC8vIENsZWFyIHRoZSBkb2N1bWVudCB3cmFwcGVyIGNhY2hlIGJl Zm9yZSB0dXJuaW5nIG9uIGFjY2VzcyBjaGVja3Mgb24KICAgICAvLyB0aGUgb2xkIERPTVdpbmRv dyB3cmFwcGVyLiBUaGlzIHdheSwgYWNjZXNzIHRvIHRoZSBkb2N1bWVudCB3cmFwcGVyCiAgICAg Ly8gd2lsbCBiZSBwcm90ZWN0ZWQgYnkgdGhlIHNlY3VyaXR5IGNoZWNrcyBvbiB0aGUgRE9NV2lu ZG93IHdyYXBwZXIuCi0gICAgY2xlYXJEb2N1bWVudFdyYXBwZXJDYWNoZSgpOworICAgIGNsZWFy RG9jdW1lbnRQcm9wZXJ0eSgpOwogCiAgICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiB3aW5kb3dX cmFwcGVyID0gVjhET01XcmFwcGVyOjpsb29rdXBET01XcmFwcGVyKFY4RE9NV2luZG93OjpHZXRU ZW1wbGF0ZSgpLCBtX2dsb2JhbC5nZXQoKSk7CiAgICAgQVNTRVJUKCF3aW5kb3dXcmFwcGVyLklz RW1wdHkoKSk7CiAgICAgd2luZG93V3JhcHBlci0+VHVybk9uQWNjZXNzQ2hlY2soKTsKICAgICBt X2NvbnRleHQtPkRldGFjaEdsb2JhbCgpOwotICAgIGRpc3Bvc2VDb250ZXh0SGFuZGxlcygpOwor ICAgIGRpc3Bvc2VDb250ZXh0KCk7CiB9CiAKIC8vIENyZWF0ZSBhIG5ldyBlbnZpcm9ubWVudCBh bmQgc2V0dXAgdGhlIGdsb2JhbCBvYmplY3QuCkBAIC0yNDgsMTEgKzI0NiwxMSBAQCB2b2lkIFY4 RE9NV2luZG93U2hlbGw6OmNsZWFyRm9yTmF2aWdhdGlvbigpCiAvLyBhbGxvdyBwcm9wZXJ0aWVz IG9mIHRoZSBKUyBET01XaW5kb3cgaW5zdGFuY2UgdG8gYmUgc2hhZG93ZWQsIHdlCiAvLyB1c2Ug YSBzaGFkb3cgb2JqZWN0IGFzIHRoZSBnbG9iYWwgb2JqZWN0IGFuZCB1c2UgdGhlIEpTIERPTVdp bmRvdwogLy8gaW5zdGFuY2UgYXMgdGhlIHByb3RvdHlwZSBmb3IgdGhhdCBzaGFkb3cgb2JqZWN0 LiBUaGUgSlMgRE9NV2luZG93Ci0vLyBpbnN0YW5jZSBpcyB1bmRldGVjdGFibGUgZnJvbSBqYXZh c2NyaXB0IGNvZGUgYmVjYXVzZSB0aGUgX19wcm90b19fCisvLyBpbnN0YW5jZSBpcyB1bmRldGVj dGFibGUgZnJvbSBKYXZhU2NyaXB0IGNvZGUgYmVjYXVzZSB0aGUgX19wcm90b19fCiAvLyBhY2Nl c3NvcnMgc2tpcCB0aGF0IG9iamVjdC4KIC8vCiAvLyBUaGUgc2hhZG93IG9iamVjdCBhbmQgdGhl IERPTVdpbmRvdyBpbnN0YW5jZSBhcmUgc2VlbiBhcyBvbmUgb2JqZWN0Ci0vLyBmcm9tIGphdmFz Y3JpcHQuIFRoZSBqYXZhc2NyaXB0IG9iamVjdCB0aGF0IGNvcnJlc3BvbmRzIHRvIGEKKy8vIGZy b20gSmF2YVNjcmlwdC4gVGhlIEphdmFTY3JpcHQgb2JqZWN0IHRoYXQgY29ycmVzcG9uZHMgdG8g YQogLy8gRE9NV2luZG93IGluc3RhbmNlIGlzIHRoZSBzaGFkb3cgb2JqZWN0LiBXaGVuIG1hcHBp bmcgYSBET01XaW5kb3cKIC8vIGluc3RhbmNlIHRvIGEgVjggb2JqZWN0LCB3ZSByZXR1cm4gdGhl IHNoYWRvdyBvYmplY3QuCiAvLwpAQCAtMjk2LDE5ICsyOTQsMTkgQEAgYm9vbCBWOERPTVdpbmRv d1NoZWxsOjppbml0aWFsaXplSWZOZWVkZWQoKQogICAgIGlmIChtX2dsb2JhbC5pc0VtcHR5KCkp IHsKICAgICAgICAgbV9nbG9iYWwuc2V0KGNvbnRleHQtPkdsb2JhbCgpKTsKICAgICAgICAgaWYg KG1fZ2xvYmFsLmlzRW1wdHkoKSkgewotICAgICAgICAgICAgZGlzcG9zZUNvbnRleHRIYW5kbGVz KCk7CisgICAgICAgICAgICBkaXNwb3NlQ29udGV4dCgpOwogICAgICAgICAgICAgcmV0dXJuIGZh bHNlOwogICAgICAgICB9CiAgICAgfQogCiAgICAgbV9wZXJDb250ZXh0RGF0YSA9IFY4UGVyQ29u dGV4dERhdGE6OmNyZWF0ZShtX2NvbnRleHQuZ2V0KCkpOwogICAgIGlmICghbV9wZXJDb250ZXh0 RGF0YS0+aW5pdCgpKSB7Ci0gICAgICAgIGRpc3Bvc2VDb250ZXh0SGFuZGxlcygpOworICAgICAg ICBkaXNwb3NlQ29udGV4dCgpOwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCiAgICAg aWYgKCFpbnN0YWxsRE9NV2luZG93KGNvbnRleHQsIG1fZnJhbWUtPmRvY3VtZW50KCktPmRvbVdp bmRvdygpKSkgewotICAgICAgICBkaXNwb3NlQ29udGV4dEhhbmRsZXMoKTsKKyAgICAgICAgZGlz cG9zZUNvbnRleHQoKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIApAQCAtNDEwLDcg KzQwOCw3IEBAIHZvaWQgVjhET01XaW5kb3dTaGVsbDo6Y2xlYXJEb2N1bWVudFdyYXBwZXIoKQog ICAgIG1fZG9jdW1lbnQuY2xlYXIoKTsKIH0KIAotdm9pZCBWOERPTVdpbmRvd1NoZWxsOjp1cGRh dGVEb2N1bWVudFdyYXBwZXJDYWNoZSgpCit2b2lkIFY4RE9NV2luZG93U2hlbGw6OnVwZGF0ZURv Y3VtZW50UHJvcGVydHkoKQogewogICAgIHY4OjpIYW5kbGVTY29wZSBoYW5kbGVTY29wZTsKICAg ICAvLyBGSVhNRTogU2hvdWxkIHdlIHVzZSBhIG5ldyBMb2NhbCBoYW5kbGUgaGVyZT8KQEAgLTQy NSw3ICs0MjMsNyBAQCB2b2lkIFY4RE9NV2luZG93U2hlbGw6OnVwZGF0ZURvY3VtZW50V3JhcHBl ckNhY2hlKCkKICAgICAvLyBhY2Nlc3NvciBoYW5kbGUgYWNjZXNzIHRvIHRoZSBkb2N1bWVudC4K ICAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgbm90IGJlIHBvc3NpYmxlIGFueW1vcmUuCiAgICAg aWYgKCFtX2ZyYW1lLT5kb2N1bWVudCgpLT5mcmFtZSgpKSB7Ci0gICAgICAgIGNsZWFyRG9jdW1l bnRXcmFwcGVyQ2FjaGUoKTsKKyAgICAgICAgY2xlYXJEb2N1bWVudFByb3BlcnR5KCk7CiAgICAg ICAgIHJldHVybjsKICAgICB9CiAKQEAgLTQzOCw3ICs0MzYsNyBAQCB2b2lkIFY4RE9NV2luZG93 U2hlbGw6OnVwZGF0ZURvY3VtZW50V3JhcHBlckNhY2hlKCkKICAgICAvLyBJZiBpbnN0YW50aWF0 aW9uIG9mIHRoZSBkb2N1bWVudCB3cmFwcGVyIGZhaWxzLCBjbGVhciB0aGUgY2FjaGUKICAgICAv LyBhbmQgbGV0IHRoZSBET01XaW5kb3cgYWNjZXNzb3IgaGFuZGxlIGFjY2VzcyB0byB0aGUgZG9j dW1lbnQuCiAgICAgaWYgKGRvY3VtZW50V3JhcHBlci5Jc0VtcHR5KCkpIHsKLSAgICAgICAgY2xl YXJEb2N1bWVudFdyYXBwZXJDYWNoZSgpOworICAgICAgICBjbGVhckRvY3VtZW50UHJvcGVydHko KTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KICAgICBBU1NFUlQoZG9jdW1lbnRXcmFwcGVyLT5J c09iamVjdCgpKTsKQEAgLTQ1MSw3ICs0NDksNyBAQCB2b2lkIFY4RE9NV2luZG93U2hlbGw6OnVw ZGF0ZURvY3VtZW50V3JhcHBlckNhY2hlKCkKICAgICB2OFJlYWxHbG9iYWwtPlNldEhpZGRlblZh bHVlKFY4SGlkZGVuUHJvcGVydHlOYW1lOjpkb2N1bWVudCgpLCBkb2N1bWVudFdyYXBwZXIpOwog fQogCi12b2lkIFY4RE9NV2luZG93U2hlbGw6OmNsZWFyRG9jdW1lbnRXcmFwcGVyQ2FjaGUoKQor dm9pZCBWOERPTVdpbmRvd1NoZWxsOjpjbGVhckRvY3VtZW50UHJvcGVydHkoKQogewogICAgIEFT U0VSVCghbV9jb250ZXh0LmlzRW1wdHkoKSk7CiAgICAgbV9jb250ZXh0LT5HbG9iYWwoKS0+Rm9y Y2VEZWxldGUodjg6OlN0cmluZzo6TmV3KCJkb2N1bWVudCIpKTsKQEAgLTUxMSw3ICs1MDksNyBA QCB2b2lkIFY4RE9NV2luZG93U2hlbGw6OnVwZGF0ZURvY3VtZW50KCkKICAgICAgICAgcmV0dXJu OwogCiAgICAgLy8gV2UgaGF2ZSBhIG5ldyBkb2N1bWVudCBhbmQgd2UgbmVlZCB0byB1cGRhdGUg dGhlIGNhY2hlLgotICAgIHVwZGF0ZURvY3VtZW50V3JhcHBlckNhY2hlKCk7CisgICAgdXBkYXRl RG9jdW1lbnRQcm9wZXJ0eSgpOwogCiAgICAgdXBkYXRlU2VjdXJpdHlPcmlnaW4oKTsKIH0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuaCBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuaAppbmRleCBkNzg4 YTAyOTFiZWQyMzY5MTNmMTQyYmY2N2Y5Y2Y4NDE0ZTY0MGY4Li4zYzE5YmI0NDE0OGE3YTU2Y2Nj NGYyODE5YTRmZTU1NDNjYTQ5NDBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9WOERPTVdpbmRvd1NoZWxsLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhET01XaW5kb3dTaGVsbC5oCkBAIC04NCwxNyArODQsMTcgQEAgcHVibGljOgogcHJpdmF0ZToK ICAgICBWOERPTVdpbmRvd1NoZWxsKEZyYW1lKik7CiAKLSAgICB2b2lkIGRpc3Bvc2VDb250ZXh0 SGFuZGxlcygpOworICAgIHZvaWQgZGlzcG9zZUNvbnRleHQoKTsKIAogICAgIHZvaWQgc2V0U2Vj dXJpdHlUb2tlbigpOwogICAgIHZvaWQgY2xlYXJEb2N1bWVudFdyYXBwZXIoKTsKIAogICAgIC8v IFRoZSBKYXZhU2NyaXB0IHdyYXBwZXIgZm9yIHRoZSBkb2N1bWVudCBvYmplY3QgaXMgY2FjaGVk IG9uIHRoZSBnbG9iYWwKLSAgICAvLyBvYmplY3QgZm9yIGZhc3QgYWNjZXNzLiBVcGRhdGVEb2N1 bWVudFdyYXBwZXJDYWNoZSBzZXRzIHRoZSB3cmFwcGVyCi0gICAgLy8gZm9yIHRoZSBjdXJyZW50 IGRvY3VtZW50IG9uIHRoZSBnbG9iYWwgb2JqZWN0LiBDbGVhckRvY3VtZW50V3JhcHBlckNhY2hl CisgICAgLy8gb2JqZWN0IGZvciBmYXN0IGFjY2Vzcy4gVXBkYXRlRG9jdW1lbnRQcm9wZXJ0eSBz ZXRzIHRoZSB3cmFwcGVyCisgICAgLy8gZm9yIHRoZSBjdXJyZW50IGRvY3VtZW50IG9uIHRoZSBn bG9iYWwgb2JqZWN0LiBDbGVhckRvY3VtZW50UHJvcGVydHkKICAgICAvLyBkZWxldGVzIHRoZSBk b2N1bWVudCB3cmFwcGVyIGZyb20gdGhlIGdsb2JhbCBvYmplY3QuCi0gICAgdm9pZCB1cGRhdGVE b2N1bWVudFdyYXBwZXJDYWNoZSgpOwotICAgIHZvaWQgY2xlYXJEb2N1bWVudFdyYXBwZXJDYWNo ZSgpOworICAgIHZvaWQgdXBkYXRlRG9jdW1lbnRQcm9wZXJ0eSgpOworICAgIHZvaWQgY2xlYXJE b2N1bWVudFByb3BlcnR5KCk7CiAKICAgICBGcmFtZSogbV9mcmFtZTsKIAo=