95122 2012-08-27 13:39:27 -0700 The static functions in V8DOMWindowShell.cpp are poorly named 2012-08-27 14:29:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 94909 1 abarth abarth eric haraken japhet webkit.review.bot oldest_to_newest 705613 0 abarth 2012-08-27 13:39:27 -0700 The static functions in V8DOMWindowShell.cpp are poorly named 705618 1 160793 abarth 2012-08-27 13:41:23 -0700 Created attachment 160793 Patch 705677 2 160793 webkit.review.bot 2012-08-27 14:29:06 -0700 Comment on attachment 160793 Patch Clearing flags on attachment: 160793 Committed r126797: <http://trac.webkit.org/changeset/126797> 705678 3 webkit.review.bot 2012-08-27 14:29:09 -0700 All reviewed patches have been landed. Closing bug. 160793 2012-08-27 13:41:23 -0700 2012-08-27 14:29:06 -0700 Patch bug-95122-20120827134115.patch text/plain 6101 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2Nzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmJiNDdiMTNiODU3MTE2 YmJhMTE4OGFjZTMxNzNiMzZkZGY2ZWJjMC4uMjY5YmM4ZWRiYTlhNTFmMWEwMGYyZTFlZGJhNmVh Y2U2OGNjZjgzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMxIEBACiAyMDEyLTA4LTI3ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgVGhlIHN0YXRpYyBmdW5jdGlv bnMgaW4gVjhET01XaW5kb3dTaGVsbC5jcHAgYXJlIHBvb3JseSBuYW1lZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTUxMjIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGNsZWFucyB1cCB0 aGUgbmFtaW5nIG9mIHRoZSBzdGF0aWMgZnVuY3Rpb25zIGluCisgICAgICAgIFY4RE9NV2luZG93 U2hlbGwuY3BwLgorCisgICAgICAgIEkndmUgaW5saW5lZCBoYW5kbGVGYXRhbEVycm9ySW5WOCBp bnRvIGl0cyBvbmUgY2FsbGVyLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01XaW5kb3dT aGVsbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyZXBvcnRGYXRhbEVycm9yKToKKyAgICAgICAg ICAgIC0gUmVtb3ZlZCBWOCBmcm9tIHRoZSBuYW1lIGJlY2F1ZXMgdGhpcyBlbnRpcmUgZmlsZSBp cyBhYm91dCBWOC4KKyAgICAgICAgKFdlYkNvcmU6OnJlcG9ydFVuY2F1Z2h0RXhjZXB0aW9uKToK KyAgICAgICAgICAgIC0gRGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpmaW5kRnJhbWUpOgorICAg ICAgICAgICAgLSBSZW1vdmUgdGhlICJnZXQiIHByZWZpeCBiZWNhdXNlIGl0J3MgYSB3ZWFrIHZl cmIuCisgICAgICAgIChXZWJDb3JlOjpyZXBvcnRVbnNhZmVKYXZhU2NyaXB0QWNjZXNzKToKKyAg ICAgICAgKFdlYkNvcmU6OmluaXRpYWxpemVWOElmTmVlZGVkKToKKyAgICAgICAgKFdlYkNvcmU6 OmNoZWNrRG9jdW1lbnRXcmFwcGVyKToKKyAgICAgICAgICAgIC0gTW92ZSB0aGlzIGZ1bmN0aW9u IHVwIHRvIHRoZSB0b3Agb2YgdGhlIGZpbGUgd2l0aCB0aGUgcmVzdCBvZiB0aGUKKyAgICAgICAg ICAgICAgc3RhdGljIGZ1bmN0aW9ucy4KKyAgICAgICAgKFdlYkNvcmUpOgorCisyMDEyLTA4LTI3 ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKICAgICAgICAgW1Y4XSBpbml0Q29u dGV4dElmTmVlZGVkIGlzIG92ZXJseSBzcGVjaWZpYwogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTUxMjAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmNwcAppbmRleCAwMmIwNmMwOTUxYjcyNjUzOGRkZjQ5 ZTNjNjRmYTU2ODFmYjNjODhhLi41ZTQ1ZGMzYzc2MWRiODZhMGQ1YzNlMjkxN2UzZDM2YmIxYzIx N2FkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1No ZWxsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxs LmNwcApAQCAtNjMsMTcgKzYzLDExIEBACiAjaW5jbHVkZSAiVjhPYmplY3RDb25zdHJ1Y3Rvci5o IgogI2luY2x1ZGUgIlY4UGVyQ29udGV4dERhdGEuaCIKICNpbmNsdWRlICJXb3JrZXJDb250ZXh0 RXhlY3V0aW9uUHJveHkuaCIKLQogI2luY2x1ZGUgPGFsZ29yaXRobT4KICNpbmNsdWRlIDxzdGRp by5oPgogI2luY2x1ZGUgPHV0aWxpdHk+CiAjaW5jbHVkZSA8djgtZGVidWcuaD4KICNpbmNsdWRl IDx2OC5oPgotCi0jaWYgRU5BQkxFKEpBVkFTQ1JJUFRfSTE4Tl9BUEkpCi0jaW5jbHVkZSA8djgt aTE4bi9pbmNsdWRlL2V4dGVuc2lvbi5oPgotI2VuZGlmCi0KICNpbmNsdWRlIDx3dGYvQXNzZXJ0 aW9ucy5oPgogI2luY2x1ZGUgPHd0Zi9Pd25BcnJheVB0ci5oPgogI2luY2x1ZGUgPHd0Zi9TdGRM aWJFeHRyYXMuaD4KQEAgLTgxLDE2ICs3NSwxMyBAQAogI2luY2x1ZGUgPHd0Zi9VbnVzZWRQYXJh bS5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KIAotbmFtZXNwYWNlIFdlYkNvcmUg eworI2lmIEVOQUJMRShKQVZBU0NSSVBUX0kxOE5fQVBJKQorI2luY2x1ZGUgPHY4LWkxOG4vaW5j bHVkZS9leHRlbnNpb24uaD4KKyNlbmRpZgogCi1zdGF0aWMgdm9pZCBoYW5kbGVGYXRhbEVycm9y SW5WOCgpCi17Ci0gICAgLy8gRklYTUU6IFdlIHRlbXBvcmFyaWx5IGRlYWwgd2l0aCBWOCBpbnRl cm5hbCBlcnJvciBzaXR1YXRpb25zCi0gICAgLy8gc3VjaCBhcyBvdXQtb2YtbWVtb3J5IGJ5IGNy YXNoaW5nIHRoZSByZW5kZXJlci4KLSAgICBDUkFTSCgpOwotfQorbmFtZXNwYWNlIFdlYkNvcmUg ewogCi1zdGF0aWMgdm9pZCByZXBvcnRGYXRhbEVycm9ySW5WOChjb25zdCBjaGFyKiBsb2NhdGlv biwgY29uc3QgY2hhciogbWVzc2FnZSkKK3N0YXRpYyB2b2lkIHJlcG9ydEZhdGFsRXJyb3IoY29u c3QgY2hhciogbG9jYXRpb24sIGNvbnN0IGNoYXIqIG1lc3NhZ2UpCiB7CiAgICAgLy8gVjggaXMg c2h1dGRvd24sIHdlIGNhbm5vdCB1c2UgVjggYXBpLgogICAgIC8vIFRoZSBvbmx5IHRoaW5nIHdl IGNhbiBkbyBpcyB0byBkaXNhYmxlIEphdmFTY3JpcHQuCkBAIC0xMDAsMTAgKzkxLDEyIEBAIHN0 YXRpYyB2b2lkIHJlcG9ydEZhdGFsRXJyb3JJblY4KGNvbnN0IGNoYXIqIGxvY2F0aW9uLCBjb25z dCBjaGFyKiBtZXNzYWdlKQogICAgIG1lbW9yeVVzYWdlTUIgPSBNZW1vcnlVc2FnZVN1cHBvcnQ6 OmFjdHVhbE1lbW9yeVVzYWdlTUIoKTsKICNlbmRpZgogICAgIHByaW50ZigiVjggZXJyb3I6ICVz ICglcykuICBDdXJyZW50IG1lbW9yeSB1c2FnZTogJWQgTUJcbiIsIG1lc3NhZ2UsIGxvY2F0aW9u LCBtZW1vcnlVc2FnZU1CKTsKLSAgICBoYW5kbGVGYXRhbEVycm9ySW5WOCgpOworICAgIC8vIEZJ WE1FOiBXZSB0ZW1wb3JhcmlseSBkZWFsIHdpdGggVjggaW50ZXJuYWwgZXJyb3Igc2l0dWF0aW9u cworICAgIC8vIHN1Y2ggYXMgb3V0LW9mLW1lbW9yeSBieSBjcmFzaGluZyB0aGUgcmVuZGVyZXIu CisgICAgQ1JBU0goKTsKIH0KIAotc3RhdGljIHZvaWQgdjhVbmNhdWdodEV4Y2VwdGlvbkhhbmRs ZXIodjg6OkhhbmRsZTx2ODo6TWVzc2FnZT4gbWVzc2FnZSwgdjg6OkhhbmRsZTx2ODo6VmFsdWU+ IGRhdGEpCitzdGF0aWMgdm9pZCByZXBvcnRVbmNhdWdodEV4Y2VwdGlvbih2ODo6SGFuZGxlPHY4 OjpNZXNzYWdlPiBtZXNzYWdlLCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gZGF0YSkKIHsKICAgICAv LyBVc2UgdGhlIGZyYW1lIHdoZXJlIEphdmFTY3JpcHQgaXMgY2FsbGVkIGZyb20uCiAgICAgRnJh bWUqIGZyYW1lID0gZmlyc3RGcmFtZShCaW5kaW5nU3RhdGU6Omluc3RhbmNlKCkpOwpAQCAtMTI5 LDcgKzEyMiw3IEBAIHN0YXRpYyB2b2lkIHY4VW5jYXVnaHRFeGNlcHRpb25IYW5kbGVyKHY4OjpI YW5kbGU8djg6Ok1lc3NhZ2U+IG1lc3NhZ2UsIHY4OjpIYW5kCiAKIC8vIFJldHVybnMgdGhlIG93 bmVyIGZyYW1lIHBvaW50ZXIgb2YgYSBET00gd3JhcHBlciBvYmplY3QuIEl0IG9ubHkgd29ya3Mg Zm9yCiAvLyB0aGVzZSBET00gb2JqZWN0cyByZXF1aXJpbmcgY3Jvc3MtZG9tYWluIGFjY2VzcyBj aGVjay4KLXN0YXRpYyBGcmFtZSogZ2V0VGFyZ2V0RnJhbWUodjg6OkxvY2FsPHY4OjpPYmplY3Q+ IGhvc3QsIHY4OjpMb2NhbDx2ODo6VmFsdWU+IGRhdGEpCitzdGF0aWMgRnJhbWUqIGZpbmRGcmFt ZSh2ODo6TG9jYWw8djg6Ok9iamVjdD4gaG9zdCwgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gZGF0YSkK IHsKICAgICBGcmFtZSogdGFyZ2V0ID0gMDsKICAgICBXcmFwcGVyVHlwZUluZm8qIHR5cGUgPSBX cmFwcGVyVHlwZUluZm86OnVud3JhcChkYXRhKTsKQEAgLTE1Miw3ICsxNDUsNyBAQCBzdGF0aWMg RnJhbWUqIGdldFRhcmdldEZyYW1lKHY4OjpMb2NhbDx2ODo6T2JqZWN0PiBob3N0LCB2ODo6TG9j YWw8djg6OlZhbHVlPiBkYQogCiBzdGF0aWMgdm9pZCByZXBvcnRVbnNhZmVKYXZhU2NyaXB0QWNj ZXNzKHY4OjpMb2NhbDx2ODo6T2JqZWN0PiBob3N0LCB2ODo6QWNjZXNzVHlwZSB0eXBlLCB2ODo6 TG9jYWw8djg6OlZhbHVlPiBkYXRhKQogewotICAgIEZyYW1lKiB0YXJnZXQgPSBnZXRUYXJnZXRG cmFtZShob3N0LCBkYXRhKTsKKyAgICBGcmFtZSogdGFyZ2V0ID0gZmluZEZyYW1lKGhvc3QsIGRh dGEpOwogICAgIGlmICghdGFyZ2V0KQogICAgICAgICByZXR1cm47CiAgICAgRE9NV2luZG93KiB0 YXJnZXRXaW5kb3cgPSB0YXJnZXQtPmRvY3VtZW50KCktPmRvbVdpbmRvdygpOwpAQCAtMTY5LDEw ICsxNjIsMTAgQEAgc3RhdGljIHZvaWQgaW5pdGlhbGl6ZVY4SWZOZWVkZWQoKQogICAgIGluaXRp YWxpemVkID0gdHJ1ZTsKIAogICAgIHY4OjpWODo6SWdub3JlT3V0T2ZNZW1vcnlFeGNlcHRpb24o KTsKLSAgICB2ODo6Vjg6OlNldEZhdGFsRXJyb3JIYW5kbGVyKHJlcG9ydEZhdGFsRXJyb3JJblY4 KTsKKyAgICB2ODo6Vjg6OlNldEZhdGFsRXJyb3JIYW5kbGVyKHJlcG9ydEZhdGFsRXJyb3IpOwog ICAgIHY4OjpWODo6U2V0R2xvYmFsR0NQcm9sb2d1ZUNhbGxiYWNrKCZWOEdDQ29udHJvbGxlcjo6 Z2NQcm9sb2d1ZSk7CiAgICAgdjg6OlY4OjpTZXRHbG9iYWxHQ0VwaWxvZ3VlQ2FsbGJhY2soJlY4 R0NDb250cm9sbGVyOjpnY0VwaWxvZ3VlKTsKLSAgICB2ODo6Vjg6OkFkZE1lc3NhZ2VMaXN0ZW5l cigmdjhVbmNhdWdodEV4Y2VwdGlvbkhhbmRsZXIpOworICAgIHY4OjpWODo6QWRkTWVzc2FnZUxp c3RlbmVyKCZyZXBvcnRVbmNhdWdodEV4Y2VwdGlvbik7CiAgICAgdjg6OlY4OjpTZXRGYWlsZWRB Y2Nlc3NDaGVja0NhbGxiYWNrRnVuY3Rpb24ocmVwb3J0VW5zYWZlSmF2YVNjcmlwdEFjY2Vzcyk7 CiAjaWYgRU5BQkxFKEpBVkFTQ1JJUFRfREVCVUdHRVIpCiAgICAgU2NyaXB0UHJvZmlsZXI6Omlu aXRpYWxpemUoKTsKQEAgLTE4NCw2ICsxNzcsMTIgQEAgc3RhdGljIHZvaWQgaW5pdGlhbGl6ZVY4 SWZOZWVkZWQoKQogICAgIHY4OjpWODo6U2V0RmxhZ3NGcm9tU3RyaW5nKGVzNVJlYWRvbmx5Rmxh Zywgc2l6ZW9mKGVzNVJlYWRvbmx5RmxhZykpOwogfQogCitzdGF0aWMgdm9pZCBjaGVja0RvY3Vt ZW50V3JhcHBlcih2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHdyYXBwZXIsIERvY3VtZW50KiBkb2N1 bWVudCkKK3sKKyAgICBBU1NFUlQoVjhEb2N1bWVudDo6dG9OYXRpdmUod3JhcHBlcikgPT0gZG9j dW1lbnQpOworICAgIEFTU0VSVCghZG9jdW1lbnQtPmlzSFRNTERvY3VtZW50KCkgfHwgKFY4RG9j dW1lbnQ6OnRvTmF0aXZlKHY4OjpIYW5kbGU8djg6Ok9iamVjdD46OkNhc3Qod3JhcHBlci0+R2V0 UHJvdG90eXBlKCkpKSA9PSBkb2N1bWVudCkpOworfQorCiBQYXNzUmVmUHRyPFY4RE9NV2luZG93 U2hlbGw+IFY4RE9NV2luZG93U2hlbGw6OmNyZWF0ZShGcmFtZSogZnJhbWUpCiB7CiAgICAgcmV0 dXJuIGFkb3B0UmVmKG5ldyBWOERPTVdpbmRvd1NoZWxsKGZyYW1lKSk7CkBAIC00MjQsMTIgKzQy Myw2IEBAIHZvaWQgVjhET01XaW5kb3dTaGVsbDo6Y2xlYXJEb2N1bWVudFdyYXBwZXIoKQogICAg IG1fZG9jdW1lbnQuY2xlYXIoKTsKIH0KIAotc3RhdGljIHZvaWQgY2hlY2tEb2N1bWVudFdyYXBw ZXIodjg6OkhhbmRsZTx2ODo6T2JqZWN0PiB3cmFwcGVyLCBEb2N1bWVudCogZG9jdW1lbnQpCi17 Ci0gICAgQVNTRVJUKFY4RG9jdW1lbnQ6OnRvTmF0aXZlKHdyYXBwZXIpID09IGRvY3VtZW50KTsK LSAgICBBU1NFUlQoIWRvY3VtZW50LT5pc0hUTUxEb2N1bWVudCgpIHx8IChWOERvY3VtZW50Ojp0 b05hdGl2ZSh2ODo6SGFuZGxlPHY4OjpPYmplY3Q+OjpDYXN0KHdyYXBwZXItPkdldFByb3RvdHlw ZSgpKSkgPT0gZG9jdW1lbnQpKTsKLX0KLQogdm9pZCBWOERPTVdpbmRvd1NoZWxsOjp1cGRhdGVE b2N1bWVudFdyYXBwZXJDYWNoZSgpCiB7CiAgICAgdjg6OkhhbmRsZVNjb3BlIGhhbmRsZVNjb3Bl Owo=