95118 2012-08-27 13:19:27 -0700 Hook procedure should check to see if hook has already been removed before attempting removal. 2012-08-27 15:18:47 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Windows 7 RESOLVED FIXED InRadar P2 Normal --- 1 roger_fong roger_fong jhoneycutt simon.fraser thorton webkit-bug-importer webkit.review.bot oldest_to_newest 705577 0 roger_fong 2012-08-27 13:19:27 -0700 When the hookFired method in LayerChangesFlusher.cpp gets called it calls CallNextHook to pass the message to the next hook procedure in the hook chain. However, sometimes, the hook procedure it gets passed to can dispatch another message that goes back through the hook chain and causes the hookFired method to get called again (before returning from CallNextHookEx). When the second hookFired call completes, it can remove the hook. When CallNextHook returns the original call to hookFired may try to remove the hook as well. However, there is no need as the hook as already been removed and in fact we get an assertion failure assert(m_hook) when we try to call removeHook(). The fix is simply to check to see that m_hook is not null before calling into removeHook, so we don't waste effort trying to remove a hook that has already been removed. Alternatively, I could just remove the assert but then just call UnhookWindowHookEx regardless of whether the hook has already been removed or not, but that seems a little sketchy to me... 705579 1 webkit-bug-importer 2012-08-27 13:20:12 -0700 <rdar://problem/12182019> 705598 2 roger_fong 2012-08-27 13:28:51 -0700 > However, sometimes, the hook procedure it gets passed to can dispatch another message that goes back through the hook chain and causes the hookFired method to get called again (before returning from CallNextHookEx). I think I missed half a sentence...: Sometimes, the hook procedure can passed to another hook procedure that can dispatch another message. This message goes back through the hook chain and causes the hookFired method to get called again (before returning from CallNextHookEx). 705625 3 160795 roger_fong 2012-08-27 13:46:40 -0700 Created attachment 160795 patch 705636 4 160798 roger_fong 2012-08-27 13:54:33 -0700 Created attachment 160798 typo in Changelog 705641 5 160798 simon.fraser 2012-08-27 13:55:28 -0700 Comment on attachment 160798 typo in Changelog View in context: https://bugs.webkit.org/attachment.cgi?id=160798&action=review > Source/WebCore/ChangeLog:8 > + Sometimes, the hook procedure can passed to another hook procedure that can dispatch another message. "can passed to"? > Source/WebCore/ChangeLog:9 > + This message goes back through the hook chain and causes the hookFired method to get called again Are you saying that it can re-enter? 705662 6 160803 roger_fong 2012-08-27 14:16:55 -0700 Created attachment 160803 more typos/clarification 705741 7 160803 webkit.review.bot 2012-08-27 15:18:43 -0700 Comment on attachment 160803 more typos/clarification Clearing flags on attachment: 160803 Committed r126805: <http://trac.webkit.org/changeset/126805> 705742 8 webkit.review.bot 2012-08-27 15:18:47 -0700 All reviewed patches have been landed. Closing bug. 160795 2012-08-27 13:46:40 -0700 2012-08-27 13:54:33 -0700 patch 95118_patch.txt text/plain 2067 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNjc4NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA4LTI3ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgSG9vayBwcm9jZWR1cmUgc2hv dWxkIHRvIHNlZSBpZiBob29rIGhhcyBhbHJlYWR5IGJlZW4gcmVtb3ZlZCBiZWZvcmUgYXR0ZW1w dGluZyByZW1vdmFsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTUxMTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBTb21ldGltZXMsIHRoZSBob29rIHByb2NlZHVyZSBjYW4gcGFzc2VkIHRvIGFub3RoZXIg aG9vayBwcm9jZWR1cmUgdGhhdCBjYW4gZGlzcGF0Y2ggYW5vdGhlciBtZXNzYWdlLiAKKyAgICAg ICAgVGhpcyBtZXNzYWdlIGdvZXMgYmFjayB0aHJvdWdoIHRoZSBob29rIGNoYWluIGFuZCBjYXVz ZXMgdGhlIGhvb2tGaXJlZCBtZXRob2QgdG8gZ2V0IGNhbGxlZCBhZ2FpbiAKKyAgICAgICAgKGJl Zm9yZSByZXR1cm5pbmcgZnJvbSBDYWxsTmV4dEhvb2tFeCkuCisKKyAgICAgICAgV2hlbiB0aGUg c2Vjb25kIGhvb2tGaXJlZCBjYWxsIGNvbXBsZXRlcywgaXQgY2FuIHJlbW92ZSB0aGUgaG9vay4g CisgICAgICAgIFdoZW4gQ2FsbE5leHRIb29rIHJldHVybnMsIHRoZSBvcmlnaW5hbCBjYWxsIHRv IGhvb2tGaXJlZCBtYXkgdHJ5IHRvIHJlbW92ZSB0aGUgaG9vayBhcyB3ZWxsLiAKKyAgICAgICAg SG93ZXZlciwgdGhlcmUgaXMgbm8gbmVlZCBhcyB0aGUgaG9vayBhcyBhbHJlYWR5IGJlZW4gcmVt b3ZlZCBhbmQgaW4gZmFjdCB3ZSBnZXQgYW4gYXNzZXJ0aW9uIGZhaWx1cmUgCisgICAgICAgIGFz c2VydChtX2hvb2spIHdoZW4gd2UgY2FsbCByZW1vdmVIb29rKCkuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9jYS93aW4vTGF5ZXJDaGFuZ2VzRmx1c2hlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpMYXllckNoYW5nZXNGbHVzaGVyOjpob29rRmlyZWQpOgorICAgICAgICBTaW1wbHkg Y2hlY2sgdG8gc2VlIGlmIHRoZSBob29rIGhhcyBhbHJlYWR5IGJlZW4gcmVtb3ZlZCBiZWZvcmUg YWN0dWFsbHkgdHJ5aW5nIHRvIHJlbW92ZSBpdC4KKwogMjAxMi0wOC0yNyAgS2V2aW4gRnVuayAg PGtldmluLmZ1bmtAa2RhYi5jb20+CiAKICAgICAgICAgRml4IGNvbXBpbGF0aW9uIHdoZW4gYm90 aCBPUyhXSU5DRSkgYW5kIFBMQVRGT1JNKFFUKSBhcmUgdHJ1ZQpJbmRleDogU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL0xheWVyQ2hhbmdlc0ZsdXNoZXIuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL3dpbi9MYXllckNo YW5nZXNGbHVzaGVyLmNwcAkocmV2aXNpb24gMTI2Nzg0KQorKysgU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2Evd2luL0xheWVyQ2hhbmdlc0ZsdXNoZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC05NSw3ICs5NSw3IEBAIExSRVNVTFQgTGF5ZXJDaGFuZ2VzRmx1c2hlcjo6aG9va0Zp cmVkKGkKIAogICAgIExSRVNVTFQgcmVzdWx0ID0gOjpDYWxsTmV4dEhvb2tFeChtX2hvb2ssIGNv ZGUsIHdQYXJhbSwgbFBhcmFtKTsKIAotICAgIGlmIChtX2hvc3RzV2l0aENoYW5nZXNUb0ZsdXNo LmlzRW1wdHkoKSkgeworICAgIGlmIChtX2hvb2sgJiYgbV9ob3N0c1dpdGhDaGFuZ2VzVG9GbHVz aC5pc0VtcHR5KCkpIHsKICAgICAgICAgLy8gV2Ugd29uJ3QgaGF2ZSBhbnkgd29yayB0byBkbyBu ZXh0IHRpbWUgYXJvdW5kLCBzbyBqdXN0IHJlbW92ZSBvdXIgaG9vay4KICAgICAgICAgcmVtb3Zl SG9vaygpOwogICAgIH0K 160798 2012-08-27 13:54:33 -0700 2012-08-27 14:16:55 -0700 typo in Changelog 95118_patch.txt text/plain 2073 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNjc4NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA4LTI3ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgSG9vayBwcm9jZWR1cmUgc2hv dWxkIGNoZWNrIHRvIHNlZSBpZiBob29rIGhhcyBhbHJlYWR5IGJlZW4gcmVtb3ZlZCBiZWZvcmUg YXR0ZW1wdGluZyByZW1vdmFsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTUxMTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBTb21ldGltZXMsIHRoZSBob29rIHByb2NlZHVyZSBjYW4gcGFzc2VkIHRvIGFu b3RoZXIgaG9vayBwcm9jZWR1cmUgdGhhdCBjYW4gZGlzcGF0Y2ggYW5vdGhlciBtZXNzYWdlLiAK KyAgICAgICAgVGhpcyBtZXNzYWdlIGdvZXMgYmFjayB0aHJvdWdoIHRoZSBob29rIGNoYWluIGFu ZCBjYXVzZXMgdGhlIGhvb2tGaXJlZCBtZXRob2QgdG8gZ2V0IGNhbGxlZCBhZ2FpbiAKKyAgICAg ICAgKGJlZm9yZSByZXR1cm5pbmcgZnJvbSBDYWxsTmV4dEhvb2tFeCkuCisKKyAgICAgICAgV2hl biB0aGUgc2Vjb25kIGhvb2tGaXJlZCBjYWxsIGNvbXBsZXRlcywgaXQgY2FuIHJlbW92ZSB0aGUg aG9vay4gCisgICAgICAgIFdoZW4gQ2FsbE5leHRIb29rIHJldHVybnMsIHRoZSBvcmlnaW5hbCBj YWxsIHRvIGhvb2tGaXJlZCBtYXkgdHJ5IHRvIHJlbW92ZSB0aGUgaG9vayBhcyB3ZWxsLiAKKyAg ICAgICAgSG93ZXZlciwgdGhlcmUgaXMgbm8gbmVlZCBhcyB0aGUgaG9vayBhcyBhbHJlYWR5IGJl ZW4gcmVtb3ZlZCBhbmQgaW4gZmFjdCB3ZSBnZXQgYW4gYXNzZXJ0aW9uIGZhaWx1cmUgCisgICAg ICAgIGFzc2VydChtX2hvb2spIHdoZW4gd2UgY2FsbCByZW1vdmVIb29rKCkuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9jYS93aW4vTGF5ZXJDaGFuZ2VzRmx1c2hlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpMYXllckNoYW5nZXNGbHVzaGVyOjpob29rRmlyZWQpOgorICAgICAgICBT aW1wbHkgY2hlY2sgdG8gc2VlIGlmIHRoZSBob29rIGhhcyBhbHJlYWR5IGJlZW4gcmVtb3ZlZCBi ZWZvcmUgYWN0dWFsbHkgdHJ5aW5nIHRvIHJlbW92ZSBpdC4KKwogMjAxMi0wOC0yNyAgS2V2aW4g RnVuayAgPGtldmluLmZ1bmtAa2RhYi5jb20+CiAKICAgICAgICAgRml4IGNvbXBpbGF0aW9uIHdo ZW4gYm90aCBPUyhXSU5DRSkgYW5kIFBMQVRGT1JNKFFUKSBhcmUgdHJ1ZQpJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL0xheWVyQ2hhbmdlc0ZsdXNoZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL3dpbi9M YXllckNoYW5nZXNGbHVzaGVyLmNwcAkocmV2aXNpb24gMTI2Nzg0KQorKysgU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL0xheWVyQ2hhbmdlc0ZsdXNoZXIuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC05NSw3ICs5NSw3IEBAIExSRVNVTFQgTGF5ZXJDaGFuZ2VzRmx1c2hlcjo6 aG9va0ZpcmVkKGkKIAogICAgIExSRVNVTFQgcmVzdWx0ID0gOjpDYWxsTmV4dEhvb2tFeChtX2hv b2ssIGNvZGUsIHdQYXJhbSwgbFBhcmFtKTsKIAotICAgIGlmIChtX2hvc3RzV2l0aENoYW5nZXNU b0ZsdXNoLmlzRW1wdHkoKSkgeworICAgIGlmIChtX2hvb2sgJiYgbV9ob3N0c1dpdGhDaGFuZ2Vz VG9GbHVzaC5pc0VtcHR5KCkpIHsKICAgICAgICAgLy8gV2Ugd29uJ3QgaGF2ZSBhbnkgd29yayB0 byBkbyBuZXh0IHRpbWUgYXJvdW5kLCBzbyBqdXN0IHJlbW92ZSBvdXIgaG9vay4KICAgICAgICAg cmVtb3ZlSG9vaygpOwogICAgIH0K 160803 2012-08-27 14:16:55 -0700 2012-08-27 15:18:43 -0700 more typos/clarification 95118_patch.txt text/plain 2249 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNjc4NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA4LTI3ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgSG9vayBwcm9jZWR1cmUgc2hv dWxkIGNoZWNrIHRvIHNlZSBpZiBob29rIGhhcyBhbHJlYWR5IGJlZW4gcmVtb3ZlZCBiZWZvcmUg YXR0ZW1wdGluZyByZW1vdmFsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTUxMTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBXaGVuIHRoZSBob29rRmlyZWQgbWV0aG9kIGluIExheWVyQ2hhbmdlc0ZsdXNo ZXIuY3BwIGdldHMgY2FsbGVkIGluIHJlc3BvbnNlIHRvIGEgbWVzc2FnZSBwb3N0ZWQgdG8gdGhl IG1lc3NhZ2UgcXVldWUKKyAgICAgICAgaXQgY2FsbHMgQ2FsbE5leHRIb29rIHRvIHBhc3MgdGhl IG1lc3NhZ2UgdG8gdGhlIG5leHQgaG9vayBwcm9jZWR1cmUgaW4gdGhlIGhvb2sgY2hhaW4uCisg ICAgICAgIAorICAgICAgICBTb21ldGltZXMsIHRoZSBtZXNzYWdlIGNhbiBnZXQgcGFzc2VkIHRv IGFub3RoZXIgaG9vayBwcm9jZWR1cmUgdGhhdCBjYW4gZGlzcGF0Y2ggYW5vdGhlciBtZXNzYWdl LiAKKyAgICAgICAgVGhpcyBtZXNzYWdlIGdldHMgcGFzc2VkIGJhY2sgdGhyb3VnaCB0aGUgaG9v ayBjaGFpbiBhbmQgd2UgZXZlbnR1YWxseSByZS1lbnRlciB0aGUgaG9va0ZpcmVkIG1ldGhvZC4K KworICAgICAgICBXaGVuIHRoYXQgaG9va0ZpcmVkIGNhbGwgY29tcGxldGVzLCBpdCBtYXkgcmVt b3ZlIHRoZSBob29rLiAKKyAgICAgICAgV2hlbiBDYWxsTmV4dEhvb2sgcmV0dXJucywgdGhlIG9y aWdpbmFsIGNhbGwgdG8gaG9va0ZpcmVkIG1heSB0cnkgdG8gcmVtb3ZlIHRoZSBob29rIGFzIHdl bGwuIAorICAgICAgICBIb3dldmVyLCB0aGVyZSBpcyBubyBuZWVkIGFzIHRoZSBob29rIGFzIGFs cmVhZHkgYmVlbiByZW1vdmVkLgorICAgICAgICBUaGlzIHJlc3VsdHMgaW4gYW4gYXNzZXJ0aW9u IGZhaWx1cmUsIGFzc2VydChtX2hvb2spLCB3aGVuIHdlIGNhbGwgcmVtb3ZlSG9vay4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhL3dpbi9MYXllckNoYW5nZXNGbHVzaGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkxheWVyQ2hhbmdlc0ZsdXNoZXI6Omhvb2tGaXJlZCk6CisgICAg ICAgIFNpbXBseSBjaGVjayB0byBzZWUgaWYgdGhlIGhvb2sgaGFzIGFscmVhZHkgYmVlbiByZW1v dmVkIGJlZm9yZSBhY3R1YWxseSB0cnlpbmcgdG8gcmVtb3ZlIGl0LgorCiAyMDEyLTA4LTI3ICBL ZXZpbiBGdW5rICA8a2V2aW4uZnVua0BrZGFiLmNvbT4KIAogICAgICAgICBGaXggY29tcGlsYXRp b24gd2hlbiBib3RoIE9TKFdJTkNFKSBhbmQgUExBVEZPUk0oUVQpIGFyZSB0cnVlCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS93aW4vTGF5ZXJDaGFuZ2VzRmx1c2hl ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Ev d2luL0xheWVyQ2hhbmdlc0ZsdXNoZXIuY3BwCShyZXZpc2lvbiAxMjY3ODQpCisrKyBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS93aW4vTGF5ZXJDaGFuZ2VzRmx1c2hlci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTk1LDcgKzk1LDcgQEAgTFJFU1VMVCBMYXllckNoYW5nZXNGbHVz aGVyOjpob29rRmlyZWQoaQogCiAgICAgTFJFU1VMVCByZXN1bHQgPSA6OkNhbGxOZXh0SG9va0V4 KG1faG9vaywgY29kZSwgd1BhcmFtLCBsUGFyYW0pOwogCi0gICAgaWYgKG1faG9zdHNXaXRoQ2hh bmdlc1RvRmx1c2guaXNFbXB0eSgpKSB7CisgICAgaWYgKG1faG9vayAmJiBtX2hvc3RzV2l0aENo YW5nZXNUb0ZsdXNoLmlzRW1wdHkoKSkgewogICAgICAgICAvLyBXZSB3b24ndCBoYXZlIGFueSB3 b3JrIHRvIGRvIG5leHQgdGltZSBhcm91bmQsIHNvIGp1c3QgcmVtb3ZlIG91ciBob29rLgogICAg ICAgICByZW1vdmVIb29rKCk7CiAgICAgfQo=